On Tue, Nov 26, 2024 at 12:27:33PM -0500, Andres Freund wrote:
> On 2024-11-22 20:44:34 -0600, Nathan Bossart wrote:
>> D'oh, I missed that ProcNumber could be used as an index for the
>> BackendStatusArray. Is the attached more like what you are imagining?
>
> Yes.
>
> I'd probably add two func
On 2024-11-26 15:07:24 -0600, Nathan Bossart wrote:
> I've attempted to add all these details in v3.
LGTM!
On Tue, 26 Nov 2024 at 21:48, Sergey Prokhorenko
wrote:
> gen_uuidv7() is OK
I'd very much prefer to not have a gen_ or get_ prefix as argued before[1][2].
My vote is still for simply uuidv7() and uuidv4()
> uuid-ossp is outdated, slow and not supported by the author. UUIDv7 is the
> renaissan
On 2024-10-16 We 7:26 PM, Bruce Momjian wrote:
Uh, where are we on this?
It slipped under my radar - I have put it back :-)
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
On Tue, Nov 26, 2024 at 1:55 PM Jelte Fennema-Nio wrote:
>
> On Tue, 26 Nov 2024 at 21:48, Sergey Prokhorenko
> wrote:
> > gen_uuidv7() is OK
>
> I'd very much prefer to not have a gen_ or get_ prefix as argued before[1][2].
>
> My vote is still for simply uuidv7() and uuidv4()
>
> > uuid-ossp is
On 26/11/2024 18:55, Andres Freund wrote:
I somewhat regularly start postmaster with log_min_messages DEBUG3-5. One
thing that makes that unnecessarily annoying is postmaster's environment dump
at startup. It's visually hard to skip over, as it emits each environment
variable as a separate log m
On Tue, Nov 26, 2024 at 11:43:02AM -0500, Tom Lane wrote:
> Bruce Momjian writes:
> > Do we want to add this complexity?
>
> I don't think this patch is doing anything I want at all.
Gee, I kind of liked the patch, but maybe you didn't like the additional
complexity to check the PDF output twice
On Sat, 23 Nov 2024, 07:44 Nathan Bossart, wrote:
> On Fri, Nov 22, 2024 at 06:13:16PM -0500, Andres Freund wrote:
> >> -if (procStatus && procStatus->st_backendType ==
> B_AUTOVAC_WORKER)
> >> +if (pgstat_get_backend_type(pid) == B_AUTOVAC_WORKER)
> >
> > Because we alrea
Robert Haas writes:
> On Mon, Nov 25, 2024 at 4:39 PM Tom Lane wrote:
>> ... I think Robert
>> must have had constraint_exclusion = on for his examples a
>> couple messages back.)
> I definitely didn't change the value of that setting. It's possible I
> was running on an older branch, but I don
On Tue, Nov 26, 2024 at 12:13 PM Tom Lane wrote:
> Maybe your test table was partitioned??
Ah, yes, it was.
--
Robert Haas
EDB: http://www.enterprisedb.com
On Mon, Aug 12, 2024 at 09:44:02AM +0200, Peter Eisentraut wrote:
> Second (or 0005), an alternative to palloc is to make the converted scan
> keys a normal local variable. Then it's just a question of whether a
> smaller palloc is preferred over an over-allocated local variable. I think
> I stil
Hi,
I ran something which triggered the error in $subject. Except that it turns
out that
a) epoll_create1() was not being called
b) we didn't actually hit EMFILE or even max_safe_fds
The reason for the failure is that we have:
if (!AcquireExternalFD())
{
/* treat t
On Mon, 25 Nov 2024 at 12:11, Masahiko Sawada wrote:
> On Mon, Nov 25, 2024 at 10:15 AM Andrey M. Borodin
> wrote:
>>
>>
>>
>> > On 25 Nov 2024, at 22:53, Masahiko Sawada wrote:
>> >
>> > In the following code, we use "defined(__darwin__) || defined(_MSC_VER)":
>> >
>> > +#if defined(__darwin__
On 25.11.24 01:57, Thomas Munro wrote:
Thanks. I'm going to have a go at adjusting the docs myself so I can
get this committed. Invitation remains open for someone closer to the
topic to rewrite in a later commit as required for maximum utility to
the reader (I'm never going to install MSYS2, o
Andres Freund writes:
> I think it's rather confusing to claim that epoll_create1() failed when we
> didn't even call it.
> Why are we misattributing the failure to a system call that we didn't make?
I think the idea was that this mechanism is equivalent to an EMFILE
limit. But if you feel a nee
On Tue, Nov 26, 2024 at 06:25:13PM +0900, Tatsuo Ishii wrote:
> I have looked into the patches.
> > %.pdf: %.fo $(ALL_IMAGES)
> > - $(FOP) -fo $< -pdf $@
> > + CLANG=C $(FOP) -fo $< -pdf $@ 2>&1 | \
>
> Shouldn't "CLANG" be "LANG"?
Yes, probably.
> > + awk 'BEGIN{err=0}{print}/not availab
Bruce Momjian writes:
> Do we want to add this complexity?
I don't think this patch is doing anything I want at all.
regards, tom lane
On Thu, Nov 21, 2024 at 2:43 PM Melanie Plageman
wrote:
>
> On Fri, Nov 1, 2024 at 5:39 PM Masahiko Sawada wrote:
> >
> > I think we agreed with what the patches proposed by Melanie do, so
> > let's focus on these patches on this thread. We can add other
> > information later if we need.
>
> Than
On Tue, Nov 26, 2024 at 12:41:37PM -0500, Tom Lane wrote:
> Bruce Momjian writes:
> > On Tue, Nov 26, 2024 at 11:43:02AM -0500, Tom Lane wrote:
> >> I don't think this patch is doing anything I want at all.
>
> > Gee, I kind of liked the patch, but maybe you didn't like the additional
> > complex
Changing the name uuidv7() to uuid_v7() is a bad idea because the RFC 9562
uses the term UUIDv7, and therefore code containing uuid_v7() will not be found
by searching the web in most cases.
It makes much more sense to rename it to get_uuidv7(), so that a query for
"uuidv7" does not return a bu
On Tue, Nov 26, 2024 at 1:55 PM Masahiko Sawada wrote:
>
> Just to be clear, do users want the number of updated VM bits or the
> number of pages whose visibility information is updated? For example,
>
> > visibility map: 5 pages set all-visible, 4 pages set all-frozen.
>
> IIUC the above log can
gen_uuidv7() is OK
uuid-ossp is outdated, slow and not supported by the author. UUIDv7 is the
renaissance of UUIDs. So we should not depend on legacy technology names
Sergey Prokhorenko sergeyprokhore...@yahoo.com.au
On Tuesday 26 November 2024 at 10:35:20 pm GMT+3, Przemysław Sztoch
wr
On Tue, Nov 26, 2024 at 11:11 AM Sergey Prokhorenko
wrote:
>
> Changing the name uuidv7() to uuid_v7() is a bad idea because the RFC 9562
> uses the term UUIDv7, and therefore code containing uuid_v7() will not be
> found by searching the web in most cases.
>
> It makes much more sense to rename
On Wed, Nov 27, 2024 at 5:23 AM Peter Eisentraut wrote:
> Attached is a simple proposal. The section about MinGW can be replaced
> mostly by "use MSYS2". That's also what CI and the buildfarm uses.
> Anyone who strays from that can figure it out themselves.
Thanks! I'll take it.
Here's what I have staged for commit (except for the commit message, which
needs some work).
--
nathan
>From c405f5a41cca9ce5de9c0e69e00d11b16ba93986 Mon Sep 17 00:00:00 2001
From: Nathan Bossart
Date: Tue, 26 Nov 2024 14:17:03 -0600
Subject: [PATCH v6 1/1] Use __attribute__((target(...))) for S
A lot of people use https://www.postgresql.org/docs/current/uuid-ossp.html.
|And `uuid_generate_v7()` will be the continuation...|
|From my point of view, absorbing uuid_generate_v5 into mainline would
be a great move too.
|
On 26.11.2024 20:30, Masahiko Sawada wrote:
On Tue, Nov 26, 2024 at
Hi, here are some review comments for patch v7-0001.
==
src/backend/replication/logical/relation.c
logicalrep_report_missing_or_gen_attrs:
1.
+/*
+ * If attempting to replicate missing or generated columns, report an error.
+ * Prioritize 'missing' errors if both occur though the prioritizat
Hi,
I spent a bit more time doing some testing on the last version of the
patch from [1]. And I ran into this assert in PostmasterStateMachine()
when stopping the cluster:
/* All types should be included in targetMask or remainMask */
Assert((remainMask.mask | targetMask.mask) == BTYPE_MASK_A
>
>
> Comments on 0003:
>
> * If we commit 0003, is it a useful feature by itself or does it
> require that we commit some or all of 0004-0014? Which of these need to
> be in v18?
>
Useful by itself.
0004 seems needed to me, unless we're fine with ~50% bloat in pg_class on a
new-upgraded system,
On 2024-11-26 Tu 1:24 AM, Marina Polyakova wrote:
Hello! Could you backport the commit "Fix meson uuid header check so
it works with MSVC" [1] to REL_16_STABLE please? Building with
-Duuid=ossp fails without it:
yep, done.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.
Yash Jain writes:
> I understand that the C-based functions can only be created by a superuser.
> Are there any other db objects that require superuser? Or is C-based
> functions the only one?
Scalar types and operator classes are two, there are probably others
I'm not thinking of. Search the CR
Hi,
On 2024-11-26 12:26:51 -0500, Tom Lane wrote:
> Andres Freund writes:
> > On 2024-11-26 11:35:56 -0500, Tom Lane wrote:
> >> You should probably check all of 3d475515a, because I think
> >> I applied the same idea in more than one place.
>
> > Yea, there's another equivalent message for kque
On Nov 25, 2024, at 20:56, Tom Lane wrote:
> None of this is a substitute for installing some kind of ABI-checking
> infrastructure; but that project doesn't seem to be moving fast.
These sound great, very useful. I wonder if the guideline docs Peter added
should link to these items (and back).
Hi Andrey, Nikolay, and Kirk
On 08.11.24 04:46, Kirk Wolak wrote:
> Hackers,
> The concept was driven by an all too common support request. A user
> accidentally dropped the wrong table. (this could also be applied to
> dropping a database, etc).
>
> If we had the LSN before the drop, this w
On Tue, Nov 26, 2024 at 11:36 AM Tom Lane wrote:
> I think the idea was that this mechanism is equivalent to an EMFILE
> limit. But if you feel a need to make a distinction, this seems fine:
I think we should never, ever confuse an error return from a system
call with any other kind of problem t
Bertrand Drouvot writes:
> On Mon, Nov 25, 2024 at 08:56:50PM -0500, Tom Lane wrote:
>> ... (But consider both 32-bit and 64-bit cases when
>> deciding what is "padding".)
> What about providing a decision table to help considering for 32-bit,
> something
> like (proposed in [1])?
> 64-bit hol
Matthias van de Meent writes:
> I would also add something like the following, to protect against
> corruption and deserialization errors of the catalog pg_node_tree
> fields, because right now the generated readfuncs.c code ignores field
> names, assumes ABI field order, and is generally quite se
Hi Rahila,
Rahila Syed , 26 Kas 2024 Sal, 13:40 tarihinde şunu
yazdı:
> Observations:
> 1. While there are a number of child contexts like index info of
> RelCacheContext,
>CatCacheContext does not have any children.
> 2. While there is a bunch of used memory in RelCacheContext and
> CatCache
On Mon, Nov 25, 2024 at 11:28:52PM +, Devulapalli, Raghuveer wrote:
>> Thanks. I think my only remaining feedback is that we should probably add a
>> comment to explain why we aren't doing this for ARM yet [0].
>
> Sounds good. Where would you like me to add this comment? Meson.build and
> co
Hi,
I somewhat regularly start postmaster with log_min_messages DEBUG3-5. One
thing that makes that unnecessarily annoying is postmaster's environment dump
at startup. It's visually hard to skip over, as it emits each environment
variable as a separate log message.
It's even worse if one uses lo
On Mon, Nov 25, 2024 at 4:39 PM Tom Lane wrote:
> BTW, it's also worth pointing out the constraint_exclusion GUC.
> If that's turned up to "on" from its default setting of "partition",
> it authorizes the planner to spend more effort looking for
> contradictory quals. It might be reasonable to ga
On Tue, 26 Nov 2024 at 12:59, Yash Jain wrote:
>
> Hi all,
> I noticed that in the CREATE EXTENSION code, the permission is elevated to
> the superuser who creates and owns all of the extension objects.
> I was wondering why this elevation is done.
> I understand that the C-based functions can on
On 2024-Nov-20, Amit Langote wrote:
> On Tue, Nov 19, 2024 at 6:41 PM Alvaro Herrera
> wrote:
> Here's an example that I think matches the above description, which,
> ISTM, leads to a state similar to what one would encounter with my
> patch as described earlier:
>
> create table parent (a int
On 15.11.24 14:53, Ryohei Takahashi (Fujitsu) wrote:
Thank you for your patch.
The patch worked in my Windows build environment and pgevent.dll is installed
to lib/ directory.
Thanks for checking. I have committed this patch and backpatched it to
PG16 and PG17. So the next minor releases wi
Andres Freund writes:
> On 2024-11-26 11:35:56 -0500, Tom Lane wrote:
>> You should probably check all of 3d475515a, because I think
>> I applied the same idea in more than one place.
> Yea, there's another equivalent message for kqueue a few lines below.
You should remove the "treat this..." co
Hi,
On 2024-11-26 11:35:56 -0500, Tom Lane wrote:
> Andres Freund writes:
> > I think it's rather confusing to claim that epoll_create1() failed when we
> > didn't even call it.
> > Why are we misattributing the failure to a system call that we didn't make?
>
> I think the idea was that this mec
Hi,
On 2024-11-22 20:44:34 -0600, Nathan Bossart wrote:
> On Fri, Nov 22, 2024 at 06:13:16PM -0500, Andres Freund wrote:
> >> - if (procStatus && procStatus->st_backendType ==
> >> B_AUTOVAC_WORKER)
> >> + if (pgstat_get_backend_type(pid) == B_AUTOVAC_WORKER)
> >
> > Because we
Bruce Momjian writes:
> On Tue, Nov 26, 2024 at 11:43:02AM -0500, Tom Lane wrote:
>> I don't think this patch is doing anything I want at all.
> Gee, I kind of liked the patch, but maybe you didn't like the additional
> complexity to check the PDF output twice, once on input (complex) and
> once
> On Mon, Nov 25, 2024 at 02:33:48PM GMT, Robert Haas wrote:
>
> I think the idea of having multiple shared memory segments is
> interesting and makes sense, but I would prefer to see them called
> "segments" rather than "slots" just as do we do for DSMs. The name
> "slot" is somewhat overused, and
On Wed, 27 Nov 2024 at 08:42, jian he wrote:
>
> On Sat, Nov 23, 2024 at 1:19 PM jian he wrote:
> >
> > I didn't add a doc entry. I will do it later.
> hi
> attached patch with thorough tests and documentation.
>
Hi! Thanks for pushing this further.
> one issue i still have is:
> CREATE SCHEMA
On Mon, Nov 25, 2024 at 03:47:59PM +, Bertrand Drouvot wrote:
> It also takes care of most of the comments that you have made in [1], meaning
> that it:
>
> - removes the backend type from PgStat_Backend and look for the backend type
> at "display" time.
> - creates PgStat_BackendPendingIO and
On Wed, 27 Nov 2024 at 08:50, Amit Kapila wrote:
>
> On Wed, Nov 27, 2024 at 3:30 AM Peter Smith wrote:
> >
> > Hi, here are some review comments for patch v7-0001.
> >
> > ==
> > src/backend/replication/logical/relation.c
> >
> > logicalrep_report_missing_or_gen_attrs:
> >
> > 1.
> > +/*
> >
On Fri, Nov 22, 2024 at 9:24 PM jian he wrote:
>
> overall i come up with the attached patch.
in v2:
create table t1 (a int, b int not null, c int, unique(b, c));
explain(costs off) select count(*) from t1 group by b,c,a;
QUERY PLAN
--
HashAggregate
Group Key: b
-
On Tue, Oct 15, 2024 at 1:25 AM Tom Lane wrote:
>
> The rest is just memory leak removal, and I suspect that nobody really
> cares that much about small leakage in the preprocessor: you'd have to
> be running some darn big files through it to notice. FTR, here are
> the total leaks reported by va
On Mon, Nov 25, 2024 at 01:29:31PM -0600, Nathan Bossart wrote:
> Or we could just enforce that you have an active snapshot whenever you
> modify a catalog with a TOAST table. That's simpler, but it requires extra
> work in some paths (and probably comments to point out that we're only
> pushing a
On Wed, 27 Nov 2024 at 12:15, vignesh C wrote:
>
> On Wed, 27 Nov 2024 at 08:50, Amit Kapila wrote:
> >
> > On Wed, Nov 27, 2024 at 3:30 AM Peter Smith wrote:
> > >
> > > Hi, here are some review comments for patch v7-0001.
> > >
> > > ==
> > > src/backend/replication/logical/relation.c
> >
Hello, hackers.
I've attached the fifth version of the patch that incorporates suggestions
from Andrei.
The version runs successfully on top of 8fcd80258bcf43dab93d877
> Right now it is not clear for me if we can get resource statistics from
> those backends while those are listed in the pg_stat
On Wed, Nov 27, 2024 at 1:42 AM Michael Paquier wrote:
> I've edited the whole, added this extra test based on \syncpipeline in
> 17~, kept the remaining tests in 14~ where pgbench is able to handle
> them, and backpatched that down to 13. Let's see now what we can do
> with the psql bits.
Thank
Thank you!
On 2024-11-26 23:46, Andrew Dunstan wrote:
On 2024-11-26 Tu 1:24 AM, Marina Polyakova wrote:
Hello! Could you backport the commit "Fix meson uuid header check so
it works with MSVC" [1] to REL_16_STABLE please? Building with
-Duuid=ossp fails without it:
yep, done.
--
Marina P
Hi, all!
It seems I have found a bug in the Query ID calculation.
Problem
===
In some cases, we could have same IDs for not identical query trees.
For two structurally similar query subnodes, we may have query
trees that look like this:
QueryA->subNodeOne = Value X;
QueryA->subNodeTwo =
On Tue, Nov 26, 2024 at 04:24:58PM +0900, Michael Paquier wrote:
> Tweaks of the tests across multiple stable branches happen all the
> time, and adding one specific to 17~ is no big issue. I'm in the
> middle of it but I'm lacking the steam to do so today. Will likely
> finish tomorrow.
I've ed
David Rowley writes:
> It would be good to understand why get_parameterized_baserel_size()
> bothers accounting for the baserestrictinfo quals and does not just do
> clauselist_selectivity() on param_clauses alone and multiply by
> rel->rows (which should already account for the baserestrictinfo).
Hello, Nathan and Michael!
I believe I’ve identified the root cause of the issue. It appears to be
related to the GetNamedDSMSegment and injection_points module.
Here’s how it happens:
* A backend attaches (even locally!) to an injection point, which might get
triggered during resource release (
On Sat, Nov 23, 2024 at 1:19 PM jian he wrote:
>
> I didn't add a doc entry. I will do it later.
hi
attached patch with thorough tests and documentation.
one issue i still have is:
CREATE SCHEMA regress_schema_2 AUTHORIZATION CURRENT_ROLE
create domain ss1 as ss
create domain ss as text;
ERRO
jian he writes:
> one issue i still have is:
> CREATE SCHEMA regress_schema_2 AUTHORIZATION CURRENT_ROLE
> create domain ss1 as ss
> create domain ss as text;
> ERROR: type "ss" does not exist
> the error message seems not that OK,
> if we can point out the error position, that would be great
Hi Nisha,
Here are some review comments for the patch v50-0002.
==
src/backend/replication/slot.c
InvalidatePossiblyObsoleteSlot:
1.
+ if (now &&
+ TimestampDifferenceExceeds(s->inactive_since, now,
+replication_slot_inactive_timeout_sec * 1000))
Previously this was using an additional
> On 27 Nov 2024, at 04:11, Masahiko Sawada wrote:
>
> On Tue, Nov 26, 2024 at 1:55 PM Jelte Fennema-Nio wrote:
>>
>> On Tue, 26 Nov 2024 at 21:48, Sergey Prokhorenko
>> wrote:
>>> gen_uuidv7() is OK
>>
>> I'd very much prefer to not have a gen_ or get_ prefix as argued
>> before[1][2].
>
David Rowley writes:
> On Tue, 26 Nov 2024 at 12:12, Tom Lane wrote:
>> I'm kind of -0.5, but I'd not bothered to vote because it was
>> pretty clear what the result was going to be.
> Just so I can properly understand, how much of the -0.5 is "don't like
> the idea" vs "rather make changes to w
On Wed, Nov 27, 2024 at 3:30 AM Peter Smith wrote:
>
> Hi, here are some review comments for patch v7-0001.
>
> ==
> src/backend/replication/logical/relation.c
>
> logicalrep_report_missing_or_gen_attrs:
>
> 1.
> +/*
> + * If attempting to replicate missing or generated columns, report an erro
On Tue, 26 Nov 2024 at 02:58, Masahiko Sawada wrote:
>
> On Mon, Nov 18, 2024 at 11:12 PM vignesh C wrote:
> >
> >
> > Few comments:
>
> Thank you for reviewing the patch!
>
> > 1) Should we have the Assert inside ReorderBufferTruncateTXNIfAborted
> > instead of having it at multiple callers, Reo
>
>
>
> I'll be rebasing (that's done) and refactoring 0003 to get rid of the
> positional column, and moving 0014 next to 0003 because they touch the same
> files.
>
As promised, rebased (as of 8fcd80258bcf43dab93d877a5de0ce3f4d2bd471)
Things have been reordered here in a mostly-priority order:
Hi!
Introduction
The simple way to wait for a given lsn to replay on standby appears to
be useful because it provides a way to achieve read-your-writes
consistency while working with both replication leader and standby.
And it's both handy and cheaper to have built-in functionality for
that inste
Hi,
In
"Re: Make COPY format extendable: Extract COPY TO format implementations" on
Mon, 25 Nov 2024 23:10:50 -0800,
Masahiko Sawada wrote:
>> Custom COPY format extensions need to use
>> CopyToStateData/CopyFromStateData. For example,
>> CopyToStateData::rel is used to retrieve table sche
On Wed, 27 Nov 2024 at 02:20, Richard Guo wrote:
> In this regard, it seems that get_parameterized_baserel_size() does
> not do anything wrong.
>
> I think it might be better to modify set_append_rel_size() to set an
> appendrel's tuples to the sum of the tuples from each live child,
> rather than
On Tue, Nov 26, 2024 at 12:37 PM Melanie Plageman
wrote:
>
> On Tue, Nov 26, 2024 at 1:55 PM Masahiko Sawada wrote:
> >
> > Just to be clear, do users want the number of updated VM bits or the
> > number of pages whose visibility information is updated? For example,
> >
> > > visibility map: 5 pa
Hi,
I was looking into this function, especially this block of code[1], so
what I have noticed is that we always try to combine the sequential
block when the lookahead blocknum is higher than the
pending_read_blocknum, that's fine for ForwardScan. My question is
should we do something for backwar
On Tue, 26 Nov 2024 at 12:12, Tom Lane wrote:
> I'm kind of -0.5, but I'd not bothered to vote because it was
> pretty clear what the result was going to be.
Just so I can properly understand, how much of the -0.5 is "don't like
the idea" vs "rather make changes to well-known behaviour"?
David
On Tue, Nov 26, 2024 at 5:45 AM Peter Smith wrote:
>
> Hi Shubham,
>
> Here are my review comments for patch v5-0001.
>
> Please don't reply with a blanket "I have fixed the given comments"
> because it was not true. E.g., some of my previous comments are
> rejected in favour of Amit's better code
I have looked into the patches.
> Subject: [PATCH v3 1/3] Disallow characters that cannot be displayed in PDF
>
> ---
> doc/src/sgml/Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/doc/src/sgml/Makefile b/doc/src/sgml/Makefile
> index a04c532b53..18bf87d031
On 21.11.24 23:46, Andrew Dunstan wrote:
Questions:
1. Since Nikita’s patches did not address the JSON data type, and JSON
currently does not support subscripting, should we limit the initial
feature set to JSONB dot-notation for now? In other words, if we aim
to fully support JSON simplified ac
Hello.
Function bringetbitmap() in src/backend/access/brin/brin.c:560 returns
type int64. But the returned variable 'totalpages' is of type int. Maybe
it makes sense to change the type of variable 'totalpages' to int64 to
avoid possible overflow in expression 'totalpages * 10'?
Patch is incl
Hi Melih, Jeff,
I tested the v4 patch along with the memory statistics reporting patch from
[1] thread.
After running a plpgsql procedure periodically and querying its memory
consumption,
I see various child contexts of CacheMemoryContext created as shown in the
image below or link [2].
[image:
Hi,
Thank you for working on this!
On Mon, 25 Nov 2024 at 21:17, Kirill Reshke wrote:
> While reviewing other threads implementing stream API for various core
> subsystems, I spotted that pgstattuple could also benefit from that.
> So, PFA.
>
> Notice refactoring around pgstat_hash_page and chan
On Tue, 26 Nov 2024 at 02:57, Tom Lane wrote:
>
> [ getting back to the document-ABI-breakage-rules-better topic ... ]
>
> I wrote:
> > That text says exactly nothing about what specific code changes to
> > make or not make. I'm not sure offhand where (or if) we have this
> > documented, but ther
On Tue, Nov 26, 2024 at 1:37 PM Shubham Khanna
wrote:
>
> I have fixed the given comments. The attached Patch contains the
> required changes.
>
The patch looks mostly good to me. I have made slight adjustments in
the comments and error message. The following proposed error message
appears to hav
Hello
On 2024-Nov-26, Dmitry Nikitin wrote:
> Monday, November 25, 2024, 10:51:31 PM, you wrote:
>
> AH> Hmm, I think if we believe this to be really possible, we should have an
> AH> 'if/elog' test (or maybe a full ereport with ERRCODE_DATA_CORRUPTED
> AH> errcode) rather than an assertion. I
On 22.11.24 01:30, Paul Jungwirth wrote:
- return get_equal_strategy_number_for_am(am);
+ /* For GiST indexes we need to ask the opclass what strategy
number to use. */
+ if (am == GIST_AM_OID)
+ return GistTranslateStratnum(opclass,
RTEqualStrategyNumber);
+
> On 26 Nov 2024, at 01:11, Masahiko Sawada wrote:
>
> I've merged patches and renamed functions (also updated the commit
> message). Please find the attachment.
This comment
* On MacOS real time is truncated to microseconds.
should also note that on Windows we use ported version of gettimeof
On Tue, Nov 26, 2024 at 4:57 PM huyajun wrote:
> The get_parameterized_baserel_size function does not differentiate for
> PARTITIONED_REL and always appends the rel's own restriction clauses.
> However, for PARTITIONED_REL, rel->tuples is computed in set_append_rel_size
> which comes from the s
On Tue, Nov 26, 2024 at 4:10 PM Rahila Syed wrote:
>
>
> Having reviewed the discussion regarding potential fragmentation issues
> caused by
> creating a large number of new contexts in each backend, I would like to
> take a step
> back and better understand the motivation behind separating these
On Mon, 18 Nov 2024 at 18:20, wenhui qiu wrote:
> HI hackers
>These are algorithmic mathematical graphs,By default, vacuum will not be
> triggered frequently.Looking at the images
> the algorithms for pow and sqrt are close, do we want to cancel one of the
> algorithms?
>
> log2
> image.
91 matches
Mail list logo
