On Tue, Nov 26, 2024 at 1:37 PM Shubham Khanna <khannashubham1...@gmail.com> wrote: > > I have fixed the given comments. The attached Patch contains the > required changes. >
The patch looks mostly good to me. I have made slight adjustments in the comments and error message. The following proposed error message appears to have a missing connector between relation and columns: "cannot replicate to target relation \"%s.%s\" generated column: %s"; so, I propose to change it to: "logical replication target relation \"%s.%s\" has incompatible generated column: %s". The proposed message is similar to the existing message for missing columns. Additionally, I kept only one test case as there is no need to keep tests for every possible combination. -- With Regards, Amit Kapila.
v7-0001-Improve-error-message-for-replication-of-generate.patch
Description: Binary data
