Re: New standby_slot_names GUC in PG 17

On Tue, Jun 25, 2024 at 1:54 PM Amit Kapila wrote: > > On Tue, Jun 25, 2024 at 8:20 AM Masahiko Sawada wrote: > > > > On Tue, Jun 25, 2024 at 11:21 AM Zhijie Hou (Fujitsu) > > wrote: > > > > > > I agree the current name seems too generic and the suggested ' > > > synchronized_standby_slots ' >

Re: Add pg_get_acl() function get the ACL for a database object

On Tue, Jun 25, 2024, at 08:42, Michael Paquier wrote: > On Tue, Jun 25, 2024 at 08:06:41AM +0200, Joel Jacobson wrote: >> Not sure if I see how to implement it for pg_get_acl() though. >> >> I've had a look at how pg_describe_object() works for this case: >> >> SELECT pg_describe_object(0,'t'::r

Re: [EXTERNAL] Re: Add non-blocking version of PQcancel

On Tue, 25 Jun 2024 at 07:00, Alexander Lakhin wrote: > I'd just like to add that that one original query assumes several "remote" > queries (see the attached excerpt from postmaster.log with verbose logging > enabled). Nice catch! All those EXPLAIN queries are definitely not intentional, and lik

Re: Track the amount of time waiting due to cost_delay

Hi, On Tue, Jun 25, 2024 at 01:12:16AM +, Imseih (AWS), Sami wrote: Thanks for the feedback! > >> 2. the leader being interrupted while waiting is also already happening on > >> master > >> due to the pgstat_progress_parallel_incr_param() calls in > >> parallel_vacuum_process_one_index() (t

Re: New standby_slot_names GUC in PG 17

On Tue, Jun 25, 2024 at 12:30 PM Masahiko Sawada wrote: > > On Tue, Jun 25, 2024 at 1:54 PM Amit Kapila wrote: > > > > > So, my > > preference is in order as follows: synchronized_standby_slots, > > wait_for_standby_slots, logical_replication_wait_slots, > > logical_replication_synchronous_slots,

add a new explain option including_query for include query string inside the json plan output

for json format, add a new option to let the explain json output also include the actual query string. it can make json usage more convenient. Now you only need to grab the json output, no need to collect another explain statement and extract the actual query from the explain statement. including

RE: Slow catchup of 2PC (twophase) transactions on replica in LR

> Dear hackers, > > I found that v12 patch set could not be accepted by the cfbot. PSA new > version. To make others more trackable, I shared changes just in case. All failures were occurred on the pg_dump code. I added an attribute in pg_subscription and modified pg_dump code, but it was wron

Re: RFC: Additional Directory for Extensions

Re: Nathan Bossart > At first glance, the general idea seems reasonable to me. I'm wondering > whether there is a requirement for this directory to be prepended or if it > could be appended to the end. That way, the existing ones would take > priority, which might be desirable from a security sta

Re: Partial aggregates pushdown

On Tue, 25 Jun 2024 at 08:33, fujii.y...@df.mitsubishielectric.co.jp wrote: > Actually, I have other tasks about "PARTIAL_AGGREAGATE" keyword > to respond Requirement1 and Requirement2 in the following mail. > https://www.postgresql.org/message-id/TYAPR01MB3088755F2281D41F5EEF06D495F92%40TYAPR01MB

Re: Conflict Detection and Resolution

On Mon, Jun 24, 2024 at 1:47 PM shveta malik wrote: > > On Thu, Jun 20, 2024 at 6:41 PM Amit Kapila wrote: > > > > >> In the second patch, we can implement simple built-in resolution > > >> strategies like apply and skip (which can be named as remote_apply and > > >> keep_local, see [3][4] for de

Re: scalability bottlenecks with (many) partitions (and more)

On 6/24/24 17:05, Robert Haas wrote: > On Sun, Jan 28, 2024 at 4:57 PM Tomas Vondra > wrote: >> For NUM_LOCK_PARTITIONS this is pretty simple (see 0001 patch). The >> LWLock table has 16 partitions by default - it's quite possible that on >> machine with many cores and/or many partitions, we ca

Re: Conflict Detection and Resolution

On Tue, Jun 25, 2024 at 3:12 PM Amit Kapila wrote: > > On Mon, Jun 24, 2024 at 1:47 PM shveta malik wrote: > > > > On Thu, Jun 20, 2024 at 6:41 PM Amit Kapila wrote: > > > > > > >> In the second patch, we can implement simple built-in resolution > > > >> strategies like apply and skip (which can

Re: RFC: Additional Directory for Extensions

On 2024-Jun-24, Robert Haas wrote: > Is "tighten up what the superuser can do" on our list of objectives? > Personally, I think we should be focusing mostly, and maybe entirely, > on letting non-superusers do more things, with appropriate security > controls. The superuser can ultimately do anythi

Backporting BackgroundPsql

While fixing a recent bug on visibility on a standby [1], I wrote a regression test that uses BackgroundPsql to run some queries in a long-running psql session. The problem is that that was refactored in v17, commit 664d757531. The test I wrote for v17 doesn't work as it is on backbranches. Opt

Re: add a new explain option including_query for include query string inside the json plan output

On Tue, 25 Jun 2024 at 10:55, jian he wrote: > > for json format, add a new option to let the explain json output also > include the actual query string. How would this cooperate with e.g. EXPLAIN (...) EXECUTE my_prepared_statement? Would this query be the prepared statement's query, or the top-

Re: Backporting BackgroundPsql

On 25/06/2024 13:26, Heikki Linnakangas wrote: While fixing a recent bug on visibility on a standby [1], I wrote a regression test that uses BackgroundPsql to run some queries in a long-running psql session. The problem is that that was refactored in v17, commit 664d757531. The test I wrote for

Re: Meson far from ready on Windows

Hi, On 2024-06-21 12:20:49 +0100, Dave Page wrote: > > I'm confused - the old build system wasn't flexible around this stuff *at > > all*. Everyone had to patch it to get dependencies to work, unless you > > chose > > exactly the right source to download from - which was often not documented > > o

Re: Meson far from ready on Windows

On Tue, 25 Jun 2024 at 11:41, Andres Freund wrote: > Hi, > > On 2024-06-21 12:20:49 +0100, Dave Page wrote: > > > I'm confused - the old build system wasn't flexible around this stuff > *at > > > all*. Everyone had to patch it to get dependencies to work, unless you > > > chose > > > exactly the

Re: Meson far from ready on Windows

Hi, On 2024-06-24 09:44:57 +0100, Dave Page wrote: > To address Andres' concerns around mis-detection of dependencies, or other > oddities such as required compiler flags not being included, I would > suggest that a) that's happened very rarely, if ever, in the past, and b) > we can always spit ou

Re: Proposal: Document ABI Compatibility

On 24.06.24 22:26, David E. Wheeler wrote: But now we're talking about API. That might be subject of another document or another section in this one, but it seems confusing to mix this with the ABI discussion. Hrm. They’re super closely-related in my mind, as an extension developer. I need t

Re: Meson far from ready on Windows

Hi, On 2024-06-25 11:54:56 +0100, Dave Page wrote: > https://github.com/dpage/winpgbuild proves that the hacks above are not > required *if* you build the dependencies in the recommended way for use > with MSVC++ (where documented), otherwise just native Windows. Partially it just means that some

Re: Backporting BackgroundPsql

Hi, On 2024-06-25 13:26:23 +0300, Heikki Linnakangas wrote: > While fixing a recent bug on visibility on a standby [1], I wrote a > regression test that uses BackgroundPsql to run some queries in a > long-running psql session. The problem is that that was refactored in v17, > commit 664d757531. Th

Re: RFC: Additional Directory for Extensions

On Tue, 25 Jun 2024 at 12:12, Alvaro Herrera wrote: > They can mutilate the system catalogs: yes, they can TRUNCATE pg_type. > So what? They've just destroyed their own ability to do anything else. > The real issue here is that they can edit pg_proc to cause SQL function > calls to call arbitrary

Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY

Hello, Michael! > As far as I can see, it depends on what kind of query semantics and > the amount of transparency you are looking for here in your > application. An error in the query itself can also be defined as > useful so as your application is aware of what happens as an effect of > the con

Re: Vacuum ERRORs out considering freezing dead tuples from before OldestXmin

Hi, On 2024-06-24 16:35:50 -0400, Robert Haas wrote: > On Mon, Jun 24, 2024 at 3:23 PM Melanie Plageman > wrote: > > Are you more concerned about having a single horizon for pruning or > > about having a horizon that does not move backwards after being > > established at the beginning of vacuumin

Re: Proposal: Document ABI Compatibility

Peter Eisentraut writes: > On 24.06.24 22:26, David E. Wheeler wrote: >>> But now we're talking about API. That might be subject of another >> document or another section in this one, but it seems confusing to mix >> this with the ABI discussion. >> Hrm. They’re super closely-related in my mind,

Re: PostgreSQL does not compile on macOS SDK 15.0

Hi, > I've reproduced this issue by: > > 1. Download the XCode 16 beta 2 ZIP file: > https://developer.apple.com/services-account/download?path=/Developer_Tools/Xcode_16_beta/Xcode_16_beta.xip > 2. Extract this to `/tmp`. > 3. Then I ran: > > export > PATH=/tmp/Xcode-beta.app/Contents/Developer/T

Re: Logical Replication of sequences

On Thu, 20 Jun 2024 at 18:24, vignesh C wrote: > > On Wed, 19 Jun 2024 at 20:33, vignesh C wrote: > > > > On Tue, 18 Jun 2024 at 16:10, Amit Kapila wrote: > > > > > > > > > Agreed and I am not sure which is better because there is a value in > > > keeping the state name the same for both sequenc

Re: Meson far from ready on Windows

Hi On Tue, 25 Jun 2024 at 12:39, Andres Freund wrote: > Hi, > > On 2024-06-25 11:54:56 +0100, Dave Page wrote: > > https://github.com/dpage/winpgbuild proves that the hacks above are not > > required *if* you build the dependencies in the recommended way for use > > with MSVC++ (where documented

Re: improve ssl error code, 2147483650

On 21.06.24 16:53, Tom Lane wrote: Peter Eisentraut writes: - strlcpy(errbuf, strerror(ERR_GET_REASON(ecode)), SSL_ERR_LEN); + strerror_r(ERR_GET_REASON(ecode), errbuf, SSL_ERR_LEN); Most of libpq gets at strerror_r via SOCK_STRERROR for Windows portability. Is that relevant here

Re: Vacuum ERRORs out considering freezing dead tuples from before OldestXmin

On Tue, Jun 25, 2024 at 8:03 AM Andres Freund wrote: > I think that's going in the wrong direction. We *want* to prune more > aggressively if we can (*), the necessary state is represented by the > vistest. That's a different thing than *having* to prune tuples beyond a > certain xmin (the cutoff

Re: Vacuum ERRORs out considering freezing dead tuples from before OldestXmin

On 2024-06-25 08:42:02 -0400, Robert Haas wrote: > On Tue, Jun 25, 2024 at 8:03 AM Andres Freund wrote: > > I think that's going in the wrong direction. We *want* to prune more > > aggressively if we can (*), the necessary state is represented by the > > vistest. That's a different thing than *hav

RE: Pgoutput not capturing the generated columns

Dear Shlok, Thanks for updating patches! Below are my comments, maybe only for 0002. 01. General IIUC, we are not discussed why ALTER SUBSCRIPTION ... SET include_generated_columns is prohibit. Previously, it seems okay because there are exclusive options. But now, such restrictions are gone.

Re: pg_combinebackup --clone doesn't work

On 21.06.24 18:10, Tomas Vondra wrote: On 6/21/24 00:07, Tomas Vondra wrote: Here's a fix adding the missing headers to pg_combinebackup, and fixing some compile-time issues in the ifdef-ed block. I've done some basic manual testing today - I plan to test this a bit more tomorrow, and I'll also

Re: Direct SSL connection and ALPN loose ends

I reviewed the documentation for "direct ALPN connections' ', and it looks like it could be improved. Here's the link: https://www.postgresql.org/docs/17/protocol-flow.html#PROTOCOL-FLOW-SSL The currently suggested values for "sslnegotiations" are "direct" and "postgres". The project name is Postg

Re: PostgreSQL does not compile on macOS SDK 15.0

Hi, > IMO the right way to test PostgreSQL against the recent beta version > of MacOS SDK would be replacing (via a symlink perhaps) the SDK > provided by the "Command Line Tools for Xcode" package > (/Library/Developer/CommandLineTools/SDKs/). Or alternatively finding > the official way of instal

Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs

On Mon, Jun 24, 2024 at 9:19 AM Jelte Fennema-Nio wrote: > > > Patch 3: Similar to 1 & 2 in that it has no actual effect yet. But > > > after bumping the version this would be a user visible API change, so > > > I expect it requires a bit more discussion. > > > > I don't know if this is the right

Recommended books for admin

I’m a complete novice, although I’ve dipped my toes in Admin waters a couple of times in my many years of using Linux. Can anyone recommend a good book on installing Postgres on multiple, connected multiuser systems, tuning it, managing users, backups, updated, etc. A cookbook/checklist approach

Re: Recommended books for admin

Hi Tom There is alot of stuff available online, you just need to find it, also the Official PG documentation is extensive too.. Regards Kashif Zeeshan On Tue, Jun 25, 2024 at 7:04 PM Tom Browder wrote: > I’m a complete novice, although I’ve dipped my toes in Admin waters a > couple of times in

Re: Recommended books for admin

Check out the left side bar https://www.postgresql.org/docs/ > On Jun 25, 2024, at 10:04 AM, Tom Browder wrote: > > I’m a complete novice, although I’ve dipped my toes in Admin waters a couple > of times in my many years of using Linux. > > Can anyone recommend a good book on installing Post

Re: Recommended books for admin

Hi , Here is a lately published book https://www.amazon.com/PostgreSQL-Administration-Cookbook-real-world-challenges-ebook/dp/B0CP5PPSTQ Muhammad Ikram Bitnine Global On Tue, 25 Jun 2024 at 19:09, Bill Smith wrote: > Check out the left side bar > > Documentation

Re: Direct SSL connection and ALPN loose ends

On Tue, 25 Jun 2024 at 09:37, Vladimir Sitnikov wrote: > I reviewed the documentation for "direct ALPN connections' ', and it looks > like it could be improved. > Here's the link: > https://www.postgresql.org/docs/17/protocol-flow.html#PROTOCOL-FLOW-SSL > > The currently suggested values for "ssl

Re: improve ssl error code, 2147483650

Peter Eisentraut writes: > On 21.06.24 16:53, Tom Lane wrote: >> Most of libpq gets at strerror_r via SOCK_STRERROR for Windows >> portability. Is that relevant here? > Looking inside the OpenSSL code, it makes no efforts to translate > between winsock error codes and standard error codes, so I

Re: add a new explain option including_query for include query string inside the json plan output

Matthias van de Meent writes: > On Tue, 25 Jun 2024 at 10:55, jian he wrote: >> for json format, add a new option to let the explain json output also >> include the actual query string. > Wouldn't the user be able to keep track of the query they wanted > explained by themselves? If not, why? In

Re: Backporting BackgroundPsql

Andres Freund writes: > On 2024-06-25 13:26:23 +0300, Heikki Linnakangas wrote: >> 1. Write the new test differently on backbranches. Before 664d757531, the >> test needs to work a lot harder to use the background psql session, calling >> pump() etc. That's doable, but as noted in the discussion t

Re: PostgreSQL does not compile on macOS SDK 15.0

Hi, On 2024-06-25 16:49:32 +0300, Aleksander Alekseev wrote: > ... to make sure Postgres will not find the older version of SDK (it > did until I made this step). You should be able to influence that by specifying -Ddarwin_sysroot=... > ... and get the error reported by Stan. Also I can confirm

Re: Vacuum ERRORs out considering freezing dead tuples from before OldestXmin

On Tue, Jun 25, 2024 at 9:07 AM Andres Freund wrote: > It's not hard - but it has downsides. It'll mean that - outside of vacuum - > we'll much more often not react to horizons going backwards due to > hot_standby_feedback. Which means that hot_standby_feedback, when used without > slots, will pre

Re: pg_combinebackup --clone doesn't work

On 6/25/24 15:21, Peter Eisentraut wrote: > On 21.06.24 18:10, Tomas Vondra wrote: >> On 6/21/24 00:07, Tomas Vondra wrote: >>> Here's a fix adding the missing headers to pg_combinebackup, and fixing >>> some compile-time issues in the ifdef-ed block. >>> >>> I've done some basic manual testing

Re: Vacuum ERRORs out considering freezing dead tuples from before OldestXmin

On 24.06.2024 17:37, Melanie Plageman wrote: On Mon, Jun 24, 2024 at 4:10 AM Alena Rybakina wrote: We can fix this by always removing tuples considered dead before VacuumCutoffs->OldestXmin. This is okay even if a reconnected standby has a transaction that sees that tuple as alive, because it w

Re: PostgreSQL does not compile on macOS SDK 15.0

Andres Freund writes: > On 2024-06-25 16:49:32 +0300, Aleksander Alekseev wrote: >> Another question is whether we should fix this while the SDK is in >> beta or only after it is released. > Yea. Stan has started multiple threads about this, which is not doing anyone any favors, but that issue w

Re: RFC: Additional Directory for Extensions

On Tue, Jun 25, 2024 at 6:12 AM Alvaro Herrera wrote: > Now, I'm not saying that this is an easy journey. But if we don't > start, we're not going to get there. I actually kind of agree with you. I think I've said something similar in a previous email to the list somewhere. But I don't agree tha

Fix possible overflow of pg_stat DSA's refcnt

Hi, During backend initialisation, pgStat DSA is attached using dsa_attach_in_place with a NULL segment. The NULL segment means that there's no callback to release the DSA when the process exits. pgstat_detach_shmem only calls dsa_detach which, as mentioned in the function's comment, doesn't inclu

Re: Backporting BackgroundPsql

On Tue, Jun 25, 2024 at 7:40 AM Andres Freund wrote: > > Hi, > > On 2024-06-25 13:26:23 +0300, Heikki Linnakangas wrote: > > While fixing a recent bug on visibility on a standby [1], I wrote a > > regression test that uses BackgroundPsql to run some queries in a > > long-running psql session. The

Re: improve predefined roles documentation

On Mon, Jun 24, 2024 at 03:53:46PM -0700, David G. Johnston wrote: > pg_database_owner owns the initially created public schema and has an > implicit membership list of one - the role owning the connected-to database. > It exists to encourage and facilitate best practices regarding database > admin

Re: Vacuum ERRORs out considering freezing dead tuples from before OldestXmin

On Tue, Jun 25, 2024 at 10:31 AM Robert Haas wrote: > > On Tue, Jun 25, 2024 at 9:07 AM Andres Freund wrote: > > It's not hard - but it has downsides. It'll mean that - outside of vacuum - > > we'll much more often not react to horizons going backwards due to > > hot_standby_feedback. Which means

Re: Direct SSL connection and ALPN loose ends

On Thu, Jun 20, 2024 at 4:32 PM Jacob Champion wrote: > Thanks, > --Jacob Hey Heikki, [sending this to the list in case it's not just me] I cannot for the life of me get GMail to deliver your latest message, even though I see it on postgresql.org. It's not in spam; it's just gone. I wonder if i

Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY

Hello, Noah! Answering https://www.postgresql.org/message-id/flat/20240612194857.1c.nmisch%40google.com#684361ba86bad11f4e9fd84dfa8e0084 > On your other thread, it would be useful to see stack traces from the high-CPU > processes once the live lock has ended all query completion. I was wrong, it

Re: Backporting BackgroundPsql

On 2024-06-25 Tu 10:26 AM, Tom Lane wrote: Andres Freund writes: On 2024-06-25 13:26:23 +0300, Heikki Linnakangas wrote: 1. Write the new test differently on backbranches. Before 664d757531, the test needs to work a lot harder to use the background psql session, calling pump() etc. That's doa

Re: Direct SSL connection and ALPN loose ends

On Tue, Jun 25, 2024 at 7:20 AM Dave Cramer wrote: > > On Tue, 25 Jun 2024 at 09:37, Vladimir Sitnikov > wrote: >> >> "SSL". Technically, the proper term is TLS, and even the document refers to >> "IANA TLS ALPN Protocol IDs" (TLS, not SSL). >> I would not die on that hill, however, going for t

Re: Injection point locking

On Tue, Jun 25, 2024 at 11:14:57AM +0900, Michael Paquier wrote: > On Mon, Jun 24, 2024 at 01:29:38PM +0300, Heikki Linnakangas wrote: > > InjectionPointRun() acquires InjectionPointLock, looks up the hash entry, > > and releases the lock: > > > > > LWLockAcquire(InjectionPointLock, LW_SHARED);

Re: improve predefined roles documentation

On Tue, Jun 25, 2024 at 11:35 AM Nathan Bossart wrote: > IIUC the intent of this is to expand on the following sentence in the > existing docs: > > pg_database_owner cannot be a member of any role, and it cannot have > non-implicit members. > > My instinct would be to do something

Re: improve predefined roles documentation

On Tue, Jun 25, 2024 at 12:16:30PM -0400, Robert Haas wrote: > pg_database_owner is a predefined role for which membership consists, > implicitly, of the current database owner. It cannot be granted > membership in any role, and no role can be granted membership in > pg_database_owner. However, lik

Re: Vacuum ERRORs out considering freezing dead tuples from before OldestXmin

On Tue, Jun 25, 2024 at 11:39 AM Melanie Plageman wrote: > On Tue, Jun 25, 2024 at 10:31 AM Robert Haas wrote: > > On Tue, Jun 25, 2024 at 9:07 AM Andres Freund wrote: > > > It's not hard - but it has downsides. It'll mean that - outside of vacuum > > > - > > > we'll much more often not react t

Re: [PATCH] Add ACL (Access Control List) acronym

On Tue, Jun 25, 2024 at 08:10:24AM +0200, Joel Jacobson wrote: > On Tue, Jun 25, 2024, at 07:11, Michael Paquier wrote: >> v1 is fine without the "privileges list" part mentioned by Nathan in >> the first reply. > > v2 is exactly that, but renamed and attached, so we have an entry this > was the l

Re: Vacuum ERRORs out considering freezing dead tuples from before OldestXmin

Hi, On 2024-06-25 12:31:11 -0400, Robert Haas wrote: > On Tue, Jun 25, 2024 at 11:39 AM Melanie Plageman > wrote: > > On Tue, Jun 25, 2024 at 10:31 AM Robert Haas wrote: > > > On Tue, Jun 25, 2024 at 9:07 AM Andres Freund wrote: > > > > It's not hard - but it has downsides. It'll mean that - ou

Re: RFC: Additional Directory for Extensions

On Jun 24, 2024, at 5:32 PM, Jelte Fennema-Nio wrote: > Still, for the sake of completeness it might make sense to support > this whole list in extension_destdir. (assuming it's easy to do) It should be with the current patch, which just uses a prefix to paths in `pg_config`. So if SHAREDIR is

Re: New standby_slot_names GUC in PG 17

On Tue, Jun 25, 2024 at 02:02:09PM +0530, Amit Kapila wrote: > On Tue, Jun 25, 2024 at 12:30 PM Masahiko Sawada > wrote: >> On Tue, Jun 25, 2024 at 1:54 PM Amit Kapila wrote: >> > So, my >> > preference is in order as follows: synchronized_standby_slots, >> > wait_for_standby_slots, logical_repl

Re: PostgreSQL does not compile on macOS SDK 15.0

Thanks, everyone. Sorry to create multiple threads on this. As I mentioned in the other thread, I've already submitted a bug report to Apple (FB14047412). My colleagues know a key macOS engineer, and they have reached out to him to review that thread and bug report. I'll update if we hear anything

RE: Proposal for Updating CRC32C with AVX-512 Algorithm.

> It would be good to know exactly what, if any, changes the Intel lawyers want > us to make to our license if we accept this patch. I asked about this and there is nothing Intel requires here license wise. They believe that there is nothing wrong with including Clause-3 BSD like licenses under

Re: Proposal for Updating CRC32C with AVX-512 Algorithm.

On Tue, Jun 25, 2024 at 05:41:12PM +, Amonson, Paul D wrote: > > It would be good to know exactly what, if any, changes the Intel > > lawyers want us to make to our license if we accept this patch. > > I asked about this and there is nothing Intel requires here license > wise. They believe that

Re: Patch bug: Fix jsonpath .* on Arrays

On Jun 25, 2024, at 12:46 AM, Степан Неретин wrote: > Hi! Looks good to me, but I have several comments. Thanks for your review! > Your patch improves tests, but why did you change formatting in > jsonpath_exec.c? What's the motivation? It’s not just formatting. From the commit message: > Wh

Re: Proposal: Document ABI Compatibility

On Jun 25, 2024, at 7:33 AM, Peter Eisentraut wrote: > I took at a stab at this, using some of your text, but discussing API and ABI > separately. Oh man this is fantastic, thank you! I’d be more than happy to just turn this into a patch. But where should it go? Upthread I assumed xfunc.sgml,

Re: Vacuum ERRORs out considering freezing dead tuples from before OldestXmin

On Tue, Jun 25, 2024 at 1:10 PM Andres Freund wrote: > That said, obviously there will be plenty setups where this won't cause an > issue. I don't really have a handle on how often it'd be a problem. Fair enough. Even if it's not super-common, it doesn't seem like a great idea to regress such sce

Re: improve predefined roles documentation

On Tue, Jun 25, 2024 at 11:28:18AM -0500, Nathan Bossart wrote: > On Tue, Jun 25, 2024 at 12:16:30PM -0400, Robert Haas wrote: >> pg_database_owner is a predefined role for which membership consists, >> implicitly, of the current database owner. It cannot be granted >> membership in any role, and n

Re: Apparent bug in WAL summarizer process (hung state)

On Mon, Jun 24, 2024 at 1:56 PM Israel Barth Rubio wrote: > I've been playing a bit with the incremental backup feature which might come > as > part of the 17 release, and I think I hit a possible bug in the WAL summarizer > process. > > The issue that I face refers to the summarizer process gett

Re: Apparent bug in WAL summarizer process (hung state)

Robert Haas writes: > Yeah, this is a bug. It seems that the WAL summarizer process, when > restarted, wants to restart from wherever it was previously > summarizing WAL, which is correct if that WAL is still around, but if > summarize_wal has been turned off in the meanwhile, it might not be > co

Re: improve predefined roles documentation

On Tue, Jun 25, 2024 at 3:26 PM Nathan Bossart wrote: > I used this in v4 (with some minor changes). Looking at this again, how happy are you with the way you've got several roles per instead of one for each? I realize that was probably part of the intent of the change, to move the data from bel

Re: Apparent bug in WAL summarizer process (hung state)

On Tue, Jun 25, 2024 at 3:51 PM Tom Lane wrote: > This comment seems to be truncated: Thanks. New version attached. -- Robert Haas EDB: http://www.enterprisedb.com v2-0001-Prevent-summarizer-hang-when-summarize_wal-turned.patch Description: Binary data

Re: scalability bottlenecks with (many) partitions (and more)

On Tue, Jun 25, 2024 at 6:04 AM Tomas Vondra wrote: > Yeah, definitely needs comment explaining this. > > I admit those numbers are pretty arbitrary primes, to implement a > trivial hash function. That was good enough for a PoC patch, but maybe > for a "proper" version this should use a better has

Re: improve predefined roles documentation

On Tue, Jun 25, 2024 at 04:04:03PM -0400, Robert Haas wrote: > Looking at this again, how happy are you with the way you've got > several roles per instead of one for each? I realize > that was probably part of the intent of the change, to move the data > from below the table into the table, and I

Re: Vacuum ERRORs out considering freezing dead tuples from before OldestXmin

On 2024-06-25 14:35:00 -0400, Robert Haas wrote: > Is there any way that we could instead tweak things so that we adjust > the visibility test object itself? Like can have a GlobalVisTest API > where we can supply the OldestXmin from the VacuumCutoffs and have it > ... do something useful with that

Re: Backporting BackgroundPsql

> On 25 Jun 2024, at 16:26, Tom Lane wrote: > > Andres Freund writes: >> On 2024-06-25 13:26:23 +0300, Heikki Linnakangas wrote: >>> 1. Write the new test differently on backbranches. Before 664d757531, the >>> test needs to work a lot harder to use the background psql session, calling >>> pump(

Should we document how column DEFAULT expressions work?

Hello, It's possible I'm the only one who's been in this situation, but I've multiple times found myself explaining to a user how column DEFAULT expressions work: namely how the quoting on an expression following the keyword DEFAULT controls whether or not the expression is evaluated at the time o

Re: Backporting BackgroundPsql

Daniel Gustafsson writes: > Before pulling any triggers I think https://commitfest.postgresql.org/48/4959/ > should be considered, since Tom found some flaws in the current code around > how > timers and timeouts are used. That's certainly another issue to consider, but is it really a blocker fo

Re: Should we document how column DEFAULT expressions work?

James Coleman writes: > It's possible I'm the only one who's been in this situation, but I've > multiple times found myself explaining to a user how column DEFAULT > expressions work: namely how the quoting on an expression following > the keyword DEFAULT controls whether or not the expression is

Re: Backporting BackgroundPsql

> On 25 Jun 2024, at 22:57, Tom Lane wrote: > > Daniel Gustafsson writes: >> Before pulling any triggers I think >> https://commitfest.postgresql.org/48/4959/ >> should be considered, since Tom found some flaws in the current code around >> how >> timers and timeouts are used. > > That's cert

Zero -downtime FULL VACUUM/clustering/defragmentation with zero-downtime and now extra disk space

Hi guys, This is inspired by this TODO list https://wiki.postgresql.org/wiki/Todo#CLUSTER and by pg_repack and pg_freeze projects. My final goal is to create an extension that does direct data-file to data-file transfer (no intermediate tables, no triggers) with no blocking at all in order to simu

Re: RFC: Additional Directory for Extensions

On Jun 25, 2024, at 10:43 AM, Robert Haas wrote: > If we want to work on making the sorts of changes that > you're proposing, let's do it on a separate thread. It's not going to > be meaningfully harder to move in that direction after some patch like > this than it is today. I appreciate this se

Re: Should we document how column DEFAULT expressions work?

On Tue, Jun 25, 2024 at 4:59 PM Tom Lane wrote: > > James Coleman writes: > > It's possible I'm the only one who's been in this situation, but I've > > multiple times found myself explaining to a user how column DEFAULT > > expressions work: namely how the quoting on an expression following > > t

Re: IPC::Run accepts bug reports

On Mon, Jun 17, 2024 at 01:56:46PM -0400, Robert Haas wrote: > On Sat, Jun 15, 2024 at 7:48 PM Noah Misch wrote: > > Separating this from the pytest thread: > > > > On Sat, Jun 15, 2024 at 01:26:57PM -0400, Robert Haas wrote: > > > The one > > > thing I know about that *I* think is a pretty big pr

Re: Should we document how column DEFAULT expressions work?

James Coleman writes: > On Tue, Jun 25, 2024 at 4:59 PM Tom Lane wrote: >> Uh ... what? I recall something about that with respect to certain >> features such as nextval(), but you're making it sound like there >> is something generic going on with DEFAULT. > Hmm, I guess I'd never considered a

Re: POC, WIP: OR-clause support for indexes

On 24.06.2024 18:28, Robert Haas wrote: On Fri, Jun 21, 2024 at 6:52 PM Alena Rybakina wrote: It's hard to tell, but I think it might be one of the good places to apply transformation. Let me describe a brief conclusion on the two approaches. This explanation is somewhat difficult for me to

Re: Vacuum ERRORs out considering freezing dead tuples from before OldestXmin

On Tue, Jun 25, 2024 at 4:41 PM Andres Freund wrote: > I doubt that's doable in the back branches. And even on HEAD, I don't think > it's a particularly attractive option - there's just a global vistest for each > of the types of objects with a specific horizon (they need to be updated > occasiona

CI, macports, darwin version problems

Hi, Problem #1: we're still using Ventura, but Cirrus has started doing this: Only ghcr.io/cirruslabs/macos-runner:sonoma is allowed. Automatically upgraded. It doesn't do it to cfbot, which runs macOS stuff on PGDG-hosted Mac Minis, but it does it to regular users who use free compute minutes t

Re: CI, macports, darwin version problems

Thomas Munro writes: > I know how to find out which darwin version is running: uname -r | sed > 's/\..*//'. What I don't know is how to find the darwin version for a > macports installation. "port platform"? regards, tom lane

Re: Backporting BackgroundPsql

On 2024-Jun-25, Tom Lane wrote: > Daniel Gustafsson writes: > > However, since Andrew is actively aiming to replace all of this shortly, > > should > > we wait a see where that lands to avoid having to backport another library > > change? > > I would like to see what he comes up with ... but i

Re: Backporting BackgroundPsql

On Wed, Jun 26, 2024 at 02:12:42AM +0200, Alvaro Herrera wrote: > FWIW I successfully used the preliminary PqFFI stuff Andrew posted to > write a test program for bug #18377, which I think ended up being better > than with BackgroundPsql, so I think it's a good way forward. As for > back-patching

Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)

On Mon, Nov 27, 2023 at 01:43:26AM +0200, Alexander Korotkov wrote: > v61 looks good to me. I'm going to push it as long as there are no > objections. This yielded commit 4ed8f09 "Index SLRUs by 64-bit integers rather than by 32-bit integers" and left some expressions coercing SLRU page numbers

Re: [PATCH] Add ACL (Access Control List) acronym

On Tue, Jun 25, 2024 at 11:55:03AM -0500, Nathan Bossart wrote: > On Tue, Jun 25, 2024 at 08:10:24AM +0200, Joel Jacobson wrote: > > On Tue, Jun 25, 2024, at 07:11, Michael Paquier wrote: > >> v1 is fine without the "privileges list" part mentioned by Nathan in > >> the first reply. > > > > v2 is

psql (PostgreSQL) 17beta2 (Debian 17~beta2-1.pgdg+~20240625.1534.g23c5a0e) Failed to retrieve data from the server..

psql (PostgreSQL) 17beta2 (Debian 17~beta2-1.pgdg+~20240625.1534.g23c5a0e) Failed to retrieve data from the server.. retrieve information from database: column "daticulocale" does not exist LINE 5: datconnlimit, daticulocale, daticurules, datcollversion, ^ HINT: Perhaps you meant to reference

  1   2   >