I saw the following message recently added to publicationcmds.c.
(ERROR: cannot use publication column list for relation "%s.%s"")
> DETAIL: Column list cannot be specified if any schema is part of the
> publication or specified in the list.
As my reading, the "the list" at the end syntactically
Hello Kyotaro,
any further thoughts on it?
Regards,
--
Alexander Kukushkin
At Fri, 16 Sep 2022 23:21:50 -0500, Justin Pryzby wrote
in
> @cfbot: rebased over adb466150, which did the same thing as one of the
> hunks in xlogreader.c.
Oops. Thanks! And then this gets a further conflict (param names
harmonization). So further rebased. And removed an extra blank line
you
On Mon, Sep 26, 2022 at 14:47 PM Andres Freund wrote:
> Hi,
>
> On 2022-09-26 06:24:42 +, wangw.f...@fujitsu.com wrote:
> > I tried to use meson and ninja and they are really efficient.
> > But when I tried to specify "c_args", it did not take effect.
>
> They should take effect, but won't b
On 2022-Sep-26, Kyotaro Horiguchi wrote:
> I saw the following message recently added to publicationcmds.c.
>
> (ERROR: cannot use publication column list for relation "%s.%s"")
> > DETAIL: Column list cannot be specified if any schema is part of the
> > publication or specified in the list.
>
Hi All,
Consider the below test:
postgres@53130=#create role test WITH login createdb;
CREATE ROLE
postgres@53130=#\c - test
You are now connected to database "postgres" as user "test".
postgres@53150=#create database test;
CREATE DATABASE
postgres@53150=#\c - rushabh
You are now connected to dat
On Mon, Sep 26, 2022 at 06:57:28AM +, kuroda.hay...@fujitsu.com wrote:
> While reviewing [1], I and Amit noticed that a flag ParallelMessagePending is
> defined
> as "volatile bool", but other flags set by signal handlers are defined as
> "volatile sig_atomic_t".
>
> How do you think?
You a
On Mon, Sep 26, 2022 at 01:13:53PM +0530, Rushabh Lathia wrote:
> Please find the attached patch which fixes the case.
Could it be possible to stress this stuff in the regression tests?
There is a gap here. (I have not looked at what you are proposing.)
--
Michael
signature.asc
Description: PGP
On Mon, Sep 26, 2022 at 1:10 PM Alvaro Herrera wrote:
>
> On 2022-Sep-26, Kyotaro Horiguchi wrote:
>
> > I saw the following message recently added to publicationcmds.c.
> >
> > (ERROR: cannot use publication column list for relation "%s.%s"")
> > > DETAIL: Column list cannot be specified if any s
At Mon, 26 Sep 2022 11:57:58 +0530, Bharath Rupireddy
wrote in
> On Mon, Sep 26, 2022 at 8:13 AM Michael Paquier wrote:
> >
> > What I had at hand seemed fine on a second look, so applied after
> > tweaking a couple of comments. One thing that I have been wondering
> > after-the-fact is whethe
On Wed, Sep 21, 2022 at 7:11 AM Andres Freund wrote:
>
> I added installation instructions for meson for a bunch of platforms, but
A couple more things for the wiki:
1) /opt/homebrew/ seems to be an "Apple silicon" path? Either way it
doesn't exist on this machine. I was able to get a working bu
Hi,
On 9/23/22 10:45 PM, Andres Freund wrote:
Hi,
On 2022-09-01 08:40:54 +0200, Drouvot, Bertrand wrote:
Thanks for the suggestion, I'm coming up with this proposal in v4 attached:
I pushed the bugfix / related test portion to 15, master. Thanks!
Thanks!
I left the replication stuff
Dear Wang,
Thanks for updating patch!... but cfbot says that it cannot be accepted [1].
I thought the header should be included, like miscadmin.h.
[1]: https://cirrus-ci.com/task/5909508684775424
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
At Sat, 17 Sep 2022 23:53:07 -0500, Justin Pryzby wrote
in
> This is an alternative implementation, which still relies on adding the
> GUC_DYNAMIC, flag but doesn't require adding a new, sql-accessible
> function to convert the GUC to a pretty/human display value.
Thanks!
I'm not sure shared_b
On 2022-Sep-26, Amit Kapila wrote:
> On Mon, Sep 26, 2022 at 1:10 PM Alvaro Herrera
> wrote:
> > ERROR: cannot use column list for relation "%s.%s" in publication "%s"
> > DETAIL: Column lists cannot be specified in publications containing FOR
> > TABLES IN SCHEMA elements.
>
> This looks m
On 2022-Sep-25, Andres Freund wrote:
> From 3eb0ca196084da314d94d1e51c7b775012a4773c Mon Sep 17 00:00:00 2001
> From: Andres Freund
> Date: Wed, 21 Sep 2022 11:03:07 -0700
> Subject: [PATCH v16 04/16] meson: Add windows resource files
> diff --git a/src/backend/jit/llvm/meson.build
> b/src/back
On Mon, Sep 26, 2022 at 2:03 PM Alvaro Herrera wrote:
>
> On 2022-Sep-26, Amit Kapila wrote:
>
> > On Mon, Sep 26, 2022 at 1:10 PM Alvaro Herrera
> > wrote:
>
> > > ERROR: cannot use column list for relation "%s.%s" in publication "%s"
> > > DETAIL: Column lists cannot be specified in publicat
On Monday, September 26, 2022 4:57 PM Amit Kapila
>
> On Mon, Sep 26, 2022 at 2:03 PM Alvaro Herrera
> wrote:
> >
> > On 2022-Sep-26, Amit Kapila wrote:
> >
> > > On Mon, Sep 26, 2022 at 1:10 PM Alvaro Herrera
> wrote:
> >
> > > > ERROR: cannot use column list for relation "%s.%s" in publicati
Hi,
On Mon, Sep 26, 2022 at 03:12:46PM +0900, bt22nakamorit wrote:
>
> pg_stat_statements module distinguishes queries with different structures,
> but some visibly different MERGE queries were combined as one
> pg_stat_statements entry.
> For example,
> MERGE INTO test1 USING test2 ON test1.id =
Wolfgang Walther writes:
> Peter Geoghegan:
>> On Sun, Sep 25, 2022 at 8:55 AM Wolfgang Walther
>> wrote:
>>> The attached patch adds a DO RETURN clause to be able to do this:
>>>
>>> INSERT INTO x (id) VALUES (1)
>>> ON CONFLICT DO RETURN
>>> RETURNING created_at;
>>>
>>> Much simpler.
On Tue, Sep 20, 2022 at 10:45 PM Jacob Champion
wrote:
> On Thu, Sep 8, 2022 at 2:34 PM Jacob Champion
> wrote:
> > I still have yet to update the section "5 to 7 days before end of CF"
> > and onward.
>
> Well, I've saved the hardest part for last...
>
> Ibrar, Hamid, have the checklist rewrite
Hi,
On 9/21/22 6:07 PM, Fujii Masao wrote:
On 2022/09/19 15:29, Drouvot, Bertrand wrote:
Please find attached v6 taking care of the remarks mentioned above.
Thanks for updating the patch!
+SET pg_stat_statements.track_utility = TRUE;
+
+-- PL/pgSQL procedure and pg_stat_statements.track =
Hi hackers,
I wanted to add ARM CPU darwin to the CI but it seems
that kerberos/001_auth fails on ARM CPU darwin.
OS:
Darwin admins-Virtual-Machine.local 21.6.0 Darwin Kernel Version 21.6.0:
Wed Aug 10 14:26:07 PDT 2022; root:xnu-8020.141.5~2/RELEASE_ARM64_VMAPPLE
arm64
Error message:
Can't exec
On Mon, Sep 26, 2022 at 8:41 AM wangw.f...@fujitsu.com
wrote:
>
> On Thur, Sep 22, 2022 at 18:12 PM Amit Kapila wrote:
>
> > 3.
> > ApplyWorkerMain()
> > {
> > ...
> > ...
> > +
> > + if (server_version >= 16 &&
> > + MySubscription->stream == SUBSTREAM_PARALLEL)
> > + options.proto.logical.s
Bilal Yavuz writes:
> It seems that kerberos is installed at the '/opt/homebrew/opt/krb5' path on
> ARM CPU darwin instances instead of the '/usr/local/opt/krb5' path.
I think this also needs to account for MacPorts, which would likely
put it under /opt/local/sbin. (I wonder where /usr/local/opt
On Monday, September 26, 2022 5:03 PM houzj.f...@fujitsu.com wrote:
>
> On Monday, September 26, 2022 4:57 PM Amit Kapila
>
> >
> > On Mon, Sep 26, 2022 at 2:03 PM Alvaro Herrera
> >
> > wrote:
> > >
> > > On 2022-Sep-26, Amit Kapila wrote:
> > >
> > > > On Mon, Sep 26, 2022 at 1:10 PM Alvaro He
On 2022-Sep-26, Julien Rouhaud wrote:
> On Mon, Sep 26, 2022 at 03:12:46PM +0900, bt22nakamorit wrote:
> > I attached a patch file that adds information about MERGE queries on the
> > documentation of pg_stat_statements, and lines of code that helps with the
> > calculation of queryid hash value
On Thu, Sep 22, 2022 at 9:44 PM Önder Kalacı wrote:
>
> Also, do you think is this a good time for me to mark the patch "Ready for
> committer" in the commit fest? Not sure when and who should change the state,
> but it seems I can change. I couldn't find any documentation on how that
> process
On Mon, Sep 26, 2022 at 4:45 PM houzj.f...@fujitsu.com
wrote:
>
>
> Attach the patch. (The patch can apply on both HEAD and PG15)
>
The patch looks good to me.
*
- errmsg("cannot add schema to the publication"),
+ errmsg("cannot add schema to publication \"%s\"",
+stmt->pubname),
I see that
On Mon, Sep 26, 2022 at 2:28 AM Wolfgang Walther
wrote:
>
> James Coleman:
> > If we have a declared constraint on x,y where x is unique based on an
> > index including on x I do not think we should have that fk constraint
> > work differently than a constraint on x,y where there is a unique
> > i
On 24.09.22 20:09, Andres Freund wrote:
On 2022-09-24 13:52:29 -0400, Tom Lane wrote:
... btw, shouldn't the CF entry [1] get closed now?
Unfortunately not - there's quite a few followup patches that haven't been
[fully] reviewed and thus not applied yet.
Here is some review of the remaining
On 2022-09-21 21:11, Damir Belyalov wrote:
Thanks for updating patch.
In the previous patch there was an error when processing constraints.
The patch was fixed, but the code grew up and became more complicated
(0005-COPY_IGNORE_ERRORS). I also simplified the logic of
safeNextCopyFrom().
You aske
Hi,
On 9/7/22 5:48 PM, Jacob Champion wrote:
On 9/7/22 07:46, Drouvot, Bertrand wrote:
Except the Nit above, that looks all good to me.
A few additional comments:
+assigned a database role. It is represented as
+auth_method:identity or
+NULL if the user has not been
Hi,
On 9/26/22 10:23 AM, Drouvot, Bertrand wrote:
Hi,
On 9/23/22 10:45 PM, Andres Freund wrote:
Hi,
On 2022-09-01 08:40:54 +0200, Drouvot, Bertrand wrote:
Thanks for the suggestion, I'm coming up with this proposal in v4
attached:
I pushed the bugfix / related test portion to 15, maste
Hi,
On 9/8/22 3:17 AM, Michael Paquier wrote:
On Wed, Sep 07, 2022 at 08:48:43AM -0700, Jacob Champion wrote:
We could pass the bare auth_method index, or update the documentation
for auth_method to state that it's guaranteed to be zero if authn_id is
NULL (and then enforce that).
c
Hi,
Postgres currently can leak memory if a failure occurs during base
backup in do_pg_backup_start() or do_pg_backup_stop() or
perform_base_backup(). The palloc'd memory such as backup_state or
tablespace_map in xlogfuncs.c or basebackup.c or tablespaceinfo or the
memory that gets allocated by bb
On Fri, 16 Sept 2022 at 13:20, Simon Riggs wrote:
>
> Thanks for the review.
>
> v10 attached
v11 attached, corrected for recent commit
14ff44f80c09718d43d853363941457f5468cc03.
--
Simon Riggshttp://www.EnterpriseDB.com/
002_minimize_calls_to_SubTransSetParent.v11.patch
Descri
James Coleman:
So the broader point I'm trying to make is that, as I understand it,
indexes backing foreign key constraints is an implementation detail.
The SQL standard details the behavior of foreign key constraints
regardless of implementation details like a backing index. That means
that the
Bharath Rupireddy writes:
> Postgres currently can leak memory if a failure occurs during base
> backup in do_pg_backup_start() or do_pg_backup_stop() or
> perform_base_backup(). The palloc'd memory such as backup_state or
> tablespace_map in xlogfuncs.c or basebackup.c or tablespaceinfo or the
>
James Coleman:
As I was reading through the email chain I had this thought: could you
get the same benefit (or 90% of it anyway) by instead allowing the
creation of a uniqueness constraint that contains more columns than
the index backing it? So long as the index backing it still guaranteed
the u
On Thu, Sep 22, 2022 at 5:19 PM James Coleman wrote:
> > Your sample query gets a plan like this:
> >
> > Nested Loop Left Join (cost=0.00..1700245.00 rows=1 width=8)
> >-> Seq Scan on foo (cost=0.00..145.00 rows=1 width=4)
> >-> Limit (cost=0.00..170.00 rows=1 width=4)
> >
On 26.09.22 13:14, Tom Lane wrote:
Bilal Yavuz writes:
It seems that kerberos is installed at the '/opt/homebrew/opt/krb5' path on
ARM CPU darwin instances instead of the '/usr/local/opt/krb5' path.
I think this also needs to account for MacPorts, which would likely
put it under /opt/local/sbi
On 22.09.22 23:21, Tom Lane wrote:
Anyway, this is a bit far afield from the stated topic of this
thread. I think we should commit something approximately like
what I posted and then start a new thread specifically about
what we'd like to do about utility commands in new-style SQL
functions.
R
On 12.09.22 19:59, Peter Eisentraut wrote:
On 12.09.22 19:03, Julien Rouhaud wrote:
On Mon, Sep 12, 2022 at 05:59:09PM +0200, Peter Eisentraut wrote:
committed, thanks
FTR lapwing is complaining about this commit:
https://brekka.postgresql.org/cgi-bin/show_log.pl?nm=lapwing&dt=2022-09-12%201
On Sat, Sep 24, 2022 at 9:44 AM Thomas Munro wrote:
>
> Although WriteFile() with a synchronous file handle and an explicit
> offset doesn't use the current file position, it appears that it still
> changes it. :-(
>
> You'd think from the documentation[1] that that isn't the case, because it
>
Hi,
The PostgreSQL 15 GA release (15.0) is now scheduled for October 13,
2022. The release team changed this from the planned date of October 6
to allow for additional testing of recent changes.
Please let us know if you have any questions. We're excited that we are
very close to officially
Hello Andrew,
> . There needs to be a check that this is being used with COPY FROM, and
> the restriction needs to be stated in the docs and tested for. c.f.
> FORCE NULL.
>
> . There needs to be support for this in psql's tab_complete.c, and
> appropriate tests added
>
> . There needs to be suppo
On Mon, Sep 26, 2022 at 10:37 AM Robert Haas wrote:
>
> On Thu, Sep 22, 2022 at 5:19 PM James Coleman wrote:
> > > Your sample query gets a plan like this:
> > >
> > > Nested Loop Left Join (cost=0.00..1700245.00 rows=1 width=8)
> > >-> Seq Scan on foo (cost=0.00..145.00 rows=1 wi
On Mon, Sep 26, 2022 at 8:12 AM Israel Barth Rubio
wrote:
> Hello Andrew,
>
> > . There needs to be a check that this is being used with COPY FROM, and
> > the restriction needs to be stated in the docs and tested for. c.f.
> > FORCE NULL.
> >
> > . There needs to be support for this in psql's ta
On Sun, Sep 25, 2022 at 5:08 AM Wolfgang Walther
wrote:
> Robert Haas:
> > Well, maybe. Suppose that role A has been granted pg_read_all_settings
> > WITH INHERIT TRUE, SET TRUE and role B has been granted
> > pg_read_all_settings WITH INHERIT TRUE, SET FALSE. A can create a
> > table owned by pg_
Hi,
On 2022-09-26 10:41:01 +0200, Alvaro Herrera wrote:
> On 2022-Sep-25, Andres Freund wrote:
>
> > From 3eb0ca196084da314d94d1e51c7b775012a4773c Mon Sep 17 00:00:00 2001
> > From: Andres Freund
> > Date: Wed, 21 Sep 2022 11:03:07 -0700
> > Subject: [PATCH v16 04/16] meson: Add windows resource
Hi, hackers
heap_force_kill/heap_force_freeze doesn’t consider other transactions that are
using the same tuples even with tuple-locks.
The functions may break transaction semantic, ex:
session1
```
create table htab(id int);
insert into htab values (100), (200), (300), (400), (500);
```
sessio
On Sat, Sep 24, 2022 at 01:41:38PM -0400, Tom Lane wrote:
> One thing I don't like about it documentation-wise is that it leaves
> the concept of backend ID pretty much completely undefined.
How specific do you think this definition ought to be? All I've come up
with so far is "internal identifie
Robert Haas:
This shows that if rhaas (or whoever) performs DML on a table owned by
pg_read_all_settings, he might trigger arbitrary code written by alice
to run under his own user ID. Now, that hazard would exist anyway for
tables owned by alice, but now it also exists for any tables owned by
pg
On Wed, Sep 21, 2022 at 6:09 AM Dilip Kumar wrote:
> Yeah you are right we can make it uint64. With respect to this, we
> can not directly use uint64 because that is declared in c.h and that
> can not be used in
> postgres_ext.h IIUC.
Ugh.
> Can we move the existing definitions from
> c.h file
Hi,
On 2022-09-26 15:01:56 +0200, Peter Eisentraut wrote:
> Here is some review of the remaining ones (might not match exactly what you
> attached, I was working off your branch):
Thanks, and makes sense.
> 9f789350a7a7 meson: ci: wip: move compilerwarnings task to meson
>
> This sounds reasona
Hi,
On 9/26/2022 2:14 PM, Tom Lane wrote:
Maybe we should first try "krb5-config --prefix" to see if that gives an answer.
I tested that command on multiple OSes and it was correct for freeBSD,
debian and openSUSE.
I don't have macOS so I tried to use CI for running macOS VMs(both arm
a
On Mon, Sep 26, 2022 at 9:29 PM Zhang Mingli wrote:
>
> Hi, hackers
>
> heap_force_kill/heap_force_freeze doesn’t consider other transactions that
> are using the same tuples even with tuple-locks.
> The functions may break transaction semantic, ex:
>
> session1
> ```
> create table htab(id int);
On 09/26/2022 11:39 am, Nazir Bilal Yavuz wrote:
Hi,
On 9/26/2022 2:14 PM, Tom Lane wrote:
Maybe we should first try "krb5-config --prefix" to see if that gives
an answer.
I tested that command on multiple OSes and it was correct for freeBSD,
debian and openSUSE.
I don't have macOS so
On Mon, Sep 26, 2022 at 9:59 AM Wolfgang Walther
wrote:
>
> James Coleman:
> > So the broader point I'm trying to make is that, as I understand it,
> > indexes backing foreign key constraints is an implementation detail.
> > The SQL standard details the behavior of foreign key constraints
> > rega
On Mon, Sep 26, 2022 at 10:04 AM Wolfgang Walther
wrote:
>
> James Coleman:
> > As I was reading through the email chain I had this thought: could you
> > get the same benefit (or 90% of it anyway) by instead allowing the
> > creation of a uniqueness constraint that contains more columns than
> >
On Mon, Sep 26, 2022 at 12:16 PM Wolfgang Walther
wrote:
> I think, when WITH INHERIT TRUE, SET FALSE is set, we should:
> - Inherit all explicitly granted privileges
> - Not inherit any DDL privileges implicitly given through ownership:
> CREATE, REFERENCES, TRIGGER.
> - Inherit all other privile
Peter Eisentraut writes:
>> Ok, it has problems with 32-bit platforms. I can reproduce it locally.
>> I'll need to take another look at this. I have reverted the patch for now.
> I have tried to analyze these issues, but I'm quite stuck. If anyone
> else has any ideas, it would be helpful.
Larry Rosenman writes:
> On 09/26/2022 11:39 am, Nazir Bilal Yavuz wrote:
>> When "krb5-config" binary is used from brew or MacPorts installations'
>> path it gives the correct path but there is another "krb5-config"
>> binary at "/usr/bin/krb5-config" path on the macOS VMs, when this
>> binary
On Mon, Sep 26, 2022 at 3:44 AM Rushabh Lathia wrote:
> Commit 6566133c5f52771198aca07ed18f84519fac1be7 ensure that
> pg_auth_members.grantor is always valid. This commit did changes
> into shdepDropOwned() function and combined the SHARED_DEPENDENCY_ACL
> and SHARED_DEPENDENCY_OWNER. In that pr
Justin Pryzby writes:
> On Fri, Sep 23, 2022 at 01:33:07PM -0400, Tom Lane wrote:
> +Previously such files were left in the current directory,
> +requiring manual cleanup. It's still necessary to remove them
> +manually afterwards, but now one can just remove that whole
>
Hi,
On 2022-09-26 15:18:29 +0700, John Naylor wrote:
> On Wed, Sep 21, 2022 at 7:11 AM Andres Freund wrote:
> >
> > I added installation instructions for meson for a bunch of platforms, but
>
> A couple more things for the wiki:
>
> 1) /opt/homebrew/ seems to be an "Apple silicon" path?
Yea, i
Robert Haas:
I don't think we're going to be very happy if we redefine inheriting
the privileges of another role to mean inheriting only some of them.
That seems pretty counterintuitive to me. I also think that this
particular definition is pretty fuzzy.
Scratch my previous suggestion. A new, l
Greetings,
* Robert Haas (robertmh...@gmail.com) wrote:
> On Thu, Sep 8, 2022 at 1:06 PM wrote:
> > In theory, I could also inherit that privilege, but that's not how the
> > system works today. By using is_member_of_role, the decision was already
> > made that this should not depend on inheritan
Greetings,
* Wolfgang Walther (walt...@technowledgy.de) wrote:
> Robert Haas:
> > I don't think we're going to be very happy if we redefine inheriting
> > the privileges of another role to mean inheriting only some of them.
> > That seems pretty counterintuitive to me. I also think that this
> > p
Hi,
On 2022-09-26 09:35:16 -0700, Andres Freund wrote:
> > 9c00d355d0e9 meson: Add PGXS compatibility
> >
> > This looks like a reasonable direction to me. How complete is it? It
> > says it works for some extensions but not others. How do we define
> > the target line here?
>
> Yea, those are
On Sun, Sep 25, 2022 at 5:38 PM Andres Freund wrote:
> # run just the main pg_regress tests against existing server
> meson test --setup running main/regress-running
> Peter, would this address your use case?
I tried out your v16 patchset, which seems to mostly work as I'd hoped
it would. Some f
Nathan Bossart writes:
> On Sat, Sep 24, 2022 at 01:41:38PM -0400, Tom Lane wrote:
>> One thing I don't like about it documentation-wise is that it leaves
>> the concept of backend ID pretty much completely undefined.
> How specific do you think this definition ought to be?
Fairly specific, I th
On Sat, Sep 24, 2022 at 8:45 AM Himanshu Upadhyaya
wrote:
> Here our objective is to validate if both Predecessor's xmin and current
> Tuple's xmin are same then cmin of predecessor must be less than current
> Tuple's cmin. In case when both tuple xmin's are same then I think
> predecessor's t_
On Mon, Sep 26, 2022 at 03:50:09PM -0400, Tom Lane wrote:
> Nathan Bossart writes:
>> On Sat, Sep 24, 2022 at 01:41:38PM -0400, Tom Lane wrote:
>>> One thing I don't like about it documentation-wise is that it leaves
>>> the concept of backend ID pretty much completely undefined.
>
>> How specifi
Martin Kalcher writes:
> [ v4-0001-Introduce-array_shuffle-and-array_sample.patch ]
I think this idea of exporting drandom()'s PRNG for all and sundry
to use is completely misguided. If we go down that path we'll
be right back in the swamp that we were in when we used random(3),
namely that (a)
On Mon, Sep 26, 2022 at 3:16 PM Wolfgang Walther
wrote:
> Robert Haas:
> > I don't think we're going to be very happy if we redefine inheriting
> > the privileges of another role to mean inheriting only some of them.
> > That seems pretty counterintuitive to me. I also think that this
> > particul
Hi,
On 2022-09-26 12:47:14 -0700, Peter Geoghegan wrote:
> On Sun, Sep 25, 2022 at 5:38 PM Andres Freund wrote:
> > # run just the main pg_regress tests against existing server
> > meson test --setup running main/regress-running
>
> > Peter, would this address your use case?
>
> I tried out you
On Mon, Sep 26, 2022 at 1:27 PM Andres Freund wrote:
> > Some feedback:
> > * I gather that "running" as it appears in commands like "meson test
> > --setup running" refers to a particular setup named "running", that
> > you invented as part of creating a meson-ish substitute for
> > installcheck.
Hi,
Meson build for the patchset failed, meson build files attached and
README/Doc package
reworked with more detailed explanation of virtual function table along
with other corrections.
On Sun, Sep 25, 2022 at 1:41 AM Nikita Malakhov wrote:
> Hi hackers!
> Last patchset has an invalid patch fil
On Mon, Sep 26, 2022 at 08:33:53PM +0530, Bharath Rupireddy wrote:
> Irrespective of what Windows does with file pointers in WriteFile(),
> should we add lseek(SEEK_SET) in our own pwrite()'s implementation,
> something like [5]? This is rather hackish without fully knowing what
> Windows does inte
On Tue, 13 Sept 2022 at 09:31, Jonathan S. Katz wrote:
> Separately, per[1], including dense_rank() in the list of window
> functions with optimizations (dense-rank.diff).
This one might have been forgotten... ? I can push it shortly if nobody objects.
David
> [1]
> https://www.postgresql.org/m
On Tue, Sep 27, 2022 at 10:27 AM Nathan Bossart
wrote:
> On Mon, Sep 26, 2022 at 08:33:53PM +0530, Bharath Rupireddy wrote:
> > Irrespective of what Windows does with file pointers in WriteFile(),
> > should we add lseek(SEEK_SET) in our own pwrite()'s implementation,
> > something like [5]? This
David Rowley writes:
> On Tue, 13 Sept 2022 at 09:31, Jonathan S. Katz wrote:
>> Separately, per[1], including dense_rank() in the list of window
>> functions with optimizations (dense-rank.diff).
> This one might have been forgotten... ? I can push it shortly if nobody
> objects.
Yeah, I miss
On Tue, Sep 27, 2022 at 10:37:38AM +1300, Thomas Munro wrote:
> I don't think so, that's an extra kernel call. I think I'll just have
> to revert part of my recent change that removed the pg_ prefix from
> those function names in our code, and restore the comment that warns
> you about the portabi
On Tue, 27 Sept 2022 at 10:45, Tom Lane wrote:
>
> David Rowley writes:
> > On Tue, 13 Sept 2022 at 09:31, Jonathan S. Katz
> > wrote:
> >> Separately, per[1], including dense_rank() in the list of window
> >> functions with optimizations (dense-rank.diff).
>
> > This one might have been forgot
Andres Freund writes:
> On 2022-03-29 14:48:54 +0800, Hao Wu wrote:
>> It's a natural requirement to unregister the callback for transaction or
>> subtransaction when the callback is invoked, so we don't have to
>> unregister the callback somewhere.
> You normally shouldn'd need to do this freque
On Mon, Sep 26, 2022 at 06:05:34PM -0400, Tom Lane wrote:
> Yeah. Whether it's efficient or not, seems like it should *work*.
> I'm a bit inclined to call this a bug-fix and backpatch it.
>
> I went looking for other occurrences of this code in places that have
> an unregister function, and found
On Tue, 20 Sept 2022 at 13:23, Tom Lane wrote:
>
> David Rowley writes:
> > Aside from that, I don't have any ideas on how to get rid of the
> > possible additional datumCopy() from non-Var arguments to these window
> > functions. Should we just suffer it? It's quite likely that most
> > argumen
Just a reminder that only some days left of "September 2022 commitfest"
As of now, there are "295" patches in total. Out of these 295 patches, "18"
patches required committer attention, and 167 patches needed reviews.
Total: 295.
Needs review: 167.
Waiting on Author: 44.
Ready for Committer: 18.
C
Hi hackers,
Enums index a number of the GUC tables. This all relies on the
elements being carefully arranged to be in the same order as those
enums. There are comments to say what enum index belongs to each table
element.
But why not use designated initializers to enforce what the comments
are ho
Hi hackers.
I have a question about the recommended way to declare the C variables
used for the GUC values.
Here are some examples from the code:
~
The GUC boot values are defined in src/backend.utils/misc/guc_tables.c
e.g. See the 4, and 2 below
{
{"max_logical_replication_workers",
PGC_POST
On Mon, Sep 26, 2022 at 05:10:16PM +0900, Kyotaro Horiguchi wrote:
> - if (strcmp(backupfrom, "standby") == 0 && !backup_started_in_recovery)
> + if (state->started_in_recovery == true &&
> + backup_stopped_in_recovery == false)
>
> Using == for Booleans may not be great?
Yes.
Peter Smith writes:
> It seems confusing to me that for the above code the initial value is
> "hardwired" in multiple places. Specifically, it looks tempting to
> just change the variable declaration value, but IIUC that's going to
> achieve nothing because it will just be overwritten by the
> "bo
On Mon, Sep 26, 2022 at 11:57:58AM +0530, Bharath Rupireddy wrote:
> +1 because callers don't use returned StringInfo structure outside of
> build_backup_content(). The patch looks good to me.
Thanks for looking.
> I think it will be
> good to add a note about the caller freeing up the retired st
On Mon, Sep 26, 2022 at 04:50:36PM +0900, Michael Paquier wrote:
> You are right. bool is not usually a problem in a signal handler, but
> sig_atomic_t is the type we ought to use. I'll go adjust that.
Done this one. I have scanned the code, but did not notice a similar
mistake. It is worth no
On Tue, Sep 27, 2022 at 10:08 AM Tom Lane wrote:
>
> Peter Smith writes:
> > It seems confusing to me that for the above code the initial value is
> > "hardwired" in multiple places. Specifically, it looks tempting to
> > just change the variable declaration value, but IIUC that's going to
> > ac
On Tue, Sep 27, 2022 at 09:27:48AM +1000, Peter Smith wrote:
> But why not use designated initializers to enforce what the comments
> are hoping for?
This is a C99 thing as far as I understand, adding one safety net.
Why not for these cases..
> Doing this also exposed a minor typo in the comments
On Mon, Sep 26, 2022 at 04:39:36PM +0200, Peter Eisentraut wrote:
> On 26.09.22 13:14, Tom Lane wrote:
>> Bilal Yavuz writes:
>> > It seems that kerberos is installed at the '/opt/homebrew/opt/krb5' path on
>> > ARM CPU darwin instances instead of the '/usr/local/opt/krb5' path.
>> I think this al
On 09/26/2022 8:25 pm, Michael Paquier wrote:
On Mon, Sep 26, 2022 at 04:39:36PM +0200, Peter Eisentraut wrote:
On 26.09.22 13:14, Tom Lane wrote:
Bilal Yavuz writes:
> It seems that kerberos is installed at the '/opt/homebrew/opt/krb5' path on
> ARM CPU darwin instances instead of the '/usr/l
1 - 100 of 133 matches
Mail list logo
