Re: Invalid comment in ParallelQueryMain

On Sat, Mar 26, 2022 at 05:12:05PM +0100, Matthias van de Meent wrote: > On Sat, 26 Mar 2022 at 17:01, Julien Rouhaud wrote: >> While reading code around I just noticed that I failed to adapt a comment a >> couple of lines above a removed line in 0f61727b75b9. Patch attached. > > +1, seems OK to

Re: Assert in pageinspect with NULL pages

On Fri, Mar 25, 2022 at 12:27:24PM +0900, Michael Paquier wrote: > Makes sense. Fine by me to stick an extra "btree" here. I have been able to look at that again today (earlier than expected), and except for one incorrect thing in the GIN tests where we were not testing the correct pattern, the r

Re: Allow file inclusion in pg_hba and pg_ident files

Hi, On Fri, Mar 25, 2022 at 08:18:31PM +0900, Michael Paquier wrote: > > Now looking at 0002. The changes in hba.c are straight-forward, > that's a nice read. Thanks! > if (!field) { \ > - ereport(LOG, \ > + ereport(elevel, \ > (errcod

GSoC: Improve PostgreSQL Regression Test Coverage

Hi all, This is Christos Maris , and I'd like to declare my interest in the GSoC project mentioned above. I'm an experienced Fullstack Developer, but still an open-source beginner. That, combined with the fact that I'd really like to contribute to Postgr

Re: Why is lorikeet so unstable in v14 branch only?

On 3/26/22 18:10, Tom Lane wrote: > >> If I understand correctly that you're only seeing this in v13 and >> HEAD, then it seems like bf68b79e5 (Refactor ps_status.c API) >> deserves a hard look. > I still stand by this opinion. Can you verify which of the ps_status.c > code paths gets used on th

Re: Add LZ4 compression in pg_dump

On Sat, Mar 26, 2022 at 12:22 PM Justin Pryzby wrote: > 0002: I wonder if you're able to re-use any of the basebackup parsing stuff > from commit ffd53659c. You're passing both the compression method *and* > level. > I think there should be a structure which includes both. In the future, that >

Re: Assert in pageinspect with NULL pages

On Fri, Mar 25, 2022 at 12:57 AM Michael Paquier wrote: > On Thu, Mar 24, 2022 at 08:54:14PM -0700, Peter Geoghegan wrote: > > amcheck's palloc_btree_page() function validates that an 8KiB page is > > in fact an nbtree page, in a maximally paranoid way. Might be an > > example worth following here

Re: Document atthasmissing default optimization avoids verification table scan

On Sat, Mar 26, 2022 at 6:25 PM James Coleman wrote: > I simply do not accept the claim that this is not a reasonable concern > to have nor that this isn't worth documenting. I don't think I said that the concern wasn't reasonable, but I don't think the fact that one person or organization had a

Re: Add a pg_get_query_def function (was Re: Deparsing rewritten query)

Julien Rouhaud writes: > [ v4-0001-Add-a-pg_get_query_def-wrapper-around-get_query_d.patch ] This seems about ready to go to me, except for (1) as an exported API, pg_get_querydef needs a full API spec in its header comment. "Read the code to figure out what to do" is not OK in my book. (2) I

Re: Add LZ4 compression in pg_dump

On Sun, Mar 27, 2022 at 10:13:00AM -0400, Robert Haas wrote: > On Sat, Mar 26, 2022 at 12:22 PM Justin Pryzby wrote: > > 0002: I wonder if you're able to re-use any of the basebackup parsing stuff > > from commit ffd53659c. You're passing both the compression method *and* > > level. > > I think

Re: [WIP] Allow pg_upgrade to copy segments of the same relfilenode in parallel

On Mon, Mar 21, 2022 at 05:34:31PM -0700, Andres Freund wrote: > Hi, > > On 2022-02-01 21:57:00 -0500, Jaime Casanova wrote: > > This patch adds a new option (-J num, --jobs-per-disk=num) in > > pg_upgrade to speed up copy mode. This generates upto ${num} > > processes per tablespace to copy seg

Re: Assert in pageinspect with NULL pages

On Sun, 27 Mar 2022 at 16:24, Robert Haas wrote: > > On Fri, Mar 25, 2022 at 12:57 AM Michael Paquier wrote: > > On Thu, Mar 24, 2022 at 08:54:14PM -0700, Peter Geoghegan wrote: > > > amcheck's palloc_btree_page() function validates that an 8KiB page is > > > in fact an nbtree page, in a maximall

Re: Why is lorikeet so unstable in v14 branch only?

Andrew Dunstan writes: > It appears that it is using PS_USE_NONE, as it doesn't have any of the > defines required for the other paths. I note that the branch for that in > get_ps_display() doesn't set *displen, which looks a tad suspicious. Indeed. I forced it to use PS_USE_NONE on my Linux mac

Re: Document atthasmissing default optimization avoids verification table scan

On Sun, Mar 27, 2022 at 11:43 AM Robert Haas wrote: > > On Sat, Mar 26, 2022 at 6:25 PM James Coleman wrote: > > I simply do not accept the claim that this is not a reasonable concern > > to have nor that this isn't worth documenting. > > I don't think I said that the concern wasn't reasonable, b

Re: Why is lorikeet so unstable in v14 branch only?

I wrote: > Andrew Dunstan writes: >> And maybe there's a good case for also >> surrounding some of the code in WaitOnLock() with "if (len) ..." > +1. I'll make it so, and check the other callers too. I had second thoughts about that part after realizing that callers cannot tell the difference b

Re: Add pg_freespacemap extension sql test

Michael Paquier writes: > Yes, we could extend that more. For now, I am curious to see what the > buildfarm has to say with the current contents of the patch, and I can > keep an eye on the buildfarm today, so I have applied it. It seems this is unstable under valgrind [1]: --- /mnt/resource/b

Re: Document atthasmissing default optimization avoids verification table scan

On Sun, Mar 27, 2022 at 10:00 AM James Coleman wrote: > As shown above, table scans (and specifically table scans used to > validate constraints, which is what this patch is about) are clearly > documented (more than once!) in the ALTER TABLE documentation. In fact > it's documented specifically

Re: refactoring basebackup.c (zstd workers)

Robert Haas writes: > [ v5-0001-Replace-BASE_BACKUP-COMPRESSION_LEVEL-option-with.patch ] Coverity has a nitpick about this: /srv/coverity/git/pgsql-git/postgresql/src/common/backup_compression.c: 194 in parse_bc_specification() 193 /* Advance to next entry and loop around.

Re: Document atthasmissing default optimization avoids verification table scan

On Sun, Mar 27, 2022 at 1:46 PM David G. Johnston wrote: > > On Sun, Mar 27, 2022 at 10:00 AM James Coleman wrote: >> >> As shown above, table scans (and specifically table scans used to >> validate constraints, which is what this patch is about) are clearly >> documented (more than once!) in the

TRAP: FailedAssertion("HaveRegisteredOrActiveSnapshot()", File: "toast_internals.c", Line: 670, PID: 19403)

Hi, On master I got a FailedAssertion("HaveRegisteredOrActiveSnapshot()" on an assert-enabled instance and with (I think) data over a certain length. I whittled it down to the attached bash (careful - it drops stuff). It has 5 tsv-data lines (one long line) that COPY slurps into a table. The

Re: Why is lorikeet so unstable in v14 branch only?

On 3/27/22 13:01, Tom Lane wrote: > >> Once I push this, you should remove the update_process_title hack >> from lorikeet's config, since that was just a workaround until >> we tracked down the problem, which I think we just did. > Minimal fix pushed, so please adjust that animal's config. > Don

Re: Race conditions in 019_replslot_limit.pl

Andres Freund writes: > How about the attached variation, which retries (for 15s, with 100ms sleeps) > if there are multiple walsenders, printing the debugging info each time? It'll > still fail the test if later iterations find just one walsender, which seems > the right behaviour for now. We ha

Re: Add LZ4 compression in pg_dump

> On 27 Mar 2022, at 00:51, Justin Pryzby wrote: > > On Sun, Mar 27, 2022 at 12:37:27AM +0100, Daniel Gustafsson wrote: >>> On 26 Mar 2022, at 17:21, Justin Pryzby wrote: >> >>> I suggested off-list to add an 0099 patch to change LZ4 to the default, to >>> exercise it more on CI. >> >> No need

Re: Assert in pageinspect with NULL pages

On Sun, Mar 27, 2022 at 7:24 AM Robert Haas wrote: > It's my impression that there are many ways of crashing the system > using pageinspect right now. We aren't very careful about making sure > that our code that reads from disk doesn't crash if the data on disk > is corrupted, and all of that sys

Re: Small TAP tests cleanup for Windows and unused modules

> On 27 Mar 2022, at 00:20, Daniel Gustafsson wrote: > I'll take it for a tour on the CI and will then apply. Which is now done, thanks! -- Daniel Gustafsson https://vmware.com/

Re: multithreaded zstd backup compression for client and server

On Wed, Mar 23, 2022 at 06:57:04PM -0400, Robert Haas wrote: > On Wed, Mar 23, 2022 at 5:52 PM Justin Pryzby wrote: > > Also because the library may not be compiled with threading. A few days > > ago, I > > tried to rebase the original "parallel workers" patch over the COMPRESS > > DETAIL > > p

Re: SQL/JSON: JSON_TABLE

On 3/24/22 18:54, Andrew Dunstan wrote: > On 3/5/22 09:35, Andrew Dunstan wrote: >> On 3/4/22 15:05, Andrew Dunstan wrote: >>> On 3/4/22 13:13, Erikjan Rijkers wrote: Op 04-03-2022 om 17:33 schreef Andrew Dunstan: > This set of patches deals with items 1..7 above, but not yet the ERROR >

Re: Assert in pageinspect with NULL pages

On Sun, Mar 27, 2022 at 4:26 PM Peter Geoghegan wrote: > We're not dealing > with adversarial page images here. I think it's bad that we have to make that assumption, considering that there's nothing whatever to keep users from supplying arbitrary page images to pageinspect. But I also agree that

Re: [PATCH] Accept IP addresses in server certificate SANs

Jacob Champion writes: > [ v10-0001-Move-inet_net_pton-to-src-port.patch etc ] There is something broken about the ssl tests as modified by this patch. The cfbot doesn't provide a lot of evidence about why it's failing, but I applied the patchset locally and what I see is ... ok 47 - mismatch b

Re: Race conditions in 019_replslot_limit.pl

Hi, On 2022-03-27 15:28:05 -0400, Tom Lane wrote: > Andres Freund writes: > > How about the attached variation, which retries (for 15s, with 100ms sleeps) > > if there are multiple walsenders, printing the debugging info each time? > > It'll > > still fail the test if later iterations find just

Re: Race conditions in 019_replslot_limit.pl

Andres Freund writes: > I still feel like there's something off here. But that's probably not enough > to keep causing failures. I'm inclined to leave the debugging in for a bit > longer, but not fail the test anymore? WFM. > The way the temporary slot removal hangs for a while seems just off:

Re: Assert in pageinspect with NULL pages

On Sun, Mar 27, 2022 at 2:02 PM Robert Haas wrote: > On Sun, Mar 27, 2022 at 4:26 PM Peter Geoghegan wrote: > > We're not dealing > > with adversarial page images here. > > I think it's bad that we have to make that assumption, considering > that there's nothing whatever to keep users from supply

Re: [PATCH] Accept IP addresses in server certificate SANs

> On 27 Mar 2022, at 23:19, Tom Lane wrote: > This may be caused by 9ca234bae or 4a7e964fc. I'd say 4a7e964fc is the culprit here. From a quick skim the the switch_server_cert() calls need to be changed along the lines of: from: switch_server_cert($node, 'server-ip-in-dnsname'); to: swi

Re: SQL/JSON: functions

I wrote: >> Andres Freund writes: >>> There's also >>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jabiru&dt=2022-03-22%2022%3A25%3A26 >>> that started failing with >>> ../../preproc/ecpg --regression -I./../../include -I. -o test1.c test1.pgc >>> test1.pgc:12: ERROR: syntax error at o

Re: SQL/JSON: functions

> On Mar 27, 2022, at 7:14 PM, Tom Lane wrote: > > I wrote: >>> Andres Freund writes: There's also https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jabiru&dt=2022-03-22%2022%3A25%3A26 that started failing with ../../preproc/ecpg --regression -I./../../include -I. -

Re: SQL/JSON: functions

Hi, On 2022-03-27 20:21:05 -0400, Andrew Dunstan wrote: > Very odd. How did it pick up just this commit and not the following one which > was pushed at the same time? The first recent failing run was with f4fb45d15c Sun Mar 27 21:03:34 2022 UTC SQL/JSON constructors f79b803dcc Sun Mar 27 21:03:

Re: [PATCH] Accept IP addresses in server certificate SANs

Hi, On 2022-03-27 17:19:27 -0400, Tom Lane wrote: > The cfbot doesn't provide a lot of evidence about > why it's failing, but I applied the patchset locally and what > I see is FWIW - and I agree that's not nice user interface wise - just below the cpu / memory graphs there's a "directory browser

Re: Corruption during WAL replay

At Thu, 24 Mar 2022 15:33:29 -0400, Robert Haas wrote in > On Thu, Mar 17, 2022 at 9:21 PM Kyotaro Horiguchi > wrote: > > All versions pass check world. > > Thanks, committed. (I was overwhelmed by the flood of following discussion..) Anyway, thanks for picking up this and committing! regar

Re: standby recovery fails (tablespace related) (tentative patch and discussion)

At Fri, 25 Mar 2022 13:26:05 +0100, Alvaro Herrera wrote in > On 2022-Mar-21, Alvaro Herrera wrote: > > > I had a look at this latest version of the patch, and found some things > > to tweak. Attached is v21 with three main changes from Kyotaro's v20: > > Pushed this, backpatching to 14 and 1

Re: SQL/JSON: functions

On 3/27/22 20:50, Andres Freund wrote: > Hi, > > On 2022-03-27 20:21:05 -0400, Andrew Dunstan wrote: >> Very odd. How did it pick up just this commit and not the following one >> which was pushed at the same time? > The first recent failing run was with > f4fb45d15c Sun Mar 27 21:03:34 2022 UTC

Re: standby recovery fails (tablespace related) (tentative patch and discussion)

On Mon, Mar 28, 2022 at 2:01 PM Kyotaro Horiguchi wrote: > At Fri, 25 Mar 2022 13:26:05 +0100, Alvaro Herrera > wrote in > > Pushed this, backpatching to 14 and 13. It would have been good to > > backpatch further, but there's an (textually trivial) merge conflict > > related to commit e6d80695

RE: Logical replication timeout problem

Dear Wang-san, Thank you for updating! ...but it also cannot be applied to current HEAD because of the commit 923def9a533. Your patch seems to conflict the adding an argument of logicalrep_write_insert(). It allows specifying columns to publish by skipping some columns in logicalrep_write_tuple

Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors

On Sun, 27 Mar 2022 15:28:41 +0900 (JST) Tatsuo Ishii wrote: > > This patch has caused the PDF documentation to fail to build cleanly: > > > > [WARN] FOUserAgent - The contents of fo:block line 1 exceed the available > > area in the inline-progression direction by more than 50 points. (See > >

Re: pg_stat_get_replication_slot() marked not strict, crashes

On Sun, Mar 27, 2022 at 11:59 AM vignesh C wrote: > > On Sun, Mar 27, 2022 at 2:54 AM Andres Freund wrote: > > > > Hi, > > > > I'm working to increase the test coverage of pgstat related stuff higher > > (for > > the shared memory stats patch, of course). > > > > "Accidentally" noticed that > >

Fix pg_waldump documentation about block option

Hi, When I read the documentation of pg_waldump, I found the description about -B option is wrong. -B block --block=block Only display records that modify the given block. The relation must also be provided with --relation or -l. Before 52b5568, the -l option is short

Re: A test for replay of regression tests

cfbot found another source of nondeterminism in the regression tests, due to the smaller shared_buffers used in this TAP test: https://cirrus-ci.com/task/4611828654276608 https://api.cirrus-ci.com/v1/artifact/task/4611828654276608/log/src/test/recovery/tmp_check/regression.diffs Turned out that w

Re: Document atthasmissing default optimization avoids verification table scan

On Sun, Mar 27, 2022 at 11:17 AM James Coleman wrote: > Hmm, I didn't realize that was project policy, Guideline/Rule of Thumb is probably a better concept. > but I'm a bit > surprised given that the sentence which 0001 replaces seems like a > direct violation of that also: "In neither case

Re: Add pg_freespacemap extension sql test

On Sun, Mar 27, 2022 at 01:18:46PM -0400, Tom Lane wrote: > skink has passed several runs since the commit went in, so it's > "unstable" not "fails consistently". I see the test tries to > disable autovacuum on that table, so that doesn't seem to be > the problem ... what is? This is a race condi

Re: Add a pg_get_query_def function (was Re: Deparsing rewritten query)

On Sun, Mar 27, 2022 at 11:53:58AM -0400, Tom Lane wrote: > Julien Rouhaud writes: > > [ v4-0001-Add-a-pg_get_query_def-wrapper-around-get_query_d.patch ] > > This seems about ready to go to me, except for > > (1) as an exported API, pg_get_querydef needs a full API spec in its > header comment.

Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors

> Even applying this patch, "make postgres-A4.pdf" arises the warning on my > machine. After some investigations, I found that previous document had a break > after 'num_transactions', but it has been removed due to this commit. Yes, your patch removed "&zwsp;". > So, > I would like to get back t

Re: Removing more vacuumlazy.c special cases, relfrozenxid optimizations

On Thu, Mar 24, 2022 at 2:40 PM Peter Geoghegan wrote: > > > This is absolutely mandatory in the aggressive case, because otherwise > > > relfrozenxid advancement might be seen as unsafe. My observation is: > > > Why should we accept the same race in the non-aggressive case? Why not > > > do essen

Re: Fix pg_waldump documentation about block option

On Mon, Mar 28, 2022 at 4:02 PM Japin Li wrote: > Before 52b5568, the -l option is short for --relation, however, it has been > changed to -R, and we forgot to update the documentation. > > Here is a patch for it. Pushed. Thanks!

Re: Invalid comment in ParallelQueryMain

Hi, On Sun, Mar 27, 2022 at 04:13:00PM +0900, Michael Paquier wrote: > On Sat, Mar 26, 2022 at 05:12:05PM +0100, Matthias van de Meent wrote: > > On Sat, 26 Mar 2022 at 17:01, Julien Rouhaud wrote: > >> While reading code around I just noticed that I failed to adapt a comment a > >> couple of lin

Re: pgbench: using prepared BEGIN statement in a pipeline could cause an error

On Fri, 25 Mar 2022 16:19:54 -0400 Tom Lane wrote: > Fabien COELHO writes: > >> [...] One way to avoid these errors is to send Parse messages before > >> pipeline mode starts. I attached a patch to fix to prepare commands at > >> starting of a script instead of at the first execution of the co

Re: Assert in pageinspect with NULL pages

On Sun, Mar 27, 2022 at 02:36:54PM -0700, Peter Geoghegan wrote: > I think that it might actually be fundamentally impossible to > guarantee that that'll be safe, because we have no idea what the > output function might be doing. It's arbitrary user-defined code that > could easily be implemented i

Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors

On Mon, 28 Mar 2022 12:17:13 +0900 (JST) Tatsuo Ishii wrote: > > Even applying this patch, "make postgres-A4.pdf" arises the warning on my > > machine. After some investigations, I found that previous document had a > > break > > after 'num_transactions', but it has been removed due to this comm

Re: pg_stat_get_replication_slot() marked not strict, crashes

Hi, On 2022-03-28 08:28:29 +0530, Amit Kapila wrote: > I am not sure if for 14 we can make a catalog change as that would > require catversion bump, so adding a code-level check as suggested by > Andres seems like a better option. Andres/Tom, any better ideas for > this? I think we could do the c

Re: pg_stat_get_replication_slot() marked not strict, crashes

Andres Freund writes: > On 2022-03-28 08:28:29 +0530, Amit Kapila wrote: >> I am not sure if for 14 we can make a catalog change as that would >> require catversion bump, so adding a code-level check as suggested by >> Andres seems like a better option. Andres/Tom, any better ideas for >> this? >

Re: Preventing indirection for IndexPageGetOpaque for known-size page special areas

On Wed, Feb 16, 2022 at 10:24:58PM +0100, Matthias van de Meent wrote: > A first good reason to do this is preventing further damage when a > page is corrupted: if I can somehow overwrite pd_special, > non-assert-enabled builds would start reading and writing at arbitrary > offsets from the page po

Re: pg_stat_get_replication_slot() marked not strict, crashes

On Sun, Mar 27, 2022 at 6:52 AM Andres Freund wrote: > > Hi, > > On 2022-03-26 17:41:53 -0400, Tom Lane wrote: > > Andres Freund writes: > > > I wonder if we ought to make PG_GETARG_DATUM(n) assert that > > > !PG_ARGISNULL(n)? > > > That'd perhaps make it easier to catch some of these... > > > >

Re: pg_stat_get_replication_slot() marked not strict, crashes

Hi, On 2022-03-27 21:09:29 -0700, Andres Freund wrote: > FWIW, I have a test for both, I was a bit "stuck" on where to put the > pg_stat_get_subscription_stats(NULL) test. I had put the > pg_stat_get_replication_slot(NULL) in contrib/test_decoding/sql/stats.sql > but pg_stat_get_subscription_stats

Re: logical decoding and replication of sequences

On Sat, Mar 26, 2022 at 3:26 PM Tomas Vondra wrote: > > On 3/26/22 08:28, Amit Kapila wrote: > >> > >> 2) The transaction handling in is a bit confusing. The non-transactional > >> increments won't have any explicit commit later, so we can't just rely > >> on begin_replication_step/end_replication

Re: Race conditions in 019_replslot_limit.pl

Hi, On 2022-03-27 17:36:14 -0400, Tom Lane wrote: > Andres Freund writes: > > I still feel like there's something off here. But that's probably not enough > > to keep causing failures. I'm inclined to leave the debugging in for a bit > > longer, but not fail the test anymore? > > WFM. I've done

RE: Failed transaction statistics to measure the logical replication progress

Hi On Friday, March 25, 2022 2:36 PM Masahiko Sawada wrote: > On Thu, Mar 24, 2022 at 12:30 PM Amit Kapila > wrote: > > > > On Thu, Mar 3, 2022 at 8:58 AM osumi.takami...@fujitsu.com > > wrote: > > > > > > > This patch introduces two new subscription statistics columns > > (apply_commit_count a

RE: Logical replication timeout problem

On Mon, Mar 28, 2022 at 9:56 AM Kuroda, Hayato/黒田 隼人 wrote: > Dear Wang-san, Thanks for your comments. > Thank you for updating! > ...but it also cannot be applied to current HEAD > because of the commit 923def9a533. > > Your patch seems to conflict the adding an argument of > logicalrep_write_

Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints

On Sat, Mar 26, 2022 at 5:55 PM Dilip Kumar wrote: > > On Fri, Mar 25, 2022 at 8:16 PM Dilip Kumar wrote: > > > > > On a quick look, I'm guessing that XLOG_DBASE_CREATE_WAL_LOG will need > > > to mirror some of the logic that was added to the replay code for the > > > existing strategy, but I hav

Re: standby recovery fails (tablespace related) (tentative patch and discussion)

At Mon, 28 Mar 2022 14:34:44 +1300, Thomas Munro wrote in > On Mon, Mar 28, 2022 at 2:01 PM Kyotaro Horiguchi > wrote: > > At Fri, 25 Mar 2022 13:26:05 +0100, Alvaro Herrera > > wrote in > > > Pushed this, backpatching to 14 and 13. It would have been good to > > > backpatch further, but the

Re: Logical replication timeout problem

On Mon, Mar 28, 2022 at 11:41 AM wangw.f...@fujitsu.com wrote: > > On Mon, Mar 28, 2022 at 9:56 AM Kuroda, Hayato/黒田 隼人 > wrote: > > > Do we have to consider something special case for that? > > I thought timeout may occur if users have huge table and publish few > > columns, > > but it is corn

Re: pg_stat_get_replication_slot() marked not strict, crashes

On Mon, Mar 28, 2022 at 10:24 AM Andres Freund wrote: > > On 2022-03-27 21:09:29 -0700, Andres Freund wrote: > > FWIW, I have a test for both, I was a bit "stuck" on where to put the > > pg_stat_get_subscription_stats(NULL) test. I had put the > > pg_stat_get_replication_slot(NULL) in contrib/test

Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors

>> > Even applying this patch, "make postgres-A4.pdf" arises the warning on my >> > machine. After some investigations, I found that previous document had a >> > break >> > after 'num_transactions', but it has been removed due to this commit. >> >> Yes, your patch removed "&zwsp;". >> >> > So, >

Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors

>>> > Even applying this patch, "make postgres-A4.pdf" arises the warning on my >>> > machine. After some investigations, I found that previous document had a >>> > break >>> > after 'num_transactions', but it has been removed due to this commit. >>> >>> Yes, your patch removed "&zwsp;". >>> >>>