On Sun, Mar 27, 2022 at 6:52 AM Andres Freund <and...@anarazel.de> wrote: > > Hi, > > On 2022-03-26 17:41:53 -0400, Tom Lane wrote: > > Andres Freund <and...@anarazel.de> writes: > > > I wonder if we ought to make PG_GETARG_DATUM(n) assert that > > > !PG_ARGISNULL(n)? > > > That'd perhaps make it easier to catch some of these... > > > > Don't see the point; such cases will crash just fine without any > > assert. The problem is lack of test coverage ... > > Not reliably. Byval types typically won't crash, just do something > bogus. As e.g. in the case of pg_stat_get_subscription_stats(NULL) I found to > also be wrong upthread.
Right. But it seems like we cannot simply add PG_ARGISNULL () to PG_GETARG_DATUM(). There are some codes such as array_remove() and array_replace() that call PG_GETARG_DATUM() and PG_ARGISNULL() and pass these values to functions that do is-null check Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/
