On Sun, May 25, 2025 at 7:52 PM Srinath Reddy Sadipiralla <
srinath2...@gmail.com> wrote:
> 1) On top of OP's patch I added support to warn if the prefix of custom
> GUC is invalid,for valid questions such as "How do you know that's a bogus
> prefix? It could perfectly well be a fully valid setti
Hi,
while going through this thread [0] i have some different views and
questions on this problem so creating a separate thread,this is just an
attempt, i might be brutally wrong here.
1) On top of OP's patch I added support to warn if the prefix of custom GUC
is invalid,for valid questions such a
Daniel Gustafsson 于2025年4月16日周三 22:20写道：
> > On 14 Apr 2025, at 15:34, Tender Wang wrote:
> >
> > Hi,
> >
> > While reading the estimate_multivariate_ndistinct(),
> > I think "If a match it found, *varinfos is
> > * updated to remove the list of matched varinfos"
> > should be "If a match is f
On Mon, 21 Apr 2025 at 11:21, Michael Paquier wrote:
> Thanks for sharing the command able to spot all these.
I just pushed a few more. The previous regex didn't account for the
duplicate word being on the next line. I dug up the following to find
the ones just committed in 78eda9e26.
ag "\s([a-
On Mon, Apr 21, 2025 at 10:42:19AM +1200, David Rowley wrote:
> On Sun, 20 Apr 2025 at 13:32, David Rowley wrote:
>> Here are a few more fixes of a similar ilk. All new in 2025,
>> predominantly from the last few days before feature freeze.
>
> I've pushed those ones.
Thanks for sharing the comm
On Sun, 20 Apr 2025 at 13:32, David Rowley wrote:
> Here are a few more fixes of a similar ilk. All new in 2025,
> predominantly from the last few days before feature freeze.
I've pushed those ones.
David
On Sat, 19 Apr 2025 at 20:00, Alexander Lakhin wrote:
> I've gathered the following collection of typos and inconsistencies
> appeared since 2025-01-01:
Here are a few more fixes of a similar ilk. All new in 2025,
predominantly from the last few days before feature freeze.
The few
Hello Michael,
19.04.2025 13:04, Michael Paquier wrote:
Good finds, Alexander, particularly for the set of function and
variable names used in the comments that do not match with the
reality. I've checked all these, and they're good for me.
Thank you for your attention to this!
GIN_TUPLE_ -
On Sat, Apr 19, 2025 at 11:00:00AM +0300, Alexander Lakhin wrote:
> I've gathered the following collection of typos and inconsistencies
> appeared since 2025-01-01:
Good finds, Alexander, particularly for the set of function and
variable names used in the comments that do not mat
Hello hackers,
I've gathered the following collection of typos and inconsistencies
appeared since 2025-01-01:
aio_worker.c -> method_worker.c
amcheck_lock_relation -> amcheck_lock_relation_and_check
be_key -> be_cancel_key
belonds -> belongs
cann -> can
> On 14 Apr 2025, at 15:34, Tender Wang wrote:
>
> Hi,
>
> While reading the estimate_multivariate_ndistinct(),
> I think "If a match it found, *varinfos is
> * updated to remove the list of matched varinfos"
> should be "If a match is found, *varinfos is
> * updated to remove the list of mat
Tender Wang 于2025年4月14日周一 21:34写道：
> Hi,
>
> While reading the estimate_multivariate_ndistinct(),
> I think "If a match it found, *varinfos is
> * updated to remove the list of matched varinfos"
> should be "If a match is found, *varinfos is
> * updated to remove the list of matched varinfos"
Hi,
While reading the estimate_multivariate_ndistinct(),
I think "If a match it found, *varinfos is
* updated to remove the list of matched varinfos"
should be "If a match is found, *varinfos is
* updated to remove the list of matched varinfos"
I've attached a patch for that.
--
Thanks,
Tende
Thank you! I had completely forgotten about this, I appreciate that you dug
this one out of the archives!
> Existing spellcheckers for code usually have quite high rates of false
> positives, so any automated tooling would have to avoid that to not
become a
> burden rather than a help. Personally
> On 3 Mar 2025, at 01:39, Jacob Brazeal wrote:
>
> This patch fixes various typos I've found, most of them from recent commits.
Thanks, I've applied the fixes for typos introduced during the v18 cycle. I
did leave a few out from your patch though:
> - Because not
t; > > While reviewing another patch, I found a couple of typos:
> > > > 1) subid should have been pubid in AlterPublicationOwner and
> > > > AlterPublicationOwner_oid functions.
> > > > 2) Only tuples with XIDs/MXIDs older than the the
> > > >
On Mon, 17 Mar 2025 at 16:57, Ashutosh Bapat
wrote:
>
> On Mon, Mar 17, 2025 at 4:46 PM Amit Kapila wrote:
> >
> > On Mon, Mar 17, 2025 at 3:44 PM vignesh C wrote:
> > >
> > > While reviewing another patch, I found a couple of typos:
>
On Mon, Mar 17, 2025 at 3:44 PM vignesh C wrote:
>
> While reviewing another patch, I found a couple of typos:
> 1) subid should have been pubid in AlterPublicationOwner and
> AlterPublicationOwner_oid functions.
> 2) Only tuples with XIDs/MXIDs older than the the
> FreezeLim
On Mon, Mar 17, 2025 at 4:46 PM Amit Kapila wrote:
>
> On Mon, Mar 17, 2025 at 3:44 PM vignesh C wrote:
> >
> > While reviewing another patch, I found a couple of typos:
> > 1) subid should have been pubid in AlterPublicationOwner and
> > AlterPublicationOwner_oid
Hi,
While reviewing another patch, I found a couple of typos:
1) subid should have been pubid in AlterPublicationOwner and
AlterPublicationOwner_oid functions.
2) Only tuples with XIDs/MXIDs older than the the
FreezeLimit/MultiXactCutoff are frozen in the common case.
Should have been"
This patch fixes various typos I've found, most of them from recent
commits. I think none should be controversial except perhaps
--- a/doc/src/sgml/ref/pgupgrade.sgml
+++ b/doc/src/sgml/ref/pgupgrade.sgml
@@ -801,7 +801,7 @@ psql --username=postgres --file=script.sql pos
On Thu, 2 Jan 2025 at 05:00, Alexander Lakhin wrote:
> Please look at another collection of typos and inconsistencies introduced
> during 2024:
The fixes all look good to me. I see some are mine, so I will take
care of pushing.
Thanks for the patch.
David
Hello hackers,
03.09.2024 08:51, Michael Paquier wrote:
And done that.
Please look at another collection of typos and inconsistencies introduced
during 2024:
behvior -> behavior
contraint -> constraint
curent -> current
disable_node -> disabled_nodes
disabled_node >
> On 31 Oct 2024, at 10:24, vignesh C wrote:
> I noticed a couple of typos in code. "the the" should have been "the",
> attached patch has the changes for the same.
Fixed, thanks.
--
Daniel Gustafsson
Hi,
I noticed a couple of typos in code. "the the" should have been "the",
attached patch has the changes for the same.
Regards,
Vignesh
diff --git a/src/backend/executor/execExprInterp.c b/src/backend/executor/execExprInterp.c
index 6a7f18f6de..30c5a19aad 100644
--- a/
ackports.
>
> I think this is pretty good logic. I think fixing comment typos in
> ancient code and backpatching to all supported versions isn't good use
> of time, but fixing a typo in "recent" code and backpatching to where
> that code was added seems useful. Newer
On Thu, Sep 05, 2024 at 03:34:31AM +1200, David Rowley wrote:
> Anyway, I doubt hard
> guidelines are warranted here, but maybe some hints about best
> practices in https://wiki.postgresql.org/wiki/Committing_checklist ?
Yep, that may be useful. I just tend to be cautious because it can be
very e
On Wed, 4 Sept 2024 at 20:24, Daniel Gustafsson wrote:
> Not mandatory at all, but since you were prepping a typo backpatch anyways I
> figured these could join to put a small dent in reducing risks for future
> backports.
I think this is pretty good logic. I think fixing comment
> On 4 Sep 2024, at 03:25, Michael Paquier wrote:
>
> On Tue, Sep 03, 2024 at 12:00:13PM +0200, Daniel Gustafsson wrote:
>> I see your v17 typo fixes, and raise you a few more. Commit 31a98934d169
>> from
>> just now contains 2 (out of 3) sets of typos intro
On Tue, Sep 03, 2024 at 12:00:13PM +0200, Daniel Gustafsson wrote:
> I see your v17 typo fixes, and raise you a few more. Commit 31a98934d169 from
> just now contains 2 (out of 3) sets of typos introduced in v17 so they should
> follow along when you push the ones mentioned here.
Is th
before the release.
I see your v17 typo fixes, and raise you a few more. Commit 31a98934d169 from
just now contains 2 (out of 3) sets of typos introduced in v17 so they should
follow along when you push the ones mentioned here.
--
Daniel Gustafsson
On Tue, Sep 03, 2024 at 02:24:32PM +0900, Michael Paquier wrote:
> On Mon, Sep 02, 2024 at 09:00:00PM +0300, Alexander Lakhin wrote:
> > I've gathered another bunch of defects with the possible substitutions.
> > Please take a look:
> > pgstat_add_kind -> pgstat_register_kind (see 7949d9594)
>
> A
On Mon, Sep 02, 2024 at 09:00:00PM +0300, Alexander Lakhin wrote:
> I've gathered another bunch of defects with the possible substitutions.
> Please take a look:
> pgstat_add_kind -> pgstat_register_kind (see 7949d9594)
And here I thought I took care of these inconsistencies. This one is
on me so
Hello,
12.08.2024 14:59, David Rowley wrote:
(I know Daniel mentioned he'd get to these, but the ScanDirection one
was my fault and I needed to clear that off my mind. I did a few
others while on this topic.)
Thank you, David, for working on that!
I've gathered another bunch of defects with t
e
> (see 60c90c16c -- Use xreflabel attributes instead of endterm ...)
I read that commit message and I agree it's now unused. I just didn't
get any vibes from the commit message that it shouldn't ever be used
again. Can Tom confirm?
> xl_commit_ts_set, SizeOfCommitTsSet
> On 4 Jul 2024, at 19:00, Alexander Lakhin wrote:
> Please look at another bunch of inconsistencies/orphaned entities I found
> in the tree, with the possible substitutions:
Thanks for these, and sorry for the delay in processing them (summer happened
etc). I've started to go through them and
Hello hackers,
03.05.2024 17:36, David Rowley wrote:
I pushed the patch after only adjusting the path in the docs which had
"module" rather than "modules".
Please look at another bunch of inconsistencies/orphaned entities I found
in the tree, with the possible substitutions:
errmsg_buf -> erro
On Fri, 3 May 2024 at 00:00, Alexander Lakhin wrote:
> (some of them are located in doc/, so it's not a code-only change)
> I've attached the patch for your convenience, though maybe some
> of the suggestions are to be discarded.
Thanks. I was hoping you'd do that.
I pushed the patch after only
Hello,
28.04.2024 11:05, David Rowley wrote:
On Sat, 20 Apr 2024 at 16:09, David Rowley wrote:
Here are a few more to see if it motivates anyone else to do a more
thorough search for another batch.
I've pushed these now.
Please look also at the list of other typos and inconsistencies
On Sat, 20 Apr 2024 at 16:09, David Rowley wrote:
> Here are a few more to see if it motivates anyone else to do a more
> thorough search for another batch.
I've pushed these now.
David
On Fri, 19 Apr 2024 at 20:13, Daniel Gustafsson wrote:
> Thanks, I incorporated these into 0001 before pushing. All the commits in
> this
> patchset are now applied.
Here are a few more to see if it motivates anyone else to do a more
thorough search for another batch.
Fixes duplicate words spa
> On 16 Apr 2024, at 15:37, Nazir Bilal Yavuz wrote:
> I realized two small typos: 'sgmr' -> 'smgr'. You may want to include
> them in 0001.
Thanks, I incorporated these into 0001 before pushing. All the commits in this
patchset are now applied.
--
Daniel Gustafsson
et's lot all these together.
> >
> > Here are a few additional ones to add to that.
>
> Thanks. Collecting all the ones submitted here, as well as a few submitted
> off-list by Alexander, the patch is now a 3-part patchset of cleanups:
>
> 0001 contains the typos
On Mon, Apr 15, 2024 at 8:26 PM Daniel Gustafsson wrote:
> Thanks. Collecting all the ones submitted here, as well as a few submitted
> off-list by Alexander, the patch is now a 3-part patchset of cleanups:
>
> 0001 contains the typos and duplicate words fixups, 0002 fixes a para
, as well as a few submitted
off-list by Alexander, the patch is now a 3-part patchset of cleanups:
0001 contains the typos and duplicate words fixups, 0002 fixes a parameter with
the wrong name in the prototype and 0003 removes a leftover prototype which was
accidentally left in a refactoring.
-
On Sat, 13 Apr 2024 at 09:17, Daniel Gustafsson wrote:
>
> > On 12 Apr 2024, at 23:15, Heikki Linnakangas wrote:
> > Here's a few more. I've accumulate these over the past couple of months,
> > keeping them stashed in a branch, adding to it whenever I've spotted a
> > minor typo while reading t
> On 12 Apr 2024, at 23:15, Heikki Linnakangas wrote:
>
> On 11/04/2024 16:05, Daniel Gustafsson wrote:
>> Now that the tree has settled down a bit post-freeze I ran some tooling to
>> check spelling. I was primarily interested in docs and README* which were
>> mo
On 11/04/2024 16:05, Daniel Gustafsson wrote:
Now that the tree has settled down a bit post-freeze I ran some tooling to
check spelling. I was primarily interested in docs and README* which were
mostly free from simply typos, while the code had some in various comments and
one in code. The
gt; Now that the tree has settled down a bit post-freeze I ran some
> > tooling
> > to
> > check spelling. I was primarily interested in docs and README*
> > which
> > were
> > mostly free from simply typos, while the code
oling
> to
> check spelling. I was primarily interested in docs and README* which
> were
> mostly free from simply typos, while the code had some in various
> comments and
> one in code. The attached fixes all that I came across (not
>
in docs and README* which were
>> mostly free from simply typos, while the code had some in various comments
>> and
>> one in code. The attached fixes all that I came across (not cross-referenced
>> against ongoing reverts or any other fixup threads but will be before pushing
>
On Fri, 12 Apr 2024, 1:05 am Daniel Gustafsson, wrote:
> Now that the tree has settled down a bit post-freeze I ran some tooling to
> check spelling. I was primarily interested in docs and README* which were
> mostly free from simply typos, while the code had some in various comme
On 2024-04-11 Th 09:05, Daniel Gustafsson wrote:
Now that the tree has settled down a bit post-freeze I ran some tooling to
check spelling. I was primarily interested in docs and README* which were
mostly free from simply typos, while the code had some in various comments and
one in code
Now that the tree has settled down a bit post-freeze I ran some tooling to
check spelling. I was primarily interested in docs and README* which were
mostly free from simply typos, while the code had some in various comments and
one in code. The attached fixes all that I came across (not cross
At Thu, 14 Mar 2024 11:23:38 +0530, Amit Kapila wrote
in
> On Thu, Mar 14, 2024 at 9:58 AM Kyotaro Horiguchi
> wrote:
> >
> > While examining reorderbuffer.c, I found several typos. I'm not sure
> > if fixing them is worthwhile, but I've attached a fix just
On Thu, Mar 14, 2024 at 9:58 AM Kyotaro Horiguchi
wrote:
>
> While examining reorderbuffer.c, I found several typos. I'm not sure
> if fixing them is worthwhile, but I've attached a fix just in case.
>
LGTM. I'll push this in some time.
--
With Regards,
Amit Kapila.
Hello.
While examining reorderbuffer.c, I found several typos. I'm not sure
if fixing them is worthwhile, but I've attached a fix just in case.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/r
On Sun, Jan 21, 2024 at 08:22:01PM +0800, Yongtao Huang wrote:
> As the title said, just fix some typos.
Thanks, applied.
--
Michael
signature.asc
Description: PGP signature
Hi all,
As the title said, just fix some typos.
Regards
Yongtao Huang
0001-Fix-some-typos.patch
Description: Binary data
On Tue, May 02, 2023 at 12:26:31PM +0900, Michael Paquier wrote:
> On Fri, Apr 21, 2023 at 12:00:00PM +0300, Alexander Lakhin wrote:
>> 4. CommitTSBuffer -> CommitTsBuffer // the inconsistency exists since
>> 5da14938f; maybe this change should be backpatched
>
> Yes, we'd better backpatch that.
On Fri, Apr 21, 2023 at 12:00:00PM +0300, Alexander Lakhin wrote:
> Please look at the following two bunches for v14+ and v13+ (split to ease
> back-patching if needed). Having processed them, I've reached the state that
> could be considered "clean" ([2], [3]); at least I don't see how to detect
>
Hi David,
21.04.2023 01:49, David Rowley wrote:
On Wed, 19 Apr 2023 at 07:00, Alexander Lakhin wrote:
please look at the similar list for v15+ (596b5af1d..HEAD).
I've now pushed most of these but didn't include the following ones:
Thank you!
3. BufFileOpenShared -> BufFileOpenFileSet // s
On Wed, 19 Apr 2023 at 07:00, Alexander Lakhin wrote:
> please look at the similar list for v15+ (596b5af1d..HEAD).
I've now pushed most of these but didn't include the following ones:
> 3. BufFileOpenShared -> BufFileOpenFileSet // see dcac5e7ac
Maybe I need to spend longer, but I just didn't
Justin Pryzby writes:
> On Tue, Apr 18, 2023 at 02:06:43PM +1200, David Rowley wrote:
>> On Tue, 18 Apr 2023 at 10:10, Justin Pryzby wrote:
>>> and s/evade/avoid/
>> I didn't touch this. You'll need to provide more justification for why
>> you think it's more correct than what's there.
> I'd
e, I would continue presenting my findings the same way.
...
You missed "boostrap" :)
Yes, that's because "boostrap" was not unique, but my semi-automatic approach
is based on `uniq -u`, so I'm sure that there are typos that can't be found
this way.
But hadn&#
On Tue, Apr 18, 2023 at 02:06:43PM +1200, David Rowley wrote:
> On Tue, 18 Apr 2023 at 10:10, Justin Pryzby wrote:
> > > - * USER SET values are appliciable only for PGC_USERSET
> > > parameters. We
> > > + * USER SET values are applicable only for PGC_USERSET
> > > par
David Rowley writes:
> On Tue, 18 Apr 2023 at 06:00, Alexander Lakhin wrote:
>> Also, maybe OID_MAX should be removed from src/include/postgres_ext.h as
>> it's unused since eb8312a22.
> I didn't touch this. It seems like it could be useful for extensions
> and client apps even if it's not used
On Tue, 18 Apr 2023 at 10:10, Justin Pryzby wrote:
> > - * USER SET values are appliciable only for PGC_USERSET
> > parameters. We
> > + * USER SET values are applicable only for PGC_USERSET
> > parameters. We
> >* use InvalidOid as role in order to evad
On Tue, 18 Apr 2023 at 06:00, Alexander Lakhin wrote:
> Please consider fixing the following unique words/identifiers introduced in
> v16:
Thanks, I've pushed all of these apart from the following 2.
> 45. tar_set_error -- remove (obsolete since ebfb814f7)
> 46. test_tranche_name -- remove (not
and s/evade/avoid/
> +++ b/src/bin/pg_dump/pg_dumpall.c
You missed "boostrap" :)
I independently found 11 of the same typos you did:
> 1. addresess -> addresses
> 3. appeneded -> appended
> 4. appliciable -> applicable
> 8. containsthe -> contains the
>
Hello hackers,
Please consider fixing the following unique words/identifiers introduced in v16:
1. addresess -> addresses
2. adminstrator -> administrator // the same typo found in src/backend/po/id.po, but perhaps it should be fixed via
pgsql-translators
3. appeneded -> appended
4. appliciable
Michael Paquier writes:
> On Wed, Feb 08, 2023 at 09:56:44AM -0600, Justin Pryzby wrote:
>> Some more accumulated/new typos.
> 0005 can indeed fix a lot of confusion around the spaces after an
> "else if" block. Is that something that could be automated with the
>
On Wed, Feb 08, 2023 at 09:56:44AM -0600, Justin Pryzby wrote:
> Some more accumulated/new typos.
0001 has been a debate for a long time, and it depends on the way SQL
is spelled. For reference:
$ git grep -i " an sql" -- *.c | wc -l
63
$ git grep -i " a sql" -- *.c | wc
Some more accumulated/new typos.
>From 6c79a0d4e0251dbbac38babb60bb2d0fbae3da8d Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Wed, 11 Jan 2023 12:52:25 -0600
Subject: [PATCH 01/10] use "an SQL" rather than a SQL
Per 04539e
---
doc/src/sgml/ecpg.sgml | 6 +++---
1 file changed,
On Tue, Jan 10, 2023 at 01:55:56PM +0530, Amit Kapila wrote:
> I have not yet started, so please go ahead.
Okay, I have looked at that and fixed the whole new things, including
the typo you have introduced. 0001~0004 have been left out, as of the
same reasons as upthread.
--
Michael
signature.a
On Tue, Jan 10, 2023 at 1:18 PM Michael Paquier wrote:
>
> On Tue, Jan 10, 2023 at 12:24:40PM +0530, Amit Kapila wrote:
> > Thanks for noticing this. I'll take care of this and some other typo
> > patches together.
>
> Does this include 0010? I was just looking at the whole set and this
> one loo
On Tue, Jan 10, 2023 at 12:24:40PM +0530, Amit Kapila wrote:
> Thanks for noticing this. I'll take care of this and some other typo
> patches together.
Does this include 0010? I was just looking at the whole set and this
one looked like a cleanup worth on its own so I was going to handle
it, unti
On Tue, Jan 10, 2023 at 10:27 AM Justin Pryzby wrote:
>
> On Tue, Jan 03, 2023 at 03:39:22PM -0600, Justin Pryzby wrote:
> > On Tue, Jan 03, 2023 at 04:28:29PM +0900, Michael Paquier wrote:
> > > On Fri, Dec 30, 2022 at 05:12:57PM -0600, Justin Pryzby wrote:
> > >
> > > # Use larger ccache ca
f them using
> > the markup.
>
> I changed it for consistency, as it's the only thing that says <>UTF-8<>
> anywhere, and charset.sgml already says <>UTF<>-8 elsewhere.
>
> Alternately, I suggest to change charset to say <>UTF8<> in both places
On Tue, Jan 03, 2023 at 04:28:29PM +0900, Michael Paquier wrote:
> On Fri, Dec 30, 2022 at 05:12:57PM -0600, Justin Pryzby wrote:
>
> # Use larger ccache cache, as this task compiles with multiple compilers
> /
> # flag combinations
> -CCACHE_MAXSIZE: "1GB"
> +CCACHE_MAXSIZE: "1
On 03.01.23 09:41, Michael Paquier wrote:
On Tue, Jan 03, 2023 at 01:03:01PM +0530, Amit Kapila wrote:
One minor comment:
-spoken in Belgium (BE), with a UTF-8 character set
+spoken in Belgium (BE), with a UTF-8 character set
Shouldn't this be UTF8 as we are using in func.sgml?
Yeah,
On Tue, Jan 03, 2023 at 01:03:01PM +0530, Amit Kapila wrote:
> One minor comment:
> -spoken in Belgium (BE), with a UTF-8 character set
> +spoken in Belgium (BE), with a UTF-8 character set
>
> Shouldn't this be UTF8 as we are using in func.sgml?
Yeah, I was wondering as well why this cha
On Tue, Jan 3, 2023 at 12:58 PM Michael Paquier wrote:
>
> On Fri, Dec 30, 2022 at 05:12:57PM -0600, Justin Pryzby wrote:
>
> # Use larger ccache cache, as this task compiles with multiple compilers
> /
> # flag combinations
> -CCACHE_MAXSIZE: "1GB"
> +CCACHE_MAXSIZE: "1G"
>
> I
On Fri, Dec 30, 2022 at 05:12:57PM -0600, Justin Pryzby wrote:
# Use larger ccache cache, as this task compiles with multiple compilers /
# flag combinations
-CCACHE_MAXSIZE: "1GB"
+CCACHE_MAXSIZE: "1G"
In 0006, I am not sure how much this matters. Perhaps somebody more
fluent
e
multiple-evaluation hazards when written as a macro, as e.g., the
case with
--
2.25.1
>From 759288c53d30d32c608d0316df06f645ffa4dccf Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Sun, 25 Sep 2022 18:40:36 -0500
Subject: [PATCH 06/16] typos
---
.cirrus.yml
On 11/19/22 17:24, Tom Lane wrote:
Andres Freund writes:
On 2022-11-19 17:10:57 -0500, Joe Conway wrote:
Rishu Bagga pointed out to me offlist that this catversion bump seems
flawed:
/* mmddN */
-#define CATALOG_VERSION_NO 202211121
+#define CATALOG_VERSION_NO 2022
Andres Freund writes:
> On 2022-11-19 17:10:57 -0500, Joe Conway wrote:
>> Rishu Bagga pointed out to me offlist that this catversion bump seems
>> flawed:
>> /* mmddN */
>> -#define CATALOG_VERSION_NO 202211121
>> +#define CATALOG_VERSION_NO 202211821
>> I think that
Hi,
On 2022-11-19 17:10:57 -0500, Joe Conway wrote:
> Rishu Bagga pointed out to me offlist that this catversion bump seems
> flawed:
>
> diff --git a/src/include/catalog/catversion.h
> b/src/include/catalog/catversion.h
> index
> c6ef593207c227ce10b0c897379476b553974f67..b3a57136b755fed182b4518
On 11/18/22 16:18, Robert Haas wrote:
Fix typos and bump catversion.
Typos reported by Álvaro Herrera and Erik Rijkers.
Catversion bump for 3d14e171e9e2236139e8976f3309a588bcc8683b was
inadvertently omitted.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff
On Sat, Sep 24, 2022 at 4:00 AM Justin Pryzby wrote:
>
> On Mon, Sep 19, 2022 at 06:10:00AM -0500, Justin Pryzby wrote:
> > On Mon, Sep 19, 2022 at 11:05:24AM +0800, Zhang Mingli wrote:
> > > Good catch. There is a similar typo in doc, runtime.sgml.
> > > ```using TLS protocols enabled by by setti
On Mon, Sep 19, 2022 at 06:10:00AM -0500, Justin Pryzby wrote:
> On Mon, Sep 19, 2022 at 11:05:24AM +0800, Zhang Mingli wrote:
> > Good catch. There is a similar typo in doc, runtime.sgml.
> > ```using TLS protocols enabled by by setting the parameter```
>
> That one should be backpatched to v15.
On Mon, 19 Sept 2022 at 23:10, Justin Pryzby wrote:
> Find below some others.
Thanks. Pushed.
David
On Mon, Sep 19, 2022 at 02:44:12AM +, houzj.f...@fujitsu.com wrote:
> While working on some other patches, I found serval typos(duplicate words and
> incorrect function name reference) in the code comments. Here is a small patch
> to fix them.
Thanks.
On Mon, Sep 19, 2022 at 11:05:2
Hi
On Sep 19, 2022, 10:57 +0800, Amit Kapila , wrote:
> On Mon, Sep 19, 2022 at 8:14 AM houzj.f...@fujitsu.com
> wrote:
> >
> > While working on some other patches, I found serval typos(duplicate words
> > and
> > incorrect function name reference) in the
On Mon, Sep 19, 2022 at 8:14 AM houzj.f...@fujitsu.com
wrote:
>
> While working on some other patches, I found serval typos(duplicate words and
> incorrect function name reference) in the code comments. Here is a small patch
> to fix them.
>
Thanks, the patch looks good to me.
Hi,
While working on some other patches, I found serval typos(duplicate words and
incorrect function name reference) in the code comments. Here is a small patch
to fix them.
Best regards,
Hou zhijie
0001-fix-typos.patch
Description: 0001-fix-typos.patch
On Tue, Aug 16, 2022 at 8:48 AM John Naylor
wrote:
>
> On Fri, Aug 12, 2022 at 8:55 PM Tom Lane wrote:
> >
> > John Naylor writes:
> > > This is really a straw-man proposal, since I'm not volunteering to do
> > > the work, or suggest anybody else should do the same. That being the
> > > case, it
On Fri, Aug 12, 2022 at 8:55 PM Tom Lane wrote:
>
> John Naylor writes:
> > This is really a straw-man proposal, since I'm not volunteering to do
> > the work, or suggest anybody else should do the same. That being the
> > case, it seems we should just go ahead with Justin's patch for
> > consist
John Naylor writes:
> This is really a straw-man proposal, since I'm not volunteering to do
> the work, or suggest anybody else should do the same. That being the
> case, it seems we should just go ahead with Justin's patch for
> consistency. Possibly we could also change the messages to say "ID"?
On Fri, Aug 12, 2022, at 3:59 AM, John Naylor wrote:
> This is really a straw-man proposal, since I'm not volunteering to do
> the work, or suggest anybody else should do the same. That being the
> case, it seems we should just go ahead with Justin's patch for
> consistency. Possibly we could also
1 - 100 of 355 matches
Mail list logo
