Hello hackers,
03.09.2024 08:51, Michael Paquier wrote:
And done that.
Please look at another collection of typos and inconsistencies introduced
during 2024:
behvior -> behavior
contraint -> constraint
curent -> current
disable_node -> disabled_nodes
disabled_node > disabled_nodes
disable_nodes -> disabled_nodes
FindFkPeriodOpers -> FindFKPeriodOpers
heap_inplace_update -> heap_inplace_update_and_unlock
InitLocks -> LockManagerShmemInit? (see fbce7dfc7)
isReadOnly -> IsReadOnly
negotations -> negotiations
notnull_inh -> notnull_islocal (coined by 14e87ffa5)
num_word -> just remove an old-fashioned comment? or change to
append_num_word (see 5bf948d56)
objectAddress -> ObjectAddress
orderProc -> orderProcs
pg_visibilitymap.c -> visibilitymap.c
postitional_fcinfo -> positional_fcinfo
preserve_formatting -> preserve_comments (see 995e0fbc1)
procesess -> processes
trapper -> trapped
trasformed -> transformed
vac_update_datfrozenid -> vac_update_datfrozenxid
XLPH_HAS_* -> XLHP_HAS_*
XLogRecordInsert -> XLogInsertRecord (coined by afd12774a)
Please find attached the corresponding patch for your convenience.
Best regards,
Alexander
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
index 329e727f80..b2dd146677 100644
--- a/src/backend/access/heap/heapam.c
+++ b/src/backend/access/heap/heapam.c
@@ -6387,7 +6387,7 @@ heap_inplace_update_and_unlock(Relation relation,
*
* ["D" is a VACUUM (ONLY_DATABASE_STATS)]
* ["R" is a VACUUM tbl]
- * D: vac_update_datfrozenid() -> systable_beginscan(pg_class)
+ * D: vac_update_datfrozenxid() -> systable_beginscan(pg_class)
* D: systable_getnext() returns pg_class tuple of tbl
* R: memcpy() into pg_class tuple of tbl
* D: raise pg_database.datfrozenxid, XLogInsert(), finish
diff --git a/src/backend/access/heap/pruneheap.c b/src/backend/access/heap/pruneheap.c
index 11c9532719..a87145aeeb 100644
--- a/src/backend/access/heap/pruneheap.c
+++ b/src/backend/access/heap/pruneheap.c
@@ -2133,7 +2133,7 @@ log_heap_prune_and_freeze(Relation relation, Buffer buffer,
sizeof(OffsetNumber) * nfrozen);
/*
- * Prepare the main xl_heap_prune record. We already set the XLPH_HAS_*
+ * Prepare the main xl_heap_prune record. We already set the XLHP_HAS_*
* flag above.
*/
if (RelationIsAccessibleInLogicalDecoding(relation))
diff --git a/src/backend/access/nbtree/nbtutils.c b/src/backend/access/nbtree/nbtutils.c
index a531d37908..593cd98d70 100644
--- a/src/backend/access/nbtree/nbtutils.c
+++ b/src/backend/access/nbtree/nbtutils.c
@@ -2584,7 +2584,7 @@ _bt_preprocess_keys(IndexScanDesc scan)
{
inkeys = arrayKeyData;
- /* Also maintain keyDataMap for remapping so->orderProc[] later */
+ /* Also maintain keyDataMap for remapping so->orderProcs[] later */
keyDataMap = MemoryContextAlloc(so->arrayContext,
numberOfKeys * sizeof(int));
}
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 6f58412bca..b5ff45602a 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -554,7 +554,7 @@ typedef struct XLogCtlData
} XLogCtlData;
/*
- * Classification of XLogRecordInsert operations.
+ * Classification of XLogInsertRecord operations.
*/
typedef enum
{
diff --git a/src/backend/catalog/pg_constraint.c b/src/backend/catalog/pg_constraint.c
index 9c05a98d28..e210886e17 100644
--- a/src/backend/catalog/pg_constraint.c
+++ b/src/backend/catalog/pg_constraint.c
@@ -1600,7 +1600,7 @@ DeconstructFkConstraintRow(HeapTuple tuple, int *numfks,
}
/*
- * FindFkPeriodOpers -
+ * FindFKPeriodOpers -
*
* Looks up the operator oids used for the PERIOD part of a temporal foreign key.
* The opclass should be the opclass of that PERIOD element.
diff --git a/src/backend/catalog/pg_depend.c b/src/backend/catalog/pg_depend.c
index 2b4514e8a3..3ed45f3cfc 100644
--- a/src/backend/catalog/pg_depend.c
+++ b/src/backend/catalog/pg_depend.c
@@ -35,7 +35,7 @@ static bool isObjectPinned(const ObjectAddress *object);
/*
- * Record a dependency between 2 objects via their respective objectAddress.
+ * Record a dependency between 2 objects via their respective ObjectAddress.
* The first argument is the dependent object, the second the one it
* references.
*
diff --git a/src/backend/catalog/storage.c b/src/backend/catalog/storage.c
index 5b22cf1099..20d9a21abc 100644
--- a/src/backend/catalog/storage.c
+++ b/src/backend/catalog/storage.c
@@ -380,7 +380,7 @@ RelationTruncate(Relation rel, BlockNumber nblocks)
* replay or visibility invariants downstream. The critical section also
* suppresses interrupts.
*
- * (See also pg_visibilitymap.c if changing this code.)
+ * (See also visibilitymap.c if changing this code.)
*/
START_CRIT_SECTION();
diff --git a/src/backend/commands/explain.c b/src/backend/commands/explain.c
index a201ed3082..c1e1e9804d 100644
--- a/src/backend/commands/explain.c
+++ b/src/backend/commands/explain.c
@@ -1384,8 +1384,8 @@ ExplainPreScanNode(PlanState *planstate, Bitmapset **rels_used)
/*
* plan_is_disabled
* Checks if the given plan node type was disabled during query planning.
- * This is evident by the disable_node field being higher than the sum of
- * the disabled_node field from the plan's children.
+ * This is evident by the disabled_nodes field being higher than the sum of
+ * the disabled_nodes field from the plan's children.
*/
static bool
plan_is_disabled(Plan *plan)
@@ -1462,7 +1462,7 @@ plan_is_disabled(Plan *plan)
}
/*
- * It's disabled if the plan's disable_nodes is higher than the sum of its
+ * It's disabled if the plan's disabled_nodes is higher than the sum of its
* child's plan disabled_nodes.
*/
if (plan->disabled_nodes > child_disabled_nodes)
diff --git a/src/backend/optimizer/path/indxpath.c b/src/backend/optimizer/path/indxpath.c
index 5d102a0d37..87ce46d3b4 100644
--- a/src/backend/optimizer/path/indxpath.c
+++ b/src/backend/optimizer/path/indxpath.c
@@ -2620,7 +2620,7 @@ match_clause_to_index(PlannerInfo *root,
*
* It is also possible to match a list of OR clauses if it might be
* transformed into a single ScalarArrayOpExpr clause. On success,
- * the returning index clause will contain a trasformed clause.
+ * the returning index clause will contain a transformed clause.
*
* For boolean indexes, it is also possible to match the clause directly
* to the indexkey; or perhaps the clause is (NOT indexkey).
diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c
index 6f849ffbcb..161020f289 100644
--- a/src/backend/postmaster/postmaster.c
+++ b/src/backend/postmaster/postmaster.c
@@ -2827,7 +2827,7 @@ PostmasterStateMachine(void)
/*
* In the PM_WAIT_BACKENDS state, wait for all the regular backends and
- * procesess like autovacuum and background workers that are comparable to
+ * processes like autovacuum and background workers that are comparable to
* backends to exit.
*
* PM_STOP_BACKENDS is a transient state that means the same as
diff --git a/src/backend/replication/logical/decode.c b/src/backend/replication/logical/decode.c
index e73576ad12..21828ac6cf 100644
--- a/src/backend/replication/logical/decode.c
+++ b/src/backend/replication/logical/decode.c
@@ -519,8 +519,8 @@ heap_decode(LogicalDecodingContext *ctx, XLogRecordBuffer *buf)
* tuples, we're not interested in the record's contents.
*
* WAL contains likely-unnecessary commit-time invals from the
- * CacheInvalidateHeapTuple() call in heap_inplace_update().
- * Excess invalidation is safe.
+ * CacheInvalidateHeapTuple() call in
+ * heap_inplace_update_and_unlock(). Excess invalidation is safe.
*/
break;
diff --git a/src/backend/statistics/attribute_stats.c b/src/backend/statistics/attribute_stats.c
index b97ba7b0c0..21d6293a23 100644
--- a/src/backend/statistics/attribute_stats.c
+++ b/src/backend/statistics/attribute_stats.c
@@ -538,7 +538,7 @@ get_attr_stat_type(Oid reloid, AttrNumber attnum, int elevel,
* When analyzing an expression index, believe the expression tree's type
* not the column datatype --- the latter might be the opckeytype storage
* type of the opclass, which is not interesting for our purposes. This
- * mimics the behvior of examine_attribute().
+ * mimics the behavior of examine_attribute().
*/
if (expr == NULL)
{
diff --git a/src/backend/statistics/stat_utils.c b/src/backend/statistics/stat_utils.c
index 728e30e780..e874497df6 100644
--- a/src/backend/statistics/stat_utils.c
+++ b/src/backend/statistics/stat_utils.c
@@ -243,7 +243,7 @@ stats_fill_fcinfo_from_arg_pairs(FunctionCallInfo pairs_fcinfo,
/*
* For each argument name/value pair, find corresponding positional
* argument for the argument name, and assign the argument value to
- * postitional_fcinfo.
+ * positional_fcinfo.
*/
for (int i = 0; i < nargs; i += 2)
{
diff --git a/src/backend/storage/lmgr/lock.c b/src/backend/storage/lmgr/lock.c
index 0576bb75b2..f549ba5be1 100644
--- a/src/backend/storage/lmgr/lock.c
+++ b/src/backend/storage/lmgr/lock.c
@@ -21,7 +21,7 @@
*
* Interface:
*
- * InitLocks(), GetLocksMethodTable(), GetLockTagsMethodTable(),
+ * LockManagerShmemInit(), GetLocksMethodTable(), GetLockTagsMethodTable(),
* LockAcquire(), LockRelease(), LockReleaseAll(),
* LockCheckConflicts(), GrantLock()
*
diff --git a/src/backend/utils/adt/cash.c b/src/backend/utils/adt/cash.c
index c1a743b2a6..611d23f3cb 100644
--- a/src/backend/utils/adt/cash.c
+++ b/src/backend/utils/adt/cash.c
@@ -85,7 +85,7 @@ append_num_word(StringInfo buf, Cash value)
else
appendStringInfo(buf, "%s %s", big[tu / 10], small[tu % 10]);
}
-} /* num_word() */
+}
static inline Cash
cash_pl_cash(Cash c1, Cash c2)
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 19969e400f..167b2bd33e 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -9347,8 +9347,8 @@ getTableAttrs(Archive *fout, TableInfo *tblinfo, int numTables)
* constraints and the columns in the child don't have their own NOT NULL
* declarations, we suppress printing constraints in the child: the
* constraints are acquired at the point where the child is attached to the
- * parent. This is tracked in ->notnull_inh (which is set in flagInhAttrs for
- * servers pre-18).
+ * parent. This is tracked in ->notnull_islocal (which is set in flagInhAttrs
+ * for servers pre-18).
*
* Any of these constraints might have the NO INHERIT bit. If so we set
* ->notnull_noinh and NO INHERIT will be printed by dumpTableSchema.
@@ -16513,7 +16513,7 @@ dumpTableSchema(Archive *fout, const TableInfo *tbinfo)
* conislocal. The inhcount is fixed by ALTER TABLE INHERIT,
* below. Special hack: in versions < 18, columns with no
* local definition need their constraint to be matched by
- * column number in conkeys instead of by contraint name,
+ * column number in conkeys instead of by constraint name,
* because the latter is not available. (We distinguish the
* case because the constraint name is the empty string.)
*/
diff --git a/src/bin/pg_rewind/parsexlog.c b/src/bin/pg_rewind/parsexlog.c
index 242326c97a..5cc1ecb6f1 100644
--- a/src/bin/pg_rewind/parsexlog.c
+++ b/src/bin/pg_rewind/parsexlog.c
@@ -227,7 +227,7 @@ findLastCheckpoint(const char *datadir, XLogRecPtr forkptr, int tliIndex,
snprintf(xlogfname, MAXFNAMELEN, XLOGDIR "/");
- /* update curent values */
+ /* update current values */
current_tli = xlogreader->seg.ws_tli;
current_segno = xlogreader->seg.ws_segno;
diff --git a/src/include/catalog/reformat_dat_file.pl b/src/include/catalog/reformat_dat_file.pl
index 838cd0af73..1cd0464229 100755
--- a/src/include/catalog/reformat_dat_file.pl
+++ b/src/include/catalog/reformat_dat_file.pl
@@ -84,7 +84,7 @@ foreach my $datfile (@ARGV)
# if you need to. In the following example, the "next if !ref $row"
# check below is a hack to filter out non-hash objects. This is because
# we build the lookup tables from data that we read using the
-# "preserve_formatting" parameter.
+# "preserve_comments" parameter.
#
##Index access method lookup.
#my %amnames;
diff --git a/src/include/commands/copyfrom_internal.h b/src/include/commands/copyfrom_internal.h
index cad52fcc78..1de843ca8e 100644
--- a/src/include/commands/copyfrom_internal.h
+++ b/src/include/commands/copyfrom_internal.h
@@ -95,7 +95,7 @@ typedef struct CopyFromStateData
* default value */
FmgrInfo *in_functions; /* array of input functions for each attrs */
Oid *typioparams; /* array of element types for in_functions */
- ErrorSaveContext *escontext; /* soft error trapper during in_functions
+ ErrorSaveContext *escontext; /* soft error trapped during in_functions
* execution */
uint64 num_errors; /* total number of rows which contained soft
* errors */
diff --git a/src/include/jit/SectionMemoryManager.h b/src/include/jit/SectionMemoryManager.h
index 93cf977157..69e4d66e5e 100644
--- a/src/include/jit/SectionMemoryManager.h
+++ b/src/include/jit/SectionMemoryManager.h
@@ -153,7 +153,7 @@ public:
/// a default alignment of 16 will be used.
uint8_t *allocateDataSection(uintptr_t Size, unsigned Alignment,
unsigned SectionID, StringRef SectionName,
- bool isReadOnly) override;
+ bool IsReadOnly) override;
/// Update section-specific memory permissions and other attributes.
///
diff --git a/src/test/postmaster/t/002_start_stop.pl b/src/test/postmaster/t/002_start_stop.pl
index 993d855ece..ad11db159e 100644
--- a/src/test/postmaster/t/002_start_stop.pl
+++ b/src/test/postmaster/t/002_start_stop.pl
@@ -54,7 +54,7 @@ for (my $i = 0; $i <= 20; $i++)
# postmaster cannot accept() them fast enough. The exact limit
# and behavior depends on the platform. To make this reliable,
# we attempt SSL negotiation on each connection before opening
- # next one. The server will reject the SSL negotations, but
+ # next one. The server will reject the SSL negotiations, but
# when it does so, we know that the backend has been launched
# and we should be able to open another connection.
