On Mon, Mar 17, 2025 at 4:46 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Mon, Mar 17, 2025 at 3:44 PM vignesh C <vignes...@gmail.com> wrote: > > > > While reviewing another patch, I found a couple of typos: > > 1) subid should have been pubid in AlterPublicationOwner and > > AlterPublicationOwner_oid functions. > > 2) Only tuples with XIDs/MXIDs older than the the > > FreezeLimit/MultiXactCutoff are frozen in the common case. > > Should have been" > > Only tuples with XIDs/MXIDs older than the FreezeLimit/MultiXactCutoff > > are frozen in the common case. > > > > The attached patch has the changes for the same. > > > > The changes look good to me.
+1 However they look unrelated. We should split them in two commits s/subid/pubid/ to one and s/the the/the/ to another. I also verified that this is the only occurrence of "the the" in the code base. -- Best Wishes, Ashutosh Bapat
