On Thu, Mar 27, 2025 at 4:42 PM Melanie Plageman
wrote:
>
> On Thu, Mar 27, 2025 at 2:46 PM Matheus Alcantara
> wrote:
> >
> > Just my 0.2 cents. I also like the first approach even though I prefer
> > the v4 version, but anyway, thanks very much for reviewing and
> > committing!
>
> Thanks for t
On Thu, Mar 27, 2025 at 2:46 PM Matheus Alcantara
wrote:
>
> Just my 0.2 cents. I also like the first approach even though I prefer
> the v4 version, but anyway, thanks very much for reviewing and
> committing!
Thanks for the patch!
FWIW, I strongly disliked about v4 that two separate parts of t
On Thu, Mar 27, 2025 at 3:35 PM Melanie Plageman
wrote:
>
> On Thu, Mar 27, 2025 at 4:45 AM Nazir Bilal Yavuz wrote:
> >
> > I liked the first approach more. We can solve the first approach's
> > problems by introducing a void pointer to pass to
> > read_stream_begin_relation(). We can set it to
On Thu, Mar 27, 2025 at 4:45 AM Nazir Bilal Yavuz wrote:
>
> I liked the first approach more. We can solve the first approach's
> problems by introducing a void pointer to pass to
> read_stream_begin_relation(). We can set it to &rsdata.range for the
> SKIP_PAGES_NONE case and &rsdata for the rest
_NONE case and &rsdata for the rest.
Example patch is attached, heapamcheck_rs_perblock_data is added to
typedefs.list too.
--
Regards,
Nazir Bilal Yavuz
Microsoft
From 642a01c6298742879cefac1197d466b6fec5df7f Mon Sep 17 00:00:00 2001
From: Matheus Alcantara
Date: Fri,
29 Nov 2024 18:52:43 -0300
Subject: [PATCH] Use read stream on amcheck
ci-os-only:
---
contrib/amcheck/verify_heapam.c | 114 +---
1 file changed, 90 insertions(+), 24 deletions(-)
diff --git a/contrib/amcheck/verify_heapam.c b/contrib/amcheck/verify_heapam.c
index 827
Hi,
On Sun, Mar 16, 2025 at 10:30 AM vignesh C wrote:
>
> On Wed, 12 Feb 2025 at 00:11, Matheus Alcantara
> wrote:
> >
> > Hi,
> >
> > Em ter., 11 de fev. de 2025 às 03:39, jian he
> > escreveu:
> > > hi. some minor issue i found.
> > >
> > > +#include "storage/block.h"
> > > no need, since "#i
On Wed, 12 Feb 2025 at 00:11, Matheus Alcantara
wrote:
>
> Hi,
>
> Em ter., 11 de fev. de 2025 às 03:39, jian he
> escreveu:
> > hi. some minor issue i found.
> >
> > +#include "storage/block.h"
> > no need, since "#include "storage/bufmgr.h" already included it.
> >
> Fixed
>
> > do we need to a
Hi,
Thank you for working on this!
On Tue, 11 Feb 2025 at 21:41, Matheus Alcantara
wrote:
>
> Thanks for the review! v3 with the fixes attached.
I have a small comment.
diff --git a/contrib/amcheck/verify_heapam.c b/contrib/amcheck/verify_heapam.c
index 827312306f6..8c83870db7d 100644
--- a/co
Hi,
Em ter., 11 de fev. de 2025 às 03:39, jian he
escreveu:
> hi. some minor issue i found.
>
> +#include "storage/block.h"
> no need, since "#include "storage/bufmgr.h" already included it.
>
Fixed
> do we need to add ``CHECK_FOR_INTERRUPTS()`` in heapam_read_stream_next_block?
>
The current co
On Fri, Jan 3, 2025 at 1:53 AM Matheus Alcantara
wrote:
>
>
> Yeap, I agree. Attached a v2 fixed.
>
hi. some minor issue i found.
+#include "storage/block.h"
no need, since "#include "storage/bufmgr.h" already included it.
do we need to add ``CHECK_FOR_INTERRUPTS()`` in heapam_read_stream_next_
Thanks for reviewing!
Em qui., 2 de jan. de 2025 às 13:16, Kirill Reshke
escreveu:
>
> However, this:
>
> >- if (skip_option == SKIP_PAGES_ALL_FROZEN)
> >- {
> >- if ((mapbits & VISIBILITYMAP_ALL_FROZEN) != 0)
> >- continue;
> >- }
> >-
> >- if (skip_option == SKIP_PAGES_ALL_VISIBLE)
> >- {
> >-
On Thu, 2 Jan 2025 at 20:29, Matheus Alcantara wrote:
>
> Hi,
>
> While reviewing some other patches implementing stream API for core
> subsystems,
> I noticed that the amcheck extension could also benefit from that.
>
> Notice the refactor when handling the "skip" parameter; The logic was moved
Hi,
While reviewing some other patches implementing stream API for core subsystems,
I noticed that the amcheck extension could also benefit from that.
Notice the refactor when handling the "skip" parameter; The logic was moved to
the heapam_read_stream_next_block callback so that verify_heapam do
14 matches
Mail list logo
