On Thu, Mar 27, 2025 at 3:35 PM Melanie Plageman <melanieplage...@gmail.com> wrote: > > On Thu, Mar 27, 2025 at 4:45 AM Nazir Bilal Yavuz <byavu...@gmail.com> wrote: > > > > I liked the first approach more. We can solve the first approach's > > problems by introducing a void pointer to pass to > > read_stream_begin_relation(). We can set it to &rsdata.range for the > > SKIP_PAGES_NONE case and &rsdata for the rest. > > Cool. I've gone with this approach but have renamed all the functions > and structs to try and be more consistent and clear. > Committed in 043799fa08c2c and I marked the commitfest entry as such.
Just my 0.2 cents. I also like the first approach even though I prefer the v4 version, but anyway, thanks very much for reviewing and committing! (I was sending my anwer just when I received your reply) -- Matheus Alcantara
