Hi, Em ter., 11 de fev. de 2025 às 03:39, jian he <jian.universal...@gmail.com> escreveu: > hi. some minor issue i found. > > +#include "storage/block.h" > no need, since "#include "storage/bufmgr.h" already included it. > Fixed
> do we need to add ``CHECK_FOR_INTERRUPTS()`` in heapam_read_stream_next_block? > The current code on master don't CHECK_FOR_INTERRUPTS, so I would prefer to not change this behaviour, but I think that is considerable. > heapam_read_stream_next_block_private need add to > src/tools/pgindent/typedefs.list > Fixed > overall, it looks good to me. Thanks for the review! v3 with the fixes attached. -- Matheus Alcantara
v3-0001-Use-read-stream-on-amcheck.patch
Description: Binary data
