Re: pg_checkpointer is not a verb or verb phrase

2022-07-05 Thread Tom Lane
Robert Haas writes: > On Tue, Jul 5, 2022 at 3:42 PM Nathan Bossart > wrote: >> On Tue, Jul 05, 2022 at 01:38:43PM -0400, Robert Haas wrote: >>> I added the catversion bump, but left out the .po >>> file changes, figuring it was better to let those files get updated >>> via the normal process.

Re: pg_checkpointer is not a verb or verb phrase

2022-07-05 Thread Robert Haas
On Tue, Jul 5, 2022 at 3:42 PM Nathan Bossart wrote: > On Tue, Jul 05, 2022 at 01:38:43PM -0400, Robert Haas wrote: > > Hearing several votes in favor and none opposed, committed and > > back-patched to v15. > > Thanks. > > > I added the catversion bump, but left out the .po > > file changes, figu

Re: pg_checkpointer is not a verb or verb phrase

2022-07-05 Thread Nathan Bossart
On Tue, Jul 05, 2022 at 01:38:43PM -0400, Robert Haas wrote: > Hearing several votes in favor and none opposed, committed and > back-patched to v15. Thanks. > I added the catversion bump, but left out the .po > file changes, figuring it was better to let those files get updated > via the normal p

Re: pg_checkpointer is not a verb or verb phrase

2022-07-05 Thread Robert Haas
On Fri, Jul 1, 2022 at 5:50 PM Nathan Bossart wrote: > On Fri, Jul 01, 2022 at 03:36:48PM +0200, Magnus Hagander wrote: > > +1 for pg_checkpoint on that -- let's not make it longer than necessary. > > > > And yes, +1 for actually changing it. It's a lot cheaper to change it now > > than it will be

Re: pg_checkpointer is not a verb or verb phrase

2022-07-01 Thread Nathan Bossart
On Fri, Jul 01, 2022 at 03:36:48PM +0200, Magnus Hagander wrote: > +1 for pg_checkpoint on that -- let's not make it longer than necessary. > > And yes, +1 for actually changing it. It's a lot cheaper to change it now > than it will be in the future. Yes, it would've been even cheaper to have > a

Re: pg_checkpointer is not a verb or verb phrase

2022-07-01 Thread Magnus Hagander
On Fri, Jul 1, 2022 at 3:18 PM Robert Haas wrote: > On Thu, Jun 30, 2022 at 9:22 PM Michael Paquier > wrote: > > "checkpoint" is not a verb (right?), so would something like > > "pg_perform_checkpoint" rather than "pg_checkpoint" fit better in the > > larger picture? > > It's true that the dicti

Re: pg_checkpointer is not a verb or verb phrase

2022-07-01 Thread Robert Haas
On Thu, Jun 30, 2022 at 9:22 PM Michael Paquier wrote: > "checkpoint" is not a verb (right?), so would something like > "pg_perform_checkpoint" rather than "pg_checkpoint" fit better in the > larger picture? It's true that the dictionary describes checkpoint as a noun, but I think in a database c

Re: pg_checkpointer is not a verb or verb phrase

2022-06-30 Thread Justin Pryzby
On Fri, Jul 01, 2022 at 10:22:16AM +0900, Michael Paquier wrote: > On Thu, Jun 30, 2022 at 08:57:04AM -0400, Isaac Morland wrote: > > I was going to point out that pg_database_owner is the same way, but it is > > fundamentally different in that it has no special allowed access and is > > meant to b

Re: pg_checkpointer is not a verb or verb phrase

2022-06-30 Thread Isaac Morland
On Thu, 30 Jun 2022 at 21:22, Michael Paquier wrote: > On Thu, Jun 30, 2022 at 08:57:04AM -0400, Isaac Morland wrote: > > I was going to point out that pg_database_owner is the same way, but it > is > > fundamentally different in that it has no special allowed access and is > > meant to be the ta

Re: pg_checkpointer is not a verb or verb phrase

2022-06-30 Thread Michael Paquier
On Thu, Jun 30, 2022 at 08:57:04AM -0400, Isaac Morland wrote: > I was going to point out that pg_database_owner is the same way, but it is > fundamentally different in that it has no special allowed access and is > meant to be the target of permission grants rather than being granted to > other ro

Re: pg_checkpointer is not a verb or verb phrase

2022-06-30 Thread Isaac Morland
On Thu, 30 Jun 2022 at 08:48, Robert Haas wrote: Almost all of these are verbs or verb phrases: having this role gives > you the ability to read all data, or write all data, or read all > settings, or whatever. But you can't say that having this role gives > you the ability to checkpointer. It gi

pg_checkpointer is not a verb or verb phrase

2022-06-30 Thread Robert Haas
Hi, I was just looking at the list of predefined roles that we have, and pg_checkpointer is conspicuously not like the others: rhaas=# select rolname from pg_authid where oid!=10; rolname --- pg_database_owner pg_read_all_data pg_write_all_data pg_monitor pg