On Fri, Dec 03, 2021 at 12:45:34PM -0500, Tom Lane wrote:
> I think it's fine as-is; good belt-and-suspenders-too programming.
> It's not like the extra check inside SysLogger_Start() is costly.
+1.
--
Michael
signature.asc
Description: PGP signature
Bharath Rupireddy writes:
> On Fri, Dec 3, 2021 at 1:43 PM Daniel Gustafsson wrote:
>> On 3 Dec 2021, at 08:58, Bharath Rupireddy
>> wrote:
>>> It seems like there's an extra Logging_collector check before calling
>>> SysLogger_Start().
>> I think the code reads clearer with the Logging_collec
On Fri, Dec 3, 2021 at 1:43 PM Daniel Gustafsson wrote:
>
> > On 3 Dec 2021, at 08:58, Bharath Rupireddy
> > wrote:
>
> > It seems like there's an extra Logging_collector check before calling
> > SysLogger_Start(). Note that the SysLogger_Start() has a check to
> > return 0 if Logging_collector
> On 3 Dec 2021, at 08:58, Bharath Rupireddy
> wrote:
> It seems like there's an extra Logging_collector check before calling
> SysLogger_Start(). Note that the SysLogger_Start() has a check to
> return 0 if Logging_collector is off. This change is consistent with
> the other usage of SysLogger_
Hi,
It seems like there's an extra Logging_collector check before calling
SysLogger_Start(). Note that the SysLogger_Start() has a check to
return 0 if Logging_collector is off. This change is consistent with
the other usage of SysLogger_Start().
/* If we have lost the log collect
