> On 3 Dec 2021, at 08:58, Bharath Rupireddy > <bharath.rupireddyforpostg...@gmail.com> wrote:
> It seems like there's an extra Logging_collector check before calling > SysLogger_Start(). Note that the SysLogger_Start() has a check to > return 0 if Logging_collector is off. This change is consistent with > the other usage of SysLogger_Start(). > > /* If we have lost the log collector, try to start a new one */ > - if (SysLoggerPID == 0 && Logging_collector) > + if (SysLoggerPID == 0) > SysLoggerPID = SysLogger_Start(); I think the code reads clearer with the Logging_collector check left intact, and avoiding a function call in this codepath doesn't hurt. -- Daniel Gustafsson https://vmware.com/
