Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> writes:
> On Fri, Dec 3, 2021 at 1:43 PM Daniel Gustafsson <dan...@yesql.se> wrote:
>> On 3 Dec 2021, at 08:58, Bharath Rupireddy
>> <bharath.rupireddyforpostg...@gmail.com> wrote:
>>> It seems like there's an extra Logging_collector check before calling
>>> SysLogger_Start().
>> I think the code reads clearer with the Logging_collector check left intact,
>> and avoiding a function call in this codepath doesn't hurt.
> In that case, can we remove if (!Logging_collector) within
> SysLogger_Start() and have the check outside?
I think it's fine as-is; good belt-and-suspenders-too programming.
It's not like the extra check inside SysLogger_Start() is costly.
regards, tom lane
