Re: Typos in the comment for the estimate_multivariate_ndistinct()

Daniel Gustafsson 于2025年4月16日周三 22:20写道： > > On 14 Apr 2025, at 15:34, Tender Wang wrote: > > > > Hi, > > > > While reading the estimate_multivariate_ndistinct(), > > I think "If a match it found, *varinfos is > > * updated to remove the list of matched varinfos" > > should be "If a match is f

Re: Typos in the code and README

On Mon, 21 Apr 2025 at 11:21, Michael Paquier wrote: > Thanks for sharing the command able to spot all these. I just pushed a few more. The previous regex didn't account for the duplicate word being on the next line. I dug up the following to find the ones just committed in 78eda9e26. ag "\s([a-

Re: Typos in the code and README

On Mon, Apr 21, 2025 at 10:42:19AM +1200, David Rowley wrote: > On Sun, 20 Apr 2025 at 13:32, David Rowley wrote: >> Here are a few more fixes of a similar ilk. All new in 2025, >> predominantly from the last few days before feature freeze. > > I've pushed those ones. Thanks for sharing the comm

Re: Typos in the code and README

On Sun, 20 Apr 2025 at 13:32, David Rowley wrote: > Here are a few more fixes of a similar ilk. All new in 2025, > predominantly from the last few days before feature freeze. I've pushed those ones. David

Re: Typos in the code and README

On Sat, 19 Apr 2025 at 20:00, Alexander Lakhin wrote: > I've gathered the following collection of typos and inconsistencies > appeared since 2025-01-01: Here are a few more fixes of a similar ilk. All new in 2025, predominantly from the last few days before feature freeze. The few I wasn't a ful

Re: Typos in the code and README

Hello Michael, 19.04.2025 13:04, Michael Paquier wrote: Good finds, Alexander, particularly for the set of function and variable names used in the comments that do not match with the reality. I've checked all these, and they're good for me. Thank you for your attention to this! GIN_TUPLE_ -

Re: Typos in the code and README

On Sat, Apr 19, 2025 at 11:00:00AM +0300, Alexander Lakhin wrote: > I've gathered the following collection of typos and inconsistencies > appeared since 2025-01-01: Good finds, Alexander, particularly for the set of function and variable names used in the comments that do not match with the realit

Re: Typos in the code and README

Hello hackers, I've gathered the following collection of typos and inconsistencies appeared since 2025-01-01: aio_worker.c -> method_worker.c amcheck_lock_relation -> amcheck_lock_relation_and_check be_key -> be_cancel_key belonds -> belongs cann -> can CheckConstraintFetch -> CheckNNConstra

Re: Typos in the comment for the estimate_multivariate_ndistinct()

> On 14 Apr 2025, at 15:34, Tender Wang wrote: > > Hi, > > While reading the estimate_multivariate_ndistinct(), > I think "If a match it found, *varinfos is > * updated to remove the list of matched varinfos" > should be "If a match is found, *varinfos is > * updated to remove the list of mat

Re: Typos in the comment for the estimate_multivariate_ndistinct()

Tender Wang 于2025年4月14日周一 21:34写道： > Hi, > > While reading the estimate_multivariate_ndistinct(), > I think "If a match it found, *varinfos is > * updated to remove the list of matched varinfos" > should be "If a match is found, *varinfos is > * updated to remove the list of matched varinfos"

Re: Typos in the code and README

On Thu, 2 Jan 2025 at 05:00, Alexander Lakhin wrote: > Please look at another collection of typos and inconsistencies introduced > during 2024: The fixes all look good to me. I see some are mine, so I will take care of pushing. Thanks for the patch. David

Re: Typos in the code and README

Hello hackers, 03.09.2024 08:51, Michael Paquier wrote: And done that. Please look at another collection of typos and inconsistencies introduced during 2024: behvior -> behavior contraint -> constraint curent -> current disable_node -> disabled_nodes disabled_node > disabled_nodes disable

Re: Typos in the code and README

> On 4 Sep 2024, at 17:34, David Rowley wrote: > > On Wed, 4 Sept 2024 at 20:24, Daniel Gustafsson wrote: >> Not mandatory at all, but since you were prepping a typo backpatch anyways I >> figured these could join to put a small dent in reducing risks for future >> backports. > > I think this i

Re: Typos in the code and README

On Thu, Sep 05, 2024 at 03:34:31AM +1200, David Rowley wrote: > Anyway, I doubt hard > guidelines are warranted here, but maybe some hints about best > practices in https://wiki.postgresql.org/wiki/Committing_checklist ? Yep, that may be useful. I just tend to be cautious because it can be very e

Re: Typos in the code and README

On Wed, 4 Sept 2024 at 20:24, Daniel Gustafsson wrote: > Not mandatory at all, but since you were prepping a typo backpatch anyways I > figured these could join to put a small dent in reducing risks for future > backports. I think this is pretty good logic. I think fixing comment typos in ancien

Re: Typos in the code and README

> On 4 Sep 2024, at 03:25, Michael Paquier wrote: > > On Tue, Sep 03, 2024 at 12:00:13PM +0200, Daniel Gustafsson wrote: >> I see your v17 typo fixes, and raise you a few more. Commit 31a98934d169 >> from >> just now contains 2 (out of 3) sets of typos introduced in v17 so they should >> follow

Re: Typos in the code and README

On Tue, Sep 03, 2024 at 12:00:13PM +0200, Daniel Gustafsson wrote: > I see your v17 typo fixes, and raise you a few more. Commit 31a98934d169 from > just now contains 2 (out of 3) sets of typos introduced in v17 so they should > follow along when you push the ones mentioned here. Is that really m

Re: Typos in the code and README

> On 3 Sep 2024, at 07:51, Michael Paquier wrote: > > On Tue, Sep 03, 2024 at 02:24:32PM +0900, Michael Paquier wrote: >> On Mon, Sep 02, 2024 at 09:00:00PM +0300, Alexander Lakhin wrote: >>> I've gathered another bunch of defects with the possible substitutions. >>> Please take a look: >>> pgsta

Re: Typos in the code and README

On Tue, Sep 03, 2024 at 02:24:32PM +0900, Michael Paquier wrote: > On Mon, Sep 02, 2024 at 09:00:00PM +0300, Alexander Lakhin wrote: > > I've gathered another bunch of defects with the possible substitutions. > > Please take a look: > > pgstat_add_kind -> pgstat_register_kind (see 7949d9594) > > A

Re: Typos in the code and README

On Mon, Sep 02, 2024 at 09:00:00PM +0300, Alexander Lakhin wrote: > I've gathered another bunch of defects with the possible substitutions. > Please take a look: > pgstat_add_kind -> pgstat_register_kind (see 7949d9594) And here I thought I took care of these inconsistencies. This one is on me so

Re: Typos in the code and README

Hello, 12.08.2024 14:59, David Rowley wrote: (I know Daniel mentioned he'd get to these, but the ScanDirection one was my fault and I needed to clear that off my mind. I did a few others while on this topic.) Thank you, David, for working on that! I've gathered another bunch of defects with t

Re: Typos in the code and README

(I know Daniel mentioned he'd get to these, but the ScanDirection one was my fault and I needed to clear that off my mind. I did a few others while on this topic.) On Fri, 5 Jul 2024 at 05:00, Alexander Lakhin wrote: > Please look at another bunch of inconsistencies/orphaned entities I found > in

Re: Typos in the code and README

> On 4 Jul 2024, at 19:00, Alexander Lakhin wrote: > Please look at another bunch of inconsistencies/orphaned entities I found > in the tree, with the possible substitutions: Thanks for these, and sorry for the delay in processing them (summer happened etc). I've started to go through them and

Re: Typos in the code and README

Hello hackers, 03.05.2024 17:36, David Rowley wrote: I pushed the patch after only adjusting the path in the docs which had "module" rather than "modules". Please look at another bunch of inconsistencies/orphaned entities I found in the tree, with the possible substitutions: errmsg_buf -> erro

Re: Typos in the code and README

On Fri, 3 May 2024 at 00:00, Alexander Lakhin wrote: > (some of them are located in doc/, so it's not a code-only change) > I've attached the patch for your convenience, though maybe some > of the suggestions are to be discarded. Thanks. I was hoping you'd do that. I pushed the patch after only

Re: Typos in the code and README

Hello, 28.04.2024 11:05, David Rowley wrote: On Sat, 20 Apr 2024 at 16:09, David Rowley wrote: Here are a few more to see if it motivates anyone else to do a more thorough search for another batch. I've pushed these now. Please look also at the list of other typos and inconsistencies I've

Re: Typos in the code and README

On Sat, 20 Apr 2024 at 16:09, David Rowley wrote: > Here are a few more to see if it motivates anyone else to do a more > thorough search for another batch. I've pushed these now. David

Re: Typos in the code and README

On Fri, 19 Apr 2024 at 20:13, Daniel Gustafsson wrote: > Thanks, I incorporated these into 0001 before pushing. All the commits in > this > patchset are now applied. Here are a few more to see if it motivates anyone else to do a more thorough search for another batch. Fixes duplicate words spa

Re: Typos in the code and README

> On 16 Apr 2024, at 15:37, Nazir Bilal Yavuz wrote: > I realized two small typos: 'sgmr' -> 'smgr'. You may want to include > them in 0001. Thanks, I incorporated these into 0001 before pushing. All the commits in this patchset are now applied. -- Daniel Gustafsson

Re: Typos in the code and README

Hi, Thanks for working on this! On Mon, 15 Apr 2024 at 15:26, Daniel Gustafsson wrote: > > > On 14 Apr 2024, at 13:19, David Rowley wrote: > > > > On Sat, 13 Apr 2024 at 09:17, Daniel Gustafsson wrote: > >> > >>> On 12 Apr 2024, at 23:15, Heikki Linnakangas wrote: > >>> Here's a few more. I'v

Re: Typos in the code and README

On Mon, Apr 15, 2024 at 8:26 PM Daniel Gustafsson wrote: > Thanks. Collecting all the ones submitted here, as well as a few submitted > off-list by Alexander, the patch is now a 3-part patchset of cleanups: > > 0001 contains the typos and duplicate words fixups, 0002 fixes a parameter > with > t

Re: Typos in the code and README

> On 14 Apr 2024, at 13:19, David Rowley wrote: > > On Sat, 13 Apr 2024 at 09:17, Daniel Gustafsson wrote: >> >>> On 12 Apr 2024, at 23:15, Heikki Linnakangas wrote: >>> Here's a few more. I've accumulate these over the past couple of months, >>> keeping them stashed in a branch, adding to it

Re: Typos in the code and README

On Sat, 13 Apr 2024 at 09:17, Daniel Gustafsson wrote: > > > On 12 Apr 2024, at 23:15, Heikki Linnakangas wrote: > > Here's a few more. I've accumulate these over the past couple of months, > > keeping them stashed in a branch, adding to it whenever I've spotted a > > minor typo while reading t

Re: Typos in the code and README

> On 12 Apr 2024, at 23:15, Heikki Linnakangas wrote: > > On 11/04/2024 16:05, Daniel Gustafsson wrote: >> Now that the tree has settled down a bit post-freeze I ran some tooling to >> check spelling. I was primarily interested in docs and README* which were >> mostly free from simply typos, whi

Re: Typos in the code and README

On 11/04/2024 16:05, Daniel Gustafsson wrote: Now that the tree has settled down a bit post-freeze I ran some tooling to check spelling. I was primarily interested in docs and README* which were mostly free from simply typos, while the code had some in various comments and one in code. The atta

Re: Typos in the code and README

On Fri, Apr 12, 2024 at 04:55:16PM -0400, Bruce Momjian wrote: > On Thu, Apr 11, 2024 at 03:37:00PM +0200, Daniel Gustafsson wrote: > > On 11 Apr 2024, at 15:29, David Rowley wrote: > > > > On Fri, 12 Apr 2024, 1:05 am Daniel Gustafsson, wrote: > > > > Now that the tree has sett

Re: Typos in the code and README

On Thu, Apr 11, 2024 at 03:37:00PM +0200, Daniel Gustafsson wrote: > On 11 Apr 2024, at 15:29, David Rowley wrote: > > On Fri, 12 Apr 2024, 1:05 am Daniel Gustafsson, wrote: > > Now that the tree has settled down a bit post-freeze I ran some > tooling > to > che

Re: Typos in the code and README

> On 11 Apr 2024, at 15:29, David Rowley wrote: > > On Fri, 12 Apr 2024, 1:05 am Daniel Gustafsson, > wrote: >> Now that the tree has settled down a bit post-freeze I ran some tooling to >> check spelling. I was primarily interested in docs and README* which were >> most

Re: Typos in the code and README

On Fri, 12 Apr 2024, 1:05 am Daniel Gustafsson, wrote: > Now that the tree has settled down a bit post-freeze I ran some tooling to > check spelling. I was primarily interested in docs and README* which were > mostly free from simply typos, while the code had some in various comments > and > one

Re: Typos in the code and README

On 2024-04-11 Th 09:05, Daniel Gustafsson wrote: Now that the tree has settled down a bit post-freeze I ran some tooling to check spelling. I was primarily interested in docs and README* which were mostly free from simply typos, while the code had some in various comments and one in code. The

Re: Typos in reorderbuffer.c.

At Thu, 14 Mar 2024 11:23:38 +0530, Amit Kapila wrote in > On Thu, Mar 14, 2024 at 9:58 AM Kyotaro Horiguchi > wrote: > > > > While examining reorderbuffer.c, I found several typos. I'm not sure > > if fixing them is worthwhile, but I've attached a fix just in case. > > > > LGTM. I'll push thi

Re: Typos in reorderbuffer.c.

On Thu, Mar 14, 2024 at 9:58 AM Kyotaro Horiguchi wrote: > > While examining reorderbuffer.c, I found several typos. I'm not sure > if fixing them is worthwhile, but I've attached a fix just in case. > LGTM. I'll push this in some time. -- With Regards, Amit Kapila.

Re: typos

Michael Paquier writes: > On Wed, Feb 08, 2023 at 09:56:44AM -0600, Justin Pryzby wrote: >> Some more accumulated/new typos. > 0005 can indeed fix a lot of confusion around the spaces after an > "else if" block. Is that something that could be automated with the > indentation, though? Same rema

Re: typos

On Wed, Feb 08, 2023 at 09:56:44AM -0600, Justin Pryzby wrote: > Some more accumulated/new typos. 0001 has been a debate for a long time, and it depends on the way SQL is spelled. For reference: $ git grep -i " an sql" -- *.c | wc -l 63 $ git grep -i " a sql" -- *.c | wc -l 135 0005 can indeed f

Re: typos

Some more accumulated/new typos. >From 6c79a0d4e0251dbbac38babb60bb2d0fbae3da8d Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Wed, 11 Jan 2023 12:52:25 -0600 Subject: [PATCH 01/10] use "an SQL" rather than a SQL Per 04539e --- doc/src/sgml/ecpg.sgml | 6 +++--- 1 file changed, 3 insertions(

Re: typos

On Tue, Jan 10, 2023 at 01:55:56PM +0530, Amit Kapila wrote: > I have not yet started, so please go ahead. Okay, I have looked at that and fixed the whole new things, including the typo you have introduced. 0001~0004 have been left out, as of the same reasons as upthread. -- Michael signature.a

Re: typos

On Tue, Jan 10, 2023 at 1:18 PM Michael Paquier wrote: > > On Tue, Jan 10, 2023 at 12:24:40PM +0530, Amit Kapila wrote: > > Thanks for noticing this. I'll take care of this and some other typo > > patches together. > > Does this include 0010? I was just looking at the whole set and this > one loo

Re: typos

On Tue, Jan 10, 2023 at 12:24:40PM +0530, Amit Kapila wrote: > Thanks for noticing this. I'll take care of this and some other typo > patches together. Does this include 0010? I was just looking at the whole set and this one looked like a cleanup worth on its own so I was going to handle it, unti

Re: typos

On Tue, Jan 10, 2023 at 10:27 AM Justin Pryzby wrote: > > On Tue, Jan 03, 2023 at 03:39:22PM -0600, Justin Pryzby wrote: > > On Tue, Jan 03, 2023 at 04:28:29PM +0900, Michael Paquier wrote: > > > On Fri, Dec 30, 2022 at 05:12:57PM -0600, Justin Pryzby wrote: > > > > > > # Use larger ccache ca

Re: typos

On Tue, Jan 03, 2023 at 03:39:22PM -0600, Justin Pryzby wrote: > On Tue, Jan 03, 2023 at 04:28:29PM +0900, Michael Paquier wrote: > > On Fri, Dec 30, 2022 at 05:12:57PM -0600, Justin Pryzby wrote: > > > > # Use larger ccache cache, as this task compiles with multiple > > compilers / > >

Re: typos

On Tue, Jan 03, 2023 at 04:28:29PM +0900, Michael Paquier wrote: > On Fri, Dec 30, 2022 at 05:12:57PM -0600, Justin Pryzby wrote: > > # Use larger ccache cache, as this task compiles with multiple compilers > / > # flag combinations > -CCACHE_MAXSIZE: "1GB" > +CCACHE_MAXSIZE: "1

Re: typos

On 03.01.23 09:41, Michael Paquier wrote: On Tue, Jan 03, 2023 at 01:03:01PM +0530, Amit Kapila wrote: One minor comment: -spoken in Belgium (BE), with a UTF-8 character set +spoken in Belgium (BE), with a UTF-8 character set Shouldn't this be UTF8 as we are using in func.sgml? Yeah,

Re: typos

On Tue, Jan 03, 2023 at 01:03:01PM +0530, Amit Kapila wrote: > One minor comment: > -spoken in Belgium (BE), with a UTF-8 character set > +spoken in Belgium (BE), with a UTF-8 character set > > Shouldn't this be UTF8 as we are using in func.sgml? Yeah, I was wondering as well why this cha

Re: typos

On Tue, Jan 3, 2023 at 12:58 PM Michael Paquier wrote: > > On Fri, Dec 30, 2022 at 05:12:57PM -0600, Justin Pryzby wrote: > > # Use larger ccache cache, as this task compiles with multiple compilers > / > # flag combinations > -CCACHE_MAXSIZE: "1GB" > +CCACHE_MAXSIZE: "1G" > > I

Re: typos

On Fri, Dec 30, 2022 at 05:12:57PM -0600, Justin Pryzby wrote: # Use larger ccache cache, as this task compiles with multiple compilers / # flag combinations -CCACHE_MAXSIZE: "1GB" +CCACHE_MAXSIZE: "1G" In 0006, I am not sure how much this matters. Perhaps somebody more fluent

Re: typos

On Thu, Apr 14, 2022 at 08:56:22AM +1200, David Rowley wrote: > 0007: Not pushed. No space after comment and closing */ pgindent > fixed one of these but not the other 2. I've not looked into why > pgindent does 1 and not the other 2. > -/* get operation priority by its code*/ > +/* get operati

Re: typos

On Tue, May 10, 2022 at 09:03:34PM -0500, Justin Pryzby wrote: > I found a bunch more typos; a couple from codespell, and several which are the > result of looking for previously-reported typos, like: Thanks, applied 0002. Regarding 0001, I don't really know which one of {AND,OR}ed or {AND,OR}-ed

Re: typos

I found a bunch more typos; a couple from codespell, and several which are the result of looking for previously-reported typos, like: time git log origin --grep '[tT]ypo' --word-diff -U1 |grep -Eo '\[-[[:lower:]]+-\]' |sed 's/^\[-//; s/-\]$//' |sort -u |grep -Fxvwf /usr/share/dict/words >badword

Re: typos

On 2022-Apr-21, Peter Eisentraut wrote: > It is referred to as "Zstandard" at both of those places. Maybe we should > use that. That is also easier to pronounce. Yeah, I looked at other places (such as Yann Collet's blog) and I agree that Zstandard seems to be the accepted spelling of the produ

Re: typos

On 21.04.22 06:36, Michael Paquier wrote: On Wed, Apr 20, 2022 at 11:32:08PM +0200, Alvaro Herrera wrote: So the attached. --- a/doc/src/sgml/install-windows.sgml +++ b/doc/src/sgml/install-windows.sgml @@ -307,9 +307,9 @@ $ENV{MSBFLAGS}="/m"; - ZSTD + Zstd -

Re: typos

On Wed, Apr 20, 2022 at 11:32:08PM +0200, Alvaro Herrera wrote: > So the attached. > > --- a/doc/src/sgml/install-windows.sgml > +++ b/doc/src/sgml/install-windows.sgml > @@ -307,9 +307,9 @@ $ENV{MSBFLAGS}="/m"; > > > > - ZSTD > + Zstd > > - Required for supportin

Re: typos

On Wed, Apr 20, 2022 at 5:31 PM Alvaro Herrera wrote: > > On 2022-Apr-20, Amit Kapila wrote: > > > Your proposed changes look good to me but I think all these places > > need to mention 'column list' as well because the behavior is the same > > for it. > > Hmm, you're right. Added that, and chang

Re: typos

On Wed, Apr 20, 2022 at 11:32:08PM +0200, Alvaro Herrera wrote: > On 2022-Apr-19, Alvaro Herrera wrote: > > > I propose we standardize on Zstd everywhere. > > Users can look it up if they're really interested. > > So the attached. > > There are other uses of zstd, but those are referring to > t

Re: typos

On 2022-Apr-19, Alvaro Herrera wrote: > I propose we standardize on Zstd everywhere. > Users can look it up if they're really interested. So the attached. There are other uses of zstd, but those are referring to the executable program. -- Álvaro Herrera PostgreSQL Developer — https:/

Re: typos

On 2022-Apr-20, Amit Kapila wrote: > Your proposed changes look good to me but I think all these places > need to mention 'column list' as well because the behavior is the same > for it. Hmm, you're right. Added that, and changed the wording somewhat because some things read awkwardly. Here's t

Re: typos

On Tue, Apr 19, 2022 at 4:35 PM Alvaro Herrera wrote: > > Yeah, more invasive rewording seems called for. I propose this: > >For publications containing partitioned tables, the row filter for each >partition is taken from the published partitioned table if the >publication parameter p

Re: typos

CCing Amit K, because I propose a few relatively minor changes to logical rep docs. On 2022-Apr-13, Justin Pryzby wrote: > $ git grep -F ", the default)" > doc/src/sgml/ref/create_publication.sgml: partition's row filter (if the > parameter is false, the default) or the root > > Maybe what's

Re: typos

On Thu, Apr 14, 2022 at 09:39:42AM +1200, David Rowley wrote: > On Thu, 14 Apr 2022 at 05:40, Justin Pryzby wrote: > > There's (only) a few remaining. > > I've pushed 0001 and 0002 of the 3rd batch of patches. I left 0003 as Thanks > I just didn't feel it was a meaningful enough improvement. >

Re: typos

(For the future, just to make discussions easier, it would be good if you could have git format-patch -v N to give a unique version number to these patches) On Thu, 14 Apr 2022 at 05:40, Justin Pryzby wrote: > There's (only) a few remaining. I've pushed 0001 and 0002 of the 3rd batch of patches.

Re: typos

On Mon, 11 Apr 2022 at 22:10, Justin Pryzby wrote: > Thanks for amending and pushing those. There's some more less obvious ones > attached. Here are my notes from yesterday that I made when reviewing and pushing many of the 2nd batch of patches. 0001: Pushed and back patched to v12 0002: Didn'

Re: typos

On Wed, Apr 13, 2022 at 07:29:34PM +0200, Alvaro Herrera wrote: > On 2022-Apr-11, David Rowley wrote: > > > and also skipped: > > 0016 (unsure if we should change these of pgindent is not touching it) > > 0017 (unsure if we should change these of pgindent is not touching it) > > I verified that p

Re: typos

On 2022-Apr-11, David Rowley wrote: > and also skipped: > 0016 (unsure if we should change these of pgindent is not touching it) > 0017 (unsure if we should change these of pgindent is not touching it) I verified that pgindent will indeed not touch these changes by running before and after. (I a

Re: typos

On Mon, Apr 11, 2022 at 4:15 PM Amit Kapila wrote: > > On Mon, Apr 11, 2022 at 3:55 PM Masahiko Sawada wrote: > > > > On Mon, Apr 11, 2022 at 7:10 PM Justin Pryzby wrote: > > > > > > Amit or Masahiko may want to comment on 0012 (doc review: Add ALTER > > > SUBSCRIPTION ... SKIP). > > > > +1. I'l

Re: typos

On Mon, Apr 11, 2022 at 4:56 AM David Rowley wrote: > 0011 (Could do with input from Robert and Joe) Seems like a reasonable change to me. -- Robert Haas EDB: http://www.enterprisedb.com

Re: typos

On Mon, Apr 11, 2022 at 3:55 PM Masahiko Sawada wrote: > > On Mon, Apr 11, 2022 at 7:10 PM Justin Pryzby wrote: > > > > Amit or Masahiko may want to comment on 0012 (doc review: Add ALTER > > SUBSCRIPTION ... SKIP). > > Thank you for the patch! I've looked at 0012 patch. Regarding the > following

Re: typos

On Mon, Apr 11, 2022 at 7:10 PM Justin Pryzby wrote: > > On Mon, Apr 11, 2022 at 04:39:30PM +1200, David Rowley wrote: > > I'm not entirely certain this is an improvement. Your commit message > > I'd say is not true going by git grep "compression algorithm". There > > are 3 matches in the docs an

Re: typos

On Mon, Apr 11, 2022 at 04:39:30PM +1200, David Rowley wrote: > I'm not entirely certain this is an improvement. Your commit message > I'd say is not true going by git grep "compression algorithm". There > are 3 matches in the docs and take [1], for example. I'd say in that > one it's better to us

Re: typos

On Mon, 11 Apr 2022 at 16:39, David Rowley wrote: > I will start pushing the less controversial of these, after a bit of > squashing. I just committed 3 separate commits for the following: Committed: 0001 + 0003 + 0004 + 0006 + 0007 (modified) + 0008 + 0009 + 0012 (doc parts) Committed: 0012 (r

Re: typos

( Added Joe and Robert for 0011 ) On Mon, 11 Apr 2022 at 14:03, Justin Pryzby wrote: > In docs and comments. Mostly for v15. 0001: Should this not use PostgreSQL? (new to master) 0002: The patch looks good. (new to v12) 0003: The patch looks good. (new to master) 0004: The patch looks go

Re: typos

On Mon, Jan 24, 2022 at 04:55:31PM +0900, Michael Paquier wrote: > I'm thinking about just removing that at the end. And done this way, keeping the whole simpler. I have applied most of the things you suggested, with a backpatch down to 10 for the relevant user-visible parts in the docs. Thanks!

Re: typos

On Mon, Jan 24, 2022 at 01:07:54AM -0600, Justin Pryzby wrote: > different from what? From each other ? Each segment could be either uncompressed, compressed with LZ4, or compressed with GZIP, so could be different from each other. > Maybe I would have written: > | This is calculated separately

Re: typos

On Mon, Jan 24, 2022 at 04:01:47PM +0900, Michael Paquier wrote: > On Sun, Jan 23, 2022 at 09:00:01PM -0600, Justin Pryzby wrote: > > Feel free to ignore this for now and revisit in April... > > I don't mind fixing that now. That means less to do later. Thanks. > > @Michael: I'm not sure what t

Re: typos

On Sun, Jan 23, 2022 at 09:00:01PM -0600, Justin Pryzby wrote: > Feel free to ignore this for now and revisit in April... I don't mind fixing that now. That means less to do later. > @Michael: I'm not sure what this is trying to say. > 1e9475694b0ae2cf1204d01d2ef6ad86f3c7cac8 > + First, sca

Re: typos (and more)

On Mon, Sep 27, 2021 at 09:27:56PM -0500, Justin Pryzby wrote: > That's an "expanded" version of 0008. Okay, thanks. > It doesn't include 0012, which is primarily about fixing incorrect references > to "index expressions" that should refer to stats expressions. Naturally 0012 > also uses the phr

Re: typos (and more)

On Tue, Sep 28, 2021 at 11:15:39AM +0900, Michael Paquier wrote: > On Mon, Sep 27, 2021 at 07:50:02PM -0500, Justin Pryzby wrote: > > Attached is an updated patch fixing more of the same. > > Does this include everything you have spotted, as well as everything > from the previous patches 0008 and

Re: typos (and more)

On Mon, Sep 27, 2021 at 07:50:02PM -0500, Justin Pryzby wrote: > Attached is an updated patch fixing more of the same. Does this include everything you have spotted, as well as everything from the previous patches 0008 and 0012 posted? -- Michael signature.asc Description: PGP signature

Re: typos (and more)

On Mon, Sep 27, 2021 at 06:04:02PM -0300, Alvaro Herrera wrote: > On 2021-Sep-27, Michael Paquier wrote: > > > The use > > of "statistic", "statistics" and "statistics object" in 0008 and 0012 > > is indeed inconsistent. The latter term is the most used, but it > > sounds a bit weird to me even i

Re: typos (and more)

On Mon, Sep 27, 2021 at 06:04:02PM -0300, Alvaro Herrera wrote: > Initially we just used "statistic" as a noun, which IIRC was already > grammatically wrong (but I didn't know that and I think Tomas didn't > either); later at some point when discussing how to use that noun in > plural we realized t

Re: typos (and more)

On 2021-Sep-27, Michael Paquier wrote: > The use > of "statistic", "statistics" and "statistics object" in 0008 and 0012 > is indeed inconsistent. The latter term is the most used, but it > sounds a bit weird to me even if it refers to the DDL object > manipulated. Simply using "statistics" woul

Re: typos (and more)

On Mon, Sep 27, 2021 at 09:24:27AM +0900, Michael Paquier wrote: > Yes, thanks for compiling all these. The two changes committed were > the only user-visible changes, which is why I have hastened this part > to include those fixes. The rest could just go on HEAD. I have looked at the full set,

Re: typos (and more)

On Sun, Sep 26, 2021 at 12:01:17PM -0500, Justin Pryzby wrote: > Thanks Michael for applying fixes to user-facing docs (I hadn't realized that > the 2nd one needed to be backpatched). Yes, thanks for compiling all these. The two changes committed were the only user-visible changes, which is why I

Re: typos (and more)

On Fri, Sep 24, 2021 at 04:58:27PM -0500, Justin Pryzby wrote: > A compilation of fixes for master. Thanks Michael for applying fixes to user-facing docs (I hadn't realized that the 2nd one needed to be backpatched). This fixes an file I failed to include in the "recheck" patch and more typos for

Re: typos in comments referring to macros

On Wed, Jun 10, 2020 at 3:19 PM Amit Kapila wrote: > > On Wed, Jun 10, 2020 at 2:47 PM John Naylor > wrote: > > > > It should be BLCKSZ and LOBLKSIZE, as in the attached. > > > > LGTM on first look. I'll push either later today or tomorrow. > Pushed. -- With Regards, Amit Kapila. EnterpriseDB

Re: typos in comments referring to macros

On Wed, Jun 10, 2020 at 2:47 PM John Naylor wrote: > > It should be BLCKSZ and LOBLKSIZE, as in the attached. > LGTM on first look. I'll push either later today or tomorrow. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com

Re: typos in comments and user docs

On Fri, Feb 7, 2020 at 9:47 AM Justin Pryzby wrote: > > On Fri, Feb 07, 2020 at 09:26:04AM +0530, Amit Kapila wrote: > > On Fri, Feb 7, 2020 at 8:41 AM Justin Pryzby wrote: > > > > > > On Fri, Feb 07, 2020 at 08:33:40AM +0530, Amit Kapila wrote: > > > > On Thu, Feb 6, 2020 at 7:26 PM Justin Pryzb

Re: typos in comments and user docs

On Fri, Feb 07, 2020 at 09:26:04AM +0530, Amit Kapila wrote: > On Fri, Feb 7, 2020 at 8:41 AM Justin Pryzby wrote: > > > > On Fri, Feb 07, 2020 at 08:33:40AM +0530, Amit Kapila wrote: > > > On Thu, Feb 6, 2020 at 7:26 PM Justin Pryzby wrote: > > > > > > > > On Thu, Feb 06, 2020 at 04:43:18PM +053

Re: typos in comments and user docs

On Fri, Feb 7, 2020 at 8:41 AM Justin Pryzby wrote: > > On Fri, Feb 07, 2020 at 08:33:40AM +0530, Amit Kapila wrote: > > On Thu, Feb 6, 2020 at 7:26 PM Justin Pryzby wrote: > > > > > > On Thu, Feb 06, 2020 at 04:43:18PM +0530, Amit Kapila wrote: > > > > On Thu, Feb 6, 2020 at 10:45 AM Michael Paq

Re: typos in comments and user docs

On Fri, Feb 07, 2020 at 08:33:40AM +0530, Amit Kapila wrote: > On Thu, Feb 6, 2020 at 7:26 PM Justin Pryzby wrote: > > > > On Thu, Feb 06, 2020 at 04:43:18PM +0530, Amit Kapila wrote: > > > On Thu, Feb 6, 2020 at 10:45 AM Michael Paquier > > > wrote: > > > > > > > > On Thu, Feb 06, 2020 at 08:47

Re: typos in comments and user docs

On Thu, Feb 6, 2020 at 7:26 PM Justin Pryzby wrote: > > On Thu, Feb 06, 2020 at 04:43:18PM +0530, Amit Kapila wrote: > > On Thu, Feb 6, 2020 at 10:45 AM Michael Paquier wrote: > > > > > > On Thu, Feb 06, 2020 at 08:47:14AM +0530, Amit Kapila wrote: > > > > Your changes look fine to me on the firs

Re: typos in comments and user docs

On Thu, Feb 06, 2020 at 04:43:18PM +0530, Amit Kapila wrote: > On Thu, Feb 6, 2020 at 10:45 AM Michael Paquier wrote: > > > > On Thu, Feb 06, 2020 at 08:47:14AM +0530, Amit Kapila wrote: > > > Your changes look fine to me on the first read. I will push this to > > > HEAD unless there are any obje

  1   2   >