On Fri, Feb 7, 2020 at 9:47 AM Justin Pryzby <pry...@telsasoft.com> wrote: > > On Fri, Feb 07, 2020 at 09:26:04AM +0530, Amit Kapila wrote: > > On Fri, Feb 7, 2020 at 8:41 AM Justin Pryzby <pry...@telsasoft.com> wrote: > > > > > > On Fri, Feb 07, 2020 at 08:33:40AM +0530, Amit Kapila wrote: > > > > On Thu, Feb 6, 2020 at 7:26 PM Justin Pryzby <pry...@telsasoft.com> > > > > wrote: > > > > > > > > > > On Thu, Feb 06, 2020 at 04:43:18PM +0530, Amit Kapila wrote: > > > > > > On Thu, Feb 6, 2020 at 10:45 AM Michael Paquier > > > > > > <mich...@paquier.xyz> wrote: > > > > > > > > > > > > > > On Thu, Feb 06, 2020 at 08:47:14AM +0530, Amit Kapila wrote: > > > > > > > > Your changes look fine to me on the first read. I will push > > > > > > > > this to > > > > > > > > HEAD unless there are any objections. If we want them in > > > > > > > > back-branches, we might want to probably segregate the changes > > > > > > > > based > > > > > > > > on the branch until those apply. > > > > > > > > > > > > > > +1. It would be nice to back-patch the user-visible changes in > > > > > > > the > > > > > > > docs. > > > > > > > > > > > > > > > > > > > Fair enough, Justin, is it possible for you to segregate the changes > > > > > > that can be backpatched? > > > > > > > > > > Looks like the whole patch can be applied to master and v12 [0]. > > > > > > > > I tried your patch master and it failed to apply. > > (Stripping trailing CRs from patch; use --binary to disable.) > > patching file doc/src/sgml/bloom.sgml > > (Stripping trailing CRs from patch; use --binary to disable.) > > patching file doc/src/sgml/config.sgml > > Hunk #1 FAILED at 4318. > > 1 out of 1 hunk FAILED -- saving rejects to file > > doc/src/sgml/config.sgml.rej > > I think you applied the first patch, which I corrected here. > https://www.postgresql.org/message-id/20200206135640.GG403%40telsasoft.com > > Just rechecked it works for master and v12. >
Okay, thanks. I have pushed user-facing changes (bloom.sgml and alter_table.sgml) to back branches till they apply and rest of the changes in just HEAD. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
