On Fri, Apr 16, 2021 at 02:03:10AM -0500, Justin Pryzby wrote:
> A bunch more found with things like this.
Thanks, applied most of it!
--
Michael
signature.asc
Description: PGP signature
A bunch more found with things like this.
find src -name '*.c' |xargs grep '^[[:space:]]*/\?\*' |grep -woE
'[[:lower:]]{3,8}' |sed 's/.*/\L&/' |
sort |uniq -c |sort -nr |awk '$1==1' |less
>From 9fd5e2797efc14f83bfb2d47d5174de81a34ac6e Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Th
On Fri, Apr 09, 2021 at 02:03:27PM +0900, Michael Paquier wrote:
> On Thu, Apr 08, 2021 at 11:40:08AM -0500, Justin Pryzby wrote:
> > Another round of doc review, not yet including all of yesterday's commits.
>
> Thanks for compiling all that. I got through the whole set and
> applied the most re
On Thu, Apr 08, 2021 at 11:40:08AM -0500, Justin Pryzby wrote:
> Another round of doc review, not yet including all of yesterday's commits.
Thanks for compiling all that. I got through the whole set and
applied the most relevant parts on HEAD. Some of them applied down to
9.6, so I have fixed it
Another round of doc review, not yet including all of yesterday's commits.
29c8d614c3 duplicate words
diff --git a/src/include/lib/sort_template.h b/src/include/lib/sort_template.h
index 771c789ced..24d6d0006c 100644
--- a/src/include/lib/sort_template.h
+++ b/src/include/lib/sort_template.h
@@ -2
On Mon, Mar 01, 2021 at 03:17:40PM +0900, Michael Paquier wrote:
> You could say here "Checksums can be enabled", but "normally" does not
> sound bad to me either as it insists on the fact that it is better to
> do that when the cluster is initdb'd as this has no downtime compared
> to enabling che
On Sun, Feb 28, 2021 at 10:33:55PM -0600, Justin Pryzby wrote:
> I still have an issue with the sentence that begins:
> "Checksums are normally enabled..."
You could say here "Checksums can be enabled", but "normally" does not
sound bad to me either as it insists on the fact that it is better to
d
On Mon, Mar 01, 2021 at 01:11:10PM +0900, Michael Paquier wrote:
> On Sun, Feb 28, 2021 at 06:46:47PM -0600, Justin Pryzby wrote:
> > It looks like you applied 0010...but I agree that it's not an improvement.
> > It
> > appears that's something I intended to go back and revisit myself.
> > The re
On Sun, Feb 28, 2021 at 06:46:47PM -0600, Justin Pryzby wrote:
> It looks like you applied 0010...but I agree that it's not an improvement. It
> appears that's something I intended to go back and revisit myself.
> The rest of the patch looks right, to me.
Oops. This was not intended.
> I'm sugg
On Wed, Feb 24, 2021 at 04:18:51PM +0900, Michael Paquier wrote:
> This leaves 0003, 0004, 0005, 0010, 0012, 0018, 0020 and 0021 as these
> did not look like improvements after review.
It looks like you applied 0010...but I agree that it's not an improvement. It
appears that's something I intende
On Wed, Feb 24, 2021 at 01:39:55AM -0600, Justin Pryzby wrote:
> On Wed, Feb 24, 2021 at 04:18:51PM +0900, Michael Paquier wrote:
>> +The status of each kind of extended statistics is shown in a column
>> +named after the "kind" (e.g. Ndistinct).
>> +NULL means that it doesn
On Wed, Feb 24, 2021 at 04:18:51PM +0900, Michael Paquier wrote:
> On Mon, Feb 22, 2021 at 02:03:45AM -0600, Justin Pryzby wrote:
> > Rebased, with a few additions.
>
> Thanks. I have done a pass through this series, and applied most of
> this stuff with a backpatch for the doc portions.
>
> +
On Mon, Feb 22, 2021 at 02:03:45AM -0600, Justin Pryzby wrote:
> Rebased, with a few additions.
Thanks. I have done a pass through this series, and applied most of
this stuff with a backpatch for the doc portions.
+The status of each kind of extended statistics is shown in a column
+
Rebased, with a few additions.
>From 27656ceb05d495300d86df40a1d25b0b454fa18b Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Fri, 8 Jan 2021 13:09:55 -0600
Subject: [PATCH 01/21] doc: pageinspect
d6061f83a166b015657fda8623c704fcb86930e9
backpatch to 9.6?
---
doc/src/sgml/pageinspect.sgml |
Another round of doc fixen.
wdiff to follow
commit 389c4ac2febe21fd48480a86819d94fd2eb9c1cc
Author: Justin Pryzby
Date: Wed Feb 10 17:19:51 2021 -0600
doc review for pg_stat_progress_create_index
ab0dfc961b6a821f23d9c40c723d11380ce195a6
should backpatch to v13
diff --gi
On Wed, Jan 27, 2021 at 02:52:14PM +0900, Michael Paquier wrote:
> And attached is a patch to clarify all that. I am letting that sleep
> for a couple of days for now, so please let me know if you have any
> comments.
I have spent some time on that, and applied this stuff as of 2a5862f
after some
On Sat, Jan 23, 2021 at 07:15:40PM +0900, Michael Paquier wrote:
> I have been looking at 0005, the patch dealing with the docs of the
> replication stats, and have some comments.
And attached is a patch to clarify all that. I am letting that sleep
for a couple of days for now, so please let me k
Hi Justin,
On Sun, Dec 27, 2020 at 02:26:05PM -0600, Justin Pryzby wrote:
> Thank you.
I have been looking at 0005, the patch dealing with the docs of the
replication stats, and have some comments.
Number of times transactions were spilled to disk while decoding
changes
-
On Fri, Jan 22, 2021 at 09:53:13PM +0900, Masahiko Sawada wrote:
> It seems to me that all work has been done. Can we mark this patch
> entry as "Committed"? Or waiting for something on the author?
Patch 0005 posted on [1], related to some docs of replication slots,
still needs a lookup.
[1]: htt
On Wed, Jan 6, 2021 at 10:37 AM Michael Paquier wrote:
>
> On Sun, Jan 03, 2021 at 09:05:09PM +0900, Michael Paquier wrote:
> > So let's use this version and call it a day for this part.
>
> This has been done as of b49154b.
It seems to me that all work has been done. Can we mark this patch
entry
On Sun, Jan 03, 2021 at 09:05:09PM +0900, Michael Paquier wrote:
> So let's use this version and call it a day for this part.
This has been done as of b49154b.
--
Michael
signature.asc
Description: PGP signature
On Sun, Jan 03, 2021 at 12:33:54AM -0600, Justin Pryzby wrote:
>
> But actually, maybe we should just use the comment that exists everywhere else
> for that.
>
> /* Propagate context related error context to libxml2 */
> xmlSetStructuredErrorFunc((void *) xtCxt->xmlerrcxt,
> xml_
On Sun, Jan 03, 2021 at 03:10:54PM +0900, Michael Paquier wrote:
> On Tue, Dec 29, 2020 at 06:22:43PM +0900, Michael Paquier wrote:
> > Yes, I have done an extra effort on those fixes where needed. On top
> > of that, I have included catalogs.sgml, pgstatstatements.sgml,
> > explain.sgml, pg_verif
On Tue, Dec 29, 2020 at 06:22:43PM +0900, Michael Paquier wrote:
> Yes, I have done an extra effort on those fixes where needed. On top
> of that, I have included catalogs.sgml, pgstatstatements.sgml,
> explain.sgml, pg_verifybackup.sgml and wal.sgml in 13.
Justin, I got to look at the libxml2 pa
Magnus Hagander writes:
> On Tue, Dec 29, 2020 at 1:37 AM Michael Paquier wrote:
>> Magnus, do I have an access to that? This is the second time I am
>> crossing an issue with this issue, but I don't really know if I should
>> act on it or not :)
> No, at this point it's just Tom (who has all t
On Tue, Dec 29, 2020 at 1:37 AM Michael Paquier wrote:
> On Mon, Dec 28, 2020 at 11:42:03AM +0100, Magnus Hagander wrote:
> > Not as much "tightly controlled" as "nobody's really bothered to grant
> any
> > permissions".
>
> Magnus, do I have an access to that? This is the second time I am
> cro
On Sun, Dec 27, 2020 at 02:26:05PM -0600, Justin Pryzby wrote:
> I think a couple of these should be backpatched.
> doc/src/sgml/ref/pg_dump.sgml
This part can go down to 9.5.
> doc/src/sgml/sources.sgml
Yes, I have done an extra effort on those fixes where needed. On top
of that, I have includ
On Tue, Dec 29, 2020 at 01:59:58PM +1300, Thomas Munro wrote:
> LGTM.
Thanks, I have done this one then.
--
Michael
signature.asc
Description: PGP signature
On Thu, Dec 24, 2020 at 9:12 PM Michael Paquier wrote:
> On Mon, Dec 21, 2020 at 10:11:53PM -0600, Justin Pryzby wrote:
> > Specifies the amount of memory that should be allocated at server
> > -startup time for use by parallel queries. When this memory region
> > is
> > +
On Mon, Dec 28, 2020 at 11:42:03AM +0100, Magnus Hagander wrote:
> Not as much "tightly controlled" as "nobody's really bothered to grant any
> permissions".
Magnus, do I have an access to that? This is the second time I am
crossing an issue with this issue, but I don't really know if I should
ac
On Sun, Dec 27, 2020 at 9:26 PM Justin Pryzby wrote:
> On Thu, Dec 24, 2020 at 05:12:02PM +0900, Michael Paquier wrote:
> > 0001-pgindent-typos.not-a-patch touches pg_bsd_indent.
>
> I'm hoping that someone will apply it there, but I realize that access to
> its
> repository is tightly controlled
On Thu, Dec 24, 2020 at 05:12:02PM +0900, Michael Paquier wrote:
> I have applied most of it on HEAD, except 0011 and the things noted
> above. Thanks again.
Thank you.
I see that I accidentally included ZSTD_COMPRESSION in pg_backup_archiver.h
while cherry-picking from the branch where I first
On Mon, Dec 21, 2020 at 10:11:53PM -0600, Justin Pryzby wrote:
> As I did last 2 years, I reviewed docs for v14...
Thanks for gathering all that!
> This year I've started early, since it takes more than a little effort and
> it's
> not much fun to argue the change in each individual hunk.
0001-
33 matches
Mail list logo
