On Sun, Feb 28, 2021 at 06:46:47PM -0600, Justin Pryzby wrote: > It looks like you applied 0010...but I agree that it's not an improvement. It > appears that's something I intended to go back and revisit myself. > The rest of the patch looks right, to me.
Oops. This was not intended. > I'm suggesting to either revert that part, or apply these more polished > changes > in 0002. I would just group both things together. Monday helping, I can see that the new wording is better on a couple of points after doing a diff of wal.sgml with c82d59d6: - "checksum protected" in the first sentence is weird, so I agree that using "By default, data pages are not protected by checksums" is an improvement. - "assigned" is indeed a bit strange, "includes" is an improvement, and I would tend to not use a passive form here. - "to recover from corrupt data" is redundant with "to recover data" so the second one should be removed. My take is to use "page corruptions" instead of "corrupt data", which should be corrupted data to be grammatically correct. This gives the attached, that has as result to not change the second paragraph compared to the pre-c82d59d6 version of the area. -- Michael
diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgml
index 02f576a1a9..f75527f764 100644
--- a/doc/src/sgml/wal.sgml
+++ b/doc/src/sgml/wal.sgml
@@ -237,19 +237,19 @@
</indexterm>
<para>
- By default, data pages are not protected by checksums, but this can optionally be
- enabled for a cluster. When enabled, each data page will be ASSIGNED a
- checksum that is updated when the page is written and verified each time
+ By default, data pages are not protected by checksums, but this can
+ optionally be enabled for a cluster. When enabled, each data page includes
+ a checksum that is updated when the page is written and verified each time
the page is read. Only data pages are protected by checksums; internal data
structures and temporary files are not.
</para>
<para>
- Checksums verification is normally ENABLED when the cluster is initialized using <link
+ Checksums are normally enabled when the cluster is initialized using <link
linkend="app-initdb-data-checksums"><application>initdb</application></link>.
They can also be enabled or disabled at a later time as an offline
operation. Data checksums are enabled or disabled at the full cluster
- level, and cannot be specified for individual databases or tables.
+ level, and cannot be specified individually for databases or tables.
</para>
<para>
@@ -260,9 +260,9 @@
</para>
<para>
- When attempting to recover from corrupt data, it may be necessary to bypass
- the checksum protection. To do this, temporarily set the configuration
- parameter <xref linkend="guc-ignore-checksum-failure" />.
+ When attempting to recover from page corruptions, it may be necessary to
+ bypass the checksum protection. To do this, temporarily set the
+ configuration parameter <xref linkend="guc-ignore-checksum-failure" />.
</para>
<sect2 id="checksums-offline-enable-disable">
signature.asc
Description: PGP signature
