A bunch more found with things like this. find src -name '*.c' |xargs grep '^[[:space:]]*/\?\*' |grep -woE '[[:lower:]]{3,8}' |sed 's/.*/\L&/' | sort |uniq -c |sort -nr |awk '$1==1' |less
>From 9fd5e2797efc14f83bfb2d47d5174de81a34ac6e Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Thu, 4 Mar 2021 19:32:05 -0600 Subject: [PATCH 01/27] doc review: Add support for PROVE_TESTS and PROVE_FLAGS in MSVC scripts
5bca69a76b3046a85c60c48271c1831fd5affa51 --- doc/src/sgml/install-windows.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/install-windows.sgml b/doc/src/sgml/install-windows.sgml index 64687b12e6..cb6bb05dc5 100644 --- a/doc/src/sgml/install-windows.sgml +++ b/doc/src/sgml/install-windows.sgml @@ -499,8 +499,8 @@ $ENV{PERL5LIB}=$ENV{PERL5LIB} . ';c:\IPC-Run-0.94\lib'; <para> The TAP tests run with <command>vcregress</command> support the - environment variables <varname>PROVE_TESTS</varname>, that is expanded - automatically using the name patterns given, and + environment variables <varname>PROVE_TESTS</varname>, which is + expanded as a glob pattern, and <varname>PROVE_FLAGS</varname>. These can be set on a Windows terminal, before running <command>vcregress</command>: <programlisting> -- 2.17.0
>From 1392ef571f6afb62f5cd79db691a9c2d2255dde0 Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Tue, 23 Mar 2021 13:39:36 -0500 Subject: [PATCH 02/27] doc review: Pass all scan keys to BRIN consistent function at once commit a1c649d889bdf6e74e9382e1e28574d7071568de --- doc/src/sgml/brin.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/brin.sgml b/doc/src/sgml/brin.sgml index d2f12bb605..d2476481af 100644 --- a/doc/src/sgml/brin.sgml +++ b/doc/src/sgml/brin.sgml @@ -833,7 +833,7 @@ typedef struct BrinOpcInfo Returns whether all the ScanKey entries are consistent with the given indexed values for a range. The attribute number to use is passed as part of the scan key. - Multiple scan keys for the same attribute may be passed at once, the + Multiple scan keys for the same attribute may be passed at once; the number of entries is determined by the <literal>nkeys</literal> parameter. </para> </listitem> -- 2.17.0
>From 1323e85320a0e5414b490ef7f0082f3cca60864c Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Fri, 26 Mar 2021 23:14:57 -0500 Subject: [PATCH 03/27] doc review: BRIN minmax-multi indexes ab596105b55f1d7fbd5a66b66f65227d210b047d --- doc/src/sgml/brin.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/brin.sgml b/doc/src/sgml/brin.sgml index d2476481af..ce7c210575 100644 --- a/doc/src/sgml/brin.sgml +++ b/doc/src/sgml/brin.sgml @@ -730,7 +730,7 @@ LOG: request for BRIN range summarization for index "brin_wi_idx" page 128 was for <xref linkend="sql-altertable"/>. When set to a positive value, each block range is assumed to contain this number of distinct non-null values. When set to a negative value, which must be greater than or - equal to -1, the number of distinct non-null is assumed linear with + equal to -1, the number of distinct non-null values is assumed to grow linearly with the maximum possible number of tuples in the block range (about 290 rows per block). The default value is <literal>-0.1</literal>, and the minimum number of distinct non-null values is <literal>16</literal>. @@ -1214,7 +1214,7 @@ typedef struct BrinOpcInfo <para> The minmax-multi operator class is also intended for data types implementing - a totally ordered sets, and may be seen as a simple extension of the minmax + a totally ordered set, and may be seen as a simple extension of the minmax operator class. While minmax operator class summarizes values from each block range into a single contiguous interval, minmax-multi allows summarization into multiple smaller intervals to improve handling of outlier values. -- 2.17.0
>From dbf9f5cd9e2c0d7ee471c29b241ae8d5bc565fd6 Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Thu, 18 Feb 2021 10:13:15 -0600 Subject: [PATCH 04/27] doc review: VACUUM (PROCESS_TOAST) 7cb3048f38e26b39dd5fd412ed8a4981b6809b35 Michael had some comments here, but it seems to exactly match my existing language. https://www.postgresql.org/message-id/yddar29pdixpg...@paquier.xyz --- doc/src/sgml/ref/vacuum.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml index 6a0028a514..949ca23797 100644 --- a/doc/src/sgml/ref/vacuum.sgml +++ b/doc/src/sgml/ref/vacuum.sgml @@ -219,7 +219,7 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet corresponding <literal>TOAST</literal> table for each relation, if one exists. This is normally the desired behavior and is the default. Setting this option to false may be useful when it is only necessary to - vacuum the main relation. This option is required when the + vacuum the main relation. This option may not be disabled when the <literal>FULL</literal> option is used. </para> </listitem> -- 2.17.0
>From 0120fa422a89e1d87b3e29ec29f52c5c6379d7ae Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Fri, 2 Apr 2021 09:23:42 -0500 Subject: [PATCH 05/27] WIP: doc review: Add DECLARE STATEMENT command to ECPG declared ad8305a43d1890768a613d3fb586b44f17360f29 --- doc/src/sgml/ecpg.sgml | 16 ++++++++-------- src/backend/tsearch/spell.c | 2 +- src/interfaces/ecpg/preproc/ecpg.c | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/doc/src/sgml/ecpg.sgml b/doc/src/sgml/ecpg.sgml index 56f5d9b5db..8f2908823a 100644 --- a/doc/src/sgml/ecpg.sgml +++ b/doc/src/sgml/ecpg.sgml @@ -354,14 +354,14 @@ current=testdb1 (should be testdb1) </para> <para> - The third option is to declare sql identifier linked to + The third option is to declare a SQL identifier linked to the connection, for example: <programlisting> EXEC SQL AT <replaceable>connection-name</replaceable> DECLARE <replaceable>statement-name</replaceable> STATEMENT; EXEC SQL PREPARE <replaceable>statement-name</replaceable> FROM :<replaceable>dyn-string</replaceable>; </programlisting> - Once you link a sql identifier to a connection, you execute a dynamic SQL - without AT clause. Note that this option behaves like preprocessor directives, + Once you link a SQL identifier to a connection, you execute dynamic SQL + without an AT clause. Note that this option behaves like preprocessor directives, therefore the link is enabled only in the file. </para> <para> @@ -6911,14 +6911,14 @@ EXEC SQL [ AT <replaceable class="parameter">connection_name</replaceable> ] DEC <title>Description</title> <para> - <command>DECLARE STATEMENT</command> declares SQL statement identifier. + <command>DECLARE STATEMENT</command> declares a SQL statement identifier. SQL statement identifier can be associated with the connection. - When the identifier is used by dynamic SQL statements, these SQLs are executed - by using the associated connection. + When the identifier is used by dynamic SQL statements, the statements are executed + using the associated connection. The namespace of the declaration is the precompile unit, and multiple declarations to - the same SQL statement identifier is not allowed. + the same SQL statement identifier are not allowed. - Note that if the precompiler run in the Informix compatibility mode and some SQL statement + Note that if the precompiler runs in Informix compatibility mode and some SQL statement is declared, "database" can not be used as a cursor name. </para> </refsect1> diff --git a/src/backend/tsearch/spell.c b/src/backend/tsearch/spell.c index 68160bd592..ebc89604ac 100644 --- a/src/backend/tsearch/spell.c +++ b/src/backend/tsearch/spell.c @@ -2020,7 +2020,7 @@ NISortAffixes(IspellDict *Conf) (const unsigned char *) Affix->repl, (ptr - 1)->len)) { - /* leave only unique and minimals suffixes */ + /* leave only unique and minimal suffixes */ ptr->affix = Affix->repl; ptr->len = Affix->replen; ptr->issuffix = issuffix; diff --git a/src/interfaces/ecpg/preproc/ecpg.c b/src/interfaces/ecpg/preproc/ecpg.c index ee2fa51588..9d861b428b 100644 --- a/src/interfaces/ecpg/preproc/ecpg.c +++ b/src/interfaces/ecpg/preproc/ecpg.c @@ -375,7 +375,7 @@ main(int argc, char *const argv[]) } cur = NULL; - /* remove old delared statements if any are still there */ + /* remove old declared statements if any are still there */ for (list = g_declared_list; list != NULL;) { struct declared_list *this = list; -- 2.17.0
>From dc82ab33783e7ed62f0a013fdf3d19a7a2388775 Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Fri, 16 Apr 2021 01:44:53 -0500 Subject: [PATCH 06/27] BRIN minmax-multi indexes: between / procedures / deduplicate ab596105b55f1d7fbd5a66b66f65227d210b047d --- src/backend/access/brin/brin_minmax_multi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/backend/access/brin/brin_minmax_multi.c b/src/backend/access/brin/brin_minmax_multi.c index 4163abef3f..5e4b234cc6 100644 --- a/src/backend/access/brin/brin_minmax_multi.c +++ b/src/backend/access/brin/brin_minmax_multi.c @@ -248,7 +248,7 @@ typedef struct DistanceValue } DistanceValue; -/* Cache for support and strategy procesures. */ +/* Cache for support and strategy procedures. */ static FmgrInfo *minmax_multi_get_procinfo(BrinDesc *bdesc, uint16 attno, uint16 procnum); @@ -1311,7 +1311,7 @@ compare_distances(const void *a, const void *b) } /* - * Given an array of expanded ranges, compute distance of the gaps betwen + * Given an array of expanded ranges, compute distance of the gaps between * the ranges - for ncranges there are (ncranges-1) gaps. * * We simply call the "distance" function to compute the (max-min) for pairs @@ -1623,7 +1623,7 @@ ensure_free_space_in_buffer(BrinDesc *bdesc, Oid colloid, * * We don't simply check against range->maxvalues again. The deduplication * might have freed very little space (e.g. just one value), forcing us to - * do depuplication very often. In that case it's better to do compaction + * do deduplication very often. In that case it's better to do compaction * and reduce more space. */ if (2 * range->nranges + range->nvalues <= range->maxvalues * MINMAX_BUFFER_LOAD_FACTOR) -- 2.17.0
>From 35b85c2101211999016c06a32ca58851fc994476 Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Sat, 10 Apr 2021 20:56:35 -0500 Subject: [PATCH 07/27] reltuples not relpages: Set pg_class.reltuples for partitioned tables commit 0e69f705cc1a3df273b38c9883fb5765991e04fe Author: Alvaro Herrera <alvhe...@alvh.no-ip.org> Date: Fri Apr 9 11:29:08 2021 -0400 --- src/backend/commands/analyze.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/commands/analyze.c b/src/backend/commands/analyze.c index cffcd54302..8aa329a2a0 100644 --- a/src/backend/commands/analyze.c +++ b/src/backend/commands/analyze.c @@ -660,7 +660,7 @@ do_analyze_rel(Relation onerel, VacuumParams *params, { /* * Partitioned tables don't have storage, so we don't set any fields in - * their pg_class entries except for relpages, which is necessary for + * their pg_class entries except for reltuples, which is necessary for * auto-analyze to work properly. */ vac_update_relstats(onerel, -1, totalrows, -- 2.17.0
>From 76dd623a432ecc85464be9c57babd7b3b14f61e6 Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Mon, 12 Apr 2021 23:31:26 -0500 Subject: [PATCH 08/27] Multirange datatypes: preprending / multirange 6df7a9698bb036610c1e8c6d375e1be38cb26d5f --- src/backend/catalog/pg_type.c | 2 +- src/backend/utils/adt/multirangetypes.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/catalog/pg_type.c b/src/backend/catalog/pg_type.c index ec5d122432..d50db2314e 100644 --- a/src/backend/catalog/pg_type.c +++ b/src/backend/catalog/pg_type.c @@ -988,7 +988,7 @@ makeMultirangeTypeName(const char *rangeTypeName, Oid typeNamespace) * makeUniqueTypeName * Generate a unique name for a prospective new type * - * Given a typeName, return a new palloc'ed name by preprending underscores + * Given a typeName, return a new palloc'ed name by prepending underscores * until a non-conflicting name results. * * If tryOriginal, first try with zero underscores. diff --git a/src/backend/utils/adt/multirangetypes.c b/src/backend/utils/adt/multirangetypes.c index b3964ea27f..7ba6ff9860 100644 --- a/src/backend/utils/adt/multirangetypes.c +++ b/src/backend/utils/adt/multirangetypes.c @@ -553,7 +553,7 @@ multirange_get_typcache(FunctionCallInfo fcinfo, Oid mltrngtypid) /* - * Estimate size occupied by serialized multirage. + * Estimate size occupied by serialized multirange. */ static Size multirange_size_estimate(TypeCacheEntry *rangetyp, int32 range_count, -- 2.17.0
>From 699690989468e6d8e9239668689d0eba298d2c2d Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Thu, 8 Apr 2021 00:11:53 -0500 Subject: [PATCH 09/27] lock: Make use of in-core query id added by commit 5fd9dfa5f5 4f0b0966c866ae9f0e15d7cc73ccf7ce4e1af84b --- src/backend/utils/activity/backend_status.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/utils/activity/backend_status.c b/src/backend/utils/activity/backend_status.c index 6110113e56..5c1b2c25ed 100644 --- a/src/backend/utils/activity/backend_status.c +++ b/src/backend/utils/activity/backend_status.c @@ -1032,10 +1032,10 @@ pgstat_get_my_queryid(void) if (!MyBEEntry) return 0; - /* There's no need for a look around pgstat_begin_read_activity / + /* There's no need for a lock around pgstat_begin_read_activity / * pgstat_end_read_activity here as it's only called from * pg_stat_get_activity which is already protected, or from the same - * backend which mean that there won't be concurrent write. + * backend which means that there won't be concurrent writes. */ return MyBEEntry->st_queryid; } -- 2.17.0
>From cb9137b727d8bbee6223ba380680054b2b8a7623 Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Thu, 15 Apr 2021 23:21:34 -0500 Subject: [PATCH 10/27] the GlobalVisTest dc7420c2c9274a283779ec19718d2d16323640c0 --- src/backend/storage/ipc/procarray.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.c index bf776286de..5ff8cab394 100644 --- a/src/backend/storage/ipc/procarray.c +++ b/src/backend/storage/ipc/procarray.c @@ -2131,7 +2131,7 @@ GetSnapshotDataReuse(Snapshot snapshot) * older than this are known not running any more. * * And try to advance the bounds of GlobalVis{Shared,Catalog,Data,Temp}Rels - * for the benefit of theGlobalVisTest* family of functions. + * for the benefit of the GlobalVisTest* family of functions. * * Note: this function should probably not be called with an argument that's * not statically allocated (see xip allocation below). -- 2.17.0
>From c893f5eb5a7640edb54c39901bdcb158e93ef6d8 Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Thu, 15 Apr 2021 23:27:06 -0500 Subject: [PATCH 11/27] rightmost 16fa9b2b30a357b4aea982bd878ec2e5e002dbcc --- src/backend/access/gist/gistbuild.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/access/gist/gistbuild.c b/src/backend/access/gist/gistbuild.c index 1054f6f1f2..90ebd41833 100644 --- a/src/backend/access/gist/gistbuild.c +++ b/src/backend/access/gist/gistbuild.c @@ -115,7 +115,7 @@ typedef struct /* * In sorted build, we use a stack of these structs, one for each level, - * to hold an in-memory buffer of the righmost page at the level. When the + * to hold an in-memory buffer of the rightmost page at the level. When the * page fills up, it is written out and a new page is allocated. */ typedef struct GistSortedBuildPageState -- 2.17.0
>From c0f8d94574a18f0556d8d57c3b760d73eb90ccfa Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Thu, 15 Apr 2021 23:30:08 -0500 Subject: [PATCH 12/27] reader 323cbe7c7ddcf18aaf24b7f6d682a45a61d4e31b --- src/bin/pg_waldump/pg_waldump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/pg_waldump/pg_waldump.c b/src/bin/pg_waldump/pg_waldump.c index d4d6bb25a9..4ec273e6d2 100644 --- a/src/bin/pg_waldump/pg_waldump.c +++ b/src/bin/pg_waldump/pg_waldump.c @@ -323,7 +323,7 @@ WALDumpCloseSegment(XLogReaderState *state) } /* - * pg_waldump's WAL page rader + * pg_waldump's WAL page reader * * timeline and startptr specifies the LSN, and reads up to endptr. */ -- 2.17.0
>From 040e398e26443af06acc94c33988bbbf02f96c15 Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Thu, 15 Apr 2021 23:32:22 -0500 Subject: [PATCH 13/27] performed 9c4f5192f69ed16c99e0d079f0b5faebd7bad212 --- src/bin/pg_rewind/pg_rewind.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/pg_rewind/pg_rewind.c b/src/bin/pg_rewind/pg_rewind.c index 9df08ab2b0..38e5d23755 100644 --- a/src/bin/pg_rewind/pg_rewind.c +++ b/src/bin/pg_rewind/pg_rewind.c @@ -605,7 +605,7 @@ perform_rewind(filemap_t *filemap, rewind_source *source, * and the target. But if the source is a standby server, it's possible * that the last common checkpoint is *after* the standby's restartpoint. * That implies that the source server has applied the checkpoint record, - * but hasn't perfomed a corresponding restartpoint yet. Make sure we + * but hasn't performed a corresponding restartpoint yet. Make sure we * start at the restartpoint's redo point in that case. * * Use the old version of the source's control file for this. The server -- 2.17.0
>From d06a1bf34f820674ae04a47ccaa5360921796f0d Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Thu, 15 Apr 2021 23:35:08 -0500 Subject: [PATCH 14/27] oriented / updatable d168b666823b6e0bcf60ed19ce24fb5fb91b8ccf --- doc/src/sgml/config.sgml | 7 ++++--- src/backend/access/nbtree/nbtpage.c | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index 776ab1a8c8..46e5d29385 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -8241,8 +8241,9 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv; This parameter specifies the default table access method to use when creating tables or materialized views if the <command>CREATE</command> command does not explicitly specify an access method, or when - <command>SELECT ... INTO</command> is used, which does not allow to - specify a table access method. The default is <literal>heap</literal>. + <command>SELECT ... INTO</command> is used, which does not allow + specification of a table access method. + The default is <literal>heap</literal>. </para> </listitem> </varlistentry> @@ -8273,7 +8274,7 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv; </para> <para> - This variable is not used for temporary tables; for them, + This variable is not used for temporary tables, for which <xref linkend="guc-temp-tablespaces"/> is consulted instead. </para> diff --git a/src/backend/access/nbtree/nbtpage.c b/src/backend/access/nbtree/nbtpage.c index ef48679cc2..706e16ae94 100644 --- a/src/backend/access/nbtree/nbtpage.c +++ b/src/backend/access/nbtree/nbtpage.c @@ -1398,7 +1398,7 @@ _bt_delitems_delete(Relation rel, Buffer buf, TransactionId latestRemovedXid, * _bt_delitems_delete. These steps must take place before each function's * critical section begins. * - * updatabable and nupdatable are inputs, though note that we will use + * updatable and nupdatable are inputs, though note that we will use * _bt_update_posting() to replace the original itup with a pointer to a final * version in palloc()'d memory. Caller should free the tuples when its done. * @@ -1504,7 +1504,7 @@ _bt_delitems_cmp(const void *a, const void *b) * some extra index tuples that were practically free for tableam to check in * passing (when they actually turn out to be safe to delete). It probably * only makes sense for the tableam to go ahead with these extra checks when - * it is block-orientated (otherwise the checks probably won't be practically + * it is block-oriented (otherwise the checks probably won't be practically * free, which we rely on). The tableam interface requires the tableam side * to handle the problem, though, so this is okay (we as an index AM are free * to make the simplifying assumption that all tableams must be block-based). -- 2.17.0
>From ae655cb6743bad086326df1c9fde355f74c56112 Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Thu, 15 Apr 2021 23:37:52 -0500 Subject: [PATCH 15/27] necessary e6bdfd9700ebfc7df811c97c2fc46d7e94e329a2 --- src/common/hmac_openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/hmac_openssl.c b/src/common/hmac_openssl.c index b5e3065d1a..5df06839e0 100644 --- a/src/common/hmac_openssl.c +++ b/src/common/hmac_openssl.c @@ -34,7 +34,7 @@ /* * In backend, use an allocation in TopMemoryContext to count for resowner - * cleanup handling if necesary. For versions of OpenSSL where HMAC_CTX is + * cleanup handling if necessary. For versions of OpenSSL where HMAC_CTX is * known, just use palloc(). In frontend, use malloc to be able to return * a failure status back to the caller. */ -- 2.17.0
>From 69e607926e9b93af78c5dcc4ff4366d78403b632 Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Thu, 15 Apr 2021 23:39:01 -0500 Subject: [PATCH 16/27] minmax 77b88cd1bb9041a735f24072150cacfa06c699a3 --- src/backend/access/brin/brin_bloom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/access/brin/brin_bloom.c b/src/backend/access/brin/brin_bloom.c index 2214fb4d0c..e83c2b82e1 100644 --- a/src/backend/access/brin/brin_bloom.c +++ b/src/backend/access/brin/brin_bloom.c @@ -409,7 +409,7 @@ typedef struct BloomOpaque { /* * XXX At this point we only need a single proc (to compute the hash), but - * let's keep the array just like inclusion and minman opclasses, for + * let's keep the array just like inclusion and minmax opclasses, for * consistency. We may need additional procs in the future. */ FmgrInfo extra_procinfos[BLOOM_MAX_PROCNUMS]; -- 2.17.0
>From bfee5f3ae5422e5742bb04055c220ca8e3e48663 Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Thu, 15 Apr 2021 23:28:37 -0500 Subject: [PATCH 17/27] reference / matching a4d75c86bf15220df22de0a92c819ecef9db3849 --- src/backend/statistics/dependencies.c | 2 +- src/backend/utils/adt/selfuncs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/statistics/dependencies.c b/src/backend/statistics/dependencies.c index cf8a6d5f68..cfe02b0cbe 100644 --- a/src/backend/statistics/dependencies.c +++ b/src/backend/statistics/dependencies.c @@ -1450,7 +1450,7 @@ dependencies_clauselist_selectivity(PlannerInfo *root, if (!bms_is_member(listidx, *estimatedclauses)) { /* - * If it's a simple column refrence, just extract the attnum. If + * If it's a simple column reference, just extract the attnum. If * it's an expression, assign a negative attnum as if it was a * system attribute. */ diff --git a/src/backend/utils/adt/selfuncs.c b/src/backend/utils/adt/selfuncs.c index 0963e2701c..3d4304cce7 100644 --- a/src/backend/utils/adt/selfuncs.c +++ b/src/backend/utils/adt/selfuncs.c @@ -4039,7 +4039,7 @@ estimate_multivariate_ndistinct(PlannerInfo *root, RelOptInfo *rel, /* * Process a simple Var expression, by matching it to keys - * directly. If there's a matchine expression, we'll try + * directly. If there's a matching expression, we'll try * matching it later. */ if (IsA(varinfo->var, Var)) -- 2.17.0
>From d76ef5ff114f157c857f8e3256c0e0600fc9aad6 Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Thu, 15 Apr 2021 23:44:39 -0500 Subject: [PATCH 18/27] involves bfa2cee784125047771db2768fcf7f04d8bd6bb4 --- src/port/bsearch_arg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/port/bsearch_arg.c b/src/port/bsearch_arg.c index 0f1eaeba83..8849bdffd2 100644 --- a/src/port/bsearch_arg.c +++ b/src/port/bsearch_arg.c @@ -43,7 +43,7 @@ * is odd, moving left simply involves halving lim: e.g., when lim * is 5 we look at item 2, so we change lim to 2 so that we will * look at items 0 & 1. If lim is even, the same applies. If lim - * is odd, moving right again involes halving lim, this time moving + * is odd, moving right again involves halving lim, this time moving * the base up one item past p: e.g., when lim is 5 we change base * to item 3 and make lim 2 so that we will look at items 3 and 4. * If lim is even, however, we have to shrink it by one before -- 2.17.0
>From 00e52b6c317cfed74b87c2289f3277d78ad8a5d6 Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Thu, 15 Apr 2021 23:50:44 -0500 Subject: [PATCH 19/27] determine 72ccf55cb99c6450dfb77f2f8f4a28b5c049ef7a --- src/backend/access/brin/brin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c index c320e21508..35e0ffcfa5 100644 --- a/src/backend/access/brin/brin.c +++ b/src/backend/access/brin/brin.c @@ -596,7 +596,7 @@ bringetbitmap(IndexScanDesc scan, TIDBitmap *tbm) * and if we're violating them. In that case we can * terminate early, without invoking the support function. * - * As there may be more keys, we can only detemine + * As there may be more keys, we can only determine * mismatch within this loop. */ if (bdesc->bd_info[attno - 1]->oi_regular_nulls && -- 2.17.0
>From 7f20482fc8381a0be0d5b4958b3b5e9bae7350b3 Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Thu, 15 Apr 2021 23:53:40 -0500 Subject: [PATCH 20/27] conservative 3b6c1259f9ca8e21860aaf24ec6735a8e5598ea0 --- contrib/amcheck/verify_heapam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/amcheck/verify_heapam.c b/contrib/amcheck/verify_heapam.c index 9366f45d74..9f159eb3db 100644 --- a/contrib/amcheck/verify_heapam.c +++ b/contrib/amcheck/verify_heapam.c @@ -930,7 +930,7 @@ check_tuple_visibility(HeapCheckContext *ctx) * If xmin_status happens to be XID_IS_CURRENT_XID, then in theory * any such DDL changes ought to be visible to us, so perhaps * we could check anyway in that case. But, for now, let's be - * conservate and treat this like any other uncommitted insert. + * conservative and treat this like any other uncommitted insert. */ return false; } -- 2.17.0
>From 85df2b17a1bf02ae73ac9f749ca4412a554f9dec Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Thu, 15 Apr 2021 23:55:57 -0500 Subject: [PATCH 21/27] clause 3696a600e2292d43c00949ddf0352e4ebb487e5b --- src/backend/rewrite/rewriteSearchCycle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/rewrite/rewriteSearchCycle.c b/src/backend/rewrite/rewriteSearchCycle.c index 1a7d66fa6f..2d0ac378a8 100644 --- a/src/backend/rewrite/rewriteSearchCycle.c +++ b/src/backend/rewrite/rewriteSearchCycle.c @@ -59,7 +59,7 @@ * SQL standard actually does it in that more complicated way), but the * internal representation allows us to construct it this way.) * - * With a search caluse + * With a search clause * * SEARCH DEPTH FIRST BY col1, col2 SET sqc * -- 2.17.0
>From 68e8197df5e00b5619ec9884090d02eabec9f61d Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Thu, 15 Apr 2021 23:57:13 -0500 Subject: [PATCH 22/27] attribute a681e3c107aa97eb554f118935c4d2278892c3dd --- src/backend/access/brin/brin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c index 35e0ffcfa5..c23ea44866 100644 --- a/src/backend/access/brin/brin.c +++ b/src/backend/access/brin/brin.c @@ -636,7 +636,7 @@ bringetbitmap(IndexScanDesc scan, TIDBitmap *tbm) /* * Collation from the first key (has to be the same for - * all keys for the same attribue). + * all keys for the same attribute). */ collation = keys[attno - 1][0]->sk_collation; -- 2.17.0
>From 0e5fcfd1a2a76eee61d380414e2039821ba00fce Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Fri, 16 Apr 2021 00:13:28 -0500 Subject: [PATCH 23/27] thinest 7854e07f25be3a3dfa9c94011a30767eca3c10ba and ec498cdcbb7e7b430acc7236ab19ef70f116441a --- src/backend/access/index/genam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/access/index/genam.c b/src/backend/access/index/genam.c index 1c3e937c61..0aa26b448b 100644 --- a/src/backend/access/index/genam.c +++ b/src/backend/access/index/genam.c @@ -633,7 +633,7 @@ systable_endscan(SysScanDesc sysscan) * Currently we do not support non-index-based scans here. (In principle * we could do a heapscan and sort, but the uses are in places that * probably don't need to still work with corrupted catalog indexes.) - * For the moment, therefore, these functions are merely the thinnest of + * For the moment, therefore, these functions are merely the thinest of * wrappers around index_beginscan/index_getnext_slot. The main reason for * their existence is to centralize possible future support of lossy operators * in catalog scans. -- 2.17.0
>From d5d45ba3094ca77e27c05dd65feb4bee20a5d932 Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Fri, 16 Apr 2021 00:23:32 -0500 Subject: [PATCH 24/27] selectivity 87779aa47463d0fb3b4743a7d5c9534994bf7c98 --- src/backend/statistics/dependencies.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/statistics/dependencies.c b/src/backend/statistics/dependencies.c index cfe02b0cbe..ba7decb6a4 100644 --- a/src/backend/statistics/dependencies.c +++ b/src/backend/statistics/dependencies.c @@ -972,7 +972,7 @@ find_strongest_dependency(MVDependencies **dependencies, int ndependencies, /* * clauselist_apply_dependencies * Apply the specified functional dependencies to a list of clauses and - * return the estimated selecvitity of the clauses that are compatible + * return the estimated selectivity of the clauses that are compatible * with any of the given dependencies. * * This will estimate all not-already-estimated clauses that are compatible -- 2.17.0
>From 95fa0242906f39467d656ea1a02e4cd3ea50cead Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Fri, 16 Apr 2021 00:14:30 -0500 Subject: [PATCH 25/27] then / remain / pivot d2d8a229bc58a2014dce1c7a4fcdb6c5ab9fb8da --- src/backend/executor/nodeIncrementalSort.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/backend/executor/nodeIncrementalSort.c b/src/backend/executor/nodeIncrementalSort.c index 459c879f0b..18f246a823 100644 --- a/src/backend/executor/nodeIncrementalSort.c +++ b/src/backend/executor/nodeIncrementalSort.c @@ -661,9 +661,9 @@ ExecIncrementalSort(PlanState *pstate) /* * We're in full sort mode accumulating a minimum number of tuples * and not checking for prefix key equality yet, so we can't - * assume the group pivot tuple will reamin the same -- unless + * assume the group pivot tuple will remain the same -- unless * we're using a minimum group size of 1, in which case the pivot - * is obviously still the pviot. + * is obviously still the pivot. */ if (nTuples != minGroupSize) ExecClearTuple(node->group_pivot); @@ -1162,7 +1162,7 @@ ExecReScanIncrementalSort(IncrementalSortState *node) } /* - * If chgParam of subnode is not null, theni the plan will be re-scanned + * If chgParam of subnode is not null, then the plan will be re-scanned * by the first ExecProcNode. */ if (outerPlan->chgParam == NULL) -- 2.17.0
>From 8bba22bba90634f0d514f22755cdfde71195a65f Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Fri, 16 Apr 2021 01:30:36 -0500 Subject: [PATCH 26/27] maximum d06215d03b50c264a0f31e335b895ee1b6753e68 --- src/backend/statistics/extended_stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/statistics/extended_stats.c b/src/backend/statistics/extended_stats.c index e54e8aa8e0..7e11cb9d5f 100644 --- a/src/backend/statistics/extended_stats.c +++ b/src/backend/statistics/extended_stats.c @@ -358,7 +358,7 @@ statext_compute_stattarget(int stattarget, int nattrs, VacAttrStats **stats) */ for (i = 0; i < nattrs; i++) { - /* keep the maximmum statistics target */ + /* keep the maximum statistics target */ if (stats[i]->attr->attstattarget > stattarget) stattarget = stats[i]->attr->attstattarget; } -- 2.17.0
>From 4a9acadbeb44cb71fcf4986c576709e82a6c6c33 Mon Sep 17 00:00:00 2001 From: Justin Pryzby <pryz...@telsasoft.com> Date: Fri, 16 Apr 2021 01:36:34 -0500 Subject: [PATCH 27/27] further b027ad9a7a95fb14b62b73b507d1a8c7d6f5e940 --- src/common/pg_lzcompress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/pg_lzcompress.c b/src/common/pg_lzcompress.c index fdd527f757..a30a2c2eb8 100644 --- a/src/common/pg_lzcompress.c +++ b/src/common/pg_lzcompress.c @@ -147,7 +147,7 @@ * * For each subsequent entry in the history list, the "good_match" * is lowered by 10%. So the compressor will be more happy with - * short matches the farer it has to go back in the history. + * short matches the further it has to go back in the history. * Another "speed against ratio" preference characteristic of * the algorithm. * -- 2.17.0