On Wed, Feb 19, 2025 at 03:40:56PM +0800, Zhang Mingli wrote:
> Thanks for the correction.
No problem. If you see anything else that you think is misleading,
please feel free to ping me on this thread.
--
Michael
signature.asc
Description: PGP signature
On Feb 19, 2025 at 14:53 +0800, Michael Paquier , wrote:
> There was a hole in the tests for the option LIKE_STORAGE. Removing
> the check for it in transformTableLikeClause() did now show a diff in
> the tests. In the case of foreign tables, extended for storage is a
> correct choice when using a
On Tue, Feb 18, 2025 at 08:43:02PM +0800, Zhang Mingli wrote:
> On Feb 18, 2025 at 09:54 +0800, Zhang Mingli , wrote:
> >
> > Will address the comments later, thanks for review!
>
> Done in patch v6.
There was a hole in the tests for the option LIKE_STORAGE. Removing
the check for it in transfo
On Feb 18, 2025 at 09:54 +0800, Zhang Mingli , wrote:
>
> Will address the comments later, thanks for review!
Done in patch v6.
--
Zhang Mingli
HashData
v6-0001-CREATE-FOREIGN-TABLE-LIKE.patch
Description: Binary data
On Feb 18, 2025 at 09:54 +0800, Zhang Mingli , wrote:
>
> Will address the comments later, thanks for review!
Done in patch v6.
--
Zhang Mingli
HashData
v6-0001-CREATE-FOREIGN-TABLE-LIKE.patch
Description: Binary data
On Feb 18, 2025 at 08:49 +0800, Michael Paquier , wrote:
> On Mon, Feb 17, 2025 at 07:14:59PM +0800, Zhang Mingli wrote:
> > On Feb 17, 2025 at 15:24 +0800, Michael Paquier ,
> > wrote:
> > > + * For foreign tables, they have no storage in Postgres.
> > > + * Inapplicable options are ignored.
> >
On Mon, Feb 17, 2025 at 07:14:59PM +0800, Zhang Mingli wrote:
> On Feb 17, 2025 at 15:24 +0800, Michael Paquier , wrote:
>> + * For foreign tables, they have no storage in Postgres.
>> + * Inapplicable options are ignored.
>>
>> Wording is a bit strange here.
>
> * Foreign tables do not store dat
On Feb 17, 2025 at 15:24 +0800, Michael Paquier , wrote:
>
> + * For foreign tables, they have no storage in Postgres.
> + * Inapplicable options are ignored.
>
> Wording is a bit strange here.
Hi, is this better?
* Foreign tables do not store data in Postgres.
* Any options that are not applic
On Tue, Feb 11, 2025 at 10:07:48AM -0600, Sami Imseih wrote:
> I agree. I was just saying the test cases you provided are
> enough. No changes needed for the tests.
>
> I have no further comments.
The checks you are adding in the parse analysis of the LIKE clauses is
surprisingly light.
+ * For
> + Foreign tables have no real storage in PostgreSQL.
> + Inapplicable options: INCLUDING INDEXES,
> INCLUDING STORAGE,
>
> Oh, I corrected another one in the code comments, but I forgot about this one.
> Done in patch v3.
I attached v4 with some slight modifications to the wording, otherwise
thi
On Feb 11, 2025 at 08:14 +0800, Sami Imseih , wrote:
> > Patch V2 addressed the comments.
> >
> > Overall this LGTM.
> >
> > I still see a "no real storage" in v2 that should be removed
> > from the documentation.
> >
> > + Foreign tables have no real storage in PostgreSQL.
> > + Inapplicable optio
> Patch V2 addressed the comments.
Overall this LGTM.
I still see a "no real storage" in v2 that should be removed
from the documentation.
+ Foreign tables have no real storage in PostgreSQL.
+ Inapplicable options: INCLUDING INDEXES,
INCLUDING STORAGE,
I think the test coverage to check for th
On Feb 8, 2025 at 12:55 +0800, Sami Imseih , wrote:
> > Fix CI failure of doc build in v1 patch.
> >
> > Thanks for the patch! I am +1 for this, but I have a few comments:
Hi, tanks for review.
> >
> > 1/ In the IDENTITY case, the remote side may not be
> > able to handle the DEFAULT value.
Yes, an
> Fix CI failure of doc build in v1 patch.
Thanks for the patch! I am +1 for this, but I have a few comments:
1/ In the IDENTITY case, the remote side may not be
able to handle the DEFAULT value. See the example below:
-- on the foreign server
postgres=# CREATE TABLE t2 (id int, c1 text);
CREATE
On Feb 7, 2025 at 22:24 +0800, Zhang Mingli , wrote:
> On Feb 6, 2025 at 18:09 +0800, Zhang Mingli , wrote:
> > On Feb 3, 2025 at 08:29 +0800, Michael Paquier , wrote:
> > > On Mon, Feb 03, 2025 at 06:22:13AM +0800, Mingli Zhang wrote:
> > > > Yes, I would like to provide a patch.
> > > >
> > > > G
On Feb 6, 2025 at 18:09 +0800, Zhang Mingli , wrote:
> On Feb 3, 2025 at 08:29 +0800, Michael Paquier , wrote:
> > On Mon, Feb 03, 2025 at 06:22:13AM +0800, Mingli Zhang wrote:
> > > Yes, I would like to provide a patch.
> > >
> > > Glad to see we have come to an agreement on this.
> >
> > Just add
On Feb 6, 2025 at 18:31 +0800, Álvaro Herrera , wrote:
>
> Ah, but our fine manual already says
>
> The LIKE clause can also be used to copy column definitions from views,
> foreign tables, or composite types. Inapplicable options (e.g.,
> INCLUDING INDEXES from a view) are ignored.
>
> so what you
On 2025-Feb-06, Álvaro Herrera wrote:
> On 2025-Feb-06, Zhang Mingli wrote:
>
> > Added support for CREATE FOREIGN TABLE LIKE to enable the creation of
> > foreign tables based on the column definitions, constraints of
> > existing source tables.
> > This feature mirrors the behavior of CREATE TA
On 2025-Feb-06, Zhang Mingli wrote:
> Added support for CREATE FOREIGN TABLE LIKE to enable the creation of
> foreign tables based on the column definitions, constraints of
> existing source tables.
> This feature mirrors the behavior of CREATE TABLE LIKE, but ignores
> inapplicable options such a
On Feb 3, 2025 at 08:29 +0800, Michael Paquier , wrote:
> On Mon, Feb 03, 2025 at 06:22:13AM +0800, Mingli Zhang wrote:
> > Yes, I would like to provide a patch.
> >
> > Glad to see we have come to an agreement on this.
>
> Just adding my +1 here. FWIW.
Hi,
Patch added.
Added support for CREATE F
On Mon, Feb 03, 2025 at 06:22:13AM +0800, Mingli Zhang wrote:
> Yes, I would like to provide a patch.
>
> Glad to see we have come to an agreement on this.
Just adding my +1 here. FWIW.
--
Michael
signature.asc
Description: PGP signature
Zhang Mingli
www.hashdata.xyz
On Feb 2, 2025 at 21:24 +0800, Álvaro Herrera ,
wrote:
Eh yeah, I guess for this use case it makes sense to allow a LIKE clause
on CREATE FOREIGN TABLE. Were you going to submit a patch?
Hi,
Yes, I would like to provide a patch.
Glad to see we have come to an agre
On 2025-Feb-01, Zhang Mingli wrote:
> For example, we use kafka_fdw to produce and consume data from a Kafka
> server. In our scenario, we sometimes need to write records from a
> local table into Kafka. Here’s a brief outline of our process:
>
> 1. We already have a wide table, local_wide_table
Zhang Mingli
www.hashdata.xyz
On Feb 1, 2025 at 20:20 +0800, Álvaro Herrera , wrote:
>
> Sure. Did you consider IMPORT FOREIGN SCHEMA?
Hi, Álvaro
Thank you very much for your suggestion.
I've looked into it, and it certainly can be beneficial, especially for
postgres_fdw.
However, I believe th
On 2025-Feb-01, Zhang Mingli wrote:
> Our DBA team uses foreign tables for ETL processes in Greenplum and
> Cloudberry,
> and we often need to create foreign tables that match the column definitions
> of local tables.
>
> When dealing with wide tables and lots of those foreign tables, it can ge
25 matches
Mail list logo
