On Tue, Feb 11, 2025 at 10:07:48AM -0600, Sami Imseih wrote: > I agree. I was just saying the test cases you provided are > enough. No changes needed for the tests. > > I have no further comments.
The checks you are adding in the parse analysis of the LIKE clauses is surprisingly light. + * For foreign tables, they have no storage in Postgres. + * Inapplicable options are ignored. Wording is a bit strange here. + * CREATE_TABLE_LIKE_COMPRESSION + * CREATE_TABLE_LIKE_IDENTITY + * CREATE_TABLE_LIKE_STORAGE + * CREATE_TABLE_LIKE_INDEXES [...] +DROP FOREIGN TABLE ctl_foreign_table1; +DROP FOREIGN TABLE ctl_foreign_table2; +DROP FOREIGN TABLE ctl_foreign_table3; +DROP FOREIGN TABLE ctl_foreign_table4; +DROP FOREIGN TABLE ctl_foreign_table5; +DROP FOREIGN TABLE ctl_foreign_table6; What's the point of creating that many tables, one for each of the four INCLUDING options you are testing? It is possible to stack all of them in a single CREATE TABLE command, still is that really necessary if we have coverage with INCLUDING ALL and EXCLUDING ALL (perhaps write it directly in the CREATE query rather than assume that it is the default) as these are all-or-nothing switches for all the option values. Of course let's be careful with HIDE_TOAST_COMPRESSION if need be. Perhaps the original table should have a primary key, also to track the fact that the NOT NULL constraint is always copied but its related index is not? Identity columns assign a NOT NULL constraint, as documented these are always copied. Just wanted to point out that this works the same way for your implementation with foreign tables, so perhaps we should have a test for that. Glad to see that you did not forget about statistics. I didn't recall that these were OK for foreign tables, TBH. expandTableLikeClause() depends on the "constr" built in the first phase of transformTableLikeClause() to bypass the parts related to generated, default and constraints properties. This dependency between both routines should be documented, I guess. Hmm.. Not sure where. -- Michael
signature.asc
Description: PGP signature
