> + Foreign tables have no real storage in PostgreSQL. > + Inapplicable options: <literal>INCLUDING INDEXES</literal>, > <literal>INCLUDING STORAGE</literal>, > > Oh, I corrected another one in the code comments, but I forgot about this one. > Done in patch v3.
I attached v4 with some slight modifications to the wording, otherwise this looks good. >> I think the test coverage to check for the negative conditions only is >> enough. >> >> > Hmm... I copied from the cases in the same file for each option. > There's no harm in having more tests, how about we keep them? I agree. I was just saying the test cases you provided are enough. No changes needed for the tests. I have no further comments. Regards, Sami
v4-0001-CREATE-FOREIGN-TABLE-LIKE.patch
Description: Binary data
