On Feb 11, 2025 at 08:14 +0800, Sami Imseih <samims...@gmail.com>, wrote: > > Patch V2 addressed the comments. > > > > Overall this LGTM. > > > > I still see a "no real storage" in v2 that should be removed > > from the documentation. > > > > + Foreign tables have no real storage in PostgreSQL. > > + Inapplicable options: <literal>INCLUDING INDEXES</literal>, > > <literal>INCLUDING STORAGE</literal>, Oh, I corrected another one in the code comments, but I forgot about this one. Done in patch v3. > > > I think the test coverage to check for the negative conditions only is > enough.
Hmm... I copied from the cases in the same file for each option. There's no harm in having more tests, how about we keep them? -- Zhang Mingli HashData
v3-0001-CREATE-FOREIGN-TABLE-LIKE.patch
Description: Binary data
