Re: Command statistics system (cmdstats)

2021-05-28 Thread Mark Dilger
> On May 28, 2021, at 6:42 AM, Alvaro Herrera wrote: > On Mar 4, 2020, at 7:43 PM, Mark Dilger wrote: > as mentioned in [1], I have created an implementation of command counter statistics very similar in purpose to the one already pending in the commitfest going by

Re: Command statistics system (cmdstats)

2021-05-28 Thread Alvaro Herrera
> >> On Mar 4, 2020, at 7:43 PM, Mark Dilger > >> wrote: > >> as mentioned in [1], I have created an implementation of command > >> counter statistics very similar in purpose to the one already > >> pending in the commitfest going by the name "pg_stat_sql". I don't > >> really care if this impl

Re: Command statistics system (cmdstats)

2020-09-22 Thread Michael Paquier
On Wed, Sep 23, 2020 at 10:41:10AM +0900, Michael Paquier wrote: > I think that this remark is a bit unfair. When it comes to any patch > in the commit fest, and I have managed a couple of them over the > years, I have tried to keep a neutral view for all of them, meaning > that I only let the num

Re: Command statistics system (cmdstats)

2020-09-22 Thread Michael Paquier
On Mon, Sep 21, 2020 at 10:41:46AM -0300, Alvaro Herrera wrote: > "A couple of weeks" of inactivity is not sufficient, in my view, to boot > a patch out of the commitfest process. Whenever the patch is > resurrected, it will be a new entry which won't have the history that it > had accumulated in

Re: Command statistics system (cmdstats)

2020-09-21 Thread Robert Haas
On Mon, Sep 21, 2020 at 9:41 AM Alvaro Herrera wrote: > "A couple of weeks" of inactivity is not sufficient, in my view, to boot > a patch out of the commitfest process. Whenever the patch is > resurrected, it will be a new entry which won't have the history that it > had accumulated in the long

Re: Command statistics system (cmdstats)

2020-09-21 Thread Alvaro Herrera
On 2020-Sep-18, Michael Paquier wrote: > Based on the low level of activity and the fact that the patch was > marked as waiting on author for a couple of weeks, it looks like > little could be achieved by the end of the CF, and the attention was > elsewhere, so it looked better (and it still does

Re: Command statistics system (cmdstats)

2020-09-17 Thread Michael Paquier
On Thu, Sep 17, 2020 at 08:03:55AM -0700, Mark Dilger wrote: > Yes, I have prioritized a couple other patches over this one, with > benchmarking this patch lower down my priority list. Thank you, > Michael, for the reminder! Based on the low level of activity and the fact that the patch was marke

Re: Command statistics system (cmdstats)

2020-09-17 Thread Mark Dilger
> On Sep 17, 2020, at 5:40 AM, Alvaro Herrera wrote: > > On 2020-Sep-17, Michael Paquier wrote: > >> On Wed, Jun 10, 2020 at 01:45:02PM -0400, Robert Haas wrote: >>> My spidey sense is tingling here, telling me that we need some actual >>> benchmarking. >> >> This patch has not received any

Re: Command statistics system (cmdstats)

2020-09-17 Thread Alvaro Herrera
On 2020-Sep-17, Michael Paquier wrote: > On Wed, Jun 10, 2020 at 01:45:02PM -0400, Robert Haas wrote: > > My spidey sense is tingling here, telling me that we need some actual > > benchmarking. > > This patch has not received any replies after this comment for three > months, so I am marking it a

Re: Command statistics system (cmdstats)

2020-09-16 Thread Michael Paquier
On Wed, Jun 10, 2020 at 01:45:02PM -0400, Robert Haas wrote: > My spidey sense is tingling here, telling me that we need some actual > benchmarking. Like, suppose we test the two patches under normal cases > and under cases that are constructed to be as bad as possible for each > of them. Or suppos

Re: Command statistics system (cmdstats)

2020-06-10 Thread Robert Haas
On Wed, Mar 4, 2020 at 10:43 PM Mark Dilger wrote: > The two main differences are that > > (1) This implementation is based on commandtags as enums, not strings and > (2) This implementation uses techniques to reduce lock contention > > I think (2) is the more important part. My spidey sense is t

Re: Command statistics system (cmdstats)

2020-06-02 Thread Mark Dilger
> On Jun 2, 2020, at 9:58 AM, Mark Dilger wrote: > >> >> On Mar 4, 2020, at 7:43 PM, Mark Dilger wrote: >> >> Hackers, >> >> as mentioned in [1], I have created an implementation of command counter >> statistics very similar in purpose to the one already pending in the >> commitfest going

Re: Command statistics system (cmdstats)

2020-06-02 Thread Mark Dilger
> On Mar 4, 2020, at 7:43 PM, Mark Dilger wrote: > > Hackers, > > as mentioned in [1], I have created an implementation of command counter > statistics very similar in purpose to the one already pending in the > commitfest going by the name "pg_stat_sql". I don't really care if this > imple

Command statistics system (cmdstats)

2020-03-04 Thread Mark Dilger
Hackers, as mentioned in [1], I have created an implementation of command counter statistics very similar in purpose to the one already pending in the commitfest going by the name "pg_stat_sql". I don't really care if this implementation is seen as building on that one or as separate, but I wa