On Sat, 6 Dec 2025 at 20:36, Dilip Kumar wrote:
>
> On Fri, Dec 5, 2025 at 10:39 AM Dilip Kumar wrote:
> >
> > On Thu, Dec 4, 2025 at 8:05 PM vignesh C wrote:
> > >
> > > On Wed, 3 Dec 2025 at 16:57, Dilip Kumar wrote:
> > > >
> > > >
On Wed, 3 Dec 2025 at 16:57, Dilip Kumar wrote:
>
> On Wed, Dec 3, 2025 at 9:49 AM shveta malik wrote:
> > >
> > > relid | 16391
> > > schemaname| public
> > > relname | conf_tab
> > > conflict_type | multiple_unique_conflicts
> > > remote_xid| 761
> > >
On Wed, 3 Dec 2025 at 16:57, Dilip Kumar wrote:
>
> On Wed, Dec 3, 2025 at 9:49 AM shveta malik wrote:
> > >
> > > relid | 16391
> > > schemaname| public
> > > relname | conf_tab
> > > conflict_type | multiple_unique_conflicts
> > > remote_xid| 761
> > >
On Thu, 4 Dec 2025 at 07:47, Peter Smith wrote:
>
> On Wed, Dec 3, 2025 at 4:47 PM tianbing wrote:
> >
> > Hi， Peter，
> > I have reviewed the v21 patch and noticed that there seems to be a memory
> > leak.
> >
> > +static bool
> > +check_publication_exists(PGconn *conn, const char *pubname, cons
Hi,
While reviewing another patch, I noticed that START_REPLICATION fails
to parse publication names that contain backslash characters (e.g. \0,
\n), even though such names are perfectly valid when used with CREATE
PUBLICATION. This can be reproduced with the following:
CREATE PUBLICATION "regress
On Mon, 1 Dec 2025 at 12:33, Masahiko Sawada wrote:
>
> On Mon, Dec 1, 2025 at 12:20 AM Masahiko Sawada wrote:
>
> I've attached the patch. All the comments I got so far have been
> addressed in this version unless I'm missing something.
Few comments:
1) We have an invalidation test at 044_inval
On Fri, 28 Nov 2025 at 09:29, Peter Smith wrote:
>
> I noticed that recently, a shadow warning has crept into the code I am
> building.
>
> --
> subscriptioncmds.c:1125:30: warning: declaration of ‘rel’ shadows a
> previous local [-Wshadow]
>foreach_ptr(SubRemoveRels, rel, sub_remove_
On Thu, 27 Nov 2025 at 17:50, Dilip Kumar wrote:
>
> On Thu, Nov 27, 2025 at 6:30 AM Peter Smith wrote:
>
> I have fixed all these comments and also the comments of 0002, now I
> feel we can actually merge 0001 and 0002, so I have merged both of
> them.
I just started to have a look at the patch
On Thu, 6 Nov 2025 at 09:35, Shubham Khanna wrote:
>
> On Thu, Nov 6, 2025 at 7:18 AM Peter Smith wrote:
> >
> > On Wed, Nov 5, 2025 at 3:42 PM Shubham Khanna
> > wrote:
> > >
> > > On Mon, Nov 3, 2025 at 12:55 PM Peter Smith wrote:
> > > >
> > > > Hi Shubham.
> > > >
> > > > A comment about th
On Thu, 27 Nov 2025 at 02:32, Masahiko Sawada wrote:
>
> On Wed, Nov 26, 2025 at 3:47 AM Amit Kapila wrote:
> >
> > On Wed, Nov 26, 2025 at 10:31 AM Amit Kapila
> > wrote:
> > >
> > > On Wed, Nov 26, 2025 at 5:59 AM Masahiko Sawada
> > > wrote:
> > > >
> > > >
> > > > After thinking of this c
On Thu, 13 Nov 2025 at 09:12, Amit Kapila wrote:
>
> On Thu, Nov 13, 2025 at 4:31 AM Peter Smith wrote:
> >
> > CURRENT
> > seq_sync_error_count
> > sync_error_count
> >
> > MY SUGGESTION
> > sync_seq_error_count
> > sync_table_error_count
> >
>
> +1. Along with consistency with other column name
Hi,
This patch proposes renaming a column in the view
pg_stat_subscription_stats to disambiguate between table sync and
sequence sync error counts. With the introduction of
seq_sync_error_count, the existing column name sync_error_count
becomes ambiguous, it's unclear whether it refers to tables,
On Tue, 11 Nov 2025 at 11:23, Chao Li wrote:
>
> Hi Vignesh,
>
> A few more comments:
>
> > On Nov 7, 2025, at 22:47, vignesh C wrote:
> >
> > The attached v20251107_2 version patch has the changes for the same.
> >
> > Regards,
> > Vignesh
On Tue, 11 Nov 2025 at 09:59, Shlok Kyal wrote:
>
> On Tue, 11 Nov 2025 at 09:02, Amit Kapila wrote:
> >
> > On Mon, Nov 10, 2025 at 4:22 PM vignesh C wrote:
> > >
> > > On Mon, 10 Nov 2025 at 14:34, Shlok Kyal wrote:
> > > >
> > > >
On Mon, 10 Nov 2025 at 14:34, Shlok Kyal wrote:
>
> While working on another thread, I found that in HEAD gram.y has
> grammar which was committed as part of this thread:
> ```
> | CREATE PUBLICATION name FOR pub_obj_type_list opt_definition
> {
> Cr
On Fri, 7 Nov 2025 at 14:54, shveta malik wrote:
>
> On Fri, Nov 7, 2025 at 10:58 AM vignesh C wrote:
> >
> >
> > Thanks for pushing the patch, here is a rebased version of the
> > remaining patches.
> >
>
> Please find a few comments on doc patch:
>
On Thu, 6 Nov 2025 at 16:07, Amit Kapila wrote:
>
> On Thu, Nov 6, 2025 at 10:48 AM vignesh C wrote:
> >
> > The patch also includes the change for buildfarm failure at [1].
> > [1] -
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=202
On Thu, 6 Nov 2025 at 10:10, Amit Kapila wrote:
>
> On Thu, Nov 6, 2025 at 8:00 AM Shinya Kato wrote:
> >
> >
> > I discovered that the sequence sync worker fails for sequences
> > containing single quotes.
> > ---
> > 2025-11-06 10:22:50.335 JST [1096008] ERROR: could not fetch sequence
> > inf
can
> be 'r' and 's', while seq-sync has to be 'r'.
>
> b) If we plan to keep the same as above, the failure-message needs to
> be changed as it mentions only table.
I have separated the query to check individually for table sync and
sequence sync.
The atta
On Wed, 5 Nov 2025 at 18:10, Amit Kapila wrote:
>
> On Wed, Nov 5, 2025 at 5:57 PM vignesh C wrote:
> >
> > On Wed, 5 Nov 2025 at 13:58, Amit Kapila wrote:
> > >
> > > On Mon, Nov 3, 2025 at 8:46 PM vignesh C wrote:
> > > >
> > > &g
On Wed, 5 Nov 2025 at 13:58, Amit Kapila wrote:
>
> On Mon, Nov 3, 2025 at 8:46 PM vignesh C wrote:
> >
> > The attached v20251103 patch has the changes for the same.
> >
>
> I have pushed the 0001 after making minor adjustments in tests and at
> a few other p
On Wed, 29 Oct 2025 at 09:19, Peter Smith wrote:
>
> Hi Vignesh,
>
> Some review comments patch V20251029-0001 (the test code only)
>
> ==
> src/test/subscription/t/036_sequences.pl
>
> 1.
> +##
> +## ALTER SUBSCRIPTION ... REFRESH PUBLICATION with (copy_data = off) should
> +# not upd
On Tue, 28 Oct 2025 at 07:17, Chao Li wrote:
>
>
>
> > On Oct 27, 2025, at 17:11, Chao Li wrote:
> >
> > The changes in 0001 are straightforward, looks good. I haven’t reviewed
> > 0004 yet.
>
> Comments for 0004:
>
> 1 - config.sgml
> ```
> -In logical replication, this parameter also l
On Mon, 27 Oct 2025 at 10:04, Dilip Kumar wrote:
>
> On Mon, Oct 27, 2025 at 8:23 AM Zhijie Hou (Fujitsu)
> wrote:
>>
>> On Friday, October 24, 2025 11:22 PM vignesh C wrote:
>> >
>> > On Thu, 23 Oct 2025 at 16:47, Amit Kapila wrote:
>> > >
On Fri, 26 Sept 2025 at 05:29, Masahiko Sawada wrote:
>
> On Thu, Jul 3, 2025 at 7:55 AM vignesh C wrote:
> >
> > On Wed, 2 Jul 2025 at 13:21, Zhijie Hou (Fujitsu)
> > wrote:
> > >
> > > On Wed, Jul 2, 2025 at 2:42 PM vignesh C wrote:
> > >
&
On Sat, 4 Oct 2025 at 21:24, Amit Kapila wrote:
>
> On Tue, Sep 30, 2025 at 9:55 PM vignesh C wrote:
> >
>
> In the 0001 patch, pg_get_sequence_data() exposes two new fields
> log_cnt and page_lsn. I see that the later subscriber-side patch uses
> both, the first one in
On Sun, 5 Oct 2025 at 07:54, Michael Paquier wrote:
>
> On Sat, Oct 04, 2025 at 09:24:32PM +0530, Amit Kapila wrote:
> > In the 0001 patch, pg_get_sequence_data() exposes two new fields
> > log_cnt and page_lsn. I see that the later subscriber-side patch uses
> > both, the first one in SetSequence
On Tue, 7 Oct 2025 at 23:40, Masahiko Sawada wrote:
>
> On Mon, Oct 6, 2025 at 6:55 PM Euler Taveira wrote:
> >
> > On Mon, Oct 6, 2025, at 5:00 PM, Masahiko Sawada wrote:
> > > I agree with your analysis. It seems there is no convenient way to
> > > move RelationSyncCache inside PGOutputData. So
On Tue, 7 Oct 2025 at 10:53, shveta malik wrote:
>
> On Mon, Oct 6, 2025 at 4:33 PM vignesh C wrote:
> >
> >
> > Here is the rebased remaining patches.
> >
>
> Thank You for the patches, please find a few comment on 001:
>
> 1)
> Shall we have &#
On Thu, 9 Oct 2025 at 00:16, Masahiko Sawada wrote:
>
> On Wed, Oct 8, 2025 at 11:39 AM vignesh C wrote:
> >
> > On Tue, 7 Oct 2025 at 23:40, Masahiko Sawada wrote:
> > >
> > > On Mon, Oct 6, 2025 at 6:55 PM Euler Taveira wrote:
> > > >
> >
On Thu, 9 Oct 2025 at 23:33, Masahiko Sawada wrote:
>
> On Thu, Oct 9, 2025 at 10:07 AM Masahiko Sawada wrote:
> >
> > On Thu, Oct 9, 2025 at 8:23 AM Euler Taveira wrote:
> > >
> > > On Thu, Oct 9, 2025, at 10:40 AM, vignesh C wrote:
> > > &
On Mon, 29 Sept 2025 at 08:58, Peter Smith wrote:
>
> Hi Shlok,
>
> I was looking at the recent v24 changes.
>
> ==
> GENERAL.
>
> I saw that you modified the system view to add a new flag:
>
> +
> +
> + exceptcol bool
> +
> +
> + True if a column list with E
On Sat, 27 Sept 2025 at 01:20, Shlok Kyal wrote:
>
> Thanks for reviewing the patch.
> I have addressed the comments and attached the updated version.
If all columns are excluded, we do not publish the changes. However,
when a table has no columns, the data is still replicated. Should we
make thi
On Fri, 5 Sept 2025 at 11:57, Shlok Kyal wrote:
>
> On Mon, 25 Aug 2025 at 13:38, Shlok Kyal wrote:
> >
> > On Thu, 21 Aug 2025 at 05:33, Peter Smith wrote:
> > >
> > > Hi Shlok,
> > >
> > > I reviewed your latest v20-0003 patch and have no more comments at
> > > this time; I only found one triv
On Fri, 5 Sept 2025 at 11:57, Shlok Kyal wrote:
>
> On Mon, 25 Aug 2025 at 13:38, Shlok Kyal wrote:
> >
> > On Thu, 21 Aug 2025 at 05:33, Peter Smith wrote:
> > >
> > > Hi Shlok,
> > >
> > > I reviewed your latest v20-0003 patch and have no more comments at
> > > this time; I only found one triv
On Fri, 21 Mar 2025 at 18:54, vignesh C wrote:
>
> On Thu, 13 Mar 2025 at 18:10, Heikki Linnakangas wrote:
> >
> >
> > Hmm, this problem isn't limited to this one pg_upgrade test, right? It
> > could happen with any pg_upgrade invocation. And perhap
On Mon, 8 Sept 2025 at 12:05, Chao Li wrote:
>
>
>
> On Sep 8, 2025, at 14:00, vignesh C wrote:
>
>
>
> 1 - 0001
> ```
> diff --git a/src/test/regress/sql/sequence.sql
> b/src/test/regress/sql/sequence.sql
> index 2c220b60749..c8adddbfa31 100644
> --- a/sr
On Fri, 5 Sept 2025 at 04:01, Masahiko Sawada wrote:
>
> On Wed, Aug 20, 2025 at 4:57 AM Amit Kapila wrote:
> >
> > On Mon, Aug 18, 2025 at 3:36 PM vignesh C wrote:
> > >
> > > Thanks for the comments, the updated version has the changes for the same.
>
On Fri, 8 Aug 2025 at 12:50, Jelte Fennema-Nio wrote:
>
> Thanks to the Claude Code AI tool I was able to get some boring
> cleanup done on the CF app in not that much time. I'll release all of
> it on August 19th.
>
> List of the changes:
> - Update to Bootstrap 5 for more modern visual look and
s?
Regards,
Vignesh
From d80a07a7a1ada926af31de180abc00240dd61ad7 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Wed, 20 Aug 2025 16:10:17 +0530
Subject: [PATCH v1] Fix pg_get_sequence_data showing incorrect last_value
Fix pg_get_sequence_data showing incorrect last_value for a newly
created sequence.
---
src/backen
On Tue, 19 Aug 2025 at 23:33, Masahiko Sawada wrote:
>
> I imagined something like case 2. For logical replication of tables,
> if we support DDL replication (i.e., CREATE/ALTER/DROP TABLE), all
> changes the apply worker executes are serialized in commit LSN order.
> Therefore, users would not ha
On Tue, 19 Aug 2025 at 06:47, Masahiko Sawada wrote:
>
> On Mon, Aug 18, 2025 at 4:21 PM Masahiko Sawada wrote:
> >
> > For example, if a sequence is dropped
> > on the publisher, the subscriber would encounter synchronization
> > failures unless the DROP SEQUENCE is properly applied.
>
> This ex
On Sat, 16 Aug 2025 at 14:15, Masahiko Sawada wrote:
>
> As I understand it, the logical replication of sequences implemented
> by these patches shares the same user interface as table replication
> (utilizing CREATE PUBLICATION and CREATE SUBSCRIPTION commands for
> configuration). However, the u
On Fri, 8 Aug 2025 at 13:47, Zhijie Hou (Fujitsu)
wrote:
>
> On Wednesday, August 6, 2025 7:23 PM vignesh C wrote:
> > On Fri, 1 Aug 2025 at 13:33, Zhijie Hou (Fujitsu)
> > wrote:
> > >
> > > On Monday, July 28, 2025 1:07 PM Hayato Kuroda (Fujitsu)
>
On Fri, 1 Aug 2025 at 13:33, Zhijie Hou (Fujitsu)
wrote:
>
> On Monday, July 28, 2025 1:07 PM Hayato Kuroda (Fujitsu)
> wrote:
> >
> > Dear Shubham,
> >
> > > The attached patch introduces a new '--table' option that can be
> > > specified after each '--database' argument.
> >
> > Do we have ano
On Mon, 4 Aug 2025 at 09:47, Ashutosh Bapat
wrote:
>
> Hi Vignesh,
> Thanks for the patches.
>
> On Sat, Aug 2, 2025 at 7:10 PM vignesh C wrote:
>
> > >
> > > The backport seems to be straight forward. Please let me know if you
> > > need my help
On Tue, 5 Aug 2025 at 12:52, Peter Smith wrote:
>
> On Tue, Aug 5, 2025 at 4:43 PM Amit Kapila wrote:
> >
> > On Tue, Aug 5, 2025 at 11:57 AM Peter Smith wrote:
> > >
> > > On Tue, Aug 5, 2025 at 2:28 PM vignesh C wrote:
> > > >
> &g
On Tue, 5 Aug 2025 at 05:35, Peter Smith wrote:
>
> Here is a v1 patch, where:
>
> - now user gets ERROR if the 'publish_generated_columns' parameter is
> specified without a value
> - regression tests are updated
Few comments:
1) Generally in other case we throw the following error "option
requi
On Mon, 4 Aug 2025 at 16:08, vignesh C wrote:
>
> On Mon, 4 Aug 2025 at 09:47, Ashutosh Bapat
> wrote:
> >
> > Hi Vignesh,
> > Thanks for the patches.
> >
> > On Sat, Aug 2, 2025 at 7:10 PM vignesh C wrote:
> >
> > > >
> > > >
On Mon, 4 Aug 2025 at 09:47, Ashutosh Bapat
wrote:
>
> Hi Vignesh,
> Thanks for the patches.
>
> On Sat, Aug 2, 2025 at 7:10 PM vignesh C wrote:
>
> > >
> > > The backport seems to be straight forward. Please let me know if you
> > > need my help
Please let me know if you
> need my help in doing so, if we decide to backport the fix.
Now that this has been reported on the back branches, we should
consider whether it's appropriate to backport the fix. Here are the
patches prepared for the back branches.
Regards,
Vignesh
From fa8d5b2
On Thu, 31 Jul 2025 at 08:23, Ajin Cherian wrote:
>
> On Wed, Jul 30, 2025 at 10:33 PM Hayato Kuroda (Fujitsu)
> wrote:
> >
> > Dear Ajin,
> >
> > > Attaching the updated patches with the changes you requested. I've
> > > also added the unchanged patches for PG_18 and HEAD (PG_18_HEAD-v6*),
> > >
On Tue, 29 Jul 2025 at 14:46, Ajin Cherian wrote:
>
> On Tue, Jul 29, 2025 at 1:13 PM Amit Kapila wrote:
> >
> > Yes, that makes sense to me. For HEAD and PG18, we can still add a new
> > argument to the API. For other bank branches, it is better to use a
> > new Ex function as suggested by Kurod
On Tue, 29 Jul 2025 at 14:46, Ajin Cherian wrote:
>
> On Tue, Jul 29, 2025 at 1:13 PM Amit Kapila wrote:
> >
> > Yes, that makes sense to me. For HEAD and PG18, we can still add a new
> > argument to the API. For other bank branches, it is better to use a
> > new Ex function as suggested by Kurod
On Fri, 25 Jul 2025 at 11:45, Masahiko Sawada wrote:
>
> On Tue, Jul 22, 2025 at 11:44 PM shveta malik wrote:
> >
> > On Tue, Jul 22, 2025 at 5:03 AM Masahiko Sawada
> > wrote:
> > >
> > > Yes, I agree. The main patch focuses on the part where we
> > > automatically change the effective WAL lev
On Thu, 24 Jul 2025 at 17:45, Ajin Cherian wrote:
>
> On Wed, Jul 23, 2025 at 8:01 PM Hayato Kuroda (Fujitsu)
> wrote:
> >
> > > Dear Ajin,
> > >
> > > Thanks for the patch. Firstly let me confirm my understanding. While
> > > altering the
> > > subscription, locks are acquired with below orderi
On Thu, 24 Jul 2025 at 22:28, Álvaro Herrera wrote:
>
> On 2025-Jul-24, Laurenz Albe wrote:
>
> > I just happened to look into https://commitfest.postgresql.org/52/
> > and saw plenty of "Active patches" there.
> >
> > I guess that's a consequence of the new rule established in [1].
>
> I don't kn
On Tue, 22 Jul 2025 at 18:43, Fujii Masao wrote:
>
> On Tue, Jul 22, 2025 at 9:49 PM Álvaro Herrera wrote:
> >
> > On 2025-Jul-22, Fujii Masao wrote:
> >
> > > On Tue, Jul 22, 2025 at 8:47 PM Álvaro Herrera
> > > wrote:
> >
> > > > Oh yeah, I should have remembered this -- see commit 213c959a29
On Mon, 21 Jul 2025 at 11:15, Dilip Kumar wrote:
>
> On Mon, Jul 21, 2025 at 10:36 AM Dilip Kumar wrote:
> >
> > I was just trying a different test, so I realized that ALTER
> > PUBLICATION ADD SEQUENCE is not supported, any reason for the same?
> >
> > postgres[154731]=# ALTER PUBLICATION pub AD
On Mon, 21 Jul 2025 at 10:36, Dilip Kumar wrote:
>
> I was just trying a different test, so I realized that ALTER
> PUBLICATION ADD SEQUENCE is not supported, any reason for the same?
>
> postgres[154731]=# ALTER PUBLICATION pub ADD sequence s1;
> ERROR: 42601: invalid publication object list
> L
On Mon, 21 Jul 2025 at 11:04, Amit Kapila wrote:
>
> On Fri, Jul 18, 2025 at 5:11 PM Alexander Korotkov
> wrote:
> >
> > While working on the patch fixing the situation when slot's
> > restart_lsn ends up pointing to a removed WAL segment [1], we
> > discovered that sometimes slot's restart_lsn
On Fri, 18 Jul 2025 at 14:11, Dilip Kumar wrote:
>
> On Fri, Jul 18, 2025 at 10:44 AM Dilip Kumar wrote:
> >
> > On Thu, Jul 17, 2025 at 4:52 PM vignesh C wrote:
> > >
>
> I was looking at the high level idea of sequence sync worker patch
> i.e. 0005, so far
On Sat, 19 Jul 2025 at 01:39, Álvaro Herrera wrote:
>
> On 2025-Jul-18, vignesh C wrote:
>
> > diff --git a/contrib/postgres_fdw/connection.c
> > b/contrib/postgres_fdw/connection.c
> > index 304f3c20f83..c1ce6f33436 100644
> > --- a/contrib/postgres_f
oop() around the string
> > they pass as "arg", for gettext to collect.
>
> Agreed. Thanks!
The attached v6 version patch has the changes for these comments.
Regards,
Vignesh
From 4d40ae938e97f5d1b4dc8ec99f6bc0adde57ed2e Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Fri, 18 Jul 2025 21:07:3
Regards,
Vignesh
From 8a0d5392f482572ebd57a6eae30c715c81b31963 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Wed, 16 Jul 2025 15:26:12 +0530
Subject: [PATCH v5 1/3] Add custom PQsetNoticeReceiver handlers for
replication connection
This patch introduces a custom notice receiver for replication
On Wed, 16 Jul 2025 at 21:30, Fujii Masao wrote:
>
>
>
> On 2025/07/16 19:45, vignesh C wrote:
> > If we don't trim the trailing newline, an extra blank line will appear
> > after the message is printed, like this:
> > 2025-07-16 12:44:20.076 IST [5343
On Wed, 16 Jul 2025 at 09:09, Fujii Masao wrote:
>
> >
> > Included it for dblink and fdw
>
> Thanks! It's better to submit each change for dblink and postgres_fdw
> as separate patches, and first focus on the patch that sets the notice
> processor for replication connections.
Modified
> > > +no
On Mon, 14 Jul 2025 at 21:36, Fujii Masao wrote:
>
>
>
> On 2025/04/15 13:37, vignesh C wrote:
> > Hi,
> >
> > Currently, when a warning is emitted by the publisher, the
> > corresponding log message does not include the log prefix. This makes
> > it ha
On Mon, 14 Jul 2025 at 16:15, vignesh C wrote:
>
> On Mon, 14 Jul 2025 at 15:46, Ajin Cherian wrote:
> >
> > On Tue, Jul 8, 2025 at 8:41 PM Ajin Cherian wrote:
> > >
> > > Patch with fix attached.
> > > I'll continue investigating whether
On Mon, 14 Jul 2025 at 15:46, Ajin Cherian wrote:
>
> On Tue, Jul 8, 2025 at 8:41 PM Ajin Cherian wrote:
> >
> > Patch with fix attached.
> > I'll continue investigating whether this issue also affects HEAD.
> >
>
> While debugging if this problem can occur on HEAD, I found out that on
> head, it
On Thu, 10 Jul 2025 at 11:47, Dilip Kumar wrote:
>
> On Thu, Jul 10, 2025 at 11:18 AM Dilip Kumar wrote:
> >
> > On Thu, Jul 10, 2025 at 11:11 AM vignesh C wrote:
> > >
> > > On Wed, 9 Jul 2025 at 17:47, Dilip Kumar wrote:
> > > >
>
On Thu, 10 Jul 2025 at 11:47, Dilip Kumar wrote:
>
> On Thu, Jul 10, 2025 at 11:18 AM Dilip Kumar wrote:
> >
> > On Thu, Jul 10, 2025 at 11:11 AM vignesh C wrote:
> > >
> > > On Wed, 9 Jul 2025 at 17:47, Dilip Kumar wrote:
> > > >
>
On Wed, 9 Jul 2025 at 17:47, Dilip Kumar wrote:
>
> On Wed, Jul 9, 2025 at 5:29 PM Álvaro Herrera wrote:
> >
> > On 2025-Jul-09, Dilip Kumar wrote:
> >
> > > On Wed, Jul 9, 2025 at 9:07 AM Dilip Kumar wrote:
> >
> > > > After further consideration, I believe your proposed method is
> > > > super
On Wed, 2 Jul 2025 at 13:21, Zhijie Hou (Fujitsu)
wrote:
>
> On Wed, Jul 2, 2025 at 2:42 PM vignesh C wrote:
>
> >
> > Hi,
> >
> > I encountered an invalid pointer access issue. Below are the steps to
> > reproduce the issue:
> ...
> > The error o
Hi,
I encountered an invalid pointer access issue. Below are the steps to
reproduce the issue:
-- Create table
CREATE TABLE t1(c1 int, c2 int);
-- Create publications with each publication selecting a different column
CREATE PUBLICATION pub1 for TABLE t1(c1);
CREATE PUBLICATION pub2 for TABLE t1
On Thu, 26 Jun 2025 at 03:21, Aleksander Alekseev
wrote:
>
> Hi,
>
> > Ugh... Turns out it was a bug, there definitely should be a "New
> > patch" button on both the 19-1 and on the Drafts page. And there
> > was... but only if you were logged in as a staff user.
>
> There is now a "New patch" but
On Mon, 30 Jun 2025 at 17:41, Hayato Kuroda (Fujitsu)
wrote:
>
> Dear Vignesh,
>
> > I was unable to reproduce the same test failure on the PG17 branch,
> > even after running the test around 500 times. However, on the master
> > branch, the failure consistently reproduces approximately once in
>
On Fri, 27 Jun 2025 at 07:05, Michael Paquier wrote:
>
> On Thu, Jun 26, 2025 at 05:25:42PM +0530, vignesh C wrote:
> > On Thu, 26 Jun 2025 at 06:22, Michael Paquier wrote:
> >> So you are suggesting the addition of an extra ReadPageInternal() that
> >> forces a
On Fri, 27 Jun 2025 at 07:05, Michael Paquier wrote:
>
> On Thu, Jun 26, 2025 at 05:25:42PM +0530, vignesh C wrote:
> > On Thu, 26 Jun 2025 at 06:22, Michael Paquier wrote:
> >> So you are suggesting the addition of an extra ReadPageInternal() that
> >> forces a
On Thu, 26 Jun 2025 at 06:22, Michael Paquier wrote:
>
> On Wed, Jun 25, 2025 at 10:19:55PM +0530, vignesh C wrote:
> > Currently, the logic attempts to read the complete WAL record based on
> > the size obtained before the crash—even though only a partial record
> > was
Hi,
Buildfarm identified one issue at [1] where it could not identify a
partial WAL record spanning across 2 pages was written due to
immediate shutdown.
Consider a scenario where a WAL record is split across multiple WAL
pages. If the server crashes before the entire WAL record is written,
the r
On Mon, 23 Jun 2025 at 04:36, Alexander Korotkov wrote:
>
> On Fri, Jun 20, 2025 at 2:24 PM vignesh C wrote:
> > On Fri, 20 Jun 2025 at 05:54, Alexander Korotkov
> > wrote:
> > > Dear Kuroda-san,
> > >
> > > On Thu, Jun 19, 2025 at
On Wed, 18 Jun 2025 at 14:35, Vitaly Davydov wrote:
>
> Dear Hayato,
>
> > To confirm, can you tell me the theory why the walsender received old LSN?
> > It is sent by the walreceiver, so is there a case that
> > LogstreamResult.Flush can go backward?
> > Not sure we can accept the situation.
>
>
Hi Alexander,
While tracking buildfarm for one of other commits, I noticed this failure:
TRAP: failed Assert("s->data.restart_lsn >=
s->last_saved_restart_lsn"), File:
"../pgsql/src/backend/replication/slot.c", Line: 1813, PID: 3945797
postgres: standby: checkpointer (ExceptionalCondition+0x83) [0
On Thu, 5 Jun 2025 at 01:50, Peter Eisentraut wrote:
>
> On 04.06.25 11:56, Amit Kapila wrote:
> >> It's not clear to me how this change now would substantially improve the
> >> user experience. The number of characters you type is approximately the
> >> same. You still need to support the old m
On Mon, 26 May 2025 at 13:59, Michael Paquier wrote:
>
> On Sat, May 24, 2025 at 11:27:05AM +0530, Amit Kapila wrote:
> > On Sat, May 24, 2025 at 6:07 AM Michael Paquier wrote:
> >> Yes, agreed that your suggested fix looks sensible with an extra check
> >> for pg_prepared_xacts on the subscriber
Hi,
The 021_twophase test has failed on Kestrel at [1] with the following error:
# Failed test 'should be no prepared transactions on subscriber'
# at
/home/bf/bf-build/kestrel/HEAD/pgsql/src/test/subscription/t/021_twophase.pl
line 438.
# got: '1'
# expected: '0'
# Looks like yo
the feedback begin. ;-)
Regarding the following:
Change the default CREATE SUBSCRIPTION streaming option from "off" to
"parallel" (Hayato Kuroda, Masahiko Sawada, Peter Smith, Amit Kapila)
The author name was incorrectly listed in the commit; it should be
"Vignesh C". This co
On Tue, 20 May 2025 at 09:54, shveta malik wrote:
>
> On Tue, May 20, 2025 at 8:35 AM Nisha Moond wrote:
> >
> > >
> > > Thanks for the comments, these are handled in the attached v20250516
> > > version patch.
> > >
> >
> > Thanks for the patches. Here are my review comments -
> >
> > Patch-0004
On Tue, 20 May 2025 at 03:16, Michael Paquier wrote:
>
> On Mon, May 19, 2025 at 11:19:48AM -0400, Robert Haas wrote:
> > The advantage of Fujii-san's proposal is that it is very simple to
> > implement. A subscription option would indeed be better, but it would
> > also be considerably more compl
On Wed, 14 May 2025 at 09:55, Nisha Moond wrote:
>
> On Sat, May 3, 2025 at 7:28 PM vignesh C wrote:
> >
> >
> > There was one pending open comment #6 from [1]. This has been
> > addressed in the attached patch.
>
> Thank you for the patches, here are my co
On Fri, 2 May 2025 at 09:23, vignesh C wrote:
>
> On Fri, 2 May 2025 at 06:30, Tom Lane wrote:
> >
> > vignesh C writes:
> > > I agree with your analysis. I was able to reproduce the issue by
> > > delaying the invalidation of the subscription until the w
On Fri, 2 May 2025 at 10:11, Xuneng Zhou wrote:
>
> Hi,
> Is this an expected behavior?
>
> A race between subscriber LSN feedback and publisher subscription change
> processing allows the walsender to restart decoding past relevant WAL
> records, bypassing the updated subscription rules for tho
On Fri, 2 May 2025 at 06:30, Tom Lane wrote:
>
> vignesh C writes:
> > I agree with your analysis. I was able to reproduce the issue by
> > delaying the invalidation of the subscription until the walsender
> > finished decoding the INSERT operation following the ALTER
&g
On Wed, 30 Apr 2025 at 17:41, Amit Kapila wrote:
>
> On Wed, Apr 30, 2025 at 11:22 AM Tom Lane wrote:
> >
> > Xuneng Zhou pointed out on Discord that the test case added by
> > 7c99dc587 has caused repeated failures in CI --- though oddly,
> > it's not failed in the buildfarm so far as I can find
Hi,
Currently, when a warning is emitted by the publisher, the
corresponding log message does not include the log prefix. This makes
it harder to correlate such messages with other log entries. For
example, in a simulated error scenario where directory removal fails,
the notice message lacks the s
On Sat, 12 Apr 2025 at 01:56, Jonathan S. Katz wrote:
>
> The Core Team would like to extend our congratulations to Jacob
> Champion, who has accepted an invitation to become our newest PostgreSQL
> committer.
>
> Please join us in wishing Jacob much success and few reverts!
Many Congratulations,
On Mon, 7 Apr 2025 at 20:37, vignesh C wrote:
>
Thanks a lot to all the members who participated in the commitfest.
Here are the final numbers at the end of the commitfest:
status | End of Commitfest
+---
Needs rev
Hi,
Thanks a lot to all the members who participated in the commitfest.
Here are the final numbers at the end of the commitfest:
status | End of Commitfest
+---
Needs review: |54
Waiting on Author: |
On Mon, 31 Mar 2025 at 08:34, vignesh C wrote:
>
> On Mon, 24 Mar 2025 at 10:07, vignesh C wrote:
Here's a quick commitfest status report as of today:
status | start | 17th | 24th | 31
1 - 100 of 1446 matches
Mail list logo
