On Wed, 19 Mar 2025 at 18:12, David Rowley <dgrowle...@gmail.com> wrote: > > On Wed, 19 Mar 2025 at 23:22, Ilia Evdokimov > <ilya.evdoki...@tantorlabs.com> wrote: > > Everything seems fine with the ANALYZE command autocompletion. Regarding > > VACUUM, I'm not entirely convinced we should provide autocompletion in > > every case. I'd prefer to keep the behavior from the v3 patch because the > > original intention behind adding the ONLY keyword was specifically for > > collecting statistics exclusively from parent tables. Therefore, > > autocompletion makes sense primarily for the ANALYZE case. > > While VACUUM ONLY on a partitioned table has no effect, the same isn't > true for inheritance parents. 62ddf7ee9 did change the behaviour of > VACUUM for these so that vacuuming the inheritance parent now vacuums > all of its children, unless ONLY is used. So, I'd say if the tab > completion is only added to ANALYZE, then it'd be incomplete still. > (I've not looked at the v3 patch to see which of those it handles.)
I also felt it is necessary for both ANALYZE and VACUUM, and the v3 patch includes changes for both. Regards, Vignesh
