On Monday, October 17, 2022 9:25 PM Kuroda, Hayato/黒田 隼人
wrote:
> > I mainly followed the steps there and
> > replaced the command "SELECT" for the remote table at 6-9 with "INSERT"
> > command.
> > Then, after waiting for few seconds, the "COMMIT" succeeded like below
> > output, even after the
On Wednesday, October 5, 2022 6:27 PM kuroda.hay...@fujitsu.com
wrote:
> Thanks for giving many comments! Based on off and on discussions, I modified
> my patch.
Here are my other quick review comments on v16.
(1) v16-0001 : definition of a new structure
CheckingRemoteServersCallbackItem can b
Hi,
On Wednesday, October 5, 2022 6:27 PM kuroda.hay...@fujitsu.com
wrote:
> Thanks for giving many comments! Based on off and on discussions, I modified
> my patch.
Thank you for your patch set !
While reviewing and testing the new v16, I've met a possible issue
by slightly adjusting the scen
Hi, Alvaro-san
On Thursday, October 13, 2022 8:38 PM Alvaro Herrera
wrote:
> On 2022-Oct-13, osumi.takami...@fujitsu.com wrote:
>
> > I noticed a possible typo in the doc for create publication.
> > This applies to PG15 as well.
> > Kindly have a look at the attached
Hi,
I noticed a possible typo in the doc for create publication.
This applies to PG15 as well.
Kindly have a look at the attached patch for it.
Best Regards,
Takamichi Osumi
v1-0001-modify-a-typo.patch
Description: v1-0001-modify-a-typo.patch
Hi,
On Monday, October 3, 2022 8:50 PM Melih Mutlu wrote:
> (4) Error message of the binary format copy
>
> I've gotten below message from data type contradiction (between
> integer and bigint).
> Probably, this is unclear for the users to understand the direct cause
> a
On Wednesday, September 28, 2022 5:36 PM Wang, Wei/王 威
wrote:
> Also rebased the patch because the change in the HEAD (20b6847).
>
> Attach the new patches.
Hi, thank you for the updated patches!
Here are my minor review comments for HEAD v12.
(1) typo & suggestion to reword one comment
+
On Tuesday, September 20, 2022 3:18 PM Wang, Wei/王 威
wrote:
> Rebased the patch based on the changes in HEAD (20b6847).
> Attach the new patches.
Hi, thank you for updating the patchset.
FYI, I noticed that the patch for head is no longer applicable.
$ git apply --check
HEAD_v10-0001-Fix-data
Hi
Few more minor comments.
On Tuesday, August 16, 2022 2:04 AM Melih Mutlu wrote:
>
>
> My main concern is to break a scenario that was previously working (14
> -> 15) but after a subscriber upgrade
> it won't (14 -> 16).
>
> Fair concern. Some cases that might break the logical
On Tuesday, August 16, 2022 2:04 AM Melih Mutlu wrote:
> Attached patch also includes some additions to the doc along with the tests.
Hi, thank you for updating the patch. Minor review comments for the v2.
(1) whitespace issues
Please fix below whitespace errors.
$ git apply v2-0001-Allow-log
Hi, hackers
I've met an assertion failure of logical decoding with below scenario on HEAD.
---
create table tab1 (val integer);
select 'init' from pg_create_logical_replication_slot('regression_slot',
'test_decoding');
begin;
savepoint sp1;
insert into tab1 values (1);
checkpoint; -- for
On Tuesday, August 9, 2022 12:59 AM Önder Kalacı wrote:
> Attaching v5 of the patch which reflects the review on this email, also few
> minor test improvements.
Hi,
Thank you for the updated patch.
FYI, I noticed that v5 causes cfbot failure in [1].
Could you please fix it in the next version ?
On Tuesday, August 9, 2022 6:47 AM Euler Taveira wrote:
> I attached a v6.
Hi, thank you for posting the updated patch.
Minor review comments for v6.
(1) commit message
"If the subscriber sets min_apply_delay parameter, ..."
I suggest we use subscription rather than subscriber, because
this p
On Sunday, July 17, 2022 9:59 PM Masahiko Sawada wrote:
> I've attached patches for all supported branches including the master.
Hi,
Minor comments for REL14.
(1) There are some foreign characters in the patches (in the commit message)
When I had a look at your patch for back branches with som
On Thursday, July 14, 2022 10:31 AM Masahiko Sawada
wrote:
> I've attached an updated patch that incorporated comments from Amit and Shi.
Hi,
Minor comments for v4.
(1) typo in the commit message
"When decoding a COMMIT record, we check both the list and the ReorderBuffer to
see if
if the tr
On Tuesday, July 5, 2022 1:05 PM Amit Kapila wrote:
> On Tue, Jul 5, 2022 at 4:03 AM Peter Smith wrote:
> >
> > On Mon, Jul 4, 2022 at 10:29 PM Euler Taveira wrote:
> > >
> > > On Mon, Jul 4, 2022, at 5:37 AM, Amit Kapila wrote:
> > >
> > > Yeah, it seems we have overlooked this point. I think w
On Thursday, May 26, 2022 11:37 AM Amit Kapila wrote:
> On Wed, May 25, 2022 at 6:54 PM Tomas Vondra
> wrote:
> >
> > On 5/25/22 13:26, Amit Kapila wrote:
> > > On Wed, May 25, 2022 at 8:16 AM Kyotaro Horiguchi
> > > wrote:
> > >>
> > >> It does "fix" the case of [1]. But AFAIS
> > >> RelationS
On Wednesday, May 25, 2022 11:25 AM wangw.f...@fujitsu.com
wrote:
> Attach the patches. (Did not change v6-0001 and v6-0002.)
Hi,
Some review comments on the new patches from v6-0001 to v6-0004.
(1) create_subscription.sgml
+ the transaction is committed. Note that if an error happ
On Monday, May 23, 2022 2:13 PM vignesh C wrote:
> Attached v7 patch which fixes the buildfarm warning for an unused warning in
> release mode as in [1].
Hi, thank you for the patches.
I'll share several review comments.
For v7-0001.
(1) I'll suggest some minor rewording.
+
+ The RESET c
On Tuesday, May 24, 2022 9:50 PM Amit Kapila wrote:
> On Sat, May 21, 2022 at 9:03 AM Amit Kapila
> wrote:
> >
> > On Fri, May 20, 2022 at 4:01 PM Tomas Vondra
> > wrote:
> >
> > > Also, we'd probably have to ignore RelationSyncEntry for a while,
> > > which seems quite expensive.
> > >
> >
> >
On Thursday, May 19, 2022 8:13 PM Amit Kapila wrote:
> On Thu, May 19, 2022 at 3:16 PM Amit Kapila
> wrote:
> >
> > On Thu, May 19, 2022 at 12:28 PM Kyotaro Horiguchi
> > wrote:
> > >
> > > At Thu, 19 May 2022 14:26:56 +1000, Peter Smith
> > > wrote in
> > > > Hi hackers.
> > > >
> > > > FYI, I
On Thursday, May 19, 2022 2:45 AM vignesh C wrote:
> On Mon, May 16, 2022 at 8:32 AM osumi.takami...@fujitsu.com
> wrote:
> > (3) src/test/regress/expected/publication.out
> >
> > +-- Verify that only superuser can reset a publication ALTER
> > +PUBL
On Monday, May 16, 2022 9:34 PM houzj.f...@fujitsu.com
wrote:
> Attach the new version patch.
Hi,
I have few minor comments.
For v2-0001.
(1) Unnecessary period at the end of column explanation
+
+
+ rowfilter text
+
+
+ Expression for the table's publicati
On Saturday, May 14, 2022 10:33 PM vignesh C wrote:
> Thanks for the comments, the attached v5 patch has the changes for the same.
> Also I have made the changes for SKIP Table based on the new syntax, the
> changes for the same are available in
> v5-0002-Skip-publishing-the-tables-specified-in-EX
On Saturday, May 14, 2022 10:33 PM vignesh C wrote:
> Thanks for the comments, the attached v5 patch has the changes for the same.
> Also I have made the changes for SKIP Table based on the new syntax, the
> changes for the same are available in
> v5-0002-Skip-publishing-the-tables-specified-in-EX
On Saturday, May 14, 2022 12:07 AM 'Bruce Momjian' wrote:
> On Fri, May 13, 2022 at 01:36:04AM +, osumi.takami...@fujitsu.com wrote:
> > >
> > > This is enabled with the subscriber option "disable_on_error"
> > > and avoids
On Friday, May 13, 2022 6:42 PM Wang, Wei/王 威 wrote:
> Attach the patches.(Only changed the patch for HEAD.).
> 1. Optimize the code. Reduce calls to function filter_partitions.
> [suggestions by
> Amit-san] 2. Improve the alias name in SQL. [suggestions by Amit-san] 3.
> Improve coding alignment
On Thursday, May 12, 2022 11:10 PM 'Bruce Momjian' wrote:
> On Thu, May 12, 2022 at 01:35:39PM +, osumi.takami...@fujitsu.com
> wrote:
> > I'd like to suggest that we mention a new option for subscription
> 'disable_on_error'.
> >
> &g
On Wednesday, May 11, 2022 12:44 AM Bruce Momjian wrote:
> I have completed the first draft of the PG 15 release notes and you can see
> the
> results here:
>
> https://momjian.us/pgsql_docs/release-15.html
>
> The feature count is similar to recent major releases:
>
> release-
On Wednesday, May 11, 2022 11:33 AM I wrote:
> On Monday, May 9, 2022 10:51 AM wangw.f...@fujitsu.com
> wrote:
> > Attach new patches.
> > The patch for HEAD:
> > 1. Modify the approach. Enhance the API of function
> > pg_get_publication_tables to handle one publication or an array of
> > publicat
On Monday, May 9, 2022 10:51 AM wangw.f...@fujitsu.com
wrote:
> Attach new patches.
> The patch for HEAD:
> 1. Modify the approach. Enhance the API of function
> pg_get_publication_tables to handle one publication or an array of
> publications.
> The patch for REL14:
> 1. Improve the table sync S
On Wednesday, April 27, 2022 9:50 PM vignesh C wrote:
> Thanks for the comments, the attached v3 patch has the changes for the same.
Hi
Thank you for updating the patch. Several minor comments on v3.
(1) commit message
The new syntax allows specifying schemas. For example:
CREATE PUBLICATION pu
On Thursday, April 21, 2022 12:15 PM vignesh C wrote:
> Updated patch by changing the syntax to use EXCEPT instead of SKIP.
Hi
This is my review comments on the v2 patch.
(1) gram.y
I think we can make a unified function that merges
preprocess_alltables_pubobj_list with check_except_in_pubobj_
Hi
On Friday, March 25, 2022 2:36 PM Masahiko Sawada wrote:
> On Thu, Mar 24, 2022 at 12:30 PM Amit Kapila
> wrote:
> >
> > On Thu, Mar 3, 2022 at 8:58 AM osumi.takami...@fujitsu.com
> > wrote:
> > >
> >
> > This patch introduces two new subscripti
On Thursday, March 17, 2022 7:56 PM Masahiko Sawada
wrote:
On Thu, Mar 17, 2022 at 5:52 PM Amit Kapila
> wrote:
> >
> > On Thu, Mar 17, 2022 at 12:39 PM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > On Thursday, March 17, 2022 3:04 PM Amit Kapila
&g
On Thursday, March 17, 2022 3:04 PM Amit Kapila wrote:
> On Wed, Mar 16, 2022 at 1:53 PM Masahiko Sawada
> wrote:
> >
> > I've attached an updated version patch.
> >
>
> The patch LGTM. I have made minor changes in comments and docs in the
> attached patch. Kindly let me know what you think of t
On Wednesday, March 16, 2022 3:37 PM I wrote:
> On Wednesday, March 16, 2022 11:33 AM Amit Kapila
> wrote:
> > On Tue, Mar 15, 2022 at 7:30 PM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > On Tuesday, March 15, 2022 3:13 PM Masahiko Sawada
> >
On Wednesday, March 16, 2022 11:33 AM Amit Kapila
wrote:
> On Tue, Mar 15, 2022 at 7:30 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Tuesday, March 15, 2022 3:13 PM Masahiko Sawada
> wrote:
> > > I've attached an updated version patch.
> &
On Tuesday, March 15, 2022 3:13 PM Masahiko Sawada
wrote:
> I've attached an updated version patch.
A couple of minor comments on v14.
(1) apply_handle_commit_internal
+ if (is_skipping_changes())
+ {
+ stop_skipping_changes();
+
+ /*
+*
On Tuesday, March 15, 2022 8:04 AM Nathan Bossart
wrote:
> My compiler is worried that syncslotname may be used uninitialized in
> start_table_sync(). The attached patch seems to silence this warning.
Thank you for your reporting !
Your fix looks good to me.
Best Regards,
Takamichi Os
On Friday, March 11, 2022 5:20 PM Masahiko Sawada wrote:
> I've attached an updated version patch. This patch can be applied on top of
> the
> latest disable_on_error patch[1].
Hi, few extra comments on v13.
(1) src/backend/replication/logical/worker.c
With regard to clear_subscription_skip_l
On Monday, March 14, 2022 7:49 PM Amit Kapila wrote:
> On Thu, Mar 10, 2022 at 12:04 PM Amit Kapila
> wrote:
> >
> > On Wed, Mar 9, 2022 at 7:57 PM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > Hi, attached v32 removed my addit
On Friday, March 11, 2022 5:20 PM Masahiko Sawada wrote:
> I've attached an updated version patch. This patch can be applied on top of
> the
> latest disable_on_error patch[1].
Hi, thank you for the patch. I'll share my review comments on v13.
(a) src/backend/commands/subscriptioncmds.c
@@ -84
On Wednesday, March 2, 2022 12:01 AM Masahiko Sawada
wrote:
> I've attached an updated patch along with two patches for cfbot tests since
> the
> main patch (0003) depends on the other two patches. Both
> 0001 and 0002 patches are the same ones I attached on another thread[2].
Hi, few comments o
On Wednesday, March 9, 2022 8:22 PM Amit Kapila wrote:
> On Wed, Mar 9, 2022 at 2:21 PM Masahiko Sawada
> wrote:
> >
> > On Wed, Mar 9, 2022 at 4:33 PM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > On Tuesday, March 8, 2022 10:23 PM Amit Kapila
>
On Tuesday, March 8, 2022 10:23 PM Amit Kapila wrote:
> On Tue, Mar 8, 2022 at 1:37 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > Kindly have a look at v30.
> >
>
> Review comments:
Thank you for checking !
> ===
> 1.
> + ereport(LOG,
>
On Wednesday, March 9, 2022 9:58 AM Masahiko Sawada
wrote:
> On Tue, Mar 8, 2022 at 5:07 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > Kindly have a look at v30.
>
> Thank you for updating the patch. Here are some comments:
Hi, thank you for your review !
> +
On Wednesday, March 9, 2022 1:29 PM Amit Kapila wrote:
> On Tue, Mar 8, 2022 at 6:53 PM Amit Kapila wrote:
> >
> > On Tue, Mar 8, 2022 at 1:37 PM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > Kindly have a look at v30.
> > >
> >
On Wednesday, March 9, 2022 3:02 PM Amit Kapila wrote:
> On Wed, Mar 9, 2022 at 11:22 AM Masahiko Sawada
> wrote:
> >
> > On Wed, Mar 9, 2022 at 12:37 PM Amit Kapila
> wrote:
> > >
> > > On Wed, Mar 9, 2022 at 6:29 AM Masahiko Sawada
> wrote:
> > > >
> > > > ---
> > > > It might have already be
On Tuesday, March 8, 2022 1:07 PM Peter Smith wrote:
> Please find below some review comments for v29.
Thank you for your comments !
> ==
>
> 1. src/backend/replication/logical/worker.c - worker_post_error_processing
>
> +/*
> + * Abort and cleanup the current transaction, then do post-e
On Tuesday, March 8, 2022 2:52 PM Amit Kapila wrote:
> On Tue, Mar 8, 2022 at 9:37 AM Peter Smith wrote:
> >
> > Please find below some review comments for v29.
> >
> > ==
> >
> > 1. src/backend/replication/logical/worker.c -
> > worker_post_error_processing
> >
> > +/*
> > + * Abort and clea
On Monday, March 7, 2022 5:45 PM Amit Kaila wrote:
> On Mon, Mar 7, 2022 at 4:55 AM Peter Smith
> wrote:
> >
> > On Fri, Mar 4, 2022 at 5:55 PM Masahiko Sawada
> wrote:
> > >
> > > ---
> > > +/*
> > > + * First, ensure that we log the error message so
> > > that i
On Monday, March 7, 2022 12:01 PM Shi, Yu/侍 雨 wrote:
> On Wed, Mar 2, 2022 5:39 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > Attached an updated patch v26.
> >
>
> Thanks for your patch. A comment on the document.
Hi, thank you for checking my patch !
> @@
On Friday, March 4, 2022 3:55 PM Masahiko Sawada wrote:
> Thank you for updating the patch.
>
> Here are some comments on v26 patch:
Thank you for your review !
> +/*
> + * Disable the current subscription.
> + */
> +static void
> +DisableSubscriptionOnError(void)
>
> This function now just u
On Friday, March 4, 2022 2:23 PM Masahiko Sawada wrote:
> I've attached updated patches.
Hi, thank you for updating the patch.
One comment on v4.
In v4-0002, we introduce 'commit_lsn' in the ApplyErrorCallbackArg.
This member is set for prepare, rollback prepared and stream_abort as well.
The ne
On Friday, March 4, 2022 10:09 AM Masahiko Sawada wrote:
> On Thu, Mar 3, 2022 at 10:02 PM Masahiko Sawada
> wrote:
> >
> >
> > I'm updating the patches and will submit them.
>
> Attached updated version patches.
Thank you for sharing the patch v3.
Few minor comments.
(1) v03-0001, apply_erro
On Wednesday, March 2, 2022 5:29 PM Shi, Yu/侍 雨 wrote:
> A comments on the v26 patch.
Thank you for checking the patch !
>
> The following document about pg_stat_subscription_stats view only says that
> "showing statistics about errors", should we add something about transactions
> here?
>
>
On Wednesday, March 2, 2022 2:18 PM Masahiko Sawada
wrote:
> On Wed, Mar 2, 2022 at 10:21 AM osumi.takami...@fujitsu.com
> wrote:
> > Also, I quickly checked other similar views(pg_stat_slru,
> > pg_stat_wal_receiver) commit logs, especially when they introduce columns.
> &
On Wednesday, March 2, 2022 12:47 PM Masahiko Sawada
wrote:
> After more thoughts, should we do both AbortOutOfAnyTransaction() and error
> message handling while holding interrupts? That is,
>
> HOLD_INTERRUPTS();
> EmitErrorReport();
> FlushErrorState();
> AbortOutOfAny Transaction();
> RESUME
On Wednesday, March 2, 2022 9:34 AM Peter Smith wrote:
> Please see below my review comments for v24.
Thank you for checking my patch !
> ==
>
> 1. src/backend/replication/logical/worker.c - start_table_sync
>
> + /* Report the worker failed during table synchronization */
> + pgstat_repo
On Wednesday, March 2, 2022 8:54 AM Euler Taveira wrote:
> On Tue, Mar 1, 2022, at 3:27 AM, osumi.takami...@fujitsu.com
> <mailto:osumi.takami...@fujitsu.com> wrote:
>
>
> $ git am v1-0001-Time-delayed-logical-replication-subscriber.patch
>
>
> I generall
On Tuesday, March 1, 2022 4:12 PM Peter Smith wrote:
> Please see below my review comments for v25.
>
> ==
>
> 1. Commit message
>
> Introduce cumulative columns of transactions of logical replication subscriber
> to the pg_stat_subscription_stats view.
>
> "cumulative columns of transacti
On Tuesday, March 1, 2022 9:19 AM Euler Taveira wrote:
> Long time, no patch. Here it is. I will provide documentation in the next
>
> version. I would appreciate some feedback.
Hi, thank you for posting the patch !
$ git am v1-0001-Time-delayed-logical-replication-subscriber.patch
Applying: T
On Tuesday, March 1, 2022 9:49 AM Peter Smith wrote:
> Please see below my review comments for v22.
>
> ==
>
> 1. Commit message
>
> "table sync worker" -> "tablesync worker"
Fixed.
> ~~~
>
> 2. doc/src/sgml/catalogs.sgml
>
> +
> + If true, the subscription will be disabled w
On Friday, February 25, 2022 9:45 PM osumi.takami...@fujitsu.com
wrote:
> Kindly have a look at attached the v22.
> It has incorporated other improvements of TAP test, refinement of the
> DisableSubscriptionOnError function and so on.
The recent commit(7a85073) has changed the sub
On Friday, February 25, 2022 7:58 AM osumi.takami...@fujitsu.com
wrote:
> Kindly have a look at v24.
Hi.
The recent commit(7a85073) has redesigned the view pg_stat_subscription_workers
and now we have pg_stat_subscription_stats. Therefore, I rebased my patch
so that my statistics patch can
On Monday, February 28, 2022 12:57 PM Amit Kapila
> On Mon, Feb 28, 2022 at 8:49 AM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Monday, February 28, 2022 11:34 AM Amit Kapila
> wrote:
> > > On Sat, Feb 26, 2022 at 1:35 PM osumi.takami...@fujitsu.com
> > &
On Monday, February 28, 2022 11:34 AM Amit Kapila
wrote:
> On Sat, Feb 26, 2022 at 1:35 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Saturday, February 26, 2022 11:51 AM Amit Kapila
> wrote:
> > > I have reviewed the latest version and made a few changes a
On Saturday, February 26, 2022 11:51 AM Amit Kapila
wrote:
> I have reviewed the latest version and made a few changes along with fixing
> some of the pending comments by Peter Smith. The changes are as
> follows: (a) Removed m_databaseid in PgStat_MsgSubscriptionError as that is
> not required n
On Tuesday, February 22, 2022 3:03 PM Peter Smith wrote:
> Here are a couple more review comments for v21.
>
> ~~~
>
> 1. worker.c - comment
>
> + subform = (Form_pg_subscription) GETSTRUCT(tup);
> +
> + /*
> + * We would not be here unless this subscription's disableonerr field
> + was
> + * t
On Wednesday, February 23, 2022 6:52 PM Tang, Haiying/唐 海英
wrote:
> I have a comment on v21 patch.
>
> I wonder if we really need subscription s2 in 028_disable_on_error.pl. I
> think for
> subscription s2, we only tested some normal cases(which could be tested with
> s1), and didn't test any e
On Thursday, February 24, 2022 4:50 PM Masahiko Sawada
wrote:
> On Tue, Feb 22, 2022 at 3:03 PM Peter Smith
> wrote:
> >
> > ~~~
> >
> > 1. worker.c - comment
> >
> > + subform = (Form_pg_subscription) GETSTRUCT(tup);
> > +
> > + /*
> > + * We would not be here unless this subscription's disable
On Thursday, February 24, 2022 8:09 PM Amit Kapila
> On Thu, Feb 24, 2022 at 1:20 PM Masahiko Sawada
> wrote:
> > + /*
> > +* Log the error that caused DisableSubscriptionOnError to be
> called. We
> > +* do this immediately so that it won't be lost if some other
> > intern
On Friday, February 25, 2022 12:57 PM Amit Kapila
wrote:
> On Thu, Feb 24, 2022 at 6:30 PM Masahiko Sawada
> wrote:
> >
> > On Thu, Feb 24, 2022 at 8:08 PM Amit Kapila
> wrote:
> > >
> > > On Thu, Feb 24, 2022 at 1:20 PM Masahiko Sawada
> wrote:
> > > >
> > > > Here are some comments:
> > > >
On Wednesday, February 23, 2022 3:30 PM Amit Kapila
> On Tue, Feb 22, 2022 at 6:45 AM tanghy.f...@fujitsu.com
> wrote:
> >
> > I found a problem when using it. When a replication workers exits, the
> > transaction stats should be sent to stats collector if they were not
> > sent before because it
On Thursday, February 24, 2022 11:07 AM Masahiko Sawada
wrote:
> I have some comments on v23 patch:
>
> @@ -66,6 +66,12 @@ typedef struct LogicalRepWorker
> TimestampTz last_recv_time;
> XLogRecPtr reply_lsn;
> TimestampTz reply_time;
> +
> + /*
> +* Transaction statistics of
On Wednesday, February 23, 2022 6:52 PM Tang, Haiying/唐 海英
wrote:
> I have a comment on v21 patch.
>
> I wonder if we really need subscription s2 in 028_disable_on_error.pl. I
> think for
> subscription s2, we only tested some normal cases(which could be tested with
> s1), and didn't test any e
On Tuesday, February 22, 2022 11:47 PM Masahiko Sawada
wrote:
> On Tue, Feb 22, 2022 at 9:22 PM osumi.takami...@fujitsu.com
> wrote:
> > (4) doc/src/sgml/monitoring.sgml
> >
> >
> > role="column_definition">
> > -
On Tuesday, February 22, 2022 2:45 PM Masahiko Sawada
wrote:
> I've attached a patch that changes pg_stat_subscription_workers view.
> It removes non-cumulative values such as error details such as error-XID and
> the error message from the view, and consequently the view now has only
> cumulativ
On Tuesday, February 22, 2022 7:53 AM Peter Smith wrote:
> On Mon, Feb 21, 2022 at 11:44 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Monday, February 21, 2022 2:56 PM Peter Smith
> wrote:
> > > Thanks for addressing my previous comments. Now I have looked a
On Tuesday, February 22, 2022 10:15 AM Tang, Haiying/唐 海英
wrote:
> On Mon, Feb 21, 2022 11:46 AM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Saturday, February 19, 2022 12:00 AM osumi.takami...@fujitsu.com
> > wrote:
> > > On Friday, February 18
On Monday, February 21, 2022 2:56 PM Peter Smith wrote:
> Thanks for addressing my previous comments. Now I have looked at v19.
>
> On Mon, Feb 21, 2022 at 11:25 AM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Friday, February 18, 2022 3:27 PM Peter Smith
> wr
On Monday, February 21, 2022 6:06 PM Monday, February 21, 2022 6:06 PM wrote:
> On Mon, Feb 21, 2022 11:46 AM Osumi, Takamichi/大墨 昂道
> wrote:
> >I've addressed this point in a new v23 patch, since there was no opinion on
> this so far.
> >Kindly have a look at the attached one.
> Thanks for updati
On Saturday, February 19, 2022 12:00 AM osumi.takami...@fujitsu.com
wrote:
> On Friday, February 18, 2022 3:34 PM Tang, Haiying/唐 海英
> wrote:
> > On Wed, Jan 12, 2022 8:35 PM osumi.takami...@fujitsu.com
> > wrote:
> > 4) I noticed that the abort_count doesn
On Friday, February 18, 2022 3:27 PM Peter Smith wrote:
> Hi. Below are my code review comments for v18.
Thank you for your review !
> ==
>
> 1. Commit Message - wording
>
> BEFORE
> To partially remedy the situation, adding a new subscription_parameter named
> 'disable_on_error'.
>
>
On Friday, February 18, 2022 3:34 PM Tang, Haiying/唐 海英
wrote:
> On Wed, Jan 12, 2022 8:35 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > The attached v21 has a couple of other minor updates like a
> > modification of error message text.
> >
> >
>
&g
On Friday, February 18, 2022 8:11 PM Amit Kapila
wrote:
> On Fri, Feb 18, 2022 at 2:04 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Thursday, February 17, 2022 6:45 PM Amit Kapila
> wrote:
> > > On Thu, Feb 17, 2022 at 3:13 PM Amit Kapila
> >
On Friday, February 18, 2022 6:18 PM Amit Kapila
wrote:
> On Tue, Feb 8, 2022 at 5:27 AM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Friday, August 13, 2021 8:01 PM Ajin Cherian wrote:
> > > On Mon, Aug 2, 2021 at 7:20 PM Amit Kapila
> > > wrote:
On Thursday, February 17, 2022 6:45 PM Amit Kapila
wrote:
> On Thu, Feb 17, 2022 at 3:13 PM Amit Kapila
> wrote:
> >
> > On Tue, Jan 4, 2022 at 5:22 PM osumi.takami...@fujitsu.com
> > wrote:
> > >
> > > On Friday, December 31, 2021 10:12 AM Tang, Haiyi
On Tuesday, February 15, 2022 2:19 PM I wrote
> On Monday, February 14, 2022 8:58 PM Amit Kapila
> > 2. Can we move the code related to tablesync worker and its error
> > handing (the code insider if (am_tablesync_worker())) to a separate
> > function say
> > LogicalRepHandleTableSync() or somethin
Hi
I'll quote one other remaining discussion of this thread again
to invoke more attentions from the community.
On Friday, August 13, 2021 8:01 PM Ajin Cherian wrote:
> On Mon, Aug 2, 2021 at 7:20 PM Amit Kapila
> wrote:
> > Few other miscellaneous comments:
> > 1.
> > static void
> > pgoutput
On Monday, February 14, 2022 8:58 PM Amit Kapila
wrote:
> On Thu, Jan 6, 2022 at 11:23 AM osumi.takami...@fujitsu.com
> wrote:
> >
> > Kindly have a look at the attached v16.
> >
>
> Few comments:
Hi, thank you for checking the patch !
>
Hi,
Thank you for your updating the patch.
I'll quote one of the past discussions
in order to make this thread go forward or more active.
On Friday, August 13, 2021 8:01 PM Ajin Cherian wrote:
> On Mon, Aug 2, 2021 at 7:20 PM Amit Kapila
> wrote:
> >
> > On Fri, Jul 23, 2021 at 3:39 PM Ajin Ch
On Thursday, January 27, 2022 9:57 PM Ajin Cherian wrote:
Hi, thanks for your patch update.
> On Wed, Jan 26, 2022 at 8:33 PM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Tuesday, January 11, 2022 6:43 PM Ajin Cherian
> wrote:
> > (3) Is this patch's repons
On Tuesday, January 11, 2022 6:43 PM From: Ajin Cherian
wrote:
> Minor update to rebase the patch so that it applies clean on HEAD.
Hi, let me share some additional comments on v16.
(1) comment of pgoutput_change
@@ -630,11 +688,15 @@ pgoutput_change(LogicalDecodingContext *ctx,
ReorderBuffer
On Tuesday, January 11, 2022 6:43 PM Ajin Cherian wrote:
> Minor update to rebase the patch so that it applies clean on HEAD.
Hi, thanks for you rebase.
Several comments.
(1) the commit message
"
transactions, keepalive messages are sent to keep the LSN locations updated
on the standby.
This pa
On Friday, January 21, 2022 2:30 PM Amit Kapila wrote:
> On Fri, Jan 21, 2022 at 10:32 AM osumi.takami...@fujitsu.com
> wrote:
> >
> > On Friday, January 21, 2022 12:08 PM Masahiko Sawada
> wrote:
> > > I've attached an updated patch that incorporated th
On Friday, January 21, 2022 12:08 PM Masahiko Sawada
wrote:
> I've attached an updated patch that incorporated these commends as well as
> other comments I got so far.
Thank you for your update !
Few minor comments.
(1) trivial question
For the users,
was it perfectly clear that in the cascadi
On Tuesday, January 18, 2022 3:05 PM Masahiko Sawada
wrote:
> I've attached a rebased patch.
Thank you for your rebase !
Several review comments on v8.
(1) doc/src/sgml/logical-replication.sgml
+
+
+ To resolve conflicts, you need to consider changing the data on the
subscriber so
+ tha
On Tuesday, January 18, 2022 1:39 PM Masahiko Sawada
wrote:
> I've attached an updated patch. All comments I got so far were incorporated
> into this patch unless I'm missing something.
Hi, thank you for your new patch v7.
For your information, I've encountered a failure to apply patch v7
on top
1 - 100 of 341 matches
Mail list logo
