RE: Optionally automatically disable logical replication subscriptions on error

[osumi.takami...@fujitsu.com]

On Monday, March 7, 2022 12:01 PM Shi, Yu/侍 雨 <shiy.f...@fujitsu.com> wrote:
> On Wed, Mar 2, 2022 5:39 PM osumi.takami...@fujitsu.com
> <osumi.takami...@fujitsu.com> wrote:
> >
> > Attached an updated patch v26.
> >
> 
> Thanks for your patch. A comment on the document.
Hi, thank you for checking my patch !


> @@ -7771,6 +7771,16 @@ SCRAM-SHA-256$<replaceable>&lt;iteration
> count&gt;</replaceable>:<replaceable>&l
> 
>       <row>
>        <entry role="catalog_table_entry"><para role="column_definition">
> +       <structfield>subdisableonerr</structfield> <type>bool</type>
> +      </para>
> +      <para>
> +       If true, the subscription will be disabled if one of its workers
> +       detects an error
> +      </para></entry>
> +     </row>
> +
> +     <row>
> +      <entry role="catalog_table_entry"><para role="column_definition">
>         <structfield>subconninfo</structfield> <type>text</type>
>        </para>
>        <para>
> 
> The document for "subdisableonerr" option is placed after "The following
> parameters control what happens during subscription creation: ". I think it
> should be placed after "The following parameters control the subscription's
> replication behavior after it has been created: ", right?
Addressed your comment for create_subscription.sgml
(not for catalogs.sgml).

Attached an updated patch v28.


Best Regards,
        Takamichi Osumi

v28-0001-Optionally-disable-subscriptions-on-error.patch
Description: v28-0001-Optionally-disable-subscriptions-on-error.patch