On Thursday, February 24, 2022 8:09 PM Amit Kapila <amit.kapil...@gmail.com> > On Thu, Feb 24, 2022 at 1:20 PM Masahiko Sawada > <sawada.m...@gmail.com> wrote: > > + /* > > + * Log the error that caused DisableSubscriptionOnError to be > called. We > > + * do this immediately so that it won't be lost if some other > > internal > > + * error occurs in the following code. > > + */ > > + EmitErrorReport(); > > + AbortOutOfAnyTransaction(); > > + FlushErrorState(); > > > > Do we need to hold interrupts during cleanup here? > > > > I think so. We do prevent interrupts via > HOLD_INTERRUPTS/RESUME_INTERRUPTS during cleanup. Fixed.
Kindly have a look at v22 shared in [1]. [1] - https://www.postgresql.org/message-id/TYCPR01MB8373D9B26F988307B0D3FE20ED3E9%40TYCPR01MB8373.jpnprd01.prod.outlook.com Best Regards, Takamichi Osumi
