On Tuesday, August 9, 2022 12:59 AM Önder Kalacı <onderkal...@gmail.com> wrote: > Attaching v5 of the patch which reflects the review on this email, also few > minor test improvements. Hi,
Thank you for the updated patch. FYI, I noticed that v5 causes cfbot failure in [1]. Could you please fix it in the next version ? [19:44:38.420] execReplication.c: In function ‘RelationFindReplTupleByIndex’: [19:44:38.420] execReplication.c:186:24: error: ‘eq’ may be used uninitialized in this function [-Werror=maybe-uninitialized] [19:44:38.420] 186 | if (!indisunique && !tuples_equal(outslot, searchslot, eq)) [19:44:38.420] | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [19:44:38.420] cc1: all warnings being treated as errors [1] - https://cirrus-ci.com/task/6544573026533376 Best Regards, Takamichi Osumi