Add LZ4 compression in pg_dump

providing debug information on those, as well as native speaker wording. Cheers, //GeorgiosFrom 8dfe12b08378571add6e1d178bed97a61e988593 Mon Sep 17 00:00:00 2001 From: Georgios Kokolatos Date: Mon, 22 Nov 2021 09:58:49 + Subject: [PATCH v1 1/2] Prepare pg_dump for additional compression met

Re: psql: \dl+ to list large objects privileges

List of relations Schema | Name| Type | Owner | Table | Persistence | Access method | Size| Description Since '\dl' already contains description, it might be worthwhile to consider to add the column `Access privileges` without introducing a verbose version. Thoughts? Cheers, //Georgios

Re: psql: \dl+ to list large objects privileges

g the above as: show_verbose = strchr(cmd, '+') ? true : false; else if (strcmp(cmd + 3, "list") == 0 success = do_lo_list(show_verbose); Thoughts? Cheers, //Georgios

Introduce pg_receivewal gzip compression tests

ments. Finally the integrity of the compressed files is verified. I hope you find this useful. Cheers, //Georgios [1] https://www.postgresql.org/message-id/flat/ZCm1J5vfyQ2E6dYvXz8si39HQ2gwxSZ3IpYaVgYa3lUwY88SLapx9EEnOf5uEwrddhx2twG7zYKjVeuP5MwZXCNPybtsGouDsAD1o2L_I5E%3D%40pm.me v1-0001-Intr

Re: Allow batched insert during cross-partition updates

‐‐‐ Original Message ‐‐‐ On Wednesday, March 10, 2021 1:23 PM, Georgios wrote: > > > Hi, > > ‐‐‐ Original Message ‐‐‐ > On Thursday, February 18, 2021 10:54 AM, Amit Langote amitlangot...@gmail.com > wrote: > > > On Thu, Feb 18, 2021 at 6

Re: Allow batched insert during cross-partition updates

Hi, ‐‐‐ Original Message ‐‐‐ On Thursday, February 18, 2021 10:54 AM, Amit Langote wrote: > On Thu, Feb 18, 2021 at 6:52 PM Amit Langote amitlangot...@gmail.com wrote: > > > Based on the discussion at: > > https://www.postgresql.org/message-id/6929d485-2d2a-da46-3681-4a400a3d794f%40en

Re: Allow batched insert during cross-partition updates

PartitionTupleRouting and not add a couple of functions to get the necessary info? If I have read the code correctly the only members actually needed to be exposed are num_partitions and partitions. Not a critique, I am just curious. Cheers, //Georgios

Re: [PATCH] postgres-fdw: column option to override foreign types

of columns, reordered, and names changed, a little opt-in flexibility with types too doesn't seem misplaced. end quote. I will add that creating a view on the remote server with type flexibility that you wish and then create foreign tables against the view, might address your problem. Respectfully, //Georgios

Re: Shared memory size computation oversight?

> makes it clear what's its purpose. My limited opinion on the matter after spending some time yesterday through the related code, is that with the current api it is easy to miss something and underestimate or just be sloppy. If only from the r

Re: Shared memory size computation oversight?

ixed rather vaguely with this patch. I am not claiming that increasing the memory used by the elements is not needed, I am claiming that I can not clearly see how is that specific increase needed. Thank you for your patience, //Georgios -- https://www.vmware.com > > [1] https://forums.postgresql.fr/viewtopic.php?pid=32138#p32138 sorry, it's > all > in French.

Re: GROUP BY DISTINCT

‐‐‐ Original Message ‐‐‐ On Tuesday, March 2, 2021 5:51 PM, Vik Fearing wrote: > On 3/2/21 4:06 PM, Georgios Kokolatos wrote: > > > As a minor gripe, I would note the addition of list_int_cmp. > > The block > > > > - /* S

Re: GROUP BY DISTINCT

The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested Hi, this is a useful feature, thank you for implementing. I gather that it f

Re: Error on failed COMMIT

Hi, this patch fails on the cfbot yet it has received an update during the current CF. I will move it to the next CF and mark it there as Waiting on Author. Cheers, Georgios The new status of this patch is: Needs review

Re: Display individual query in pg_stat_activity

This patch fails in the cfbot for quite some time now. I shall close it as Return With Feedback and not move it to the next CF. Please feel free to register an updated version afresh for the next CF. Cheers, //Georgios

Re: Supporting = operator in gin/gist_trgm_ops

‐‐‐ Original Message ‐‐‐ On Friday, November 13, 2020 10:50 AM, Julien Rouhaud wrote: > On Wed, Nov 11, 2020 at 8:34 PM Georgios Kokolatos > gkokola...@protonmail.com wrote: > > > The following review has been posted through the commitfest application: > > ma

Re: Add session statistics to pg_stat_database

‐‐‐ Original Message ‐‐‐ On Thursday, November 12, 2020 9:31 AM, Laurenz Albe wrote: > I wrote: > > > On Tue, 2020-11-10 at 15:03 +0000, Georgios Kokolatos wrote: > > > > > I noticed that the cfbot fails for this patch. > > > For this, I am setti

Re: Supporting = operator in gin/gist_trgm_ops

x. This is gin_extract_value_trgm() and is indeed using generate_trgm(). I have no opinion over Alexander's second comment regarding costing. I change the status to 'Waiting on Author', but please feel free to override my opinion if you feel I am wrong and reset it to 'Needs review&

Re: SQL-standard function body

Hi, I noticed that this patch fails on the cfbot. For this, I changed the status to: 'Waiting on Author'. Cheers, //Georgios The new status of this patch is: Waiting on Author

Re: Error on failed COMMIT

Hi, I noticed that this patch fails on the cfbot. For this, I changed the status to: 'Waiting on Author'. Cheers, //Georgios The new status of this patch is: Waiting on Author

Re: WIP: System Versioned Temporal Table

Hi, just a quick comment that this patch fails on the cfbot. Cheers, //Georgios

Re: Allow an alias to be attached directly to a JOIN ... USING

Hi, I noticed that this patch fails on the cfbot. For this, I changed the status to: 'Waiting on Author'. Cheers, //Georgios The new status of this patch is: Waiting on Author

Re: [PATCH] Add extra statistics to explain for Nested Loop

Hi, I noticed that this patch fails on the cfbot. For this, I changed the status to: 'Waiting on Author'. Cheers, //Georgios The new status of this patch is: Waiting on Author

Re: Get memory contexts of an arbitrary backend process

Hi, I noticed that this patch fails on the cfbot. For this, I changed the status to: 'Waiting on Author'. Cheers, //Georgios The new status of this patch is: Waiting on Author

Re: Display individual query in pg_stat_activity

Hi, I noticed that this patch is failing on the cfbot. For this, I changed the status to: 'Waiting on Author' Cheers, Georgios The new status of this patch is: Waiting on Author

Re: Add session statistics to pg_stat_database

Hi, I noticed that the cfbot fails for this patch. For this, I am setting the status to: 'Waiting on Author'. Cheers, //Georgios The new status of this patch is: Waiting on Author

Re: Strange behavior with polygon and NaN

changing the status to "Ready for Committer". For what little is worth, I learned a lot from this patch, thank you. Cheers, Georgios The new status of this patch is: Ready for Committer

Re: Error on failed COMMIT

Hi, thank you for your contribution. I did notice that the cfbot [1] is failing for this patch. Please try to address the issue for the upcoming commitfest. Cheers, //Georgios [1] http://cfbot.cputube.org/dave-cramer.html

Re: pg_upgrade analyze script

Hi, thank you for you contribution. I did notice that the cfbot [1] is failing for this patch. Please try to address the issues for the upcoming Commitfest. Cheers, //Georgios [1] http://cfbot.cputube.org/magnus-hagander.html

Re: Extending range type operators to cope with elements

Hi, thank you for your contribution. I did notice that the cfbot [1] is failing for this patch. Please try to address the issues if you can for the upcoming commitfest. Cheers, //Georgios [1] http://cfbot.cputube.org/esteban-zimanyi.html

Re: Consistent error reporting for encryption/decryption in pgcrypto

Hi, thank you for your contribution. I did notice that the cfbot [1] is not failing for this patch. Cheers, //Georgios [1] http://cfbot.cputube.org/daniel-gustafsson.html

Re: shared-memory based stats collector

Hi, I noticed that according to the cfbot this patch no longer applies. As it is registered in the upcoming commitfest, it would be appreciated if you could rebase it. Cheers, //Georgios

Re: New default role- 'pg_read_all_data'

Hi, this patch is in "Ready for committer" state and the Cfbot is happy. Is there any committer that is available for taking a look at it? Cheers, //Georgios - CFM 2020-11

Re: v13: show extended stats target in \d

‐‐‐ Original Message ‐‐‐ On Thursday, 10 September 2020 00:36, Justin Pryzby wrote: > On Tue, Sep 01, 2020 at 12:35:19PM +0000, Georgios Kokolatos wrote: > > > I will humbly disagree with the current review. I shall refrain from > > changing the status though bec

Re: v13: show extended stats target in \d

added in the documentation. Have you considered adding something in doc/src/sgml/ref/psql-ref.sgml? If no, will you consider it? If yes, why did you discard it? Regards, Georgios

Re: New default role- 'pg_read_all_data'

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: not tested Spec compliant: not tested Documentation:not tested Version 2 of the patch, implements a useful feature. Based on the mailing

Re: Include access method in listTables output

‐‐‐ Original Message ‐‐‐ On Tuesday, 1 September 2020 07:41, Michael Paquier wrote: > On Thu, Aug 20, 2020 at 08:16:19AM +0000, Georgios wrote: > > > Please find version 7 attached which hopefully addresses the error along > > with a proper > > expansion

Re: [PATCH] - Provide robust alternatives for replace_string

‐‐‐ Original Message ‐‐‐ On Wednesday, 19 August 2020 11:07, Georgios wrote: > > > ‐‐‐ Original Message ‐‐‐ > On Friday, 7 August 2020 09:02, Asim Praveen pa...@vmware.com wrote: > > > > On 05-Aug-2020, at 7:01 PM, Alvaro Herrera alvhe...@2ndquadrant.

Re: New default role- 'pg_read_all_data'

Thank you for the patch. My high level review comment: The patch seems to be implementing a useful and requested feature. The patch applies cleanly and passes the basic regress tests. Also the commitfest bot is happy. A first pass at the code, has not revealed any worthwhile comments. Please all

Re: Include access method in listTables output

added it. > > Attached a new patch for the same. > > I felt patch is in shape for committer to have a look at this. > > The patch tester shows it's failing xmllint ; could you send a fixed patch ? > > /usr/bin/xmllint --path . --noout --valid postgres.sgml > ref/

Re: [PATCH] - Provide robust alternatives for replace_string

ht become a bit slow in large files. Please find v3 which simply continues reading the line if fgets fills the buffer and there is still data to read. Also this version, implements Alvaro's suggestion to break API compatibility. To that extent, ecpg regress has been slightly modified to use the

[PATCH] - Provide robust alternatives for replace_string

test suits. It should not hurt to do a bit better though. //Asim and Georgios 0001-Use-stringInfo-instead-of-char-in-replace_string.patch Description: Binary data 0001-Heap-allocated-string-version-of-replace_string.patch Description: Binary data

Re: Include access method in listTables output

‐‐‐ Original Message ‐‐‐ On Saturday, July 25, 2020 2:41 AM, vignesh C wrote: > On Thu, Jul 16, 2020 at 7:35 PM Georgios gkokola...@protonmail.com wrote: > > > ‐‐‐ Original Message ‐‐‐ > > On Saturday, July 11, 2020 3:16 PM, vignesh C vignes...@gmail.com w

Re: Using Valgrind to detect faulty buffer accesses (no pin or buffer content lock held)

‐‐‐ Original Message ‐‐‐ On Tuesday, July 21, 2020 11:52 PM, Peter Geoghegan wrote: > On Mon, Jul 6, 2020 at 1:35 AM Georgios Kokolatos > gkokola...@protonmail.com wrote: > > > As a general overview, the series of patches in the mail thread do match > > t

Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

apply the same here. The expression in the branch is already asserted for in macro, why not switch there and remove the responsibility from the caller? Any thoughts on the above? Cheers, Georgios The new status of this patch is: Waiting on Author

Re: Include access method in listTables output

‐‐‐ Original Message ‐‐‐ On Saturday, July 11, 2020 3:16 PM, vignesh C wrote: > On Mon, Jul 6, 2020 at 1:24 PM Georgios gkokola...@protonmail.com wrote: > > > ‐‐‐ Original Message ‐‐‐ > > On Monday, July 6, 2020 3:12 AM, Michael Paquier mich...@paquier.xyz w

Re: Using Valgrind to detect faulty buffer accesses (no pin or buffer content lock held)

As a general overview, the series of patches in the mail thread do match their description. The addition of the stricter, explicit use of instrumentation does improve the design as the distinction of the use cases requiring a pin or a lock is made more clear. The added commentary is descriptive

Re: Include access method in listTables output

‐‐‐ Original Message ‐‐‐ On Monday, July 6, 2020 3:12 AM, Michael Paquier wrote: > On Sun, Jul 05, 2020 at 07:13:10AM +0530, vignesh C wrote: > > > I'm not sure if we should include showViews, I had seen that the > > access method was not getting selected for view. > > +1. These have no

Re: Include access method in listTables output

‐‐‐ Original Message ‐‐‐ On Saturday, June 20, 2020 3:15 PM, vignesh C wrote: > On Tue, Jun 16, 2020 at 6:13 PM Georgios gkokola...@protonmail.com wrote: > > > > Few comments: > > > > > > - if (pset.sversion >= 12) > > > > > &

Use TableAm API in pg_table_size

calculate_relation_size can be adapted to call into the TableAm for those kinds of relations that makes sense. If agreed, a more complete patch can be provided. Cheers, //Georgios 0001-Use-tableam-for-pg_table_size.patch Description: Binary data

Re: Include access method in listTables output

‐‐‐ Original Message ‐‐‐ On Monday, June 15, 2020 3:20 AM, vignesh C wrote: > On Tue, Jun 9, 2020 at 6:45 PM Georgios gkokola...@protonmail.com wrote: > > > > > > > Please add it to the commitfest at https://commitfest.postgresql.org/28/ > > > > Than

Re: Relation wide 'LIKE' clause

‐‐‐ Original Message ‐‐‐ On Wednesday, June 10, 2020 12:08 PM, Peter Eisentraut wrote: > On 2020-06-10 11:42, Georgios wrote: > > > Postgres create table statement supports `LIKE source_table [like_option... > > ]` > > to specify `a table from which the

Relation wide 'LIKE' clause

parameters that interact both at relation and column level, especially when the source relation is column oriented. If the possibility for such a statment is not discarded, a patch can be readily provided. Cheers, //Georgios [1] https://www.postgresql.org/docs/13/sql-createtable.html

Re: Include access method in listTables output

‐‐‐ Original Message ‐‐‐ On Tuesday, June 9, 2020 1:34 PM, David Rowley wrote: > On Tue, 9 Jun 2020 at 23:03, Georgios gkokola...@protonmail.com wrote: > > > A small patch is attached [1] to see if you think it makes sense. I have > > not included any > >

Include access method in listTables output

as needed. Cheers, //Georgios 0001-Include-AM-in-listTables-output.patch Description: Binary data

Re: Refactor compile-time assertion checks for C/C++

Thank you for updating the status of the issue. I have to admit that I completely missed the CF bot. Lesson learned. For whatever is worth, my previous comment that the patch improves readability also applies to the updated version of the patch. The CF bot seems happy now, which means that your

Re: ALTER TEXT SEARCH DICTIONARY tab completion

The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested It looks good and does what it says on the tin. One minor nitpick I feel I s

Re: Refactor compile-time assertion checks for C/C++

The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested In my humble opinion the patch improves readability, hence gets my +1. No fu

Re: Duplicate Workers entries in some EXPLAIN plans

The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested > Ah, I see. I think I got that from ExplainPrintSettings. I've > corrected m

Re: Duplicate Workers entries in some EXPLAIN plans

>> + int num_workers = planstate->worker_instrument->num_workers; >> + int n; >> + worker_strs = (StringInfo *) palloc0(num_workers * >> sizeof(StringInfo)); >> + for (n = 0; n < num_workers; n++) { >> >> I think C99 would be better here. Also no parenthesis needed. > > > P

Re: Duplicate Workers entries in some EXPLAIN plans

tern void ExplainCloseWorker(ExplainState *es); +extern void ExplainFlushWorkers(StringInfo *worker_strs, int num_workers, ExplainState *es); No need to expose those, is there? I feel there should be static. Awaiting for answer or resolution of these comments to change the status. //Georgios

Re: Duplicate Workers entries in some EXPLAIN plans

> Sounds good, I'll try that format. Any idea how to test YAML? With the > JSON format, I was able to rely on Postgres' own JSON-manipulating > functions to strip or canonicalize fields that can vary across > executions--I can't really do that with YAML. Yes, this approach was clear in the patch

Re: Duplicate Workers entries in some EXPLAIN plans

The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: not tested Spec compliant: not tested Documentation:not tested The current version of the patch (v2) applies cleanly and does what it sa

Re: Duplicate Workers entries in some EXPLAIN plans

The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested This is a high level review only. However, seeing that there is a conflict an

Re: CPU costs of random_zipfian in pgbench

The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested Version 3 of the patch looks ready for committer. Thank you for taking the t

Re: CPU costs of random_zipfian in pgbench

The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested For whatever it is worth, the patch looks good to me. A minor nitpick would

Re: Adding a TAP test checking data consistency on standby with minRecoveryPoint

Hi, you are right in saying that my comment didn't offer much of a constructive explanation. Apologies for that. To the issue at hand. Tests were run in the same manner as in all other cases and the test in question was the only one to fail in the whole tree. By looking a bit closer to the err

Re: Adding a TAP test checking data consistency on standby with minRecoveryPoint

Hi, I applied the patch on current master and run the tests, but I am afraid that the newly introduced test failed on installcheck-world: ```t/016_min_consistency.pl . # Looks like your test exited with 29 before it could output anything. t/016_min_consistency.pl . Dubio

Re: Tighten error control for OpenTransientFile/CloseTransientFile

The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: not tested Spec compliant: not tested Documentation:not tested The second version of this patch seems to be in order and ready for commi

Re: Tighten error control for OpenTransientFile/CloseTransientFile

Overall the patch looks good and according to the previous discussion fulfils its purpose. It might be worthwhile to also check for errors on close in SaveSlotToPath(). pgstat_report_wait_end(); CloseTransientFile(fd); /* rename to permanent file, fsync file and directo