‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Wednesday, 19 August 2020 11:07, Georgios <gkokola...@protonmail.com> wrote:
> > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ > On Friday, 7 August 2020 09:02, Asim Praveen pa...@vmware.com wrote: > > > > On 05-Aug-2020, at 7:01 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: > > > On 2020-Aug-05, Asim Praveen wrote: > > > > > > > Please find attached a StringInfo based solution to this problem. It > > > > uses fgetln instead of fgets such that a line is read in full, without > > > > ever splitting it. > > > > > > never heard of fgetln, my system doesn't have a manpage for it, and we > > > don't use it anywhere AFAICS. Are you planning to add something to > > > src/common for it? > > > > Indeed! I noticed fgetln on the man page of fgets and used it without > > checking. And this happened on a MacOS system. > > Please find a revised version that uses fgetc instead. > > Although not an issue in the current branch, fgetc might become a bit slow > in large files. Please find v3 which simply continues reading the line if > fgets fills the buffer and there is still data to read. > > Also this version, implements Alvaro's suggestion to break API compatibility. > > To that extent, ecpg regress has been slightly modified to use the new version > of replace_string() where needed, or remove it all together where possible. I noticed that the cfbot [1] was unhappy with the raw use of __attribute__ on windows builds. In retrospect it is rather obvious it would complain. Please find v4 attached. //Georgios > > //Georgios > > > Asim [1] https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.105985
v4-0001-Use-a-stringInfo-instead-of-a-char-for-replace_st.patch
Description: Binary data
