‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Saturday, June 20, 2020 3:15 PM, vignesh C <vignes...@gmail.com> wrote:
> On Tue, Jun 16, 2020 at 6:13 PM Georgios gkokola...@protonmail.com wrote: > > > > Few comments: > > > > > > - if (pset.sversion >= 120000) > > > > > > - appendPQExpBufferStr(&buf, > > > > > > - "\n LEFT JOIN pg_catalog.pg_am am ON am.oid = c.relam"); > > > Should we include pset.hide_tableam check along with the version > > > check? > > > > > > > I opted against it, since it seems more intuitive to have a single > > switch and placed on the display part. A similar pattern can be found > > in describeOneTableDetails(). I do not hold a strong opinion and will > > gladly ament if insisted upon. > > I felt we could add that check as we might be including > pg_catalog.pg_am in cases even though we really don't need it. As promised, I gladly ament upon your request. Also included a fix for a minor oversight in tests, they should now be stable. Finally in this version, I extended a bit the logic to only include the access method column if the relations displayed can have one, for example sequences. > > Regards, > Vignesh > EnterpriseDB: http://www.enterprisedb.com
0001-Include-AM-in-listTables-output-v3.patch
Description: Binary data
