On 2025-05-02 09:02, Fujii Masao wrote:
On 2025/05/02 2:27, Fujii Masao wrote:
On 2025/05/01 21:42, Robert Haas wrote:
On Thu, May 1, 2025 at 3:53 AM Fujii Masao
wrote:
Just idea, what do you think about adding a flag to indicate whether
ProcessLogMemoryContextInterrupt() is currently runni
On Fri, 2 May 2025 at 10:11, Xuneng Zhou wrote:
>
> Hi,
> Is this an expected behavior?
>
> A race between subscriber LSN feedback and publisher subscription change
> processing allows the walsender to restart decoding past relevant WAL
> records, bypassing the updated subscription rules for tho
Xuneng Zhou writes:
> Is this an expected behavior?
I'm wondering that too. I don't see how the repro method Vignesh
describes could correspond to a simple timing issue. It smells
like there's a bug here somewhere.
regards, tom lane
On Thu, May 1, 2025 at 7:35 PM Tom Lane wrote:
>
> Bruce Momjian writes:
> > On Thu, May 1, 2025 at 11:05:56AM +0530, Dilip Kumar wrote:
> >> Does it make sense to load "shared_preload_libraries" during binary
> >> upgrade mode?
>
> > Well, the library might be required to load the data. Why wo
Hi,
Is this an expected behavior?
A race between subscriber LSN feedback and publisher subscription change
processing allows the walsender to restart decoding past relevant WAL
records, bypassing the updated subscription rules for those records.
On Wed, 30 Apr 2025 at 17:41, Amit Kapila wrote:
Hi Bruce,
On Fri, May 2, 2025 at 11:44 AM Bruce Momjian wrote:
> I have committd the first draft of the PG 18 release notes.
>
> I will continue improving it until beta 1, and until the final release.
> I will probably add markup in 1-3 weeks. Let the feedback begin. ;-)
Thanks as always for w
On Fri, 2 May 2025 at 06:30, Tom Lane wrote:
>
> vignesh C writes:
> > I agree with your analysis. I was able to reproduce the issue by
> > delaying the invalidation of the subscription until the walsender
> > finished decoding the INSERT operation following the ALTER
> > SUBSCRIPTION through a d
+1, I was unable to reproduce this with lldb, not sure my way is
appropriate or not.
>
> Can you be a little more specific about how you reproduced this?
> I tried inserting sleep() calls in various likely-looking spots
> and could not get a failure that way.
>
> regards,
I have committd the first draft of the PG 18 release notes. The item
count looks strong:
release-7.4: 263
release-8.0: 230
release-8.1: 174
release-8.2: 215
release-8.3: 214
release-8.4: 314
release-9.0: 237
release-9.1: 203
hi.
catalog.sgml:
convalidated bool
Has the constraint been validated?
Currently, can be false only for foreign keys and CHECK constraints
with NOT NULL NOT VALID,
we need rephrase it to something like:
"Currently, can be false only fo
On Thu, May 01, 2025 at 09:14:50AM -0500, Nathan Bossart wrote:
> +1, I believe I've seen cases where loading the library was necessary and
> others where it breaks the upgrade. A one-size-fits-all approach probably
> won't work here.
Yes, it really depends on one's expections.
The area I known
vignesh C writes:
> I agree with your analysis. I was able to reproduce the issue by
> delaying the invalidation of the subscription until the walsender
> finished decoding the INSERT operation following the ALTER
> SUBSCRIPTION through a debugger and using the lsn from the pg_waldump
> of the INS
On 2025/05/02 2:27, Fujii Masao wrote:
On 2025/05/01 21:42, Robert Haas wrote:
On Thu, May 1, 2025 at 3:53 AM Fujii Masao wrote:
Just idea, what do you think about adding a flag to indicate whether
ProcessLogMemoryContextInterrupt() is currently running? Then,
when a backend receives a sig
On Thu, May 01, 2025 at 12:15:30PM -0700, Masahiko Sawada wrote:
> In light of these concerns, I've been contemplating alternative
> interface designs. One promising approach would involve registering
> custom copy formats via a C function during module loading
> (specifically, in _PG_init()). This
On Thu, 1 May 2025 at 13:08, Tom Lane wrote:
> Oh! That's an excellent point. The OP didn't mention if their tests
> were done before or after 3d0b4b1, but that might well matter.
The benchmarks we conducted are based on REL_17_2 branch which do not
include the TAS_SPIN(lock) change for ARM yet
On Thu, May 01, 2025 at 03:57:16PM -0500, Sami Imseih wrote:
> I think what we should really allow the broader scope of expressions that
> are allowed via prepared statements, and this will make this implementation
> consistent between prepared vs non-prepared statements. I don't see why
> not. In
On Thu, May 01, 2025 at 04:08:06PM -0400, Tom Lane wrote:
> Nathan Bossart writes:
>> ... commit 3d0b4b1 recently added a non-locking
>> initial test in AArch64's TAS_SPIN, so I wonder if the ISB is still
>> appropriate. It'd be interesting to see the performance difference of
>> removing the ISB
On May 1, 2025, at 16:24, Peter Eisentraut wrote:
> I see. I have committed it now describing the current state.
>
> Btw., the shown directory names that illustrate how "postgresql" is appended
> were not correct. I have corrected that.
Thank you. I gotta say I find them confusing TBH.
Best,
I spent a few hours looking into this today and to your points below:
> > I agree that the current solution we have in the tree feels incomplete
> > because we are not taking into account the most common cases that
> > users would care about. Now, allowing PARAM_EXTERN means that we
> > allow any
On Mon, Apr 21, 2025 at 9:57 AM Jacob Champion
wrote:
> So to recap: I'm happy to add a Google compatibility mode, but I'd
> like to gather some evidence that their device flow can actually
> authorize tokens for third parties safely, before we commit to that.
> Thoughts?
Hi Ivan, I know the thre
Robert Haas writes:
> Consider:
> robert.haas=# create role alice;
> CREATE ROLE
> There is now a role called 'alice' and you have all of alice's
> privileges. But now consider:
> robert.haas=# create role admin createrole;
> CREATE ROLE
> robert.haas=# set role admin;
> SET
> robert.haas=> cre
On Thu, May 1, 2025 at 12:24 PM Jacob Champion
wrote:
> I'm running the attached fixup through CI now.
(Pushed, and indri is happy again.)
--Jacob
On 01.05.25 16:31, David E. Wheeler wrote:
On May 1, 2025, at 07:50, Peter Eisentraut wrote:
The documentation in config.sgml says:
Note that the path elements should typically end in
extension if the normal installation layouts are
followed.
So I think your change here between v
On Wed, Apr 30, 2025 at 4:29 PM Tom Lane wrote:
> I confess to not having paid close enough attention when
> these patches went in, or I would have complained about
> createrole_self_grant. It changes the user-visible behavior
> of SQL commands, specifically CREATE ROLE. We have learned
> over a
Nathan Bossart writes:
> ... commit 3d0b4b1 recently added a non-locking
> initial test in AArch64's TAS_SPIN, so I wonder if the ISB is still
> appropriate. It'd be interesting to see the performance difference of
> removing the ISB with and without commit 3d0b4b1 applied.
Oh! That's an excell
On Thu, May 01, 2025 at 02:48:59PM -0400, Tom Lane wrote:
> Robert Haas writes:
>> On Wed, Apr 30, 2025 at 4:53 AM Salvatore Dipietro
>> wrote:
>>> we would like to propose the removal of the Instruction
>>> Synchronization Barrier (isb) for aarch64 architectures. Based on our
>>> testing on Grav
> On Thu, May 01, 2025 at 09:29:13AM GMT, Michael Paquier wrote:
>
> I agree that the current solution we have in the tree feels incomplete
> because we are not taking into account the most common cases that
> users would care about. Now, allowing PARAM_EXTERN means that we
> allow any expression
I wrote:
> I still haven't figured out why this wasn't a problem in the old
> version of functions.c.
Oh, got it: I was misremembering the API contract for
tuplestore_gettupleslot. There are two possible ways for it to
load the slot with a tuple:
* tuple points into the tuplestore's memory, and
On Thu, May 1, 2025 at 10:38 AM Jacob Champion
wrote:
> I've thrown some more Autoconf testing at Rocky, Mac, and Ubuntu.
>
> So, committed.
I forgot --enable-nls in my Mac testing, so indri complains about my
omission of -lintl... I'd incorrectly thought it was no longer needed
after all the get
On Fri, Apr 25, 2025 at 5:45 AM Sutou Kouhei wrote:
>
> Hi,
>
> I've updated the patch set. See the attached v40 patch set.
>
> In
> "Re: Make COPY format extendable: Extract COPY TO format implementations"
> on Wed, 23 Apr 2025 23:44:55 -0700,
> Masahiko Sawada wrote:
>
> >> Are the follow
On 01.05.2025 16:37, Andrei Lepikhov wrote:
I still think that two meaningful digits are enough for an EXPLAIN. We
usually need to estimate the tuple set's size, not a precise number of
tuples or groups. And definitely, not an arbitrarily chosen two digits
after the point. So, IMO, good examp
On Thu, May 1, 2025 at 8:22 PM Andrei Lepikhov wrote:
> On 1/5/2025 14:11, Alexander Korotkov wrote:
> > 3. Should the ChangeVarNodesWalkExpression function return the walker's
> > returning value?
> >
> >
> > Done.
> Thanks for your efforts! Looks good to me.
Thank you. I'm going to pus
Robert Haas writes:
> On Wed, Apr 30, 2025 at 4:53 AM Salvatore Dipietro
> wrote:
>> we would like to propose the removal of the Instruction
>> Synchronization Barrier (isb) for aarch64 architectures. Based on our
>> testing on Graviton instances (m7g.16xlarge), we can see on average
>> over mult
On Wed, Apr 30, 2025 at 5:16 PM David G. Johnston
wrote:
> On Wed, Apr 30, 2025 at 1:29 PM Tom Lane wrote:
>> But don't we need to add
>>
>> createrole_self_grant to the set of GUCs that pg_dump[all]
>> resets in the emitted SQL?
>>
>
> The other approach would be to do what we do for the role op
On Wed, Apr 30, 2025 at 4:53 AM Salvatore Dipietro
wrote:
> we would like to propose the removal of the Instruction
> Synchronization Barrier (isb) for aarch64 architectures. Based on our
> testing on Graviton instances (m7g.16xlarge), we can see on average
> over multiple iterations up to 12% bet
Hello hackers,
Please take a look at the April report on buildfarm failures:
# SELECT br, count(*) FROM failures WHERE dt >= '2025-04-01' AND
dt < '2025-05-01' GROUP BY br;
REL_13_STABLE: 1
REL_14_STABLE: 2
REL_15_STABLE: 5
REL_16_STABLE: 7
REL_17_STABLE: 8
master: 261
-- Total: 284
(Counting t
On Wed, Apr 30, 2025 at 11:09 AM Daniel Gustafsson wrote:
> I'll try to kick the tyres a bit more as well.
Thanks! Alpine seems to be happy with the dlopen() arrangement. And
I've thrown some more Autoconf testing at Rocky, Mac, and Ubuntu.
So, committed. Thanks everyone for all the excellent fe
On 2025/05/01 21:42, Robert Haas wrote:
On Thu, May 1, 2025 at 3:53 AM Fujii Masao wrote:
Just idea, what do you think about adding a flag to indicate whether
ProcessLogMemoryContextInterrupt() is currently running? Then,
when a backend receives a signal and ProcessLogMemoryContextInterrupt(
On 1/5/2025 14:11, Alexander Korotkov wrote:
3. Should the ChangeVarNodesWalkExpression function return the walker's
returning value?
Done.
Thanks for your efforts! Looks good to me.
--
regards, Andrei Lepikhov
Hi,
I am unable to apply the patch on master. Can you please confirm if the patch
is rebased?
Regards,
Akshat Jaimini
On Thu, May 1, 2025 at 3:22 AM Peter Eisentraut wrote:
> On 30.04.25 17:17, Robert Treat wrote:
> > But otherwise this LGTM.
>
> Thanks, I have worked this into the commit. I wanted to get away from
> phrases like "needs to be rebuilt" or "must be rebuilt" because that
> possibly sounds like you
On Thu, May 01, 2025 at 05:13:07PM +0900, Fujii Masao wrote:
> On 2025/05/01 15:30, Erik Rijkers wrote:
>> It seems to me that, in doc/src/sgml/ref/pgupgrade.sgml, this phrase:
>>
>> "Because not all statistics are not transferred"
>>
>> should be:
>>
>> "Because not all statistics are tra
On May 1, 2025, at 07:50, Peter Eisentraut wrote:
> The documentation in config.sgml says:
>
>Note that the path elements should typically end in
>extension if the normal installation layouts are
>followed.
>
> So I think your change here between v3 and v4 is incorrect.
Right, sorr
I wrote:
> Hmm. What seems to be going on here is that once the aggfns_trans()
> result gets large enough that the SQL-function-result tuplestore
> decides to spill to disk, when we pull the result tuple back out
> of the tuplestore with tuplestore_gettupleslot we end up with the
> jf_resultSlot h
On Thu, May 01, 2025 at 10:05:48AM -0400, Tom Lane wrote:
> Bruce Momjian writes:
>> On Thu, May 1, 2025 at 11:05:56AM +0530, Dilip Kumar wrote:
>>> Does it make sense to load "shared_preload_libraries" during binary
>>> upgrade mode?
>
>> Well, the library might be required to load the data. W
Bruce Momjian writes:
> On Thu, May 1, 2025 at 11:05:56AM +0530, Dilip Kumar wrote:
>> Does it make sense to load "shared_preload_libraries" during binary
>> upgrade mode?
> Well, the library might be required to load the data. Why would we
> avoid it with no known error reports?
You could inv
On 5/1/25 14:22, Ilia Evdokimov wrote:
Estimated Hit Percent: 50.00
Any suggestions?
I still think that two meaningful digits are enough for an EXPLAIN. We
usually need to estimate the tuple set's size, not a precise number of
tuples or groups. And definitely, not an arbitrarily chosen tw
On Thu, May 1, 2025 at 11:05:56AM +0530, Dilip Kumar wrote:
> Does it make sense to load "shared_preload_libraries" during binary
> upgrade mode?
>
> An extension might unintentionally interfere with pg_upgrade, for
> example, by connecting to the 'postgres' database, which can cause the
> upgrad
Hi, Peter and Richard
On Thu, 01 May 2025 at 12:13, Peter Eisentraut wrote:
> On 30.04.25 17:48, Japin Li wrote:
>> While working on [1], I found outdated comments in IndexInfo.
>> The attached patch corrects them.
>> [1]
>> https://www.postgresql.org/message-id/2A40921D-83AB-411E-ADA6-7E509A46F
On Wed, Apr 30, 2025 at 6:56 PM Michael Paquier wrote:
> I'm actually rather scared of the patch, isn't there a risk of
> breaking existing patterns that worked out of the box by forcing the
> resowner to not be set? My spidey sense tingles when I see such
> patterns, because this is enforcing as
Hi,
On Thu, May 1, 2025 at 4:26 AM Michael Paquier wrote:
> On Wed, Apr 30, 2025 at 06:03:49PM -0400, Robert Haas wrote:
> > Sorry to turn up late here, but I strongly disagree with the notion
> > that this is a bug in the DSM or DSA code. It seems to me that it is
> > the caller's responsibilit
On Thu, May 1, 2025 at 3:53 AM Fujii Masao wrote:
> Just idea, what do you think about adding a flag to indicate whether
> ProcessLogMemoryContextInterrupt() is currently running? Then,
> when a backend receives a signal and ProcessLogMemoryContextInterrupt()
> is invoked, it can simply return imm
On 27.04.2025 22:58, Ilia Evdokimov wrote:
Therefore, I think it is better to report percentages directly. Since
non-text EXPLAIN formats do not display units, I propose to rename the
field to "hit_percent" in all formats, including the text format. This
way, the meaning of the value remains c
Hello,
I've been looking at this bug once again and I think I finally
understood what's going on and how to fix it.
Ref 1: https://postgr.es/m/20230707175859.17c91538@karst
Re: Issue attaching a table to a partitioned table with an
auto-referenced foreign key
(Guillaume Lelar
Hi, Andrei!
Thank you for your review!
On Wed, Apr 30, 2025 at 4:34 PM Andrei Lepikhov wrote:
> On 4/30/25 13:22, Alexander Korotkov wrote:
> >> Thank you, Andrei. I've put it all together.
> >> 0001 Fixes material bugs in ChangeVarNodes_walker() including
> regression test
> >> 0002 Puts back
On 28.04.25 23:14, David E. Wheeler wrote:
On Apr 25, 2025, at 15:23, David E. Wheeler wrote:
Thank you for the review. Here’s v3*.
V4 removes “/extension” from the end of the `extension_control_path` value.
The documentation in config.sgml says:
Note that the path elements should typ
Hi David,
On Thu, May 1, 2025 at 2:15 PM David Rowley wrote:
>
> On Thu, 1 May 2025 at 17:35, Junwang Zhao wrote:
> >
> > On Thu, May 1, 2025 at 8:12 AM David Rowley wrote:
> > > It sounds like the aim is to fix the problem with autovacuum vacuuming
> > > the same table over and over and being
On 30.04.25 17:48, Japin Li wrote:
While working on [1], I found outdated comments in IndexInfo.
The attached patch corrects them.
[1]
https://www.postgresql.org/message-id/2A40921D-83AB-411E-ADA6-7E509A46F1E4%40logansw.com
Maybe these per-column comments should be moved inline, similar to, f
> On 1 May 2025, at 00:04, Robert Haas wrote:
>
> On Wed, Apr 30, 2025 at 5:24 PM Daniel Gustafsson wrote:
>> Attached is a current v4 with a few small tweaks.
>
> Sorry to turn up late here, but I strongly disagree with the notion
> that this is a bug in the DSM or DSA code. It seems to me th
On Fri, Apr 11, 2025 at 3:51 PM Richard Guo wrote:
> On Fri, Apr 11, 2025 at 4:45 AM Robert Haas wrote:
> > OK. Maybe I shouldn't be worrying about the table_open() /
> > table_close() here, because I see that you are right that
> > has_subclass() is nearby, which admittedly does not involve open
On 2025/05/01 15:30, Erik Rijkers wrote:
Hi,
It seems to me that, in doc/src/sgml/ref/pgupgrade.sgml, this phrase:
"Because not all statistics are not transferred"
should be:
"Because not all statistics are transferred"
You seem to be right (though I'm not a native English speaker)
On 2025/05/01 2:15, Robert Haas wrote:
On Tue, Apr 6, 2021 at 12:45 AM Fujii Masao wrote:
Add function to log the memory contexts of specified backend process.
Hi,
I think this might need a recursion guard. I tried this:
diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgre
On 30.04.25 17:17, Robert Treat wrote:
On Wed, Apr 30, 2025 at 5:15 AM Peter Eisentraut wrote:
On 28.04.25 18:56, Álvaro Herrera wrote:
On 2025-Apr-23, Nathan Bossart wrote:
On Mon, Mar 24, 2025 at 11:37:20AM +0100, Álvaro Herrera wrote:
I'd add a note about these two things to the open
63 matches
Mail list logo
