On Thu, May 1, 2025 at 10:38 AM Jacob Champion <jacob.champ...@enterprisedb.com> wrote: > I've thrown some more Autoconf testing at Rocky, Mac, and Ubuntu. > > So, committed.
I forgot --enable-nls in my Mac testing, so indri complains about my omission of -lintl... I'd incorrectly thought it was no longer needed after all the gettext motion. I'm running the attached fixup through CI now. --Jacob
From 379c3fb40547391c649bb5c53668581ee017489e Mon Sep 17 00:00:00 2001 From: Jacob Champion <jacob.champion@enterprisedb.com> Date: Thu, 1 May 2025 12:03:28 -0700 Subject: [PATCH] oauth: Fix Autoconf build on macOS Oversight in b0635bfda. -lintl is necessary for gettext on Mac, which libpq-oauth depends on via pgport/pgcommon. (I'd incorrectly removed this change from an earlier version of the patch, where it was suggested by Peter Eisentraut.) Per buildfarm member indri. --- src/interfaces/libpq-oauth/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/interfaces/libpq-oauth/Makefile b/src/interfaces/libpq-oauth/Makefile index 3e4b34142e0..270fc0cf2d9 100644 --- a/src/interfaces/libpq-oauth/Makefile +++ b/src/interfaces/libpq-oauth/Makefile @@ -47,7 +47,7 @@ $(stlib): override OBJS += $(OBJS_STATIC) $(stlib): $(OBJS_STATIC) SHLIB_LINK_INTERNAL = $(libpq_pgport_shlib) -SHLIB_LINK = $(LIBCURL_LDFLAGS) $(LIBCURL_LDLIBS) +SHLIB_LINK = $(LIBCURL_LDFLAGS) $(LIBCURL_LDLIBS) $(filter -lintl, $(LIBS)) SHLIB_PREREQS = submake-libpq SHLIB_EXPORTS = exports.txt -- 2.34.1
