On Fri, Aug 02, 2024 at 05:53:31AM +0900, Michael Paquier wrote:
> Attached is a rebased set of the rest, with 0001 now introducing the
> pluggable core part.
So, I have been able to spend a few more days on all that while
travelling across three continents, and I have applied the core patch
follo
The now preferred way to call realpath() is by passing NULL as the
second argument and get a malloc'ed result. We still supported the
old way of providing our own buffer as a second argument, for some
platforms that didn't support the new way yet. Those were only
Solaris less than version 11 and
On 03.08.24 22:46, Tom Lane wrote:
Peter Eisentraut writes:
This has all been committed now.
Various buildfarm animals are complaining about
g++ -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement
-Werror=vla -Werror=unguarded-availability-new -Wendif-labels
-Wmissing-
On Wed, 31 Jul 2024 at 14:39, shveta malik wrote:
>
> On Mon, Jun 10, 2024 at 5:00 PM vignesh C wrote:
> >
> > On Mon, 10 Jun 2024 at 12:24, Amul Sul wrote:
> > >
> > >
> > >
> > > On Sat, Jun 8, 2024 at 6:43 PM vignesh C wrote:
> > >>
> > >> On Wed, 5 Jun 2024 at 14:11, Amit Kapila wrote:
> >
Hi,
On Thu, Jul 11, 2024 at 06:10:23AM +, Bertrand Drouvot wrote:
> Hi,
>
> On Thu, Jul 11, 2024 at 01:58:19PM +0900, Michael Paquier wrote:
> > On Wed, Jul 10, 2024 at 01:38:06PM +, Bertrand Drouvot wrote:
> > > So, I think it makes sense to link the hashkey to all the RelFileLocator
> >
On Mon, Aug 5, 2024 at 10:05 AM shveta malik wrote:
>
> On Mon, Aug 5, 2024 at 9:19 AM Amit Kapila wrote:
> >
> > On Fri, Aug 2, 2024 at 6:28 PM Nisha Moond wrote:
> > >
> > > Test Summary -
> > > -- The duration for case-2 was reduced to 2-3 minutes, matching the
> > > times of the other cases.
On Thu, 1 Aug 2024 at 04:25, Peter Smith wrote:
>
> Hi Vignesh,
>
> I noticed that when replicating sequences (using the latest patches
> 0730_2*) the subscriber-side checks the *existence* of the sequence,
> but apparently it is not checking other sequence attributes.
>
> For example, consider:
On Thu, 1 Aug 2024 at 03:33, Peter Smith wrote:
>
> Hi Vignesh,
>
> I have a question about the subscriber-side behaviour of currval().
>
> ==
>
> AFAIK it is normal for currval() to give error is nextval() has not
> yet been called [1]
>
> For example.
> test_pub=# create sequence s1;
> CREAT
On Mon, Aug 5, 2024 at 9:19 AM Amit Kapila wrote:
>
> On Fri, Aug 2, 2024 at 6:28 PM Nisha Moond wrote:
> >
> > Performance tests done on the v8-0001 and v8-0002 patches, available at [1].
> >
>
> Thanks for doing the detailed tests for this patch.
>
> > The purpose of the performance tests is to
On Sun, Aug 4, 2024 at 1:04 PM Zhijie Hou (Fujitsu)
wrote:
>
> On Friday, July 26, 2024 2:26 PM Amit Kapila wrote:
> >
> >
> > I agree that displaying pk where applicable should be okay as we display it
> > at
> > other places but the same won't be possible when we do sequence scan to
> > fetch
On Sun, Aug 4, 2024 at 1:22 PM Zhijie Hou (Fujitsu)
wrote:
>
> Here is the V11 patch set which addressed above and Kuroda-san[1] comments.
>
Thanks for the patch. Few comments:
1)
Can you please recheck conflict.h inclusion. I think, these are not required:
#include "access/xlogdefs.h"
#include
On 8/2/24 20:37, Robert Haas wrote:
On Fri, Apr 19, 2024 at 11:47 AM Robert Haas wrote:
Hmm, that's an interesting perspective. I've always been very
skeptical of doing verification only around missing files and not
anything else. I figured that wouldn't be particularly meaningful, and
that's p
On Fri, Aug 2, 2024 at 6:28 PM Nisha Moond wrote:
>
> Performance tests done on the v8-0001 and v8-0002 patches, available at [1].
>
Thanks for doing the detailed tests for this patch.
> The purpose of the performance tests is to measure the impact on
> logical replication with track_commit_time
Hi,
Writing many new test case combinations has exposed a possible bug in
patch 0001.
In my previous post [1] there was questionable behaviour when
replicating from a normal (not generated) column on the publisher side
to a generated column on the subscriber side. Initially, I thought the
test mi
Hi Shubhab.
Here are some more review comments for the v23-0001.
==
011_generated.pl b/src/test/subscription/t/011_generated.pl
nitpick - renamed /regress_pub/regress_pub_tab1/ and
/regress_sub1/regress_sub1_tab1/
nitpick - typo /inital data /initial data/
nitpick - typo /snode_subscriber2/n
Senglee Choi 于2024年8月5日周一 09:24写道：
> Fixed a minor typo in src/include/storage/bufpage.h.
> Please let me know if any further action is required.
>
Good catch. +1
--
Tender Wang
Fixed a minor typo in src/include/storage/bufpage.h.
Please let me know if any further action is required.
---
Best regards,
Senglee Choi
v1-0001-fix-typo-in-bufpage-header-comment.patch
Description: Binary data
Hi!
On Wed, Apr 3, 2024 at 9:07 AM Andrei Lepikhov
wrote:
> On 3/15/24 17:57, Teodor Sigaev wrote:
> >> Okay, I've applied this piece for now. Not sure I'll have much room
> >> to look at the rest.
> >
> > Thank you very much!
> I have spent some time reviewing this feature. I think we can discu
On Fri, Jun 14, 2024 at 8:00 AM Alexander Lakhin
wrote:
>
>And the most interesting case to me:
>SET temp_buffers TO 10;
>
>CREATE TEMP TABLE t(i int PRIMARY KEY);
>INSERT INTO t VALUES(1);
>
>#4 0x7f385cdd37f3 in __GI_abort () at ./stdlib/abort.c:79
>#5 0x000
On 2024-07-30 08:30 +0200, Yugo NAGATA wrote:
> On Tue, 30 Jul 2024 01:36:55 +0200
> Erik Wienhold wrote:
>
> > On 2024-07-01 15:08 +0200, Yugo NAGATA wrote:
> > > I would like to propose to add a new field to psql's \dAo+ meta-command
> > > to show whether the underlying function of an operator
One of our customers recently asked me to look into buffer mapping.
Following is my POV on the problem of optimal NUM_BUFFER_PARTITIONS.
I’ve found some dead code: BufMappingPartitionLockByIndex() is unused, and
unused for a long time. See patch 1.
> On 23 Feb 2024, at 22:25, Tomas Vondra wrote
On 01.08.2024 22:41, Nathan Bossart wrote:
Here is a new patch set. Besides rebasing, I've added the recursive call
to process_slot() mentioned in the quoted text, and I've added quite a bit
of commentary to async.c.
That's much better now, thanks! Here's my code review, note that I
haven't t
On Tue, 2024-07-23 at 16:21 +0300, Heikki Linnakangas wrote:
> So, I got a feeling that adding this to the rmgr interface is not
> quite
> right. The rmgr callbacks are for things that run when WAL is
> *replayed*, while checkpoints are related to how WAL is generated.
> Let's
> design this as a
On Sun, Aug 4, 2024 at 4:45 AM Heikki Linnakangas wrote:
> On 04/08/2024 06:29, Robert Treat wrote:
> > I was looking at trace_connection_negotiation and ran across this
> > commit removing it's mention from the release notes because it is
> > undocumented:
> > https://git.postgresql.org/gitweb/
On 2024-08-03 Sa 10:13 PM, Junwang Zhao wrote:
On Sat, Aug 3, 2024 at 7:30 PM Andrew Dunstan wrote:
On 2024-08-02 Fr 2:45 PM, Peter Eisentraut wrote:
On 01.08.24 23:38, Andrew Dunstan wrote:
Not totally opposed, and I will probably give it a try very soon, but
I'm wondering if this really
> On 28 Jul 2024, at 23:44, Andrey M. Borodin wrote:
>
> PFA version accepting offset interval.
There was a bug: when time was not moving on, I was updating used time by a
nanosecond, instead of 1/4096 of millisecond.
V27 fixes that.
Thanks!
Best regards, Andrey Borodin.
v27-0001-Impleme
On 04/08/2024 06:29, Robert Treat wrote:
I was looking at trace_connection_negotiation and ran across this
commit removing it's mention from the release notes because it is
undocumented:
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=95cabf542f04b634303f899600ea62fb256a08c2
On Friday, July 26, 2024 2:26 PM Amit Kapila wrote:
>
> On Fri, Jul 26, 2024 at 9:39 AM shveta malik wrote:
> >
> > On Thu, Jul 11, 2024 at 7:47 AM Zhijie Hou (Fujitsu)
> > wrote:
> > >
> > > On Wednesday, July 10, 2024 5:39 PM shveta malik
> wrote:
> > > >
> >
> > > > 2)
> > > > Another case
Hi
I am attaching a new patch for a minor feature addition.
- Adding support for 'Labels and properties: EXCEPT list'
Please let me know if something is missing.
Thanks and Regards
Imran Zaheer
On Mon, Jul 22, 2024 at 9:02 PM Ashutosh Bapat
wrote:
>
> On Wed, Jul 17, 2024 at 11:04 AM Ashutosh
29 matches
Mail list logo
