On Sun, Aug 4, 2024 at 1:22 PM Zhijie Hou (Fujitsu) <houzj.f...@fujitsu.com> wrote: > > Here is the V11 patch set which addressed above and Kuroda-san[1] comments. >
Thanks for the patch. Few comments: 1) Can you please recheck conflict.h inclusion. I think, these are not required: #include "access/xlogdefs.h" #include "executor/tuptable.h" #include "utils/relcache.h" Only these should suffice: #include "nodes/execnodes.h" #include "utils/timestamp.h" 2) create_subscription.sgml: For 'insert_exists' as well, we can mention that track_commit_timestamp should be enabled *on the susbcriber*. thanks Shveta
