Hi
Dne po 15. 5. 2023 8:01 uživatel Kirk Wolak napsal:
> This would be a trivial change. Willing to do it, and push it.
>
> In effect, we have this GREAT feature:
> \set ECHO_HIDDON on
>
> Which outputs a bunch of queries (as you all know).
> But somehow nobody thought that a user might want to
Dear Peter,
Thank you for reviewing! PSA new version.
> 1. check_new_cluster
>
> + if (user_opts.include_logical_slots)
> + {
> + get_logical_slot_infos(&new_cluster);
> + check_for_parameter_settings(&new_cluster);
> + }
> +
> check_new_cluster_is_empty();
> ~
>
> The code is OK, but maybe y
On Mon, May 15, 2023 at 03:16:46PM +0900, torikoshia wrote:
> On 2023-05-15 09:18, Michael Paquier wrote:
>> How about plugging in some long options, and use something more
>> explicit like --clean-backup-history?
>
> Agreed.
If you begin to implement that, it seems to me that this should be
shap
On 2023-05-15 09:18, Michael Paquier wrote:
On Fri, May 12, 2023 at 05:53:45PM +0900, torikoshia wrote:
On 2023-05-10 17:52, Bharath Rupireddy wrote:
I was a little concerned about what to do when deleting both the files
ending in .gz and backup history files.
Is making it possible to specify bo
This would be a trivial change. Willing to do it, and push it.
In effect, we have this GREAT feature:
\set ECHO_HIDDON on
Which outputs a bunch of queries (as you all know).
But somehow nobody thought that a user might want to paste ALL of the
queries into their query editor, or even into anothe
On Thu, May 11, 2023 at 01:28:40PM +0900, Michael Paquier wrote:
> On Tue, May 09, 2023 at 09:48:24AM -0700, Andres Freund wrote:
>> On 2023-05-08 12:11:17 -0700, Andres Freund wrote:
>>> I can reproduce a significant regression due to f193883fc of a workload just
>>> running
>>> SELECT CURRENT_TIM
On Fri, May 12, 2023 at 11:58 PM Bharath Rupireddy
wrote:
> Andres, rightly put it - 'mis-using' CV infrastructure. It is simple,
> works, and makes the WalSndWakeup() easy solving the performance
> regression.
Yeah, this seems OK, and better than the complicated alternatives. If
one day we want
Personally I would appreciate it if \sv actually showed you the DDL.
Oftentimes I will \ev something to review it, with syntax highlighting.
Obviously this won't go in until V17, but looking at other tab-completion
fixes.
This should not be that difficult. Just looking for feedback.
Admittedly \
On Mon, May 15, 2023 at 2:57 PM Michael Paquier wrote:
> On Mon, May 15, 2023 at 02:08:32PM +1200, Thomas Munro wrote:
> > After 495ed0e, do these references to Windows SDK 8.1 still make sense?
> As listed on https://en.wikipedia.org/wiki/Microsoft_Windows_SDK,
> likely not. What do you think a
On Sun, May 14, 2023 at 1:59 PM Peter Geoghegan wrote:
> Have you read the documentation in question recently? The first two
> paragraphs, in particular:
>
> https://www.postgresql.org/docs/devel/routine-vacuuming.html#VACUUM-FOR-WRAPAROUND
>
> As I keep pointing out, we literally introduce the wh
On Mon, May 15, 2023 at 02:08:32PM +1200, Thomas Munro wrote:
> After 495ed0e, do these references to Windows SDK 8.1 still make sense?
>
> src/sgml/install-windows.sgml: as well as standalone Windows SDK
> releases 8.1a to 10.
> src/sgml/install-windows.sgml: Microsoft Windows
> SDK version 8.1
Thanks a lot for the clarification!
The "..." looks enigmatic right now. I think cstring would save newcomers
some head-scratching.
Open to suggestions though.
Best regards,
Steve
On Sun, 14 May 2023 at 22:36, Tom Lane wrote:
> Steve Chavez writes:
> > I found "..." confusing in some comment
On Friday, May 12, 2023 7:58 PM Bharath Rupireddy
wrote:
>
> On Wed, May 10, 2023 at 3:23 PM Drouvot, Bertrand
> wrote:
> >
> > >> My current guess is that mis-using a condition variable is the best
> > >> bet. I think it should work to use
> > >> ConditionVariablePrepareToSleep() before a WalS
After 495ed0e, do these references to Windows SDK 8.1 still make sense?
src/sgml/install-windows.sgml: as well as standalone Windows SDK
releases 8.1a to 10.
src/sgml/install-windows.sgml: Microsoft Windows
SDK version 8.1a to 10 or
Steve Chavez writes:
> I found "..." confusing in some comments, so this patch changes it to
> "cstring". Which seems to be the intention after all.
Those comments are Berkeley-era, making them probably a decade older
than the "cstring" pseudotype (invented in b663f3443). Perhaps what
you sugges
Steve Chavez writes:
> In this case I just propose adding 'tags'. I believe it's reasonable to
> ignore these as they're produced by make_ctags.
Our policy on this is that the project's .gitignore files should ignore
files that are produced by our standard build scripts. Anything else
you should
On Fri, May 12, 2023 at 9:14 PM John Naylor
wrote:
> Attached is v9, which is mostly editing the steps for restoring normal
> operation, which are in 0003 now but will be squashed into 0002. Comments to
> polish the wording welcome.
I'll try to get you more feedback on this soon.
BTW, Google c
On Fri, May 12, 2023 at 05:53:45PM +0900, torikoshia wrote:
> On 2023-05-10 17:52, Bharath Rupireddy wrote:
> I was a little concerned about what to do when deleting both the files
> ending in .gz and backup history files.
> Is making it possible to specify both "-x .backup" and "-x .gz" the way to
Hello Michael,
On the previous patch:
- `.*.swp` was added, which I entirely agree shouldn't be in .gitignore as
it's editor specific(despite me using vim).
- The discussion dabbled too much around the *.swp addition.
In this case I just propose adding 'tags'. I believe it's reasonable to
ignore
On Mon, May 15, 2023 at 11:26:31AM +1200, Thomas Munro wrote:
> On Sat, Apr 8, 2023 at 5:21 PM Andres Freund wrote:
> > On 2023-04-08 13:18:55 +1200, Thomas Munro wrote:
> > > Subject: [PATCH] Fix default wal_writer_flush_after value.
> > LGTM.
>
> Thanks, pushed.
Somewhat forgot about this thre
On Sun, May 14, 2023 at 06:13:21PM -0300, Steve Chavez wrote:
> I use postgres/src/tools/make_ctags and it works great. But it leaves the
> tags files ready to be committed in git. So, I've added 'tags' to
> .gitignore.
This has been proposed in the past, where no conclusion was reached
about whet
On Sat, Apr 8, 2023 at 5:21 PM Andres Freund wrote:
> On 2023-04-08 13:18:55 +1200, Thomas Munro wrote:
> > Subject: [PATCH] Fix default wal_writer_flush_after value.
> LGTM.
Thanks, pushed.
On Mon, May 15, 2023 at 9:09 AM Noah Misch wrote:
> This looks reasonable.
Pushed with a small change: a couple of GUC_check_errdetail strings
needed s/io_direct/debug_io_direct/. Thanks.
Hello hackers,
I use postgres/src/tools/make_ctags and it works great. But it leaves the
tags files ready to be committed in git. So, I've added 'tags' to
.gitignore.
Best regards,
Steve
On Mon, May 01, 2023 at 02:47:57PM +1200, Thomas Munro wrote:
> On Mon, May 1, 2023 at 12:00 PM Tom Lane wrote:
> > Justin Pryzby writes:
> > > Since this is -currently- a developer-only feature, it seems reasonable
> > > to rename the GUC to debug_direct_io, and (at such time as it's
> > > consi
Hello hackers,
I found "..." confusing in some comments, so this patch changes it to
"cstring". Which seems to be the intention after all.
Best regards,
Steve
From cb1792c45ea9a2fbd2c08e185653b60dc262a17d Mon Sep 17 00:00:00 2001
From: steve-chavez
Date: Sun, 14 May 2023 18:00:49 -0300
Subject:
On Sat, May 13, 2023 at 7:47 PM Greg Stark wrote:
> It's not like there are 2 billion XIDs in a big pool being used and
> returned and as long as you don't use too many XIDs leaving the pool
> empty you're ok. When people talk about resource exhaustion they
> imagine that they just need a faster m
On 2023-05-13 Sa 23:11, Greg Stark wrote:
On Sat, 13 May 2023 at 09:46, Tom Lane wrote:
Andrew Dunstan writes:
I could see an argument for a STRICT mode which would disallow partially
quoted fields, although I'd like some evidence that we're dealing with a
real problem here. Is there really
28 matches
Mail list logo
