On Tue, Oct 5, 2021 at 10:21 PM Jaime Casanova
wrote:
> At this time I'm looking to close the CF.
Thanks, Jaime.
--
Peter Geoghegan
Hi all,
Following up with Peter E's recent commit 73aa5e0 to add some
forgotten level incrementations, I got to look again at what I did
wrong and why this stuff is useful.
I have gone through all the TAP tests and any code paths using
subroutines, to note that we could improve the locations of t
On Tue, Oct 5, 2021 at 11:00 PM Alexander Lakhin wrote:
> I think that ideally pg_amcheck should not fail on a live database, that
> does not contain corrupted data, and should not affect the database
> usage by other users (as it's "only a check").
I agree that that's ideal. As you said, one or
On Wed, 6 Oct 2021, 03:30 Andres Freund, wrote:
> Hi,
>
>
> My first attempt was to try to use the existing crashdump stuff in
> pgwin32_install_crashdump_handler(). That's not really quite what I want,
> because it only handles postmaster rather than any binary, but I thought
> it'd
> be a good
On Thu, Jun 10, 2021 at 7:47 PM Thomas Munro wrote:
> On Thu, Jun 10, 2021 at 7:37 PM Anastasia Lubennikova
> wrote:
> > For some reason, it failed on cfbot, so I'll switch it back to 'Waiting on
Sorry for the delay. I got stuck in a CI loop trying to make a new
improved version work on Windows
On 2021-10-04 17:27:44 +0900, Michael Paquier wrote:
> On Fri, Oct 01, 2021 at 02:11:15PM +0900, Michael Paquier wrote:
> > A couple of months later, I have looked back at this thread and this
> > report. I have rechecked all the standby handling and snapshot builds
> > involving KnownAssignedXids
Hello Mark, Peter, Robert,
05.10.2021 20:22, Peter Geoghegan пишет:
> On Tue, Oct 5, 2021 at 10:03 AM Mark Dilger
> wrote:
>> I took no offense. Actually, I owe you a thank-you for having put so much
>> effort into debating the behavior with me. I think the patch to fix bug
>> #17212 will be b
Hi,
After a recent migration of the skink and a few other animals (sorry for the
false reports on BF, I forgot to adjust a path), I looked at the time it takes
to complete a valgrind run:
9.6: Consumed 4h 53min 18.518s CPU time
10: Consumed 5h 32min 50.839s CPU time
11: Consumed 7h 7min 17.455s
On Tue, Oct 5, 2021 at 6:57 AM Greg Nancarrow wrote:
>
> On Mon, Oct 4, 2021 at 4:55 AM vignesh C wrote:
> >
> > Attached v36 patch has the changes for the same.
> >
>
> I have some comments on the v36-0001 patch:
>
> src/backend/commands/publicationcmds.c
>
> (1)
> GetPublicationSchemas()
>
> +
On Wed, Oct 06, 2021 at 02:24:40PM +0900, bt21masumurak wrote:
> If you do tab completion in a situation like A, you will see ["on"] instead
> of [on].
>
> A : "ALTER SYSTEM SET wal_compression TO "
>
> I made a patch for this problem.
This would break the completion of enum entries that require
Hi
If you do tab completion in a situation like A, you will see ["on"]
instead of [on].
A : "ALTER SYSTEM SET wal_compression TO "
I made a patch for this problem.
regards,
Kosei Masumuradiff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index 4155d81252..86087e790b 10064
Hi everyone,
At this time I'm looking to close the CF.
So, I will write and mark as RwF the patches currently failing on the
cfbot and move to the next CF all other patches.
RwF:
- ALTER SYSTEM READ { ONLY | WRITE }
- GUC to disable cancellation of awaiting for synchronous replication
- Introduc
Hi all,
While reviewing the code of elog.c to plug in JSON as a file-based log
destination, I have found what looks like a bug in
send_message_to_server_log(). If LOG_DESTINATION_CSVLOG is enabled,
we would do the following to make sure that the log entry is not
missed:
- If redirection_done or i
Hi,
On 2021-10-06 17:01:53 +1300, Thomas Munro wrote:
> On Sat, Oct 2, 2021 at 11:27 AM Andres Freund wrote:
> > - runs check-world on FreeBSD, Linux, macOS - all using gcc
>
> Small correction: on macOS and FreeBSD it's using the vendor compiler,
> which is some kind of clang.
Oh, oops. I guess
On Sat, Oct 02, 2021 at 07:00:01PM -0300, Alvaro Herrera wrote:
> A patch was proposed on that thread on September 22nd, can to try with
> that and see if this problem still reproduces?
Yes, the failure still shows up, even with a timeout set at 30s which
is the default of the patch.
--
Michael
On Sat, Oct 2, 2021 at 11:27 AM Andres Freund wrote:
> - runs check-world on FreeBSD, Linux, macOS - all using gcc
Small correction: on macOS and FreeBSD it's using the vendor compiler,
which is some kind of clang.
BTW, on those two OSes there are some messages like this each time a
submake dump
On Wed, Oct 6, 2021 at 7:52 AM Michael Paquier wrote:
> My take is that there is value for both installcheck-world and
> check-world, depending on if we want to test on an installed instance
> or not. For CIs, check-world makes things simpler perhaps?
>
> > vcregress plcheck
> > vcregress contrib
On 2021/10/05 10:38, Masahiko Sawada wrote:
Hi,
On Tue, Oct 5, 2021 at 9:56 AM k.jami...@fujitsu.com
wrote:
Hi Sawada-san,
I noticed that this thread and its set of patches have been marked with "Returned
with Feedback" by yourself.
I find the feature (atomic commit for foreign transacti
On Tue, Oct 5, 2021 at 4:41 PM Amit Kapila wrote:
>
> On Tue, Oct 5, 2021 at 11:10 AM Greg Nancarrow wrote:
> >
> > On Tue, Oct 5, 2021 at 3:11 PM Amit Kapila wrote:
> > >
> > > > Code has been added to prevent a table being set (via ALTER TABLE) to
> > > > UNLOGGED if it is part of a publicatio
On Wed, Oct 06, 2021 at 07:19:04AM +0530, Bharath Rupireddy wrote:
> I was thinking of the same. +1 for "vcregress check-world" which is
> more in sync with it's peer "make check-world" instead of "vcregress
> all-taptest". I'm not sure whether we can also have "vcregress
> installcheck-world" as w
On Mon, Oct 4, 2021 at 4:31 PM Amit Kapila wrote:
>
> I think here the main point is that does this addresses Peter's
> concern for this Patch to use a separate syntax? Peter E., can you
> please confirm? Do let us know if you have something else going in
> your mind?
>
Peter's concern seemed to
On Wed, Oct 6, 2021 at 5:10 AM Michael Paquier wrote:
>
> On Tue, Oct 05, 2021 at 12:16:06PM -0400, Robert Haas wrote:
> > Perhaps that's so, but it doesn't seem like a good reason not to make
> > them more responsive.
>
> Yeah, that's still some information that the user asked for. Looking
> at
On Wed, Oct 6, 2021 at 6:53 AM Alvaro Herrera wrote:
>
> On 2021-Oct-06, Michael Paquier wrote:
>
> > On Tue, Oct 05, 2021 at 06:18:47PM -0400, Andrew Dunstan wrote:
> > > On 10/5/21 4:38 PM, Andres Freund wrote:
> > >> My problem with that is that that means there's no convenient way to
> > >> d
On 2021-Oct-06, Michael Paquier wrote:
> On Tue, Oct 05, 2021 at 06:18:47PM -0400, Andrew Dunstan wrote:
> > On 10/5/21 4:38 PM, Andres Freund wrote:
> >> My problem with that is that that means there's no convenient way to
> >> discover
> >> what one needs to do to run all tests. Perhaps we coul
On Tue, Oct 5, 2021 at 03:30:07PM -0700, Jeremy Schneider wrote:
> On 10/5/21 15:07, Bruce Momjian wrote:
> > On Wed, Sep 8, 2021 at 07:18:08PM +0530, Bharath Rupireddy wrote:
> >> While working on one of the internal features, we found that it is a
> >> bit difficult to run pg_waldump for a norm
On Tue, Oct 5, 2021 at 06:22:19PM -0400, Chapman Flack wrote:
> On 10/05/21 18:07, Bruce Momjian wrote:
> > Uh, are we going to implement everything that is only available at the
> > command line as an extension just for people who are using managed cloud
> > services
>
> One extension that runs
On Tue, Oct 05, 2021 at 06:18:47PM -0400, Andrew Dunstan wrote:
> On 10/5/21 4:38 PM, Andres Freund wrote:
>> My problem with that is that that means there's no convenient way to discover
>> what one needs to do to run all tests. Perhaps we could have one all-taptest
>> target or such?
>>
>
> Yeah
On Tue, Oct 05, 2021 at 12:16:06PM -0400, Robert Haas wrote:
> Perhaps that's so, but it doesn't seem like a good reason not to make
> them more responsive.
Yeah, that's still some information that the user asked for. Looking
at the things that have a PGPROC entry, should we worry about the main
On 10/5/21 15:07, Bruce Momjian wrote:
> On Wed, Sep 8, 2021 at 07:18:08PM +0530, Bharath Rupireddy wrote:
>> While working on one of the internal features, we found that it is a
>> bit difficult to run pg_waldump for a normal user to know WAL info and
>> stats of a running postgres database insta
On 10/05/21 18:07, Bruce Momjian wrote:
> Uh, are we going to implement everything that is only available at the
> command line as an extension just for people who are using managed cloud
> services
One extension that runs a curated menu of command-line tools for you
and returns their stdout?
Reg
On 10/5/21 4:38 PM, Andres Freund wrote:
> Hi,
>
> On 2021-10-05 16:03:53 -0400, Andrew Dunstan wrote:
>> I would actually prefer to reduce the number of special things in
>> vcregress.pl rather than add more. We should be able to add a new set of
>> TAP tests somewhere without having to do anyth
On Wed, Sep 8, 2021 at 07:18:08PM +0530, Bharath Rupireddy wrote:
> Hi,
>
> While working on one of the internal features, we found that it is a
> bit difficult to run pg_waldump for a normal user to know WAL info and
> stats of a running postgres database instance in the cloud. Many a
> times us
On Tue, Oct 5, 2021 at 10:25 AM John Naylor
wrote:
> int64 is used elsewhere in this file, and I see now reason to do otherwise.
Right. The point of using int64 in tuplesort.c is that the values may
become negative in certain edge-cases. The whole LACKMEM() concept
that tuplesort.c uses to enforc
On Tue, Oct 5, 2021 at 04:29:25PM -0400, Bruce Momjian wrote:
> On Tue, Sep 28, 2021 at 12:30:02PM +0300, Ants Aasma wrote:
> > On Mon, 27 Sept 2021 at 23:34, Bruce Momjian wrote:
> > We are still working on our TDE patch. Right now the focus is on refactoring
> > temporary file access to make th
Hi,
On 2021-10-05 16:03:53 -0400, Andrew Dunstan wrote:
> I would actually prefer to reduce the number of special things in
> vcregress.pl rather than add more. We should be able to add a new set of
> TAP tests somewhere without having to do anything to vcregress.pl.
> That's more or less why I ad
On Tue, Sep 28, 2021 at 12:30:02PM +0300, Ants Aasma wrote:
> On Mon, 27 Sept 2021 at 23:34, Bruce Momjian wrote:
> We are still working on our TDE patch. Right now the focus is on refactoring
> temporary file access to make the TDE patch itself smaller. Reconsidering
> encryption mode choices giv
Hi,
On 2021-09-14 10:34:09 +0530, Amul Sul wrote:
> +# recovery_end_command_file executed only on recovery end which can happen on
> +# promotion.
> +$standby3->promote;
> +ok(-f "$recovery_end_command_file",
> + 'recovery_end_command executed after promotion');
It'd be good to test what happ
On 10/5/21 1:25 PM, Bharath Rupireddy wrote:
> Hi,
>
> While working one of the internal features, I figured out that we
> don't have subscription TAP tests option for "vcregress" tool for msvc
> builds. Is there any specific reason that we didn't add "vcregress
> subscriptioncheck" option simila
> On Oct 5, 2021, at 10:20 AM, Stephen Frost wrote:
>
> Greetings,
>
> On Tue, Oct 5, 2021 at 13:17 Mark Dilger wrote:
> > On Oct 5, 2021, at 10:14 AM, Stephen Frost wrote:
> >
> > What does the “ownership” concept actually buy us then?
>
> DROP ... CASCADE
>
> I’m not convinced that we
Hi,
As threatened in [1]... For CI, originally in the AIO project but now more
generally, I wanted to get windows backtraces as part of CI. I also was
confused why visual studio's "just in time debugging" (i.e. a window popping
up offering to debug a process when it crashes) didn't work with postg
On 9/27/21, 11:06 AM, "Bossart, Nathan" wrote:
> On 9/24/21, 9:29 AM, "Robert Haas" wrote:
>> So what I am inclined to do is commit
>> v1-0001-Improve-performance-of-pgarch_readyXlog-with-many.patch.
>> However, v6-0001-Do-fewer-directory-scans-of-archive_status.patch has
>> perhaps evolved a bit
Hi Stefan,
On 2021-Oct-03, Stefan Keller wrote:
> Just for my understanding - and perhaps as input for the documentation of
> this:
> Are Foreign Key Arrays a means to implement "Generic Foreign Keys" as
> in Oracle [1] and Django [2], and of "Polymorphic Associations" as
> they call this in Rub
On 10/5/21 18:28, Simon Riggs wrote:
On Tue, 5 Oct 2021 at 12:24, Dilip Kumar wrote:
On Tue, Oct 5, 2021 at 4:08 PM Simon Riggs wrote:
On Mon, 27 Sept 2021 at 06:52, Amit Kapila wrote:
On Thu, Sep 23, 2021 at 11:11 AM Dilip Kumar wrote:
On Thu, Sep 23, 2021 at 10:04 AM Sadhuprasad
On 10/05/21 13:47, Tom Lane wrote:
>> An alternative I've sometimes used elsewhere is to typedef the function
>> type itself, and use the * when declaring a pointer to it:
>> typedef void Furbinator(char *furbee);
>
> Is that legal C? I doubt that it was before C99 or so. As noted
> in the Ghost
Robert Haas wrote:
> On Tue, Oct 5, 2021 at 1:24 PM Robert Haas wrote:
> > On Mon, Oct 4, 2021 at 10:00 PM Stephen Frost wrote:
> > > I do want to point out, as I think I did when we discussed this but want
> > > to be sure it's also captured here- I don't think that temporary file
> > > access
Chapman Flack writes:
> From everything I've seen, the PostgreSQL style seems to be to include
> the * in a typedef for a function type to which pointers will be held:
> typedef void (*Furbinator)(char *furbee);
Yup.
> An alternative I've sometimes used elsewhere is to typedef the function
> typ
On Mon, Oct 04, 2021 at 02:08:58PM -0500, Jaime Casanova wrote:
> Hi,
>
> Here's the list mentioned in ${SUBJECT}, please can the committers
> mention what they want to do with those?
>
To move forward I have moved all RfC entries to next CF
--
Jaime Casanova
Director de Servicios Profesional
On Tue, Oct 5, 2021 at 1:24 PM Robert Haas wrote:
> On Mon, Oct 4, 2021 at 10:00 PM Stephen Frost wrote:
> > I do want to point out, as I think I did when we discussed this but want
> > to be sure it's also captured here- I don't think that temporary file
> > access should be forced to be block-o
Hi,
While working one of the internal features, I figured out that we
don't have subscription TAP tests option for "vcregress" tool for msvc
builds. Is there any specific reason that we didn't add "vcregress
subscriptioncheck" option similar to "vcregress recoverycheck"? It
looks like one can run
On Wed, Sep 15, 2021 at 5:35 PM Heikki Linnakangas wrote:
> Thanks, here's another rebase.
>
> - Heikki
I've had a chance to review and test out the v5 patches.
0001 is a useful simplification. Nothing in 0002 stood out as needing
comment.
I've done some performance testing of master versus bot
On Mon, Oct 4, 2021 at 10:00 PM Stephen Frost wrote:
> I do want to point out, as I think I did when we discussed this but want
> to be sure it's also captured here- I don't think that temporary file
> access should be forced to be block-oriented when it's naturally (in
> very many cases) sequenti
On Sat, Mar 06, 2021 at 06:50:13PM +0900, Kohei KaiGai wrote:
>
> On the other hand, I'm uncertain whether the pfree(new_path) at the tail
> of add_path makes sense on the modern hardware, because they allow to
> recycle just small amount of memory, then entire memory consumption
> by the optimize
On Tue, Oct 5, 2021 at 10:03 AM Mark Dilger
wrote:
> I took no offense. Actually, I owe you a thank-you for having put so much
> effort into debating the behavior with me. I think the patch to fix bug
> #17212 will be better for it.
Glad that you think so. And, thanks for working on the issue
Greetings,
On Tue, Oct 5, 2021 at 13:17 Mark Dilger
wrote:
> > On Oct 5, 2021, at 10:14 AM, Stephen Frost wrote:
> >
> > What does the “ownership” concept actually buy us then?
>
> DROP ... CASCADE
I’m not convinced that we need to invent the concept of ownership in order
to find a sensible w
On Wed, Jul 21, 2021 at 04:44:53PM +0800, Richard Guo wrote:
> On Fri, Nov 27, 2020 at 8:05 PM Ashutosh Bapat
> wrote:
>
> >
> > In the example you gave earlier, the equi join on partition key was
> > there but it was replaced by individual constant assignment clauses.
> > So if we keep the origi
> On Oct 5, 2021, at 10:14 AM, Stephen Frost wrote:
>
> What does the “ownership” concept actually buy us then?
DROP ... CASCADE.
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Greetings,
On Tue, Oct 5, 2021 at 13:09 Robert Haas wrote:
> On Tue, Oct 5, 2021 at 12:38 PM Mark Dilger
> wrote:
> > Additionally, role "alice" might not exist anymore, which would leave
> the privilege irrevocable.
>
> I thought that surely this couldn't be right, but apparently we have
> abs
Greetings,
On Tue, Oct 5, 2021 at 12:38 Mark Dilger
wrote:
>
>
> > On Oct 5, 2021, at 9:23 AM, Robert Haas wrote:
> >
> >> - Disallow roles from being able to REVOKE role membership that they
> >> didn't GRANT in the first place.
> >
> > I think that's not quite the right test. For example, if
On Tue, Oct 5, 2021 at 12:41 PM Amul Sul wrote:
> No, InRecovery flag get cleared before this point. I think, we can use
> lastReplayedEndRecPtr what you have suggested in other thread.
Hmm, right, that makes sense. Perhaps I should start remembering what
I said in my own emails.
--
Robert Haa
On Tue, Oct 5, 2021 at 12:38 PM Mark Dilger
wrote:
> Additionally, role "alice" might not exist anymore, which would leave the
> privilege irrevocable.
I thought that surely this couldn't be right, but apparently we have
absolutely no problem with leaving the "grantor" column in pg_authid
as a d
Greetings,
On Tue, Oct 5, 2021 at 12:23 Robert Haas wrote:
> On Mon, Oct 4, 2021 at 10:57 PM Stephen Frost wrote:
> > - Disallow roles from being able to REVOKE role membership that they
> > didn't GRANT in the first place.
>
> I think that's not quite the right test. For example, if alice an
> On Oct 5, 2021, at 9:58 AM, Peter Geoghegan wrote:
>
> I apologize to Mark.
I took no offense. Actually, I owe you a thank-you for having put so much
effort into debating the behavior with me. I think the patch to fix bug #17212
will be better for it.
(And thanks to Robert for the conc
Hi,
>From everything I've seen, the PostgreSQL style seems to be to include
the * in a typedef for a function type to which pointers will be held:
typedef void (*Furbinator)(char *furbee);
struct Methods
{
Furbinator furbinate;
};
An alternative I've sometimes used elsewhere is to typedef
On Tue, Oct 5, 2021 at 9:41 AM Robert Haas wrote:
> On Mon, Oct 4, 2021 at 7:10 PM Peter Geoghegan wrote:
> > All of the underlying errors are cases that were clearly intended to
> > catch user error -- every single one. But apparently pg_amcheck is
> > incapable of error, by definition. Like HAL
On Mon, Oct 04, 2021 at 02:12:49AM -0500, Jaime Casanova wrote:
> On Sun, Oct 03, 2021 at 03:14:58PM -0400, Tom Lane wrote:
> [...]
> >
> > Here's what I found, along with some commentary about each one.
> >
> > Patch Age in CFs
> >
> > Protect syscache from bloating with negative
On Mon, Sep 27, 2021 at 3:15 AM tushar wrote:
> It would be great if we throw an error rather than silently ignoring
> this parameter , I opened a separate email for this
>
> https://www.postgresql.org/message-id/CAC6VRoY3SAFeO7kZ0EOVC6mX%3D1ZyTocaecTDTh209W20KCC_aQ%40mail.gmail.com
Hearing no f
On Mon, Oct 4, 2021 at 7:10 PM Peter Geoghegan wrote:
> All of the underlying errors are cases that were clearly intended to
> catch user error -- every single one. But apparently pg_amcheck is
> incapable of error, by definition. Like HAL 9000.
After some thought, I agree with the idea that pg_a
On Tue, 5 Oct 2021 at 9:04 PM, Robert Haas wrote:
> On Tue, Oct 5, 2021 at 7:44 AM Amul Sul wrote:
> > I was trying to understand the v1 patch and found that at the end
> > RequestCheckpoint() is called unconditionally, I think that should
> > have been called if REDO had performed,
>
> You're r
> On Oct 5, 2021, at 9:23 AM, Robert Haas wrote:
>
>> - Disallow roles from being able to REVOKE role membership that they
>> didn't GRANT in the first place.
>
> I think that's not quite the right test. For example, if alice and bob
> are superusers and alice grants pg_monitor to doug, bob
On Tue, 5 Oct 2021 at 12:24, Dilip Kumar wrote:
>
> On Tue, Oct 5, 2021 at 4:08 PM Simon Riggs
> wrote:
> >
> > On Mon, 27 Sept 2021 at 06:52, Amit Kapila wrote:
> > >
> > > On Thu, Sep 23, 2021 at 11:11 AM Dilip Kumar
> > > wrote:
> > > >
> > > > On Thu, Sep 23, 2021 at 10:04 AM Sadhuprasad
On 2021/10/04 21:53, kuroda.hay...@fujitsu.com wrote:
if (*p == '-' ? isdigit(p[1]) : isdigit(p[0]))
{
char *endptr;
padding = strtol(p, &endptr, 10);
if (p == endptr)
On Mon, Oct 4, 2021 at 10:57 PM Stephen Frost wrote:
> - Disallow roles from being able to REVOKE role membership that they
> didn't GRANT in the first place.
I think that's not quite the right test. For example, if alice and bob
are superusers and alice grants pg_monitor to doug, bob should be
On Tue, Oct 5, 2021 at 8:28 AM Tom Lane wrote:
> It's not real clear to me why we need to care about this in those
> processes' idle loops. Their memory consumption is unlikely to be
> very interesting in that state, nor could it change before they
> wake up.
Perhaps that's so, but it doesn't se
On Tue, Oct 5, 2021 at 7:44 AM Amul Sul wrote:
> I was trying to understand the v1 patch and found that at the end
> RequestCheckpoint() is called unconditionally, I think that should
> have been called if REDO had performed,
You're right. But I don't think we need an extra variable like this,
ri
On 2021/10/05 10:58, Kyotaro Horiguchi wrote:
At Tue, 5 Oct 2021 00:59:46 +0900, Fujii Masao
wrote in
I think that it's better to comment why "retry" is not necessary
when not in standby mode.
---
When not in standby mode, an invalid page header should cause recovery
to end
On Mon, 4 Oct 2021 at 15:09, Jaime Casanova
wrote:
>
> - Extending amcheck to check toast size and compression
> Last patch from may-2021, also it seems there is no activity since
> Jul-2021. Peter Geoghegan, are you planning to look at this one?
I'll look at this if nobody minds.
Other pa
On Tue, 2021-10-05 at 15:08 +0200, Daniel Gustafsson wrote:
> Thanks! These changes looks good. Since you accidentally based this on v43
> and not the v44 I posted with the cryptohash fix in, the attached is a v45
> with
> both your v44 and the previous one, all rebased over HEAD.
Thanks, and s
On Mon, Oct 4, 2021 at 12:09 PM Jaime Casanova
wrote:
> - Extending amcheck to check toast size and compression
> Last patch from may-2021, also it seems there is no activity since
> Jul-2021. Peter Geoghegan, are you planning to look at this one?
I didn't plan on it, no.
--
Peter Geoghega
Op 05-10-2021 om 14:30 schreef Daniel Gustafsson:
Unless there are objections, I think this is pretty much ready to go in.
Agreed. One typo:
'This keyword can only be with the exclude keyword.'should be
'This keyword can only be used with the exclude keyword.'
thanks,
Erik Rijkers
Andrew Dunstan writes:
> Seems OK. Note that the Msys DTK perl currawong uses to build with is
> ancient (5.6.1). That's going to stay as it is until it goes completely
> out of scope in about 13 months. The perl it builds plperl against is
> much more modern - 5.16.3.
That brings up something I
On Tue, Oct 05, 2021 at 03:24:40PM +0900, Etsuro Fujita wrote:
> Hi Jaime,
>
> On Tue, Oct 5, 2021 at 4:09 AM Jaime Casanova
> wrote:
> > - Fast COPY FROM command for the foreign tables
> > Last patch was on Jun-2021, no further activity after that.
> > Etsuro-san, are you going to commit thi
On 10/4/21 11:12 PM, Tom Lane wrote:
>
> In short: (a) we're not testing against anything older than 5.8.3
> and (b) it seems quite unlikely that anybody cares about 5.8.x anyway.
> So if we want to mess with this, maybe we should set the cutoff
> to 5.8.3 not 5.8.1.
>
>
Seems OK. Note t
Greetings,
* Noah Misch (n...@leadboat.com) wrote:
> On Mon, Oct 04, 2021 at 10:57:46PM -0400, Stephen Frost wrote:
> > "A role is not considered to hold WITH ADMIN OPTION on itself, but it
> > may grant or revoke membership in itself from a database session where
> > the session user matches the
út 5. 10. 2021 v 14:30 odesílatel Daniel Gustafsson
napsal:
> > On 1 Oct 2021, at 15:19, Daniel Gustafsson wrote:
>
> > I'm still not happy with the docs, I need to take another look there and
> see if
> > I make them more readable but otherwise I don't think there are any open
> issues
> > with
https://vmware.com/
pg_dump-filteropt-20211005.patch
Description: Binary data
Bharath Rupireddy writes:
> On Tue, Oct 5, 2021 at 2:50 PM bt21tanigaway
> wrote:
>> Log output takes time between several seconds to a few tens when using
>> ‘SELECT pg_log_backend_memory_contexts(1234)’ with PID of ‘autovacuum
>> launcher’.
>> I made a patch for this problem.
> Thanks for the
"Verona, Luiz" writes:
> I am writing to resurrect this 3-year-old thread. Attached is a patch to
> address earthdistance related failures during pg_restore.
> The proposed patch will:
> - Create a new version of earthdistance (1.2) and make this new version
> default
> - Change earthdistance
=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= writes:
> Tom Lane writes:
>> Hard to tell if that is a local update or official IBM distribution.
> Looks like they update the Perl version in OS updates and service packs:
> https://www.ibm.com/support/pages/aix-perl-updates-and-support-perlrte
Oh, in
Tom Lane writes:
> Interestingly, although cpan's table says AIX 7.1 shipped with perl
> 5.10.1, what's actually on those buildfarm animals is
>
> tgl@gcc111:[/home/tgl]which perl
> /usr/bin/perl
> tgl@gcc111:[/home/tgl]ls -l /usr/bin/perl
> lrwxrwxrwx1 root system 29 Nov 09 202
=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= writes:
> Daniel Gustafsson writes:
>> Not being able to test against older versions in the builfarm seems like a
>> pretty compelling reason to set 5.8.3 as the required version.
> Looking at the list of Perl versions shipped with various OSes
> (https:
I was trying to understand the v1 patch and found that at the end
RequestCheckpoint() is called unconditionally, I think that should
have been called if REDO had performed, here is the snip from the v1
patch:
/*
- * If this was a promotion, request an (online) checkpoint now. This isn't
- * requ
On Tue, Oct 5, 2021 at 4:08 PM Simon Riggs wrote:
>
> On Mon, 27 Sept 2021 at 06:52, Amit Kapila wrote:
> >
> > On Thu, Sep 23, 2021 at 11:11 AM Dilip Kumar wrote:
> > >
> > > On Thu, Sep 23, 2021 at 10:04 AM Sadhuprasad Patro
> > > wrote:
> > > >
> > > > And to get the multi-column hash index
On Tue, Oct 5, 2021 at 11:10 AM Greg Nancarrow wrote:
>
> On Tue, Oct 5, 2021 at 3:11 PM Amit Kapila wrote:
> >
> > > Code has been added to prevent a table being set (via ALTER TABLE) to
> > > UNLOGGED if it is part of a publication, but I found that I could
> > > still add all tables of a schem
On 10/5/21 4:29 AM, Stephen Frost wrote:
> Greetings,
>
> * Peter Geoghegan (p...@bowt.ie) wrote:
>> On Sun, Oct 3, 2021 at 1:30 PM Tom Lane wrote:
>>> Fair. My concern here is mostly that we not just keep kicking the
>>> can down the road. If we see that a patch has been hanging around
>>> thi
On Fri, 13 Aug 2021 at 05:01, Amit Kapila wrote:
>
> On Thu, Aug 12, 2021 at 8:30 PM Robert Haas wrote:
> >
> > On Thu, Aug 12, 2021 at 12:22 AM Amit Kapila
> > wrote:
> > > The design of the patch has changed since the initial proposal. It
> > > tries to perform unique inserts by holding a wri
On Mon, Oct 4, 2021 at 1:57 PM Rushabh Lathia
wrote:
>
>
>
> On Fri, Oct 1, 2021 at 2:29 AM Robert Haas wrote:
>>
>> On Thu, Sep 30, 2021 at 7:59 AM Amul Sul wrote:
>> > To find the value of InRecovery after we clear it, patch still uses
>> > ControlFile's DBState, but now the check condition
On Mon, 27 Sept 2021 at 06:52, Amit Kapila wrote:
>
> On Thu, Sep 23, 2021 at 11:11 AM Dilip Kumar wrote:
> >
> > On Thu, Sep 23, 2021 at 10:04 AM Sadhuprasad Patro
> > wrote:
> > >
> > > And to get the multi-column hash index selected, we may set
> > > enable_hashjoin =off, to avoid any condit
On Tue, Oct 5, 2021 at 2:50 PM bt21tanigaway
wrote:
>
> Hi,
>
> Log output takes time between several seconds to a few tens when using
> ‘SELECT pg_log_backend_memory_contexts(1234)’ with PID of ‘autovacuum
> launcher’.
> I made a patch for this problem.
Thanks for the patch. Do we also need to d
Daniel Gustafsson writes:
>> On 5 Oct 2021, at 05:12, Tom Lane wrote:
>
>> In short: (a) we're not testing against anything older than 5.8.3
>> and (b) it seems quite unlikely that anybody cares about 5.8.x anyway.
>> So if we want to mess with this, maybe we should set the cutoff
>> to 5.8.3 no
Hi Robert,
I have fixed the autoFlush issue. Basically, I was wrongly initializing
the lz4 preferences in bbsink_lz4_begin_archive() instead of
bbsink_lz4_begin_backup(). I have fixed the issue in the attached
patch, please have a look at it.
Regards,
Jeevan Ladhe
On Fri, Sep 24, 2021 at 6:27 P
1 - 100 of 107 matches
Mail list logo
