On 2021/10/05 10:58, Kyotaro Horiguchi wrote:
At Tue, 5 Oct 2021 00:59:46 +0900, Fujii Masao <masao.fu...@oss.nttdata.com> 
wrote in
I think that it's better to comment why "retry" is not necessary
when not in standby mode.

-------------------
When not in standby mode, an invalid page header should cause recovery
to end, not retry reading the page, so we don't need to validate the
page
header here for the retry. Instead, ReadPageInternal() is responsible
for
the validation.

LGTM.

Thanks for the review! I updated the comment and pushed the patch.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION


Reply via email to