On 10/5/21 1:25 PM, Bharath Rupireddy wrote: > Hi, > > While working one of the internal features, I figured out that we > don't have subscription TAP tests option for "vcregress" tool for msvc > builds. Is there any specific reason that we didn't add "vcregress > subscriptioncheck" option similar to "vcregress recoverycheck"? It > looks like one can run with "vcregress taptest" option and PROVE_FLAGS > environment variable(I haven't tried it myself), but having > subscriptioncheck makes life easier. > > Here's a small patch for that. Thoughts? >
I would actually prefer to reduce the number of special things in vcregress.pl rather than add more. We should be able to add a new set of TAP tests somewhere without having to do anything to vcregress.pl. That's more or less why I added the taptest option in the first place. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
