On Friday, September 6, 2019 11:51 PM (GMT+9), Alvaro Herrera wrote:
Hi Alvaro,
Thank you very much for the review!
> On 2019-Sep-05, Jamison, Kirk wrote:
>
> > I also mentioned it from my first post if we can just remove this dead code.
> > If not, it would require to modify the function becaus
On Thu, Sep 05, 2019 at 03:52:48PM +0900, Michael Paquier wrote:
> Right, there was this part. This brings also the point of having one
> interface for the backend as all the error messages for the backend
> are actually the same, with the most simple name being that:
> pg_strtoint(value, size, er
Confirmed. Thank you all for your help.
The only concern is that this test:
SET TRANSACTION READ WRITE\; COMMIT AND CHAIN; -- error
SHOW transaction_read_only;
SET TRANSACTION READ WRITE\; ROLLBACK AND CHAIN; -- error
SHOW transaction_read_only;
makes more sense with READ ONLY bec
On Sun, Sep 8, 2019 at 1:06 PM Amit Kapila wrote:
>
> On Thu, Sep 5, 2019 at 2:17 PM Masahiko Sawada wrote:
> >
> > Thanks. I hope the attached new patch fixes this issue.
> >
>
Some more comments:
*
+SELECT t_infomask, t_infomask2, flags
+FROM heap_page_items
(get_raw_page('test1', 0)),
+ L
On Sun, Sep 08, 2019 at 07:44:16PM -0400, Tom Lane wrote:
> Yeah, perhaps, but I wasn't sure about how to do that easily.
> Feel free to add it ...
Feeding the makefile contents and then doing a lookup using =~ should
be enough. I think that we should just refactor set of routines for
fetchTests(
On 9/8/19 6:18 PM, Tom Lane wrote:
> Andrew Dunstan writes:
>> On 9/8/19 5:59 PM, Tom Lane wrote:
>>> Hm. Changing the buildfarm script would be an alternative way to
>>> fix the issue so far as the buildfarm is concerned, but it doesn't
>>> seem like it provides any useful way for one to manua
Michael Paquier writes:
> I think that it is a good idea to add in subdircheck an extra path to
> check after TAP tests and run optionally these on top of the normal
> regression tests. I have a couple of comments.
> Shouldn't we check after TAP_TESTS in the Makefile?
Yeah, perhaps, but I wasn'
On Sun, Sep 08, 2019 at 06:18:33PM -0400, Tom Lane wrote:
> Sure, I saw that you can run one test that way ... but what do you
> do when you want the equivalent of check-world?
I think that it is a good idea to add in subdircheck an extra path to
check after TAP tests and run optionally these on t
Andrew Dunstan writes:
> On 9/8/19 5:59 PM, Tom Lane wrote:
>> Hm. Changing the buildfarm script would be an alternative way to
>> fix the issue so far as the buildfarm is concerned, but it doesn't
>> seem like it provides any useful way for one to manually invoke
>> the tests on Windows. Or am
On 9/8/19 5:59 PM, Tom Lane wrote:
> Andrew Dunstan writes:
>> On 9/8/19 12:07 PM, Tom Lane wrote:
>>> It looks to me like the reason is that src/tools/msvc/vcregress.pl's
>>> subroutine subdircheck isn't considering the possibility that
>>> subdirectories of src/test/modules contain TAP tests.
Diagnosing this took quite a lot of time and detective work. For some
reason I don't quite understand, when calling the Windows command
processor in a modern msys2/WindowsServer2019 installation, you need to
double the slash, thus:
cmd //c foo.bat
Some Internet postings at least seem to su
Andrew Dunstan writes:
> I'm going to disable this test (src/test/recovery/t/017_shm.pl) on
> Windows on the back branches too unless there's a violent objection.
As I said before, I think that test does nothing useful unless SysV
shmem is in use, so I see no reason not to disable it on Windows.
Andrew Dunstan writes:
> On 9/8/19 12:07 PM, Tom Lane wrote:
>> It looks to me like the reason is that src/tools/msvc/vcregress.pl's
>> subroutine subdircheck isn't considering the possibility that
>> subdirectories of src/test/modules contain TAP tests. The
>> same code is used for contrib, so s
On 9/6/19 3:51 PM, Andrew Dunstan wrote:
> On 9/6/19 2:42 PM, Tom Lane wrote:
>> Andrew Dunstan writes:
>>> Given your stated intention, I think the simplest way to get it is just
>>> this, without worrying about what the perl modules might do:
>>> -if ($@)
>>> +if ($@ || $windows_os)
>> WFM, do
On 9/8/19 12:07 PM, Tom Lane wrote:
> I noticed $subject while checking to see if commit db4383189's
> new test script was behaving properly in the buildfarm. dory,
> for one, should be running it but it just isn't.
>
> It looks to me like the reason is that src/tools/msvc/vcregress.pl's
> subro
On Tue, Sep 3, 2019 at 2:19 AM Alvaro Herrera wrote:
>
> On 2019-Sep-03, Alexander Korotkov wrote:
>
> > I think patches 0001-0008 are very clear and extends our index-AM
> > infrastructure in query straightforward way. I'm going to propose
> > them for commit after some further polishing.
>
> Hm
On 2019-09-07 18:32, fn ln wrote:
>> Missed them somehow. But I don't think they're quite sufficient. I think
>> at least we also need tests that test things like multi-statement
>> exec_simple-query() *with* explicit transactions and chaining.
> Added a few more tests for that.
I committed this p
On Fri, Sep 6, 2019 at 5:44 PM Alexander Korotkov
wrote:
> I'm going to push both if no objections.
So, pushed!
--
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
On Wed, Sep 4, 2019 at 5:43 PM Murat Tuncer wrote:
> Hello hackers
>
> I am getting sporadic errors when I tried to use PG12 bionic debian
> repository.
>
> Here is the error message that is result of apt-get update.
> ---
> Failed to fetch
> http://apt.postgresql.org/pub/repos/apt/dists/
## Tom Lane (t...@sss.pgh.pa.us):
> I took a stab at fixing this, but lacking a Windows environment
> to test in, I can't be sure if it works. The attached does kinda
> sorta work if I run it in a Linux environment --- but I found that
> system() doesn't automatically expand "t/*.pl" on Linux. I
Peter Eisentraut writes:
> On 2019-09-07 22:18, Tom Lane wrote:
>> So this subject has just intruded itself again, because new buildfarm
>> member "morepork" is failing in the pre-v10 branches, because ... you
>> guessed it ... it has "python3" but not "python". This situation is
>> going to get
I noticed $subject while checking to see if commit db4383189's
new test script was behaving properly in the buildfarm. dory,
for one, should be running it but it just isn't.
It looks to me like the reason is that src/tools/msvc/vcregress.pl's
subroutine subdircheck isn't considering the possibili
On 2019-09-07 22:18, Tom Lane wrote:
> So this subject has just intruded itself again, because new buildfarm
> member "morepork" is failing in the pre-v10 branches, because ... you
> guessed it ... it has "python3" but not "python". This situation is
> going to get worse, not better, as time goes
Hello
On 2019/09/06 23:19, Tomas Vondra wrote:
> On Wed, Sep 04, 2019 at 07:19:47PM +0300, Sergei Kornilov wrote:
>>
>> ...
>>
>> Results:
>>
>> test | mode | average_tps | degradation_perc
>> --+--+-+--
>> head_no_pgss
Hello
> Hearing no comments, I've pushed that patch, and marked the v12
> open item closed.
Thank you!
regards, Sergei
> 1 сент. 2019 г., в 15:53, Andrey Borodin написал(а):
>
>
>
Here's V3 of the patch set.
Changes:
1. Added some documentation of new sort support routines
2. Fixed bug with dirty pages
I did not add sort support procs to built-in boxes, circles and polys, since it
may be not optimal index
Alvaro, Peter, thanks for working on this!
> 7 сент. 2019 г., в 6:26, Peter Geoghegan написал(а):
>
> On Fri, Sep 6, 2019 at 3:22 PM Peter Geoghegan wrote:
>> I'll take care of it, then.
>
> Attached is v10, which has some comment and style fix-ups, including
> the stuff Alvaro mentioned. It a
On Thu, Sep 5, 2019 at 2:17 PM Masahiko Sawada wrote:
>
> Thanks. I hope the attached new patch fixes this issue.
>
*
+-- decode infomask flags as human readable flag names
+CREATE FUNCTION heap_infomask_flags(
+ infomask integer,
+ infomask2 integer,
+ decode_combined boolean D
28 matches
Mail list logo
