On 9/6/19 3:51 PM, Andrew Dunstan wrote: > On 9/6/19 2:42 PM, Tom Lane wrote: >> Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: >>> Given your stated intention, I think the simplest way to get it is just >>> this, without worrying about what the perl modules might do: >>> -if ($@) >>> +if ($@ || $windows_os) >> WFM, do you want to push that? >> >> > > done. > >
[redirected to -hackers] I'm going to disable this test (src/test/recovery/t/017_shm.pl) on Windows on the back branches too unless there's a violent objection. The reason is that the script runs "postgres --single" and that fails on Windows when run by an administrative account. We've carefully enabled postgres and its tests to run safely under an admin account. I discovered this as part of my myss2 testing. cheers andrew