On 9/8/19 12:07 PM, Tom Lane wrote: > I noticed $subject while checking to see if commit db4383189's > new test script was behaving properly in the buildfarm. dory, > for one, should be running it but it just isn't. > > It looks to me like the reason is that src/tools/msvc/vcregress.pl's > subroutine subdircheck isn't considering the possibility that > subdirectories of src/test/modules contain TAP tests. The > same code is used for contrib, so several existing TAP tests > are being missed there too. > > I took a stab at fixing this, but lacking a Windows environment > to test in, I can't be sure if it works. The attached does kinda > sorta work if I run it in a Linux environment --- but I found that > system() doesn't automatically expand "t/*.pl" on Linux. Is that > an expected difference between Linux and Windows perl? I hacked > around that by adding a glob() call in sub tap_check, as seen in > the first hunk below, but I'm not very sure if that hunk should > get committed or not. > > For ease of review, I did not re-indent the main part of sub > subdircheck, though that needs to be done before committing. > > Anybody with suitable tools care to test/commit this? > >
Actually, I think vcregress.pl is OK, this is a gap in the buildfarm client's coverage that will be fixed when I make a new release. Any day now I hope. See <https://github.com/PGBuildFarm/client-code/commit/1fc4e81e831fda64d62937de242ecda0ba145901> bowerbird which is already running that code is running the test you refer to: <https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=bowerbird&dt=2019-09-08%2017%3A51%3A19&stg=test_misc-check> cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
