Re: Undo logs

On Thu, Nov 29, 2018 at 6:27 PM Dilip Kumar wrote: > > On Mon, Nov 26, 2018 at 2:13 PM Amit Kapila wrote: > > > > 10. > > + if (!UndoRecPtrIsValid(multi_prep_urp)) > > + urecptr = UndoRecordAllocateMulti(urec, 1, upersistence, txid); > > + else > > + urecptr = multi_prep_urp; > > + > > + size = U

Re: pgsql: Switch pg_verify_checksums back to a blacklist

On Sat, Dec 01, 2018 at 08:00:16AM +0900, Michael Paquier wrote: > Thanks Andrew for confirming. I have committed your suggestion, which > should calm down jacana. And it is now green: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2018-12-01%2004%3A02%3A53 -- Michael signatu

Re: WIP: Avoid creation of the free space map for small tables

On 11/29/18, Amit Kapila wrote: > On Thu, Nov 29, 2018 at 3:07 PM John Naylor wrote: >> Done. I tried adding it to several schedules, but for some reason >> vacuuming an empty table failed to truncate the heap to 0 blocks. >> Putting the test in its own group fixed the problem, but that doesn't >

Re: [HACKERS] proposal: schema variables

so 1. 12. 2018 v 0:16 odesílatel Dmitry Dolgov <9erthali...@gmail.com> napsal: > > On Wed, Nov 21, 2018 at 8:25 AM Pavel Stehule > wrote: > > > > just rebase > > Thanks for working on this patch. > > I'm a bit confused, but cfbot again says that there are some conflicts. > Probably they are the m

Re: make installcheck-world in a clean environment

Hello, 30.11.2018 23:59, Dmitry Dolgov wrote: >> On Sun, Nov 18, 2018 at 8:31 AM Alexander Lakhin wrote: >> >> I've modified the patch to use the installed version of pg_regress. It >> simplifies a lot. The main idea of the change is to not build pg_regress. > Hi, > > I've noticed that for this p

Re: Synchronous replay take III

On Sat, Dec 01, 2018 at 02:48:29PM +1300, Thomas Munro wrote: > On Sat, Dec 1, 2018 at 9:06 AM Dmitry Dolgov <9erthali...@gmail.com> wrote: >> Unfortunately, cfbot says that patch can't be applied without conflicts, >> could >> you please post a rebased version and address commentaries from Masahi

Re: Synchronous replay take III

On Sat, Dec 1, 2018 at 9:06 AM Dmitry Dolgov <9erthali...@gmail.com> wrote: > Unfortunately, cfbot says that patch can't be applied without conflicts, could > you please post a rebased version and address commentaries from Masahiko? Right, it conflicted with 4c703369 and cfdf4dc4. While rebasing

Re: [PATCH] Log CSV by default

On Fri, Nov 30, 2018 at 04:55:30PM -0500, Tom Lane wrote: > Andres Freund writes: > > On 2018-11-30 19:53:18 +0100, David Fetter wrote: > >> This makes it much simpler for computers to use the logs while not > >> making it excessively difficult for humans to use them. > > > While perhaps not exce

Re: [PATCH] Log CSV by default

On Fri, Nov 30, 2018 at 06:11:03PM -0500, Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> I think we should reject this out of hand. > > Agreed. +1. -- Michael signature.asc Description: PGP signature

Frontends including fd.h

Hi all, We have a couple of frontend binaries (pg_rewind, and now pg_verify_checksums) including directly fd.h to get the definitions of PG_TEMP_FILES_DIR and PG_TEMP_FILE_PREFIX. This is a poor choice I think, because fd.h is aimed at being used by the backend, and there are some routines decla

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

>On Sat, Dec 1, 2018 at 12:49 AM Dave Cramer wrote: > > Thanks, I have done a preliminary check and it seems pretty straightforward. > > I will clean it up for Monday Great, thank you!

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

Dmitry, Thanks, I have done a preliminary check and it seems pretty straightforward. I will clean it up for Monday Thanks for your patience! Dave Cramer On Fri, 30 Nov 2018 at 18:22, Dmitry Dolgov <9erthali...@gmail.com> wrote: > On Sat, Dec 1, 2018 at 12:17 AM Dave Cramer wrote: > > > > Wh

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

On Sat, Dec 1, 2018 at 12:17 AM Dave Cramer wrote: > > Why is this being closed? I did not see the first email looking for > clarification. Well, mostly due total absence of response and broken mind reading crystal ball. > I can certainly rebase it. Yes, please do. I'll change the CF item stat

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

Why is this being closed? I did not see the first email looking for clarification. The history is the original author dropped off the planet (no idea where he is) I can certainly rebase it. Dave Cramer On Fri, 30 Nov 2018 at 18:00, Dmitry Dolgov <9erthali...@gmail.com> wrote: > > On Mon, Nov

Re: [HACKERS] proposal: schema variables

> On Wed, Nov 21, 2018 at 8:25 AM Pavel Stehule wrote: > > just rebase Thanks for working on this patch. I'm a bit confused, but cfbot again says that there are some conflicts. Probably they are the minor one, from src/bin/psql/help.c For now I'm moving it to the next CF.

Re: [PATCH] Log CSV by default

Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Andres Freund writes: > > On 2018-11-30 19:53:18 +0100, David Fetter wrote: > >> This makes it much simpler for computers to use the logs while not > >> making it excessively difficult for humans to use them. > > > While perhaps not excessively

Re: pgsql: Avoid duplicate XIDs at recovery when building initial snapshot

On Fri, Nov 30, 2018 at 02:55:47PM +, Simon Riggs wrote: > 1df21ddb looks OK to me and was simple enough to backpatch safely. Thanks for the feedback! > Seems excessive to say that the WAL record is corrupt, it just contains > duplicates, just as exported snapshots do. There's a few other imp

Re: Add extension options to control TAP and isolation tests

On Fri, Nov 30, 2018 at 02:18:04PM +0300, Arthur Zakirov wrote: > As far as I understand bloom TAP tests are stable on some platforms, such as > linux. Can be TAP test disabled only for some specific platforms? That can be done with PORTNAME. However I am doubting that those tests are even reliab

Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

> On Mon, Nov 19, 2018 at 4:58 PM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > On Tue, Jul 24, 2018 at 5:52 PM Dave Cramer wrote: > > > > Back in 2016 a patch was proposed that seems to have died on the vine. See > > https://www.postgresql.org/message-id/flat/cafgjrd3hdyoa33m69tbeofnner2bzb

Re: pgsql: Switch pg_verify_checksums back to a blacklist

On Fri, Nov 30, 2018 at 02:18:18PM -0500, Andrew Dunstan wrote: > All it actually needs is this additional line after the mkdir: > >$tablespace_dir = TestLib::real_dir($tablespace_dir); > > Explanation: TAP tests on msys need to run with the DTK perl, which > understands msys virtualized path

Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead

> On Mon, Nov 19, 2018 at 2:30 PM Nikolay Shaplov wrote: > > В письме от 2 октября 2018 13:46:13 пользователь Michael Paquier написал: > > On Fri, Sep 14, 2018 at 09:30:25PM +0300, Nikolay Shaplov wrote: > > > BTW this commit shows why do this patch is important: 857f9c36 adds new > > > option for

Re: NOTIFY and pg_notify performance when deduplicating notifications

> On Mon, Nov 19, 2018 at 8:30 AM Julien Demoor wrote: > > Thank you for the review. I've addressed all your points in the attached > patch. The patch was made against release 11.1. I've noticed, that cfbot complains about this patch [1], since: Duplicate OIDs detected: 3423 found 1 duplicate OI

Re: doc - improve description of default privileges

On 2018-Nov-30, Tom Lane wrote: > I feel if we're going to do anything, we should put a unified description > of privileges and aclitem-reading into section 5.6, and take that material > out of the various places where it lives now. Like the attached, in which > I failed to resist the temptation

Re: [HACKERS] Fix performance degradation of contended LWLock on NUMA

> On Fri, Nov 30, 2018 at 10:31 PM Юрий Соколов wrote: > >> Due to lack of response and taking into account this commentary, I'm marking >> this patch as "Returned with feedback", but hopefully I can pick it up later >> to >> improve. > > Good luck. Unexpected for me, but promising reaction - re

Re: [PATCH] Log CSV by default

Andres Freund writes: > On 2018-11-30 19:53:18 +0100, David Fetter wrote: >> This makes it much simpler for computers to use the logs while not >> making it excessively difficult for humans to use them. > While perhaps not excessively so, I think it increases the difficulty > sufficiently that I'

Re: doc - improve description of default privileges

Fabien COELHO writes: > Attached v4: > - moves the table to the privileges section > - updates the table column headers > - adds a privilege/aclitem letter mapping table > - adds some appropriate links towards psql & aclitem TBH, I don't think this goes nearly far enough. It seems like i

Re: [HACKERS] Fix performance degradation of contended LWLock on NUMA

пт, 30 нояб. 2018 г., 19:21 Dmitry Dolgov 9erthali...@gmail.com: > > On Sat, Nov 10, 2018 at 8:37 PM Andres Freund > wrote: > > > > On 2018-11-10 20:18:33 +0100, Dmitry Dolgov wrote: > > > > On Mon, 2 Jul 2018 at 15:54, Jesper Pedersen < > jesper.peder...@redhat.com> wrote: > > > > > > > > The pa

Re: pg_dumpall --exclude-database option

On 11/18/18 1:41 PM, Andrew Dunstan wrote: On 11/17/18 9:55 AM, Alvaro Herrera wrote: The comment in expand_dbname_patterns is ungrammatical and mentions "OID" rather than "name", so I suggest /* * The loop below might sometimes result in duplicate entries in the * output name l

Re: [PATCH] Log CSV by default

> I think having a bin/pg_logparse tool that can parse postgres' config > file and attempt to parse the log contents in whatever format they are > would be much much more useful. Obviously not every log_line_prefix can > be parsed unambiguously, but a lot of formats can, and a lot more > formats ca

[PATCH] Fix Proposal - Deadlock Issue in Single User Mode When IO Failure Occurs

Greetings, Recently, we hit a few occurrences of deadlock when IO failure (including disk full, random remote disk IO failures) happens in single user mode. We found the issue exists on both Linux and Windows in multiple postgres versions. Here are the steps to repro on Linux (as Windows re

Re: make installcheck-world in a clean environment

> On Sun, Nov 18, 2018 at 8:31 AM Alexander Lakhin wrote: > > I've modified the patch to use the installed version of pg_regress. It > simplifies a lot. The main idea of the change is to not build pg_regress. Hi, I've noticed that for this patch cfbot show strange error USE_INSTALLED_ASSETS=1 m

Re: dsa_allocate() faliure

On Fri, Nov 30, 2018 at 08:20:49PM +0100, Jakub Glapa wrote: > In the last days I've been monitoring no segfault occurred but the > das_allocation did. > I'm starting to doubt if the segfault I've found in dmesg was actually > related. The dmesg looks like a real crash, not just OOM. You can hope

Re: pg_dumpall --exclude-database option

> On Sun, Nov 18, 2018 at 7:41 PM Andrew Dunstan > wrote: > > On 11/17/18 9:55 AM, Alvaro Herrera wrote: > > The comment in expand_dbname_patterns is ungrammatical and mentions > > "OID" rather than "name", so I suggest > > Will fix. > > > Other than that, the patch seems fine to me -- I tested a

Re: [PATCH] Log CSV by default

Hi, On 2018-11-30 19:53:18 +0100, David Fetter wrote: > This makes it much simpler for computers to use the logs while not > making it excessively difficult for humans to use them. While perhaps not excessively so, I think it increases the difficulty sufficiently that I'm against such a proposal.

Re: Range phrase operator in tsquery

> On Thu, Nov 15, 2018 at 11:15 PM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > On Fri, 27 Apr 2018 at 13:03, Aleksandr Parfenov > > wrote: > > > > Nowadays, phrase operator in Postgres FTS supports only exact match of > > the distance between two words. It is sufficient for a search of > >

Re: Synchronous replay take III

> On Thu, Nov 15, 2018 at 6:34 AM Masahiko Sawada wrote: > > On Thu, Mar 1, 2018 at 10:40 AM Thomas Munro > > wrote: > > > > In previous threads[1][2][3] I called this feature proposal "causal > > reads". That was a terrible name, borrowed from MySQL. While it is > > probably a useful term of

Re: pgbench doc fix

So I do not think a more precise wording harms. Maybe: "prepared: use extended query protocol with REUSED named prepared statements" would be even less slightly ambiguous. I like this. But maybe we can remove "named"? I also think it makes sense to adjust wording a bit here, and this versio

Re: Add function to release an allocated SQLDA

> On Wed, Nov 14, 2018 at 6:01 PM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > On Wed, 13 Jun 2018 at 06:30, Kato, Sho wrote: > > > > I add a function called ECPGfreeSQLDA() becasue there is no API for > > releasing the SQLDA stored the result set. > > > > On Mon, 18 Jun 2018 at 07:42, Thom

Re: dsa_allocate() faliure

Hi, just a small update. I've configured the OS for taking crash dumps on Ubuntu 16.04 with the following (maybe somebody will find it helpful): I've added LimitCORE=infinity to /lib/systemd/system/postgresql@.service under [Service] section I've reloaded the service config with sudo systemctl daem

Re: pgsql: Switch pg_verify_checksums back to a blacklist

On 11/30/18 12:35 AM, Michael Paquier wrote: On Fri, Nov 30, 2018 at 01:36:43AM +, Michael Paquier wrote: Switch pg_verify_checksums back to a blacklist This basically reverts commit d55241af705667d4503638e3f77d3689fd6be31, leaving around a portion of the regression tests still adapted wi

Re: partitioned tables referenced by FKs

Here's a more credible version of this patch series. 0001 refactors some duplicative code that interprets a pg_constraint row for a foreign key back into a Constraint node. Only what is necessary for current features is read. 0002 moves some code that I added in 3de241dba86f to src/backend/catal

Re: ToDo: show size of partitioned table

čt 29. 11. 2018 v 7:58 odesílatel Michael Paquier napsal: > On Thu, Nov 22, 2018 at 03:47:11PM +0100, Pavel Stehule wrote: > > I have not feel well when I see in one report numbers 40 and 16, I see > much > > more comfortable when I see 24 and 16, but for this I need a different > > perspective >

Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query

On 28/11/2018 14:43, Alvaro Herrera wrote: > On 2018-Nov-28, Amit Kapila wrote: > >> The problem with this idea is that if someone specifies a particular >> parameter using query and the query doesn't return any parameters, >> then it can lead to inadvertent behavior. For example, if user uses >>

Re: pgbench doc fix

On 30/11/2018 15:42, Dmitry Dolgov wrote: >> On Sat, Nov 3, 2018 at 1:08 AM Tatsuo Ishii wrote: >> >>> So I do not think a more precise wording harms. Maybe: "prepared: use >>> extended query protocol with REUSED named prepared statements" would >>> be even less slightly ambiguous. >> >> I like th

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

ath parser/ > + * preprocessor. This XPath parser transforms a XPath expression to > another > + * XPath expression that can be used by libxml2 XPath evaluation. It > doesn't > + * replace libxml2 XPath parser or libxml2 XPath expression evaluation. > > - "add" -> "adds", "def_namespace_name" seems to need to be > replaced with something else. > > + * This transformation add def_namespace_name to any unqualified node > name > + * or attribute name of xpath expression. > I tried to formulate it better, but I am sorry, my English is not good. > > (Sorry, I'll look further later.) > I am sending a updated patch Regards Pavel > regards. > > -- > Kyotaro Horiguchi > NTT Open Source Software Center > default-namespaces-20181130-2.patch.gz Description: application/gzip

Re: Support custom socket directory in pg_upgrade

On 30/11/2018 17:58, Tom Lane wrote: > So we seem to be at an impasse here. By my count, three people have > expressed support for the patch's approach of adding a socket-directory > option, while two people seem to prefer the idea of putting pg_upgrade's > socket under /tmp (possibly with a way t

Re: [HACKERS] WAL logging problem in 9.4.3?

> On Wed, Nov 14, 2018 at 4:48 AM Kyotaro HORIGUCHI > wrote: > > 0004 was shot by e9edc1ba0b. Rebased to the current HEAD. > Successfully built and passeed all regression/recovery tests > including additional recovery/t/016_wal_optimize.pl. Thank you for working on this patch. Unfortunately, cfb

Re: [HACKERS] Optional message to user when terminating/cancelling backend

On Mon, Nov 12, 2018 at 8:36 PM Tom Lane wrote: > > Daniel Gustafsson writes: > > I’ve split the patch into two logical parts, the signalling functionality > > and > > the userfacing terminate/cancel part. For extra clarity I’ve also included > > the > > full v19 patch, in case you prefer that

Re: Support custom socket directory in pg_upgrade

I wrote: > Alvaro Herrera writes: >> On 12/11/2018 20:00, Tom Lane wrote: >>> Also, even if we had an arguably-better idea, I suspect that there would >>> always be cases where it didn't work. >> Surely they can just set TMPDIR if /tmp is not writable? If TMPDIR is >> set and not writable, bark

Re: test_pg_dump missing cleanup actions

Michael, * Michael Paquier (mich...@paquier.xyz) wrote: > On Tue, Sep 04, 2018 at 04:14:15PM -0700, Michael Paquier wrote: > > On Tue, Sep 04, 2018 at 06:02:51PM -0400, Stephen Frost wrote: > >> * Tom Lane (t...@sss.pgh.pa.us) wrote: > >>> I'm confused. Isn't the point of that script exactly to c

Re: [HACKERS] [PATCH v2] Add and report the new "session_read_only" GUC pseudo-variable.

> On Mon, Nov 12, 2018 at 8:30 PM Elvis Pranskevichus wrote: > > On Monday, November 12, 2018 1:08:37 PM EST Tom Lane wrote: > > Looking through the thread, it seems like there's a pretty fundamental > > design issue that hasn't been resolved, namely whether and how this > > ought to interact with

Re: [HACKERS] Fix performance degradation of contended LWLock on NUMA

> On Sat, Nov 10, 2018 at 8:37 PM Andres Freund wrote: > > On 2018-11-10 20:18:33 +0100, Dmitry Dolgov wrote: > > > On Mon, 2 Jul 2018 at 15:54, Jesper Pedersen > > > wrote: > > > > > > The patch from November 27, 2017 still applies (with hunks), > > > > > > https://commitfest.postgresql.org/1

Re: pg_dump multi VALUES INSERT

> On Thu, Nov 8, 2018 at 2:03 PM Surafel Temesgen wrote: > > yes its not much line of code. Attach is a patch that optionally accept the > number of row in a single insert statement and if it is not specified one row > per statement used Hi, Unfortunately, patch needs to be rebased, could you

Re: POC: Cleaning up orphaned files using undo logs

> On Thu, Nov 8, 2018 at 4:03 AM Thomas Munro > wrote: > > On Tue, Nov 6, 2018 at 12:42 AM Kuntal Ghosh > wrote: > > On Thu, Nov 1, 2018 at 8:53 AM Thomas Munro > > wrote: > > > It passes make check on Unix and Windows, though currently it's > > > failing some of the TAP tests for reasons I'm

Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line

> On Wed, Nov 7, 2018 at 10:58 AM Alexey Kondratov > wrote: > > On 30.10.2018 06:01, Michael Paquier wrote: > > > On Mon, Oct 29, 2018 at 12:09:21PM +0300, Alexey Kondratov wrote: > >> Currently in the patch, with dry-run option (-n) pg_rewind only fetches > >> missing WALs to be able to build fi

Re: [PATCH] Improve tab completion for CREATE TABLE

ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes: > Hi hackers, > > Please find attached a patch that adds the following tab completions for > CREATE TABLE: Added to the 2019-01 commitfest: https://commitfest.postgresql.org/21/1895/ - ilmari -- "A disappointingly low fraction of the human ra

Re: [HACKERS] Two pass CheckDeadlock in contentent case

> On Tue, Nov 6, 2018 at 5:19 AM Masahiko Sawada wrote: > > The idea of this patch seems reasonable. > > I've looked at this patch. This patch still can be applied cleanly to > the current HEAD and passed regression tests. > > Here is review comments. Thanks for the review. Just for the records,

Re: Hash Joins vs. Bloom Filters / take 2

On Thu, Nov 1, 2018 at 10:17 PM Tomas Vondra wrote: > > I haven't really planned to work on this anytime soon, unfortunately, > which is why I proposed to mark it as RwF at the end of the last CF. I > already have a couple other patches there, and (more importantly) I > don't have a very clear ide

Re: pg_config wrongly marked as not parallel safe?

Joe Conway writes: > On 11/30/18 3:30 AM, Kyotaro HORIGUCHI wrote: >> # And returning to the topic, I vote for pg_config should be "stable". > And on that note, Does this change does warrant backpatching, or should > be applied to master only? I don't think back-patching the catalog change is re

Re: Flexible permissions for REFRESH MATERIALIZED VIEW

On Mon, Nov 5, 2018 at 4:19 PM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > This patch went through the last two commit fests without any noticeable > activity. As far as I can see, judging from the discussion, there isn't a > single opinion everyone would agree with, except that simply introdu

Re: pg_config wrongly marked as not parallel safe?

Greetings, * Joe Conway (m...@joeconway.com) wrote: > On 11/30/18 3:30 AM, Kyotaro HORIGUCHI wrote: > > # And returning to the topic, I vote for pg_config should be "stable". > > And on that note, Does this change does warrant backpatching, or should > be applied to master only? Given that it's

Re: Undo worker and transaction rollback

> On Mon, Nov 5, 2018 at 1:32 PM Dilip Kumar wrote: > > Updated patch, include defect fix from Kuntal posted on [1]. > > [1] > https://www.postgresql.org/message-id/CAGz5QCKpCG6egFAdazC%2BJgyk7YSE1OBN9h-QpwCkg-NnSWN5AQ%40mail.gmail.com Thanks for working on this feature. Unfortunately, looks lik

Re: [HACKERS] Lazy hash table for XidInMVCCSnapshot (helps Zipfian a bit)

>On Sun, Nov 4, 2018 at 1:27 PM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > > On Sun, 1 Apr 2018 at 19:58, Yura Sokolov wrote: > > > > I didn't change serialized format. Therefore is no need to change > > SerializeSnapshot. > > But in-memory representation were changed, so RestoreSnapshot is

Re: pgsql: Avoid duplicate XIDs at recovery when building initial snapshot

On Thu, 1 Nov 2018 at 06:09, Michael Paquier wrote: > On Tue, Oct 23, 2018 at 10:43:38AM +0900, Michael Paquier wrote: > > Well, following the same kind of thoughts, txid_current_snapshot() uses > > sort_snapshot() to remove all the duplicates after fetching its data > > from GetSnapshotData(), s

Re: Markdown format output for psql, design notes

Hi, No I meant independently of the screen, if there's an LF character > in a cell. Or a '|' character, since that's the same problem: an > element of structure happening to be in the contents. > The specs mentioned upthread don't seem to give any indication > about that being supported. > > i've

Re: pgbench doc fix

> On Sat, Nov 3, 2018 at 1:08 AM Tatsuo Ishii wrote: > > > So I do not think a more precise wording harms. Maybe: "prepared: use > > extended query protocol with REUSED named prepared statements" would > > be even less slightly ambiguous. > > I like this. But maybe we can remove "named"? I also t

Re: [HACKERS] Custom compression methods

> On Thu, Sep 6, 2018 at 5:27 PM Ildus Kurbangaliev > wrote: > > Hi, attached latest set of patches. Rebased and fixed pg_upgrade errors > related with zlib support. Thank you for working on this patch, I believe the ideas mentioned in this thread are quite important for Postgres improvement. Un

Re: pgsql: Avoid duplicate XIDs at recovery when building initial snapshot

> On Thu, Nov 1, 2018 at 7:09 AM Michael Paquier wrote: > > On Tue, Oct 23, 2018 at 10:43:38AM +0900, Michael Paquier wrote: > > Well, following the same kind of thoughts, txid_current_snapshot() uses > > sort_snapshot() to remove all the duplicates after fetching its data > > from GetSnapshotData

Re: [HACKERS] Can ICU be used for a database's default sort order?

> On Tue, Oct 30, 2018 at 9:07 AM Andrey Borodin wrote: > > Hi! > > > 2 окт. 2018 г., в 11:37, Michael Paquier написал(а): > > > > Please note that the latest patch set does not apply, so this has been > > switched to commit fest 2018-11, waiting on author for a rebase. > > PFA rebased version. I

Re: COPY FROM WHEN condition

On 11/30/18 2:00 PM, Surafel Temesgen wrote: On Thu, Nov 29, 2018 at 2:17 AM Tomas Vondra mailto:tomas.von...@2ndquadrant.com>> wrote: (c) allow VOLATILE functions in the FILTER clause, but change the behavior to make the behavior sane  Did changing the behavior means getting ne

Re: pg_config wrongly marked as not parallel safe?

On 11/30/18 3:30 AM, Kyotaro HORIGUCHI wrote: > # And returning to the topic, I vote for pg_config should be "stable". And on that note, Does this change does warrant backpatching, or should be applied to master only? Joe -- Crunchy Data - http://crunchydata.com PostgreSQL Support for Secure En

Re: New GUC to sample log queries

On 2018-Nov-30, Sergei Kornilov wrote: > > Ah, I feared that some compiler would not be smart enough to be silent > > about that. I hope it does not emit a warning with this patch? > Yes, with this change build is clean. Thank you Thanks, pushed. > PS: currently i use old gcc (Debian 4.9.2-10+de

Re: COPY FROM WHEN condition

On Thu, Nov 29, 2018 at 2:17 AM Tomas Vondra wrote: (c) allow VOLATILE functions in the FILTER clause, but change the > behavior to make the behavior sane > Did changing the behavior means getting new snapshot before evaluating a tuple to ensure the function sees results of any previously execu

Re: [HACKERS] Support for Secure Transport SSL library on macOS as OpenSSL alternative

> On Sun, Oct 28, 2018 at 11:42 PM Daniel Gustafsson wrote: > > > On 26 Sep 2018, at 23:19, Daniel Gustafsson wrote: > > > I’ve rebased these changes on top of your v9 patch as the attached v10. > > Attached is a v11 rebased on top of todays HEAD, which had minor conflicts due > to the recent snp

Re: Connection slots reserved for replication

Hi, attaching the new version of the patch. Now it simply reserves max_wal_senders slots in the ProcGlobal, what guarantees that only walsender process could use them. Regards, -- Alexander Kukushkin diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c index a33a

Re: [PATCH] Incremental sort (was: PoC: Partial sort)

> On Mon, Mar 20, 2017 at 10:34 AM Alexander Korotkov > wrote: > > Please, find rebased patch in the attachment. It's been a while since this patch was posted. There is already some amount of feedback in this thread, and the patch itself unfortunately has some conflicts with the current master.

Re: New GUC to sample log queries

Hi > Ah, I feared that some compiler would not be smart enough to be silent > about that. I hope it does not emit a warning with this patch? Yes, with this change build is clean. Thank you PS: currently i use old gcc (Debian 4.9.2-10+deb8u1) 4.9.2 regards, Sergei

Re: New GUC to sample log queries

On 2018-Nov-30, Sergei Kornilov wrote: > Hello > > I can not build current HEAD cleanly. I got warning: > > > postgres.c: In function ‘check_log_duration’: > > postgres.c:2254:17: warning: ‘in_sample’ may be used uninitialized in this > > function [-Wmaybe-uninitialized] > > if ((exceeded &&

Re: GiST VACUUM

> On Sun, Oct 28, 2018 at 6:32 PM Andrey Borodin wrote: > > Hi everyone! > > > 2 окт. 2018 г., в 6:14, Michael Paquier написал(а): > > Andrey, your latest patch does not apply. I am moving this to the next > > CF, waiting for your input. > > I'm doing preps for CF. > Here's rebased version. Loo

Re: "SELECT ... FROM DUAL" is not quite as silly as it appears

On 11/29/18 22:13, Tom Lane wrote: Ooops, I had not seen this before sending v4 patch. Doesn't seem worth posting a v5 for, but I'll be sure to fix it. Thanks for updating, v4 looks good to me. -- Alexander Kuzmenkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Comp

Re: libpq host/hostaddr/conninfo inconsistencies

> On Fri, Oct 26, 2018 at 9:22 AM Fabien COELHO wrote: > > To sum up: > > (1) you are somehow against changing the current implementation, eg > erroring out on possibly misleading configurations, because you do not > think it is really useful to help users in those cases. > > (2) you are not again

Re: Add extension options to control TAP and isolation tests

On 29.11.2018 05:00, Michael Paquier wrote: The main patch had to be reverted a couple of days ago via 1d7dd18, and I have been digging and fixing the set of issues the buildfarm has been complaining about since. There were two problems: Thank you for working on the patch. I run world-check.

Re: New GUC to sample log queries

Hello I can not build current HEAD cleanly. I got warning: > postgres.c: In function ‘check_log_duration’: > postgres.c:2254:17: warning: ‘in_sample’ may be used uninitialized in this > function [-Wmaybe-uninitialized] > if ((exceeded && in_sample) || log_duration) Should not we have such cha

Re: de-deduplicate code in DML execution hooks in postgres_fdw

(2018/11/30 2:58), Dmitry Dolgov wrote: On Mon, Oct 1, 2018 at 2:55 PM Etsuro Fujita wrote: (2018/10/01 19:42), Michael Paquier wrote: On Mon, Jul 23, 2018 at 02:17:38PM +0530, Ashutosh Bapat wrote: Fujita-san, you are registered as a reviewer of this patch. Are you planning to look at it so

Re: [PATCH] pg_hba.conf : new auth option : clientcert=verify-full

Hello Thomas, thank you for reviewing our patch. > Why did you put "trust" there instead of "$authmethod" like the previous > lines? That is a good question in deed. We changed that accordingly. > The tests pass and show the feature working correctly. I think this > is getting close to committ

Re: FETCH FIRST clause PERCENT option

On Fri, Nov 30, 2018 at 10:23 AM Surafel Temesgen wrote: > Attach is a patch that include a fix for it > > By mistake the patch coerce OFFSET clause to float8 too which is not necessary . The attached patch correct it regards Surafel diff --git a/doc/src/sgml/ref/select.sgml b/doc/src/sgml/ref/s

Re: Speeding up text_position_next with multibyte encodings

> At Fri, 19 Oct 2018 15:52:59 +0300, Heikki Linnakangas wrote > Attached is a patch to speed up text_position_setup/next(), in some > common cases with multibyte encodings. Hi, Unfortunately, patch doesn't compile anymore due: varlena.c: In function ‘text_position_next_internal’: varlena.c:133

Re: Reduce amount of WAL generated by CREATE INDEX for gist, gin and sp-gist

> On Tue, Jul 31, 2018 at 6:36 AM Andrey Lepikhov > wrote: > > With the consent of Anastasia I will improving this patch further. > Attachment contains next version of the patch set. Thank you. I played a bit with this patch, and can confirm visible WAL size reduction (it's rather obvious, but s

RE: [PROPOSAL]a new data type 'bytea' for ECPG

Meskes-san Sorry to bother you, but I hope any comment of yours. Regards Ryo Matsumura > Subject: RE: [PROPOSAL]a new data type 'bytea' for ECPG > > > From: Tsunakawa, Takayuki [mailto:tsunakawa.ta...@jp.fujitsu.com] > > > > I think the host variable data type that corresponds to the server-sid

Re: [HACKERS] Cached plans and statement generalization

> On Fri, Nov 30, 2018 at 3:06 AM Yamaji, Ryo wrote: > > On Fri, Nov 30, 2018 at 3:48 AM, Dmitry Dolgov wrote: > > > Hi, > > > > Thanks for reviewing. Since another CF is about to end, maybe you can > > post the full review feedback? > > Since I had been busy with my private work, I couldn't revie

Re: postgres_fdw: oddity in costing aggregate pushdown paths

(2018/11/28 13:38), Etsuro Fujita wrote: > BTW another thing I noticed is this comment on costing aggregate > pushdown paths using local statistics in estimate_path_cost_size: > > * Also, core does not care about costing HAVING expressions and > * adding that to the cos

Re: Changing the autovacuum launcher scheduling; oldest table first algorithm

> On Fri, Nov 30, 2018 at 3:05 AM Masahiko Sawada wrote: > > On Fri, Nov 30, 2018 at 10:48 AM Michael Paquier wrote: > > > > On Thu, Nov 29, 2018 at 06:21:34PM +0100, Dmitry Dolgov wrote: > > > Nothing changed since then, but also the patch got not enough review to > > > say > > > that there was

Re: [Todo item] Add entry creation timestamp column to pg_stat_replication

On Thu, Nov 29, 2018 at 05:43:26PM +0900, myungkyu.lim wrote: > Changed field name 'last_msg_send_time' to 'reply_time'. Looks pretty to me at quick glance, unfortunately I have not spent much time on it, particularly testing it. + + reply_time + timestamp with time zone + Send ti

Re: New GUC to sample log queries

On 11/30/18 7:42 AM, Nikolay Samokhvalov wrote: On Thu, Nov 29, 2018 at 1:49 PM Alvaro Herrera > wrote: Thanks!  I pushed this with two changes -- one was to reword the docs a bit more, and the other was to compute in_sample only if it's going to be u

Re: New GUC to sample log queries

On 11/29/18 10:48 PM, Alvaro Herrera wrote: Thanks! I pushed this with two changes -- one was to reword the docs a bit more, and the other was to compute in_sample only if it's going to be used (when exceeded is true). I hope this won't upset any compilers ... Thanks! I wonder if there's a

Re: pg_config wrongly marked as not parallel safe?

At Thu, 29 Nov 2018 15:03:00 -0800, Andres Freund wrote in <20181129230300.vkj3csjwk7jt2...@alap3.anarazel.de> > Hi, > > On 2018-11-29 16:23:42 -0500, Robert Haas wrote: > > Generally, I think Andres is wrong to argue that immutability > > shouldn't mean *anything* across major versions. If we

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

Hello. At Fri, 30 Nov 2018 07:48:26 +0100, Pavel Stehule wrote in > Hi > > čt 29. 11. 2018 v 14:44 odesílatel Dmitry Dolgov <9erthali...@gmail.com> > napsal: > > > > On Fri, Sep 21, 2018 at 1:30 PM Pavel Stehule > > wrote: > > > > > > Thank you for comments > > > > > > Attached updated patch

Re: Fixes for missing schema qualifications

On Thu, Nov 29, 2018 at 10:29:04PM -0800, Noah Misch wrote: > This patch provides no meaningful increment in security or reliability, but it > does improve stylistic consistency. Fine to proceed on those grounds, but > this description doesn't fit. Indeed, you are right. I agree. > > --- a/src/