> On Tue, Oct 30, 2018 at 9:07 AM Andrey Borodin <x4...@yandex-team.ru> wrote: > > Hi! > > > 2 окт. 2018 г., в 11:37, Michael Paquier <mich...@paquier.xyz> написал(а): > > > > Please note that the latest patch set does not apply, so this has been > > switched to commit fest 2018-11, waiting on author for a rebase. > > PFA rebased version. I've added LDFLAGS_INTERNAL += $(ICU_LIBS) in libpq,
Thanks for providing the rebased version. > but I'm not entirely sure this is correct way to deal with complaints on ICU > functions from libpq linking. Well, it was enough on my own Gentoo, where patch actually compiles without errors and pass "make check". But for cfbot it doesn't compile, I'm not sure why. ../../../src/interfaces/libpq/libpq.so: undefined reference to `ucol_open_52' ../../../src/interfaces/libpq/libpq.so: undefined reference to `uloc_toLanguageTag_52' ../../../src/interfaces/libpq/libpq.so: undefined reference to `u_errorName_52' ../../../src/interfaces/libpq/libpq.so: undefined reference to `ucol_getVersion_52' ../../../src/interfaces/libpq/libpq.so: undefined reference to `u_versionToString_52' ../../../src/interfaces/libpq/libpq.so: undefined reference to `uloc_setDefault_52' ../../../src/interfaces/libpq/libpq.so: undefined reference to `uloc_getDefault_52' ../../../src/interfaces/libpq/libpq.so: undefined reference to `ucol_close_52' As a side note, I'm a bit confused, who is the original author of the proposed patch? If it's Marina, why she isn't involved in the discussion or even mentioned in the patch itself?
