> On Sun, Nov 18, 2018 at 7:41 PM Andrew Dunstan > <andrew.duns...@2ndquadrant.com> wrote: > > On 11/17/18 9:55 AM, Alvaro Herrera wrote: > > The comment in expand_dbname_patterns is ungrammatical and mentions > > "OID" rather than "name", so I suggest > > Will fix. > > > Other than that, the patch seems fine to me -- I tested and it works as > > intended. > > > > Personally I would say "See also expand_table_name_patterns" instead of > > "This is similar to code in pg_dump.c for handling matching table names.", > > as well as mention this function in expand_table_name_patterns' comment. > > (No need to mention expand_schema_name_patterns, since these are > > adjacent.) But this is mostly stylistic and left to your own judgement. > > > > In the long run, I think we should add an option to processSQLNamePattern > > to use OR instead of AND, which would fix both this problem as well as > > pg_dump's. I don't think that's important enough to stall this patch. > > Thanks for the review.
Unfortunately judging from cfbot output patch needs to be rebased, could you please post an updated version with those fixes mentioned above?
