Hi Peter,
On Sat, Sep 01, 2018 at 07:28:37AM +0200, Peter Eisentraut wrote:
> rebased patch, no functionality changes
Could you rebase once again? I am going through the patch and wanted to
test pg_upgrade on Linux with XFS, but it does not apply anymore.
Thanks,
--
Michael
signature.asc
Desc
On Fri, Aug 24, 2018 at 03:37:17PM +0100, Alexandra Ryzhevich wrote:
> CONNECT ON DATABASE privilege is granted to public by default (so
> all users by default can select pg_database_size()) and
> REVOKE CONNECT ... FROM command doesn't impact
> user's privileges. The only way to revoke connect pr
On Wed, Sep 19, 2018 at 7:07 AM Fabien COELHO wrote:
> > I reviewed 'pgbench-prp-func/pgbench-prp-func-4.patch'. [...] I thinks
> > this patch is fine.
modular_multiply() is an interesting device. I will leave this to
committers with a stronger mathematical background than me, but I have
a small
On Tue, Sep 25, 2018 at 06:42:51PM -0700, Andres Freund wrote:
> My point is that FuncCallContext->slot isn't actually all that related
> to TupleDescGetSlot() and could be used entirely independently.
That's fair. Why not just replacing the existing comment with something
like "slot can be used
On Tue, Sep 25, 2018 at 01:39:59PM +0200, Dmitry Dolgov wrote:
> Shouldn't it be fixed by adding EventTriggerAlterTableStart? Judging from the
> following call of ATController, we can just pass NULL as parsetree.
Hmm. I don't think that this is correct as this data could always be
used to fetch a
On 2018-09-26 10:38:51 +0900, Michael Paquier wrote:
> On Tue, Sep 25, 2018 at 05:10:39PM -0700, Andres Freund wrote:
> >> git grep TupleDescGetSlot
> >> doc/src/sgml/xfunc.sgml: * user-defined SRFs that use the deprecated
> >> TupleDescGetSlot().
> >> src/include/funcapi.h: * user-defined S
On Tue, Sep 25, 2018 at 05:10:39PM -0700, Andres Freund wrote:
>> git grep TupleDescGetSlot
>> doc/src/sgml/xfunc.sgml: * user-defined SRFs that use the deprecated
>> TupleDescGetSlot().
>> src/include/funcapi.h: * user-defined SRFs that use the deprecated
>> TupleDescGetSlot().
>
> But he
On Tue, Sep 25, 2018 at 11:54:53PM +0900, Masahiko Sawada wrote:
> Can we use "XLOG_PARAMETER_CHANGE record" instead of "record
> XLOG_PARAMETER_CHANGE" at the second hunk because the comment of the
> first hunk uses it. The other part of this patch looks good to me.
Let's use your suggestion, an
On Thu, Aug 9, 2018 at 12:59 PM Asim R P wrote:
> On Tue, Aug 7, 2018 at 7:00 PM, Peter Geoghegan wrote:
> > I wonder if it would be a better idea to enable Valgrind's memcheck to
> > mark buffers as read-only or read-write. We've considered doing
> > something like that for years, but for whatev
Hi,
Sorry for my late response.
> Between perf/systemtap/dtrace and wireshark, you can already do pretty much
> all of that. Have you looked at those and found anything missing?
These commands provide detailed information to us.
However, I think the trace log is necessary from the following po
Hello. Thank you for the comments.
At Thu, 20 Sep 2018 10:37:24 -0700, Andres Freund wrote in
<20180920173724.5w2n2nwkxtyi4...@alap3.anarazel.de>
> Hi,
>
> On 2018-09-20 09:55:27 +0200, Antonin Houska wrote:
> > I've spent some time reviewing this version.
> >
> > Design
> > --
> >
> > 1.
On Tue, Sep 25, 2018 at 03:01:31PM -0700, David G. Johnston wrote:
> On Sat, Sep 22, 2018 at 5:27 PM, Bruce Momjian wrote:
>
> On Fri, Sep 21, 2018 at 06:35:02PM -0400, Bruce Momjian wrote:
> > Does the SQL standard have anything to say about CURRENT_TIMESTAMP in
> > procedures? Do w
On 2018-09-26 09:04:14 +0900, Michael Paquier wrote:
> Hi Andres,
>
> On Tue, Sep 25, 2018 at 11:39:05PM +, Andres Freund wrote:
> > Remove absolete function TupleDescGetSlot().
> >
> > TupleDescGetSlot() was kept around for backward compatibility for
> > user-written SRFs. With the TupleTabl
On 2018-09-04 18:35:34 +0530, Amit Khandekar wrote:
> The attached v11 tar has the above set of changes.
> Subject: [PATCH 07/14] Restructure TupleTableSlot to allow tuples other than
> HeapTuple
> +
> +/*
> + * This is a function used by all getattr() callbacks which deal with a heap
> + * tup
Hi Andres,
On Tue, Sep 25, 2018 at 11:39:05PM +, Andres Freund wrote:
> Remove absolete function TupleDescGetSlot().
>
> TupleDescGetSlot() was kept around for backward compatibility for
> user-written SRFs. With the TupleTableSlot abstraction work, that code
> will need to be version specifi
Hi,
On 2018-09-04 18:35:34 +0530, Amit Khandekar wrote:
> Subject: [PATCH 05/14] Use tts_flags instead of previous bool members
>
> Pack the boolean members in TupleTableSlot into a 16 bit tts_flags.
> This reduces the size of TupleTableSlot since each bool member takes
> at least a byte on the p
On 2018-09-25 14:50:02 -0700, Andres Freund wrote:
> ISTM this is an issue that belongs on the open items list. Peter, could
> you comment?
Done so, per discussion with the rest of the RMT.
On 2018-09-04 18:35:34 +0530, Amit Khandekar wrote:
> The attached v11 tar has the above set of changes.
- I've pushed 0003 - although that commit seems to have included a lot
of things unrelated to the commit message. I guess two patches have
accidentally been merged? Could you split out the
Thomas Munro writes:
> ... and now I'm on macOS 10.14. I removed all traces of MacPorts from
> my PATH and configure line to test this. --with-tcl worked, but
> --with-perl couldn't find "perl.h". Then I realised that it was
> because I was still on Xcode 9, so I was in for another ~5GB of
> up
Heikki Linnakangas writes:
> On 27/06/18 21:57, Daniel Gustafsson wrote:
>> Courtesy of the ever-present Murphy I managed to forget some testcode in
>> src/backend/Makefile which broke compilation for builds without secure
>> transport, attached v8 patch fixes that.
> I've read through this patch
On Wed, Sep 26, 2018 at 3:14 AM Tom Lane wrote:
> Thomas Munro writes:
> > On Tue, Sep 25, 2018 at 4:49 PM Tom Lane wrote:
> >> I've tested this on all the macOS versions I have at hand, and it
> >> doesn't seem to break anything. Only part (1) could possibly
> >> affect other platforms, and th
On Tue, Sep 25, 2018 at 12:05:42PM -0400, Tom Lane wrote:
> Alvaro Herrera writes:
>> Actually I think it *is* useful to do it like this, because then the
>> user knows to fix the netmsg.dll problem so that they can continue to
>> investigate the winsock problem. If we don't report the secondary
On Mon, Sep 24, 2018 at 09:27:35PM -0700, Andres Freund wrote:
> On 2018-09-25 11:50:47 +0900, Michael Paquier wrote:
>> PGDLLIMPORT changes don't get back-patched as well...
>
> We've been more aggressive with that lately, and I think that's good. It
> just is a unnecessarily portability barrier
Hi Amit,
Could you rebase this patch, it doesn't apply anymore.
Greetings,
Andres Freund
On Tue, 25 Sep 2018 at 10:23, Edmund Horner wrote:
> I have a small tweak. In make_one_rel, we currently have:
>
> /*
> * Compute size estimates and consider_parallel flags for each base rel,
> * then generate access paths.
> */
> set_base_rel_sizes(root);
> set_base_re
On Sat, Sep 22, 2018 at 5:27 PM, Bruce Momjian wrote:
> On Fri, Sep 21, 2018 at 06:35:02PM -0400, Bruce Momjian wrote:
> > Does the SQL standard have anything to say about CURRENT_TIMESTAMP in
> > procedures? Do we need another function that does advance on procedure
> > commit?
>
> I found a se
Hello,
I am a Master Degree Student at University of Pecs, Hungary.
I will like to be a mentor for Google Code In for PostgresSQL project
Please, how can I apply?
Thank you.
Saheed
Hi,
On 2018-09-20 19:40:40 -0400, Bruce Momjian wrote:
> This function shows that only clock_timestamp() advances inside a
> procedure, not statement_timestamp() or transaction_timestamp():
>
> CREATE OR REPLACE PROCEDURE test_timestamp () AS $$
> DECLARE
> str TEXT;
>
I did not notice until today that there is some ambiguity in
this paragraph:
bgw_restart_time is the interval, in seconds, that postgres should
wait before restarting the process, in case it crashes. It can be
any positive value, or BGW_NEVER_RESTART, indicating not to restart
the process
Hi,
On 2018-09-25 12:50:34 -0700, Andres Freund wrote:
> On 2018-09-25 01:47:49 -0700, Andres Freund wrote:
> > Planning Time: 0.152 ms
> > JIT:
> > Functions: 4
> > Options: Inlining true, Optimization true, Expressions true, Deforming
> > true
> > Timing: Generation 0.955 ms, Inlining 157
Hi,
On 2018-09-25 01:47:49 -0700, Andres Freund wrote:
> Forcing parallelism and JIT to be on, I get:
>
> postgres[20216][1]=# EXPLAIN (ANALYZE, VERBOSE, BUFFERS) SELECT count(*) FROM
> pg_class;
>
> Finalize Aggregate (cost=15.43..15.44 rows=1 width=8) (actual
> time=183.282..183.282 rows=1
Hi, thanks for the reply!
> What are you using it for?
I want to use it to validate status of related entities in other database
(queue) in short interval after PG transaction commit/rollback.
> I can't reproduce that...
Yes, it happens only with one cluster. All others work as expected.
> You
Hi,
On 2018-09-25 19:47:40 +0300, Michail Nikolaev wrote:
> I see strange beaviour of txid_status with one of my production servers.
What are you using it for?
> SELECT txid_status(txid_current()) -> NULL
I can't reproduce that...
> SELECT txid_current() -> 4447342811
>
> It also returns nu
Sorry, some auto formatting in recent email.
Again wtih fixed formatiing:
I see strange beaviour of txid_status with one of my production servers.
SELECT txid_status(txid_current()) -> NULL
SELECT txid_current() -> 4447342811
It also returns null for recent commited and aborted transactions.
S
On Mon, Sep 24, 2018 at 4:10 PM Stephen Frost wrote:
>
> * Don Seiler (d...@seiler.us) wrote:
> >
> > OK I created a new function called clean_ascii() in common/string.c. I
> call
> > this from my new logic in postmaster.c as well as replacing the logic in
> > guc.c's check_application_name() and
Hello everyone.
I see strange beaviour of txid_status with one of my production servers.
SELECT txid_status(txid_current()) -> NULL
SELECT txid_current() -> 4447342811
It also returns null for recent commited and aborted transactions.
SELECT datname, age(datfrozenxid), datfrozenxid FROM pg_data
Alvaro Herrera writes:
> On 2018-Sep-25, Tom Lane wrote:
>> We could possibly write something like
>>
>> sprintf(wserrbuf, "winsock error %d (could not load netmsg.dll to translate:
>> error code %lu)", err, GetLastError(;
>>
>> but I'm unconvinced that that's useful.
> Actually I think it
> On Sep 25, 2018, at 8:08 AM, Mark Dilger wrote:
>
>
>
>> On Sep 25, 2018, at 5:07 AM, Surafel Temesgen wrote:
>>
>> hey
>>
>> On 9/21/18, Mark Dilger wrote:
>>
>>> Surafel, there are no regression tests that I can see in your patch. It
>>> would help if you added some, as then I coul
On 2018-Sep-25, Tom Lane wrote:
> Michael Paquier writes:
> > Ok. I won't fight hard on that. Why changing the error message from
> > "could not load netmsg.dll" to "unrecognized winsock error" then? The
> > original error string is much more verbose to grab the context.
>
> As the code stan
Thomas Munro writes:
> On Tue, Sep 25, 2018 at 4:49 PM Tom Lane wrote:
>> I've tested this on all the macOS versions I have at hand, and it
>> doesn't seem to break anything. Only part (1) could possibly
>> affect other platforms, and that seems safe enough.
>>
>> I'd like to commit and backpat
> On Sep 25, 2018, at 5:07 AM, Surafel Temesgen wrote:
>
> hey
>
> On 9/21/18, Mark Dilger wrote:
>
>> Surafel, there are no regression tests that I can see in your patch. It
>> would help if you added some, as then I could precisely what behavior you
>> are expecting.
> thank you for look
On Mon, Sep 24, 2018 at 01:53:05PM -0400, Tom Lane wrote:
> Noah Misch writes:
> > In this proof of concept, the
> > postmaster does not close its copy of a backend socket until the backend
> > exits.
>
> That seems unworkable because it would interfere with detection of client
> connection drops
On Tue, Sep 25, 2018 at 1:43 PM, Michael Paquier wrote:
> Sawada-san,
>
> On Mon, Sep 24, 2018 at 08:28:45AM +0900, Michael Paquier wrote:
>> Wouldn't it be better to incorporate the new test as part of
>> 004_restart.pl? This way, we avoid initializing a full instance, which
>> is always a good
On Fri, Sep 21, 2018 at 7:29 AM Thomas Munro
wrote:
> I'll add it to the next Commitfest so I know when to rebase it.
I signed up as reviewer in that CF.
--
Kevin Grittner
VMware vCenter Server
https://www.vmware.com/
Andrew Gierth writes:
> So I've tried to rough out a decision tree for the various options on
> how this might be implemented (discarding the "use precedence hacks"
> option). Opinions? Additions?
I think it'd be worth at least drafting an implementation for the
lexical-lookahead fix. I think it
Michael Paquier writes:
> On Mon, Sep 24, 2018 at 01:18:47PM -0400, Tom Lane wrote:
>> Well, we have to change the code somehow to make it usable in frontend
>> as well as backend. And we can *not* have it do exit(1) in libpq.
>> So the solution I chose was to make it act the same as if FormatMes
Chris Travers writes:
> However, what I think one could do is use a struct of volatile
> sig_atomic_t members and macros for checking/setting. Simply writing a
> value is safe in C89 and higher.
Yeah, we could group those flags in a struct, but what's the point?
regards
hey
On 9/21/18, Mark Dilger wrote:
> Surafel, there are no regression tests that I can see in your patch. It
> would help if you added some, as then I could precisely what behavior you
> are expecting.
thank you for looking at it .the attach patch add regression tests
diff --git a/doc/src/sgml/
On Tue, Sep 25, 2018 at 4:51 AM Bradley DeJong wrote:
>
> On 2018-09-22, Amit Kapila wrote ...
> > ... duplicate the same information in different words at three
> different places ...
>
> I count 7 different places. In the protocol docs, there is the old
> mention in the "Summary of Changes sinc
Re: Thomas Munro 2018-09-24
> I wonder if we would be practically constrained to using the
> distro-supplied ICU (by their policies of not allowing packages to
> ship their own copies ICU); it seems like it. I wonder which distros
> allow multiple versions of ICU to be installed. I see that Deb
On Mon, Sep 24, 2018 at 05:36:39PM -0400, Tom Lane wrote:
> I reviewed and pushed this.
Great! Thank you.
> As a cross-check on the patch, I cloned the Snowball github repo
> and built the derived files in it. I noticed that they'd incorporated
> several new stemmers since 2007 --- not only your
> On Mon, 24 Sep 2018 at 17:58, Alvaro Herrera wrote:
>
> On 2018-Sep-20, Marco Slot wrote:
>
> > We're seeing a segmentation fault when creating a partition of a
> > partitioned table with a primary key when there is a sql_drop trigger on
> > Postgres 11beta4.
> >
> > We discovered it because the
Let me explain this trace log in a bit more detail.
This log is not turned on in the system by default.
Turn it on when an issue occurs and you want to check the information in the
application in order to clarify the cause.
I will present three use cases for this log.
1. Confirmation on cause
On 2018-09-18 10:03:02 +0530, Amit Khandekar wrote:
> Attached v3 patch that does the above change.
Attached is a revised version of that patch. I've changed quite a few
things:
- I've reverted the split of "base" and "provider specific" contexts - I
don't think it really buys us anything here.
On Tue, Sep 25, 2018 at 4:49 PM Tom Lane wrote:
> I've tested this on all the macOS versions I have at hand, and it
> doesn't seem to break anything. Only part (1) could possibly
> affect other platforms, and that seems safe enough.
>
> I'd like to commit and backpatch this, because otherwise lon
On Mon, Sep 24, 2018 at 01:18:47PM -0400, Tom Lane wrote:
> Michael Paquier writes:
>> On Wed, Sep 12, 2018 at 01:40:01PM -0400, Tom Lane wrote:
>>> Rebase attached --- no substantive changes.
>
>> - if (handleDLL == NULL)
>> - ereport(FATAL,
>> - (errmsg_interna
On Mon, Sep 24, 2018 at 7:06 PM Andres Freund wrote:
> On 2018-09-24 11:45:10 +0200, Chris Travers wrote:
> > I did some more reading.
> >
> > On Mon, Sep 24, 2018 at 10:15 AM Chris Travers >
> > wrote:
> >
> > > First, thanks for taking the time to write this. Its very helpful.
> > > Additiona
57 matches
Mail list logo
